[Catalyst] Follow-up to new uri_for() bug

2006-09-11 Thread apv 
http://lists.rawmode.org/pipermail/catalyst/2006-September/ 
009531.html (I did start a new message there, blame Mail.app, not me  
for the bad threading)

Okay, mean guys. Make me solve my own, er, Catalyst's own, bugs.

Line 118 (5.7001) of Catalyst::Engine::CGI looks like this:
 $base_path =~ s/$ENV{PATH_INFO}$//;

Unless I'm losing it, it should look like this:
 $base_path =~ s/\Q$ENV{PATH_INFO}\E$//;

Otherwise uri_for (well, request-base and anything that uses it)  
gets borked by any number of regex chars in the URI.



–Ashley
-- 




___
List: Catalyst@lists.rawmode.org
Listinfo: http://lists.rawmode.org/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.rawmode.org/
Dev site: http://dev.catalyst.perl.org/

Re: [Catalyst] Follow-up to new uri_for() bug

2006-09-11 Thread Matt S Trout 
apv wrote:
 http://lists.rawmode.org/pipermail/catalyst/2006-September/ 
 009531.html (I did start a new message there, blame Mail.app, not me  
 for the bad threading)
 
 Okay, mean guys. Make me solve my own, er, Catalyst's own, bugs.
 
 Line 118 (5.7001) of Catalyst::Engine::CGI looks like this:
  $base_path =~ s/$ENV{PATH_INFO}$//;
 
 Unless I'm losing it, it should look like this:
  $base_path =~ s/\Q$ENV{PATH_INFO}\E$//;
 
 Otherwise uri_for (well, request-base and anything that uses it)  
 gets borked by any number of regex chars in the URI.

That seems like a sane complaint.

If you can add a failing test I can get it into 5.70002 ...

-- 
  Matt S Trout   Offering custom development, consultancy and support
   Technical Directorcontracts for Catalyst, DBIx::Class and BAST. Contact
Shadowcat Systems Ltd.  mst (at) shadowcatsystems.co.uk for more information

+ Help us build a better perl ORM: http://dbix-class.shadowcatsystems.co.uk/ +

___
List: Catalyst@lists.rawmode.org
Listinfo: http://lists.rawmode.org/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.rawmode.org/
Dev site: http://dev.catalyst.perl.org/

Re: [Catalyst] Follow-up to new uri_for() bug

2006-09-11 Thread apv 
Yay. I'll take a look through the tests to see if I can figure out  
where to send you a new one (or the diff for a current one).

-Ashley

On Sep 11, 2006, at 6:22 PM, Matt S Trout wrote:
 That seems like a sane complaint.

 If you can add a failing test I can get it into 5.70002 ...


___
List: Catalyst@lists.rawmode.org
Listinfo: http://lists.rawmode.org/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.rawmode.org/
Dev site: http://dev.catalyst.perl.org/