Re: [Catalyst] trouble with LocationMatch

2006-10-30 Thread Dave Howorth
Hironori Yoshida wrote:
 -$base_path = $location;
 +$self-apache-path_info =~ m/$location/msx;
 +$base_path = $;# I know this is the match-vars

Programming Perl, Third Edition

24.2.1. Time Efficiency

Avoid $ and its two buddies, $` and $'. Any occurrence in your program
causes all matches to save the searched string for possible future
reference. (However, once you've blown it, it doesn't hurt to have more
of them.)

Cheers, Dave

___
List: Catalyst@lists.rawmode.org
Listinfo: http://lists.rawmode.org/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.rawmode.org/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] trouble with LocationMatch

2006-10-28 Thread Matt S Trout

Hironori Yoshida wrote:

However, the patch is just a sample.
I want the opinion about it.


Without it including additions to the tests we've no idea what it does or 
whethr it works so can't really give you an opinion. Any chance of a test or 
three?


--
 Matt S Trout   Offering custom development, consultancy and support
  Technical Directorcontracts for Catalyst, DBIx::Class and BAST. Contact
Shadowcat Systems Ltd.  mst (at) shadowcatsystems.co.uk for more information

+ Help us build a better perl ORM: http://dbix-class.shadowcatsystems.co.uk/ +

___
List: Catalyst@lists.rawmode.org
Listinfo: http://lists.rawmode.org/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.rawmode.org/
Dev site: http://dev.catalyst.perl.org/