Re: [ccache] [PATCH 2/2] Fix Segmentation fault error when gcc -o /dev/null
On 1/23/19 11:23 PM, Joel Rosdahl wrote: On Tue, 22 Jan 2019 at 10:36, Robert Yang via ccache wrote: Fixed: $ export CCACHE_DEBUG=1 $ ccache gcc -c hello.c -o /dev/null Segmentation fault (core dumped) This is because failed to open /dev/null.foo (Permission denied), check file stream before write to it can fix the problem. Thanks, applied on master. On a side note, I had to edit the author information before applying your patches via "git am" since the mails were sent from "Robert Yang via ccache ". I don't know why that happened in your case. Thank you very much, I don't know what happened, I will use github next time. // Robert Regardless, I prefer patches via GitHub pull requests nowadays if possible. I have updated https://github.com/ccache/ccache/blob/master/CONTRIBUTING.md#contributing-code accordingly. -- Joel ___ ccache mailing list ccache@lists.samba.org https://lists.samba.org/mailman/listinfo/ccache
Re: [ccache] [PATCH 2/2] Fix Segmentation fault error when gcc -o /dev/null
On Tue, 22 Jan 2019 at 10:36, Robert Yang via ccache wrote: > Fixed: > $ export CCACHE_DEBUG=1 > $ ccache gcc -c hello.c -o /dev/null > > Segmentation fault (core dumped) > > This is because failed to open /dev/null.foo (Permission denied), check file > stream before write to it can fix the problem. Thanks, applied on master. On a side note, I had to edit the author information before applying your patches via "git am" since the mails were sent from "Robert Yang via ccache ". I don't know why that happened in your case. Regardless, I prefer patches via GitHub pull requests nowadays if possible. I have updated https://github.com/ccache/ccache/blob/master/CONTRIBUTING.md#contributing-code accordingly. -- Joel ___ ccache mailing list ccache@lists.samba.org https://lists.samba.org/mailman/listinfo/ccache
[ccache] [PATCH 2/2] Fix Segmentation fault error when gcc -o /dev/null
Fixed:
$ export CCACHE_DEBUG=1
$ ccache gcc -c hello.c -o /dev/null
Segmentation fault (core dumped)
This is because failed to open /dev/null.foo (Permission denied), check file
stream before write to it can fix the problem.
Signed-off-by: Robert Yang
---
src/ccache.c | 15 ---
src/util.c | 8 ++--
2 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/src/ccache.c b/src/ccache.c
index b4cdb86..8c227df 100644
--- a/src/ccache.c
+++ b/src/ccache.c
@@ -521,9 +521,13 @@ init_hash_debug(struct hash *hash, const char *obj_path,
char type,
char *path = format("%s.ccache-input-%c", obj_path, type);
FILE *debug_binary_file = fopen(path, "wb");
- hash_enable_debug(hash, section_name, debug_binary_file,
debug_text_file);
+ if (debug_binary_file) {
+ hash_enable_debug(hash, section_name, debug_binary_file,
debug_text_file);
+ exitfn_add(fclose_exitfn, debug_binary_file);
+ } else {
+ cc_log("Failed to open %s: %s", path, strerror(errno));
+ }
free(path);
- exitfn_add(fclose_exitfn, debug_binary_file);
}
static enum guessed_compiler
@@ -3670,8 +3674,13 @@ ccache(int argc, char *argv[])
if (conf->debug) {
char *path = format("%s.ccache-input-text", output_obj);
debug_text_file = fopen(path, "w");
+ if (debug_text_file) {
+ exitfn_add(fclose_exitfn, debug_text_file);
+ }
+ else {
+ cc_log("Failed to open %s: %s", path, strerror(errno));
+ }
free(path);
- exitfn_add(fclose_exitfn, debug_text_file);
}
struct hash *common_hash = hash_init();
diff --git a/src/util.c b/src/util.c
index e442cc4..a49fb4c 100644
--- a/src/util.c
+++ b/src/util.c
@@ -219,8 +219,12 @@ void
cc_dump_log_buffer(const char *path)
{
FILE *file = fopen(path, "w");
- (void) fwrite(logbuffer, 1, logsize, file);
- fclose(file);
+ if (file) {
+ (void) fwrite(logbuffer, 1, logsize, file);
+ fclose(file);
+ } else {
+ cc_log("Failed to open %s: %s", path, strerror(errno));
+ }
}
// Something went badly wrong!
--
2.7.4
___
ccache mailing list
ccache@lists.samba.org
https://lists.samba.org/mailman/listinfo/ccache
