Re: RGW S3 Website hosting, non-clean code for early review
On 12/03/2015 10:47 PM, Robin H. Johnson wrote: > On Wed, Dec 02, 2015 at 03:02:12PM +0100, Javier Muñoz wrote: >> I would appreciate to know the current status of the implementation if >> possible. Any progress? Any 'deadline' to go upstream? :) > > When: > As soon as it works 100% and passes my testsuite, which I hope is very > soon. I would very much like to have this in Jewel. > > My work was being done in this branch > https://github.com/dreamhost/ceph/tree/wip-static-website-robbat2-master > However, due to master moving forward, I can't use the latest parts of > the gitbuilder and automatic testing successfully (they've moved on, > while this has stayed behind). > > Yehuda wanted me to try and NOT rebase it, for ease of his review, but > that was no longer possible :-(. > (tagged as wip-static-website-robbat2-master_yehuda-review-20151012 in > the dreamhost fork). > > The above, but squashed and updated to master as of 2015/12/02 > https://github.com/dreamhost/ceph/tree/wip-static-website-robbat2-master-20151202 > It's presently running against my testsuite, and if it passes the pieces > that I know it should [1], I'll be splitting it up to submit. > > [1] I'm seeing some failures of places where I didn't touch the code, so > having to separate those out. Thanks for the update! Javier -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: RGW S3 Website hosting, non-clean code for early review
Hi, I would appreciate to know the current status of the implementation if possible. Any progress? Any 'deadline' to go upstream? :) Thanks in advance! Javier On 07/31/2015 10:21 AM, Robin H. Johnson wrote: > I'm busy travelling and wrapping other things up, but will resume major > work on this in August, probably week 2/3, depending on other > interrupts/priorities. > > It's almost complete, the only missing features are: > - error page fetcher gets confused on conditional requests (I think a > different approach is needed, esp re range & if-modified requests, > they still seem to leak into the custom req_info on the second request) > - cascaded errors on conditional requests need more handling (eg > 404 bounces to the error page that doesn't exist as well) > Some further work that isn't blocking is also: > - review handling of x-amz-website-redirect-location header when it > conflicts with RoutingRules > - Check what input validations Amazon does, because already they don't > match the docs > - eg docs say any http code for redirect, but it really only allows > 301-305, 307, 308 > - Exact validation on the URI/paths is also not immediately clear, I > had some unexpected results with URL-escaped inputs. > - Review cases in which AMZ sets the errors in the header as well as the > page, didn't seem consistent, esp in the double-error cases. > - more cleanup/refactor of test cases > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html