Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
On Tue, Jan 15, 2013 at 6:55 AM, Noah Watkins wrote: > On Tue, Jan 15, 2013 at 1:32 AM, Danny Al-Gaaf > wrote: >> Am 15.01.2013 10:04, schrieb James Page: >>> On 12/01/13 16:36, Noah Watkins wrote: On Thu, Jan 10, 2013 at 9:13 PM, Gary Lowell wrote: >> >> I would also prefer to not add another huge build dependency to ceph, >> especially since it's e.g. not supported by SLES11 and since ceph >> currently builds fine (even with these small warnings from autotools). > > Ahh, I had in my head a separate repository for Java bindings managed > by maven (or ant). Either way, I have no strong opinion -- we only > have one junit dependency :) I don't believe Ceph currently requires any Java to build, and it's going to remain that way if I have anything to say about it. ;) Hadoop bindings can be packaged in about a billion different ways that don't require core Ceph to depend on a Java toolchain. -Greg -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
On Tue, Jan 15, 2013 at 1:32 AM, Danny Al-Gaaf wrote: > Am 15.01.2013 10:04, schrieb James Page: >> On 12/01/13 16:36, Noah Watkins wrote: >>> On Thu, Jan 10, 2013 at 9:13 PM, Gary Lowell >>> wrote: > > I would also prefer to not add another huge build dependency to ceph, > especially since it's e.g. not supported by SLES11 and since ceph > currently builds fine (even with these small warnings from autotools). Ahh, I had in my head a separate repository for Java bindings managed by maven (or ant). Either way, I have no strong opinion -- we only have one junit dependency :) -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
Am 15.01.2013 10:04, schrieb James Page: > On 12/01/13 16:36, Noah Watkins wrote: >> On Thu, Jan 10, 2013 at 9:13 PM, Gary Lowell >> wrote: Thanks Danny. Installing sharutils solved that minor issue. We now get though the build just fine on opensuse 12, but sles 11sp2 gives more warnings (pasted below). Should we be using a newer version of autoconf on sles? I've tried moving AC_CANONICAL_TARGET earlier in the file, but that causes some other issues with the new java macros. >> We could also move away from using autoconf/automake for Java, and >> use a packaging/dependency system designed for Java, like Maven. > > If this route it taken please bear in mind that use of Maven will > create some challenges in Ubuntu; specifically with regards to the > fact that ceph is in main and supported by Canonical and Maven + > associated toolchain is *huge* in terms of packages and is not in main. > > Ant however is in main and fully supported. I would also prefer to not add another huge build dependency to ceph, especially since it's e.g. not supported by SLES11 and since ceph currently builds fine (even with these small warnings from autotools). Danny -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/01/13 16:36, Noah Watkins wrote: > On Thu, Jan 10, 2013 at 9:13 PM, Gary Lowell > wrote: >>> >>> Thanks Danny. Installing sharutils solved that minor issue. >>> We now get though the build just fine on opensuse 12, but sles >>> 11sp2 gives more warnings (pasted below). Should we be using a >>> newer version of autoconf on sles? I've tried moving >>> AC_CANONICAL_TARGET earlier in the file, but that causes some >>> other issues with the new java macros. > We could also move away from using autoconf/automake for Java, and > use a packaging/dependency system designed for Java, like Maven. If this route it taken please bear in mind that use of Maven will create some challenges in Ubuntu; specifically with regards to the fact that ceph is in main and supported by Canonical and Maven + associated toolchain is *huge* in terms of packages and is not in main. Ant however is in main and fully supported. - -- James Page Technical Lead Ubuntu Server Team james.p...@canonical.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBCAAGBQJQ9RufAAoJEL/srsug59jDYwoQAJbE3nEhxi0qiEQmyQpvkNlO VhY2CA2Mu5z+WDkPuF2YqiisM1+v+10RUK077ZOv1K8QIcEffHGWJtuXxRarHGDY +PHWTinNvNm56BDC6mxAOJPU1hPv0hOgho9E8jW9LJDNTajVGskr03BxMHDLu/OQ W3X9CqrhD97WAXv95fhPGKQoWxyHUNLMxvusZvbRqMEr23+ccgkMfulOdjETe8LG BwBCV8FPiFAYxJPaVxm9UvbRXHo3PXvOU8CIpEP0Wk87f3FDQbCTVzJIdSyp30xJ 762U+cXgN6zMkTpvZYHX6vN29vWGSNmkRcsSrGoIlbxZCTkYt13S8iBvSMDeCbVa SX/YZQNPYEcnkcEDrgHoG0y4xQNcSwIjkji+dKf2A5lxOHU6qDEIcXMp7XMvx3ha PVh+d2MkRiIPSw48n3d4TZch8VkbJBFFW1klLlC1yKHRsOPee8Ck+tyBAqnW6nCQ 2goiXsH73CASzznfjI3qo9kkIza4eL7k15AjeyMfXh3b88ssuALgDV1Bk9JI0G1b LyzY7JMqCDqlvmGTJQwm14qKcP3HRGXl8WaNV8gGUo84BV3a2VmqjJw0WWekyk+z 3wSbPgFpQE31N7SmsYBhjROMngOrMdWc4ccEs/EiukDrvC+LnMrhuUmYQfa01iaS zm59v1Ys83hx+2vapx0M =Mjh1 -END PGP SIGNATURE- -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
On Jan 12, 2013, at 1:59 PM, Danny Al-Gaaf wrote: > Am 11.01.2013 06:13, schrieb Gary Lowell: > [...] >> Thanks Danny. Installing sharutils solved that minor issue. We now >> get though the build just fine on opensuse 12, but sles 11sp2 gives >> more warnings (pasted below). Should we be using a newer version of >> autoconf on sles? I've tried moving AC_CANONICAL_TARGET earlier in >> the file, but that causes some other issues with the new java >> macros. >> >> Thanks, Gary > > I'll take a look at it, I guess it's a problem in configure.ac. > > I see the same warnings in our build system at SUSE for SLES (see: e.g. > logs at > https://build.opensuse.org/project/monitor?project=home%3Adalgaaf%3Abranches%3Afilesystems), > but the package builds just fine for openSUSE, SLES, Fedora, RHEL and > CentOS there Looks like it is the usage of AC_CANONICAL_SYSTEM in ac_prog_javah.m4 that cause the warning on centos and sles. Using AC_CANONICAL_HOST fixed the warning. I'm not sure if that's the real solution, or if something should be changed in the configure.ac file. The diff of the change I tried is below. Thanks, Gary diff --git a/m4/ac_prog_javah.m4 b/m4/ac_prog_javah.m4 index 0cc93f9..118e02f 100644 --- a/m4/ac_prog_javah.m4 +++ b/m4/ac_prog_javah.m4 @@ -10,7 +10,7 @@ dnl @version 2002-03-25 dnl @license AllPermissive AC_DEFUN([AC_PROG_JAVAH],[ -AC_REQUIRE([AC_CANONICAL_SYSTEM])dnl +AC_REQUIRE([AC_CANONICAL_HOST])dnl AC_REQUIRE([AC_PROG_CPP])dnl AC_PATH_PROG(JAVAH,javah) if test x"`eval 'echo $ac_cv_path_JAVAH'`" != x ; then -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
Am 11.01.2013 06:13, schrieb Gary Lowell: [...] > Thanks Danny. Installing sharutils solved that minor issue. We now > get though the build just fine on opensuse 12, but sles 11sp2 gives > more warnings (pasted below). Should we be using a newer version of > autoconf on sles? I've tried moving AC_CANONICAL_TARGET earlier in > the file, but that causes some other issues with the new java > macros. > > Thanks, Gary I'll take a look at it, I guess it's a problem in configure.ac. I see the same warnings in our build system at SUSE for SLES (see: e.g. logs at https://build.opensuse.org/project/monitor?project=home%3Adalgaaf%3Abranches%3Afilesystems), but the package builds just fine for openSUSE, SLES, Fedora, RHEL and CentOS there. Danny -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
On Thu, Jan 10, 2013 at 9:13 PM, Gary Lowell wrote: > > Thanks Danny. Installing sharutils solved that minor issue. We now get > though the build just fine on opensuse 12, but sles 11sp2 gives more warnings > (pasted below). Should we be using a newer version of autoconf on sles? > I've tried moving AC_CANONICAL_TARGET earlier in the file, but that causes > some other issues with the new java macros. We could also move away from using autoconf/automake for Java, and use a packaging/dependency system designed for Java, like Maven. - Noah -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
On Jan 9, 2013, at 11:55 PM, Danny Al-Gaaf wrote: > Am 10.01.2013 05:32, schrieb Gary Lowell: >> I have this patch, and the ones from Friday in the wip-rpm-update branch. >> Everything looks good except that we have the following new warning from >> configure: >> >> …. >> checking for kaffe... no >> checking for java... java >> checking for uudecode... no >> WARNING: configure: I have to compile Test.class from scratch >> checking for gcj... no >> checking for guavac... no >> checking for jikes… no >> …. >> >> This may have to do with something in our build environment. > > I assume you have no uudecode installed. It should be part of sharutils > (http://www.gnu.org/software/sharutils/) Thanks Danny. Installing sharutils solved that minor issue. We now get though the build just fine on opensuse 12, but sles 11sp2 gives more warnings (pasted below). Should we be using a newer version of autoconf on sles? I've tried moving AC_CANONICAL_TARGET earlier in the file, but that causes some other issues with the new java macros. Thanks, Gary + ./autogen.sh warning: configure.ac:274: AC_ARG_PROGRAM was called before AC_CANONICAL_TARGET ../../lib/autoconf/general.m4:1795: AC_CANONICAL_TARGET is expanded from... ../../lib/autoconf/general.m4:1819: AC_CANONICAL_SYSTEM is expanded from... m4/ac_prog_javah.m4:12: AC_PROG_JAVAH is expanded from... ../../lib/m4sugar/m4sh.m4:505: AS_IF is expanded from... configure.ac:274: the top level aclocal: installing `m4/libtool.m4' from `/usr/share/aclocal/libtool.m4' aclocal: installing `m4/ltoptions.m4' from `/usr/share/aclocal/ltoptions.m4' aclocal: installing `m4/ltsugar.m4' from `/usr/share/aclocal/ltsugar.m4' aclocal: installing `m4/ltversion.m4' from `/usr/share/aclocal/ltversion.m4' aclocal: installing `m4/lt~obsolete.m4' from `/usr/share/aclocal/lt~obsolete.m4' aclocal: installing `m4/pkg.m4' from `/usr/share/aclocal/pkg.m4' warning: configure.ac:274: AC_ARG_PROGRAM was called before AC_CANONICAL_TARGET ../../lib/autoconf/general.m4:1795: AC_CANONICAL_TARGET is expanded from... ../../lib/autoconf/general.m4:1819: AC_CANONICAL_SYSTEM is expanded from... m4/ac_prog_javah.m4:12: AC_PROG_JAVAH is expanded from... ../../lib/m4sugar/m4sh.m4:505: AS_IF is expanded from... configure.ac:274: the top level -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
Am 10.01.2013 05:32, schrieb Gary Lowell: > I have this patch, and the ones from Friday in the wip-rpm-update branch. > Everything looks good except that we have the following new warning from > configure: > > …. > checking for kaffe... no > checking for java... java > checking for uudecode... no > WARNING: configure: I have to compile Test.class from scratch > checking for gcj... no > checking for guavac... no > checking for jikes… no > …. > > This may have to do with something in our build environment. I assume you have no uudecode installed. It should be part of sharutils (http://www.gnu.org/software/sharutils/) Regards, Danny -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
I have this patch, and the ones from Friday in the wip-rpm-update branch. Everything looks good except that we have the following new warning from configure: …. checking for kaffe... no checking for java... java checking for uudecode... no WARNING: configure: I have to compile Test.class from scratch checking for gcj... no checking for guavac... no checking for jikes… no …. This may have to do with something in our build environment. Cheers, Gary On Jan 9, 2013, at 1:54 PM, Noah Watkins wrote: > I haven't tested this yet, but I like it. I think several of these > macros can be used to simplify a bit more of the Java config bit. I > also just saw the ax_jni_include_dir macro in the autoconf archive and > it looks like that can help clean-up too. > > On Wed, Jan 9, 2013 at 1:35 PM, Danny Al-Gaaf wrote: >> The attached patch depends on the set of 6 patches I send some days ago. >> See: http://thread.gmane.org/gmane.comp.file-systems.ceph.devel/11793 >> >> Danny Al-Gaaf (1): >> configure.ac: check for org.junit.rules.ExternalResource >> >> autogen.sh| 2 +- >> configure.ac | 29 ++--- >> m4/ac_check_class.m4 | 108 >> ++ >> m4/ac_check_classpath.m4 | 24 +++ >> m4/ac_check_rqrd_class.m4 | 26 +++ >> m4/ac_java_options.m4 | 33 ++ >> m4/ac_prog_jar.m4 | 39 + >> m4/ac_prog_java.m4| 83 +++ >> m4/ac_prog_java_works.m4 | 98 + >> m4/ac_prog_javac.m4 | 45 +++ >> m4/ac_prog_javac_works.m4 | 36 >> m4/ac_prog_javah.m4 | 28 >> m4/ac_try_compile_java.m4 | 40 + >> m4/ac_try_run_javac.m4| 41 ++ >> 14 files changed, 615 insertions(+), 17 deletions(-) >> create mode 100644 m4/ac_check_class.m4 >> create mode 100644 m4/ac_check_classpath.m4 >> create mode 100644 m4/ac_check_rqrd_class.m4 >> create mode 100644 m4/ac_java_options.m4 >> create mode 100644 m4/ac_prog_jar.m4 >> create mode 100644 m4/ac_prog_java.m4 >> create mode 100644 m4/ac_prog_java_works.m4 >> create mode 100644 m4/ac_prog_javac.m4 >> create mode 100644 m4/ac_prog_javac_works.m4 >> create mode 100644 m4/ac_prog_javah.m4 >> create mode 100644 m4/ac_try_compile_java.m4 >> create mode 100644 m4/ac_try_run_javac.m4 >> >> -- >> 1.8.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] configure.ac: check for org.junit.rules.ExternalResource
I haven't tested this yet, but I like it. I think several of these macros can be used to simplify a bit more of the Java config bit. I also just saw the ax_jni_include_dir macro in the autoconf archive and it looks like that can help clean-up too. On Wed, Jan 9, 2013 at 1:35 PM, Danny Al-Gaaf wrote: > The attached patch depends on the set of 6 patches I send some days ago. > See: http://thread.gmane.org/gmane.comp.file-systems.ceph.devel/11793 > > Danny Al-Gaaf (1): > configure.ac: check for org.junit.rules.ExternalResource > > autogen.sh| 2 +- > configure.ac | 29 ++--- > m4/ac_check_class.m4 | 108 > ++ > m4/ac_check_classpath.m4 | 24 +++ > m4/ac_check_rqrd_class.m4 | 26 +++ > m4/ac_java_options.m4 | 33 ++ > m4/ac_prog_jar.m4 | 39 + > m4/ac_prog_java.m4| 83 +++ > m4/ac_prog_java_works.m4 | 98 + > m4/ac_prog_javac.m4 | 45 +++ > m4/ac_prog_javac_works.m4 | 36 > m4/ac_prog_javah.m4 | 28 > m4/ac_try_compile_java.m4 | 40 + > m4/ac_try_run_javac.m4| 41 ++ > 14 files changed, 615 insertions(+), 17 deletions(-) > create mode 100644 m4/ac_check_class.m4 > create mode 100644 m4/ac_check_classpath.m4 > create mode 100644 m4/ac_check_rqrd_class.m4 > create mode 100644 m4/ac_java_options.m4 > create mode 100644 m4/ac_prog_jar.m4 > create mode 100644 m4/ac_prog_java.m4 > create mode 100644 m4/ac_prog_java_works.m4 > create mode 100644 m4/ac_prog_javac.m4 > create mode 100644 m4/ac_prog_javac_works.m4 > create mode 100644 m4/ac_prog_javah.m4 > create mode 100644 m4/ac_try_compile_java.m4 > create mode 100644 m4/ac_try_run_javac.m4 > > -- > 1.8.1 > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
