Re: [CF-metadata] [cf-convention/cf-conventions] Add earth shape parameters to geostationary projection (#241)

2020-04-02 Thread Klaus Zimmermann
For what it's worth (probably not much), I approve.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/241#issuecomment-607889648

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.

Re: [CF-metadata] [cf-convention/cf-conventions] Add earth shape parameters to geostationary projection (#241)

2020-04-02 Thread JimBiardCics
Ah, well then, I totally approve.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/241#issuecomment-607868287

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.

Re: [CF-metadata] [cf-convention/cf-conventions] Add earth shape parameters to geostationary projection (#241)

2020-04-02 Thread Daniel Lee
...Of course that's assuming that you **would** wish to express approval - 
sorry for putting words in your mouth there :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/241#issuecomment-607849574

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.

Re: [CF-metadata] [cf-convention/cf-conventions] Add earth shape parameters to geostationary projection (#241)

2020-04-02 Thread Daniel Lee
@JimBiardCics as moderator you can express approval for the change. However, 
[we need at least 3 people](http://cfconventions.org/rules.html) to express 
support for the change, 2 of which need to be from the Conventions Committee. 
As it stands we're 2 for 3, but of course it might be that somebody has 
objections.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/241#issuecomment-607848353

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.

Re: [CF-metadata] [cf-convention/cf-conventions] Add earth shape parameters to geostationary projection (#241)

2020-04-02 Thread JimBiardCics
This proposed change is to make the generic statement
> The attributes which describe the ellipsoid and prime the final section.
meridian may be included, when applicable, with any grid mapping.

to
> The attributes which describe the ellipsoid and prime meridian may be 
> included, when applicable, with any grid mapping.
> These are:
> - `earth_radius`
> - `inverse_flattening`
> - `longitude_of_prime_meridian`
> - `prime_meridian_name`
> - `reference_ellipsoid_name`
> - `semi_major_axis`
> - `semi_minor_axis`

This removes any uncertainty about which attributes are being referred to.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/241#issuecomment-607844593

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.

Re: [CF-metadata] [cf-convention/cf-conventions] Add earth shape parameters to geostationary projection (#241)

2020-04-02 Thread JimBiardCics
As moderator I guess I can't approve of the change, so we need others to come 
and say so or give reason why not.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/241#issuecomment-607844973

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.

Re: [CF-metadata] [cf-convention/cf-conventions] Resolve some errors in the current master branch of CF 1.8 docs (#238)

2020-04-02 Thread JonathanGregory
I've merged it. As you say, it was past the time limit and since it was a 
defect it's approved by default. Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/238#issuecomment-607691084

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.

Re: [CF-metadata] [cf-convention/cf-conventions] Resolve some errors in the current master branch of CF 1.8 docs (#238)

2020-04-02 Thread JonathanGregory
Closed #238 via #240.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/238#event-3191054853

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.

Re: [CF-metadata] [cf-convention/cf-conventions] Resolve Example 3.4 and 3.5 mis-ordering issue (#240)

2020-04-02 Thread JonathanGregory
Merged #240 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/pull/240#event-3191054844

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.

Re: [CF-metadata] [cf-convention/cf-conventions] Add earth shape parameters to geostationary projection (#241)

2020-04-02 Thread Daniel Lee
@JimBiardCics thanks! I've assigned you.

@davidhassell this would apply for all grid mappings "when applicable".  The 
details are in #242 - in essence the change would be to explicitly list what 
users must currently infer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/241#issuecomment-607677253

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.

Re: [CF-metadata] [cf-convention/cf-conventions] Update geostationary projection to allow clean description of newer generation satellites (#258)

2020-04-02 Thread Daniel Lee
Hi @rhorne99 you're right, there's nothing that prevents a 3-axis stabilised 
satellite from behaving like Meteosat 1st or 2nd  generation.

Meteosat 3rd generation deviates from the concept of previous generations by 
scanning in out of alignment with the image's axes. And to make matters more 
interesting this misalignment is different throughout the full disc scan - it's 
skewed in opposite directions in opposing hemispheres. This picture illustrates 
how it works:
![FCI scan 
principle](https://www.eumetsat.int/website/wcm/idc/idcplg?IdcService=GET_FILE=IMG_MTG_FCI_SCANNING_FDSS=LatestReleased=Web)

The result of this is that the position within the data array doesn't 
necessarily map to a position on the Earth in the same way that it did before. 
I think you put it well when [you 
said](https://github.com/cf-convention/cf-conventions/issues/258#issuecomment-607480360)

> the location of data points in the projection vary as a function of how the 
> imaging instrument works

In this configuration there isn't really a fixed axis at all. This is why we'd 
like to be able to signify which axes give elevation and azimuth angles. 
Independently of how the instrument is scanning, then, a rectified product 
would be well-described using these attributes.

If this approach makes sense to somebody who's not me I'll put together a pull 
request showing the exact changes proposed :)

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/258#issuecomment-607661664

This list forwards relevant notifications from Github.  It is distinct from 
cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
cf-metadata-unsubscribe-requ...@listserv.llnl.gov.