Re: [CF-metadata] [cf-convention/cf-conventions] Check that PRs do not break Asciidoctor build (#251)
Merged #251 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/251#event-3185183259 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Check that PRs do not break Asciidoctor build (#251)
Two positive reviews and it looks good to me. I'm going to merge. I will look at how to require reviews for this type of PR, probably by members of the [info-mgmt](https://github.com/orgs/cf-convention/teams/info-mgmt/members) team - @cf-convention/info-mgmt -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/251#issuecomment-606877191 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Check that PRs do not break Asciidoctor build (#251)
> This is great! > Would it be possible to upload the pdf and html individually, not in an > archive so as to facilitate easy inspection? That would be great! Currently, the `actions/upload-artifact` github action does not support it, but it's on their list of improvements (more info [here](https://github.com/actions/upload-artifact/issues/3#issuecomment-598820814)). > Maybe it would also be a good idea to upload a log (perhaps just the console > output)? > Like this, we might catch some warnings more easily that don't prevent a > successful creation, but would be nice to know anyways. I've updated this PR to enable the asciidoctor build to use the `--verbose` flag, which seems to show warnings. An example of what the output looks like now can be found [here](https://github.com/lesserwhirls/cf-conventions/runs/528953848#step:5:5). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/251#issuecomment-602903313 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Check that PRs do not break Asciidoctor build (#251)
This is great! Would it be possible to upload the pdf and html individually, not in an archive so as to facilitate easy inspection? Maybe it would also be a good idea to upload a log (perhaps just the console output)? Like this, we might catch some warnings more easily that don't prevent a successful creation, but would be nice to know anyways. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/251#issuecomment-602501875 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Check that PRs do not break Asciidoctor build (#251)
marqh approved this pull request. This looks well set up to me -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/251#pullrequestreview-377932598 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Check that PRs do not break Asciidoctor build (#251)
I agree this is a useful and sensible step thank you for the input @lesserwhirls -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/251#issuecomment-601308317 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Check that PRs do not break Asciidoctor build (#251)
As an example of what this will look like, see [here](https://github.com/lesserwhirls/cf-conventions/actions/runs/58486955). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/251#issuecomment-600877353 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
[CF-metadata] [cf-convention/cf-conventions] Check that PRs do not break Asciidoctor build (#251)
This PR enables a github action to check that PRs do not break the asciidoc build. If the build is successful, the pdf and html files are uploaded as artifacts to the action, which allow for easier previews of the generated files. You can view, comment on, or merge this pull request online at: https://github.com/cf-convention/cf-conventions/pull/251 -- Commit Summary -- * Check that PRs do not break Asciidoctor build -- File Changes -- A .github/workflows/check_adoc_build.yml (68) -- Patch Links -- https://github.com/cf-convention/cf-conventions/pull/251.patch https://github.com/cf-convention/cf-conventions/pull/251.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/251 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
