Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
Merged #344 into main. -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*event-6117012802__;Iw!!G2kpM7uM-TzIFchu!gO4PwwNZOWIo6TQxycY1hK2OM-jm_rJh_t1vyMQRKJXbXz6DZINb1PCzIkn2gZWN925zvvLMxAE$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
@zklaus pushed 1 commit. 66193b2e9804a2094053691a7658dbbfb1cff6ad Adopt better attribute name as suggested by @ethanrd -- View it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344/files/5acfa18af61bb8c63b6ea6049474cf086e20e657..66193b2e9804a2094053691a7658dbbfb1cff6ad__;!!G2kpM7uM-TzIFchu!k1j1q_bbeiU1Y6pM9KrpgFrsMGjCK77zO-Dof8YqXnyukHIt6ElDJQalpBEODy8AstPb2mE9JRw$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
I don't think that's necessary. Let's just check that everything works as expected. If it doesn't, we'll update the artifacts post-hoc. -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*issuecomment-1009113709__;Iw!!G2kpM7uM-TzIFchu!j5SCyNXhdf_VcgZlGzYj20Ay3F-shyR6lLsxSrbwOR4b0zAn22ZWnpCReZqGLJC-xmhIZxfOrvE$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
Would it be possible to make and destroy a test release? Or is that over the top? -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*issuecomment-1009048564__;Iw!!G2kpM7uM-TzIFchu!itM_s2O4D_hvJYChSV6smQOX5QLixUIesWlA2TCyunYzX925PeWy7NT41S4tUUWKAcTt6SNZtQA$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
Thanks, @erget. Before we merge, we should address the point raised by @ethanrd in #343, namely the name of the second attribute. Also, there is one caveat: The automatic "final" tagging is hard to test because the real conditions only show up at the release, so at least for the first release we should be ready for it to fail and have an eye on that. -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*issuecomment-1008988286__;Iw!!G2kpM7uM-TzIFchu!nkrC7kz-LjRg_Vs9YLHY2wtxfIlloJbrHfwcqSoACKhckFp5hS6HBJbJBkHhcv_ItjHE7RYiH_4$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
@zklaus pushed 2 commits. b5f746651571405b02008cbddc5ea04659fcd47b Correct typos and trailing whitespace in workflow ef00c0dc1484f1404cd65dc59c549a2ae72edc84 Add automatic final versioning to workflow -- View it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344/files/ff0a539a242555b27cd6aa5018e6e9a0c65b1530..ef00c0dc1484f1404cd65dc59c549a2ae72edc84__;!!G2kpM7uM-TzIFchu!nlbI9umPRbLIqXF9L9Tyw7xTkLZutdHWXlwEVUjJn49va9tgPmMNXx3BnXqGZoHHTJx1Cklz2yM$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
@erget approved this pull request. -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*pullrequestreview-846429155__;Iw!!G2kpM7uM-TzIFchu!gjlHWVKXdza87fBXgWxjOwY0_ebHrPPWjPn20bkyeSmb0dKKXZIdm-RQEwwAl_Sg-9FRnmt4b0w$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
I have added a fancified version of the version handling. Let me know what you think or if you want me to explain a bit more. -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*issuecomment-1007108115__;Iw!!G2kpM7uM-TzIFchu!hTgR6yWW07-VIEpVyzfJT3j9NlNJuxLZhy-Qs_yjJ14AqXYgLtz9YZ_lvvyLKFHNfQADgy5yQjk$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
@zklaus pushed 1 commit. ff0a539a242555b27cd6aa5018e6e9a0c65b1530 Fancify single sourced version -- View it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344/files/1bae8aead25c12a9b0f7cd0af7cfd636a8ed1ca3..ff0a539a242555b27cd6aa5018e6e9a0c65b1530__;!!G2kpM7uM-TzIFchu!l3zFgo2SFQp858jyayGeZ7ZYiZD29X1MHHR7seV2wuw-VrtDUxLkdQusrVng8mJtSxtQ4PnKAsk$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
@zklaus pushed 1 commit. 1bae8aead25c12a9b0f7cd0af7cfd636a8ed1ca3 Add -draft suffix to version -- View it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344/files/cf497a5759c3db2b36ff924381eb1aaab0067426..1bae8aead25c12a9b0f7cd0af7cfd636a8ed1ca3__;!!G2kpM7uM-TzIFchu!iDa0AGkFyxXRJo9tT-1BSCm8MUvZDnD1P0rvyy3O12UvlWY_u5ItiT_C7adbGmIE1pK5QvItZ8I$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
@erget commented on this pull request. > @@ -0,0 +1 @@ +:current-version: 1.10 I don't have overly strong feelings here, but in the absence of Sturm und Drang from other corners my preference would be to go with using `current-version` for the whole shebang. Reasoning: - It's simpler than having 2 attributes - It doesn't result in invalid CDL, since space characters are allowed and thus it would be easier to maintain, and also more obvious that one is working with a draft. -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*discussion_r779423131__;Iw!!G2kpM7uM-TzIFchu!i-lLctLOpkeIGqFCsuJ5EX69WCWBhTW8-cqMiqoZUWfWft6oqoeco78uTHWL--XgZrdOCLiAhys$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
@zklaus commented on this pull request. > @@ -0,0 +1 @@ +:current-version: 1.10 I had this locally at some point, but I removed it again because I felt that it looked odd in the `:Conventions` attribute both in the examples, which would read ``` // global attributes: :Conventions = "CF-1.10 draft" ; :featureType = "timeSeries" ; ``` and in the text where this attribute is described, for example ``` [...] attribute **`Conventions`** to a string value that contains "**`CF-1.10 draft`**". ``` Hence my suggestion to add a second `:status-indicator:` or similar that can be combined with the `:current-version:` where appropriate. But I am happy to use the simpler solution :) -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*discussion_r779005345__;Iw!!G2kpM7uM-TzIFchu!nGoSOyyQZg3LbY1jcYZsVySm4gPTv1Bfr3mDwIvnKeVhN5gmSoxbab-VvlzYgZPFsK8A4v5DlnY$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
@zklaus this looks cleverly solved to me. @davidhassell any thoughts here? You can check [the artefacts](https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344/checks__;!!G2kpM7uM-TzIFchu!h2oNcarcq0dskDk5BqBZugXJ8siKtV_FtX_BsAsLYShdDGZ-lxnupaS7UlJVcOcQNJDeHJ_CJSM$ ) and see how it looks when built. I've made a suggestion on `version.adoc` that might improve handling, let me know what you think. -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*issuecomment-1005686069__;Iw!!G2kpM7uM-TzIFchu!h2oNcarcq0dskDk5BqBZugXJ8siKtV_FtX_BsAsLYShdDGZ-lxnupaS7UlJVcOcQNJDeTRvSsWs$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
@erget commented on this pull request. > @@ -0,0 +1 @@ +:current-version: 1.10 Might it make sense to do this?: `:current-version: 1.10 draft` And then remove ` draft` pre-release? -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*pullrequestreview-844597929__;Iw!!G2kpM7uM-TzIFchu!jXBdileTf3p-prhQVJNCXXh2Ked4MHgoJLdGVLTnN5EuQfI9pNR_SJOvDFrczyQgcNAxQMTtKfU$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
This single sources the version number as discussed in #343. There are a few open questions. I split the version itself out into the new file `version.adoc`, which allows us to share the same version between `cf-conventions.adoc` and `conformance.adoc`. There was one small hiccup with the conformance document, which is that it used the version even in the top level anchor. The solution to address this here is to remove the version from the anchor, but this should be discussed. One other idea is to add the "draft" bit as well, either in a kind of "long" or "full" version attribute, or as a separate `status-designator` attribute. Finally, I made a few more replacements than originally mentioned. Most, I think, are uncontroversial, but please have a look and see if you disagree with any of them. -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344*issuecomment-1005047943__;Iw!!G2kpM7uM-TzIFchu!nCV9KldQ3MKgaa_aTXVwwJEBBnTPunMVROgr0bgCcAW8yOc2_rmlJgqSOjob2Hf1cAnI1MZyY0Y$ You are receiving this because you are subscribed to this thread. Message ID: This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
[CF-metadata] [cf-convention/cf-conventions] Single source version (PR #344)
See issue #343 for discussion of these changes. # Release checklist - [ ] Authors updated in `cf-conventions.adoc`? - [ ] Next version in `cf-conventions.adoc` up to date? Versioning inspired by [SemVer](https://urldefense.us/v3/__https://semver.org__;!!G2kpM7uM-TzIFchu!gfMppZYidvlnSbm-umwXX5wukH4W0mk5PgOrLhKF18gVtbpGxG6UU7Sm9dUhguXSNsuTt7yMPis$ ). - [ ] `history.adoc` up to date? - [ ] Conformance document up-to-date? # For maintainers After the merge remember to delete the source branch. Tags are set at the conclusion of the annual meeting; until then `master` always is a draft for the next version. You can view, comment on, or merge this pull request online at: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344__;!!G2kpM7uM-TzIFchu!gfMppZYidvlnSbm-umwXX5wukH4W0mk5PgOrLhKF18gVtbpGxG6UU7Sm9dUhguXSNsuTGhsd2Ag$ -- Commit Summary -- * Single-source version for cf-conventions * Single-source version for conformance -- File Changes -- M cf-conventions.adoc (3) M ch01.adoc (2) M ch02.adoc (2) M ch07.adoc (4) M conformance.adoc (7) A version.adoc (1) -- Patch Links -- https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344.patch__;!!G2kpM7uM-TzIFchu!gfMppZYidvlnSbm-umwXX5wukH4W0mk5PgOrLhKF18gVtbpGxG6UU7Sm9dUhguXSNsuTBl7R9aQ$ https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344.diff__;!!G2kpM7uM-TzIFchu!gfMppZYidvlnSbm-umwXX5wukH4W0mk5PgOrLhKF18gVtbpGxG6UU7Sm9dUhguXSNsuTPQI5Sf4$ -- Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/344__;!!G2kpM7uM-TzIFchu!gfMppZYidvlnSbm-umwXX5wukH4W0mk5PgOrLhKF18gVtbpGxG6UU7Sm9dUhguXSNsuTGhsd2Ag$ You are receiving this because you are subscribed to this thread. Message ID: cf-convention/cf-conventions/pull/3...@github.com This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
