Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
Closed #230 via ff0fccde628abf1d4ae21f08cbeae19704595039. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#event-3057228120 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
@erget I believe it is. I was out of town. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-589097492 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
Just a note concerning the pending merge of the PR corresponding to this issue - it is also attached to #231, which seems uncontroversial and has not generated any discussion. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-585879990 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
It appears that there is enough support for this proposal to start the countdown clock for acceptance of change #232. If there are no substantive modifications or objections, it can be merged in three weeks (February 13, 2020) for inclusion in CF 1.9 per the [contribution guidelines](https://github.com/cf-convention/cf-conventions/blob/master/CONTRIBUTING.md). -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-577782757 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
I'm just catching up on this, and I also support the proposal as it stands. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-576581870 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
> @magau your input is very valuable and there's no reason that you'd have to > be ashamed of any part of it - for such a widely used standard as CF there is > a need for a diversity of perspectives in order to catch all the > ramifications of changes like this and thus it's very much appreciated! I also agree with @erget . It is important that CF doesn't push for purity at the expense of users, so thank you for speaking up. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-576448968 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
Totally agree with @erget - I see no reason to be ashamed, and your input and perspective is certainly appreciated! @magau - would you happen to know of an easy to access dataset with the map coordinates in `m` instead of radians? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-576426857 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
@magau your input is very valuable and there's no reason that you'd have to be ashamed of any part of it - for such a widely used standard as CF there is a need for a diversity of perspectives in order to catch all the ramifications of changes like this and thus it's very much appreciated! -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-576176401 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
Since I've been the only one raising concerns about the proposal, which I'm a bit shame of, I must say that I agree with most of all that has been said by all of you. Actually, I'm in contradiction with myself activities since, has I've said before, I've been putting some efforts for the radian units, for the geostationary projection, to be supported by other software than the java-netcdf. But what I really think, is that nothing of this wold be necessary if the geostationary coordinates units were defined in meters. Which is, I guess, what Proj library is using, and also GDAL for writing. As most of the projected coordinates systems (safeguarding some exceptions like the equirectangular projection and derived using latitude/longitude...). Like @erget said, and I totally agree, for those who are encoding netcdf files, as data producers, the impact of this changes will be minimum. My concerns goes for those who are, or that may be in future, developing automated processes for making projection transforms and post writing. Maybe It would be good that they have less exceptions to handle with... Any way, I totally agree that what has been discussed here is effectively a defect and it has to be solved. So, it won't be me who'll keep feeding the discussion. I'd also like to thanks to all of you that are participating and are giving their contribute for a better understanding of the implications of this change, in a way that the cf-conventions can keep responding to the CF community needs. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-575898816 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
I support the proposal. I understand that this will be a nuisance for software reading the existing files that use angles instead of distance. However, I too think it should be easy enough to modify the existing code. Another option would be for those users to continue using CF 1.7 for their data, although I would hope they switch to CF 1.8. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-575824986 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
Here's a summary of the issue to date. New standard names to be used with coordinates variables for the geostationary projection have been proposed to resolve a problem with canonical units that exists with the standard names being used to date. This problem is a defect in the current version of CF (CF 1.7). The current CF conventions specify that the rectangular coordinates for the geostationary projection are identified by the **`standard_name`** attributes **`projection_x_coordinate`** and **`projection_y_coordinate`**. The standard name table declares these standard names to have canonical units of meters. The CF convention regarding standard names specifies that the units for a variable with a given standard name must have units that are convertible to the canonical units for that standard name. This conversion must be a simple units conversion — length to length, volume to volume, etc. The coordinate values for the geostationary projection are angles and have units of degrees or radians. It is a defect to use **`standard_name`** attributes of **`projection_x_coordinate`** and **`projection_y_coordinate`** for such coordinate variables because units of angles are not directly convertible to units of length. The proposed correction for the defect is creation of two new standard names for use with the geostationary projection. The new standard names are **`projection_x_angular_coordinate`** and **`projection_y_angular_coordinate`**. These new names would have canonical units of radians. A number of commenters have said they approve of the change. Others have expressed reservations about impacts on those who have already implemented software based on the current version of CF that might not recognize the coordinate variables because it was expecting the old standard names. @magau asked if it might be possible to change the CF conventions regarding standard name canonical units or make some exception for these particular standard names to resolve the defect without specifying new standard names. @erget suggested that the reservations, while valid, should not prevent correction of the defect, as it would not invalidate files claiming adherence to CF 1.7 (or 1.8), and it should not be difficult for software to support the new standard names. People indicating approval so far are: @iso @JimBiardCics @steingod @JonathanGregory Randy Horne @mraspaud People indicating concerns so far are: @magau -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-575788782 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
PR updated. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-575709077 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
Deferred to v1.9? That's probably a good plan. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-575708106 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
Thanks @JimBiardCics ! I was digging through the rules and wasn't able to find out what deadlines apply to corrections vs. enhancements (I'd consider this a correction, but others may disagree). The 1.8 release will probably be early February this year, should we try to vector this in there? If not I'll need to adjust the wording to reflect that it's deprecated from v1.9. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-575707430 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
@erget I'd moderate. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-575706288 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
I've implemented the discussed changes in the referenced PR. Anyone like to step in as moderator and start the clock/debate? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-575690684 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
I'm partly responsible for having the projection coordinates in radians today, but I support this proposal. I would suggest that the units of the `projection_x/y_coordinate` would be used in the libs mentionned by @magau to determine if the values need to be multiplied by the `perspective_point_height` or not. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-575168391 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
I'm not sure if I totally agree with this proposal... In fact I've been working on NetCDFs with geostationary projection for a while and have made my own contribution in the GDAL library and ADAGUC Server, in order to support "radian" units for the geostationary projection coordinates/dimension: OSGeo/gdal#1799 KNMI/adaguc-server#122 and Proj4 Documentation review: OSGeo/PROJ#1179 I also know that the netcdf-java library supports "radian" units, and besides it looks for the "projection_x_coordinate" and "projection_y_coordinate" values for the `standard_name` attribute to find the x\y horizontal coordinates variables: https://github.com/Unidata/netcdf-java/blob/master/cdm/core/src/main/java/ucar/unidata/geoloc/projection/sat/Geostationary.java#L33 This library (netcdf-java) is used by a bunch of NetCDF visualisation softwares like Panoply, McIDAS, THREDDS Data Server, etc... Thus, if your proposal is accepted I gess you'll loose a lot of software compatibility. One thing that I've missed is why we shoud assume that "meters" is the canonical units of the horizontal coordinates. If so, what is the `units` attribute for? I hope my considerations can help you to better understand of the inpact of this proposal... -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-574742097 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
I'm in favour as well. Thanks. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-574290142 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
I also support the proposal. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-574215701 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
I fully support this proposal, I work in the NWCSAF http://nwc-saf.eumetsat.int/, for the NWCSAF GEO part this inclusion is really convenient. This inclusion will highly benefit the users' community Llorenç Lliso PM Deputy of the NWCSAF -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-574200550 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#230)
I support this proposal to achieve a consistent approach. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/230#issuecomment-574175582 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
