[clang] cppcheck: use move semantics for 'NodeKinds' and update possible callers to use it (PR #87273)

[Amila Senadheera via cfe-commits]

Amila-Rukshan wrote:

@RKSimon I have rebased the changes

https://github.com/llvm/llvm-project/pull/87273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cppcheck: use move semantics for 'NodeKinds' and update possible callers to use it (PR #87273)

[Amila Senadheera via cfe-commits]

https://github.com/Amila-Rukshan updated 
https://github.com/llvm/llvm-project/pull/87273

>From d85a9656d72e6380171f25c79cb4454b694286da Mon Sep 17 00:00:00 2001
From: amila 
Date: Tue, 2 Apr 2024 00:15:59 +0530
Subject: [PATCH] use move semantics for NodeKinds and update possible callers
 to use it

Signed-off-by: amila 
---
 clang/lib/ASTMatchers/Dynamic/Marshallers.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/lib/ASTMatchers/Dynamic/Marshallers.h 
b/clang/lib/ASTMatchers/Dynamic/Marshallers.h
index c76ddf17b719d4..0e640cbada7268 100644
--- a/clang/lib/ASTMatchers/Dynamic/Marshallers.h
+++ b/clang/lib/ASTMatchers/Dynamic/Marshallers.h
@@ -937,7 +937,7 @@ class MapAnyOfMatcherDescriptor : public MatcherDescriptor {
 public:
   MapAnyOfMatcherDescriptor(ASTNodeKind CladeNodeKind,
 std::vector NodeKinds)
-  : CladeNodeKind(CladeNodeKind), NodeKinds(NodeKinds) {}
+  : CladeNodeKind(CladeNodeKind), NodeKinds(std::move(NodeKinds)) {}
 
   VariantMatcher create(SourceRange NameRange, ArrayRef Args,
 Diagnostics *Error) const override {
@@ -1026,7 +1026,7 @@ class MapAnyOfBuilderDescriptor : public 
MatcherDescriptor {
 }
 
 return std::make_unique(CladeNodeKind,
-   NodeKinds);
+   std::move(NodeKinds));
   }
 
   bool isVariadic() const override { return true; }

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cppcheck: use move semantics for 'NodeKinds' and update possible callers to use it (PR #87273)

[Amila Senadheera via cfe-commits]

Amila-Rukshan wrote:

Ping

https://github.com/llvm/llvm-project/pull/87273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cppcheck: use move semantics for 'NodeKinds' and update possible callers to use it (PR #87273)

[Amila Senadheera via cfe-commits]

Amila-Rukshan wrote:

@firewave, Thank you for pointing it out! I blindly tried to fix it looking at 
the cppcheck output. 

https://github.com/llvm/llvm-project/pull/87273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cppcheck: use move semantics for 'NodeKinds' and update possible callers to use it (PR #87273)

[Amila Senadheera via cfe-commits]

https://github.com/Amila-Rukshan edited 
https://github.com/llvm/llvm-project/pull/87273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cppcheck: pass NodeKinds by const reference (PR #87273)

[Amila Senadheera via cfe-commits]

https://github.com/Amila-Rukshan updated 
https://github.com/llvm/llvm-project/pull/87273

>From 4f8349936403d29ac14179fb7d9e1429a09914ff Mon Sep 17 00:00:00 2001
From: amila 
Date: Tue, 2 Apr 2024 00:15:59 +0530
Subject: [PATCH] use move semantics for NodeKinds and update possible callers
 to use it

Signed-off-by: amila 
---
 clang/lib/ASTMatchers/Dynamic/Marshallers.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/lib/ASTMatchers/Dynamic/Marshallers.h 
b/clang/lib/ASTMatchers/Dynamic/Marshallers.h
index c76ddf17b719d4..0e640cbada7268 100644
--- a/clang/lib/ASTMatchers/Dynamic/Marshallers.h
+++ b/clang/lib/ASTMatchers/Dynamic/Marshallers.h
@@ -937,7 +937,7 @@ class MapAnyOfMatcherDescriptor : public MatcherDescriptor {
 public:
   MapAnyOfMatcherDescriptor(ASTNodeKind CladeNodeKind,
 std::vector NodeKinds)
-  : CladeNodeKind(CladeNodeKind), NodeKinds(NodeKinds) {}
+  : CladeNodeKind(CladeNodeKind), NodeKinds(std::move(NodeKinds)) {}
 
   VariantMatcher create(SourceRange NameRange, ArrayRef Args,
 Diagnostics *Error) const override {
@@ -1026,7 +1026,7 @@ class MapAnyOfBuilderDescriptor : public 
MatcherDescriptor {
 }
 
 return std::make_unique(CladeNodeKind,
-   NodeKinds);
+   std::move(NodeKinds));
   }
 
   bool isVariadic() const override { return true; }

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cppcheck: pass NodeKinds by const reference (PR #87273)

[Amila Senadheera via cfe-commits]

https://github.com/Amila-Rukshan created 
https://github.com/llvm/llvm-project/pull/87273

Fix the cppcheck identified performance issue: 
https://github.com/llvm/llvm-project/issues/87248

I ran the following to check the possible perf issue in 
`clang/lib/ASTMatchers/Dynamic` directory:
```
cppcheck --enable=performance --language=c++ .
```

>From addf9911ffb22eb96f6b26e6a7eabcb8cc325123 Mon Sep 17 00:00:00 2001
From: amila 
Date: Tue, 2 Apr 2024 00:15:59 +0530
Subject: [PATCH] cppcheck: pass NodeKinds by const reference

Signed-off-by: amila 
---
 clang/lib/ASTMatchers/Dynamic/Marshallers.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/lib/ASTMatchers/Dynamic/Marshallers.h 
b/clang/lib/ASTMatchers/Dynamic/Marshallers.h
index c76ddf17b719d4..fc0771d7496df2 100644
--- a/clang/lib/ASTMatchers/Dynamic/Marshallers.h
+++ b/clang/lib/ASTMatchers/Dynamic/Marshallers.h
@@ -936,7 +936,7 @@ class MapAnyOfMatcherDescriptor : public MatcherDescriptor {
 
 public:
   MapAnyOfMatcherDescriptor(ASTNodeKind CladeNodeKind,
-std::vector NodeKinds)
+const std::vector& NodeKinds)
   : CladeNodeKind(CladeNodeKind), NodeKinds(NodeKinds) {}
 
   VariantMatcher create(SourceRange NameRange, ArrayRef Args,

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits