[PATCH] D52967: Extend shelf-life by 70 years

[Bernhard M. Wiedemann via Phabricator via cfe-commits]

bmwiedemann accepted this revision.
bmwiedemann added a comment.
Herald added a subscriber: dexonsmith.
Herald added a project: clang.

Can someone please merge this change?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52967/new/

https://reviews.llvm.org/D52967



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52967: Extend shelf-life by 70 years

[Bernhard M. Wiedemann via Phabricator via cfe-commits]

bmwiedemann added a comment.

As to the why: I'm working on reproducible builds for openSUSE and for that I 
verify that our packages can still give identical build results 15 years from 
now (which is the expected lifetime of today's enterprise software). `kvm -rtc 
base` option helps there.
Sometimes I even make it +20 years to find year-2038 bugs such as those in 
ninja and python , because it is better to 
fix them now rather than be surprised later and have a hard time with plenty 
busy work getting the fixes everywhere in time.

Now, it would be nice if someone could push this patch to the git repo.
I already got 200+ forks in my github home - most with just 1 small patch that 
eventually gets merged.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52967/new/

https://reviews.llvm.org/D52967



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52967: Extend shelf-life by 70 years

[Bernhard M. Wiedemann via Phabricator via cfe-commits]

bmwiedemann added a comment.

I tested now, that it still works on i586 (in addition to x86_64)


Repository:
  rC Clang

https://reviews.llvm.org/D52967



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52967: Extend shelf-life by 70 years

[Bernhard M. Wiedemann via Phabricator via cfe-commits]

bmwiedemann created this revision.
bmwiedemann added a reviewer: RKSimon.
Herald added a subscriber: cfe-commits.

Without this patch, tests would fail after 2030.

Note: requires timestamps with more than 31 bits


Repository:
  rC Clang

https://reviews.llvm.org/D52967

Files:
  test/Modules/fmodules-validate-once-per-build-session.c


Index: test/Modules/fmodules-validate-once-per-build-session.c
===
--- test/Modules/fmodules-validate-once-per-build-session.c
+++ test/Modules/fmodules-validate-once-per-build-session.c
@@ -51,8 +51,8 @@
 // RUN: not diff %t/modules-to-compare/Foo-before-user.pcm 
%t/modules-to-compare/Foo-after-user.pcm
 
 // ===
-// Recompile the module if the today's date is before 01 January 2030.
-// RUN: %clang_cc1 -cc1 -fmodules -fimplicit-module-maps -fdisable-module-hash 
-fmodules-cache-path=%t/modules-cache -fsyntax-only -isystem %t/Inputs 
-fbuild-session-timestamp=1893456000 -fmodules-validate-once-per-build-session 
%s
+// Recompile the module if the today's date is before 01 January 2100.
+// RUN: %clang_cc1 -cc1 -fmodules -fimplicit-module-maps -fdisable-module-hash 
-fmodules-cache-path=%t/modules-cache -fsyntax-only -isystem %t/Inputs 
-fbuild-session-timestamp=4102441200 -fmodules-validate-once-per-build-session 
%s
 // RUN: ls -R %t/modules-cache | grep Foo.pcm.timestamp
 // RUN: cp %t/modules-cache/Foo.pcm %t/modules-to-compare/Foo-after.pcm
 


Index: test/Modules/fmodules-validate-once-per-build-session.c
===
--- test/Modules/fmodules-validate-once-per-build-session.c
+++ test/Modules/fmodules-validate-once-per-build-session.c
@@ -51,8 +51,8 @@
 // RUN: not diff %t/modules-to-compare/Foo-before-user.pcm %t/modules-to-compare/Foo-after-user.pcm
 
 // ===
-// Recompile the module if the today's date is before 01 January 2030.
-// RUN: %clang_cc1 -cc1 -fmodules -fimplicit-module-maps -fdisable-module-hash -fmodules-cache-path=%t/modules-cache -fsyntax-only -isystem %t/Inputs -fbuild-session-timestamp=1893456000 -fmodules-validate-once-per-build-session %s
+// Recompile the module if the today's date is before 01 January 2100.
+// RUN: %clang_cc1 -cc1 -fmodules -fimplicit-module-maps -fdisable-module-hash -fmodules-cache-path=%t/modules-cache -fsyntax-only -isystem %t/Inputs -fbuild-session-timestamp=4102441200 -fmodules-validate-once-per-build-session %s
 // RUN: ls -R %t/modules-cache | grep Foo.pcm.timestamp
 // RUN: cp %t/modules-cache/Foo.pcm %t/modules-to-compare/Foo-after.pcm
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50559: [gnu-objc] Make selector order deterministic.

[Bernhard M. Wiedemann via Phabricator via cfe-commits]

bmwiedemann added a comment.

I got it compiled with std::sort on top of 6.0.1 and found that it indeed 
removes the indeterminism: When I compiled libobjc2-1.8.1/arc.m 25 times, I got 
the same md5sum every time - and the same result with and without ASLR.


Repository:
  rC Clang

https://reviews.llvm.org/D50559



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50559: [gnu-objc] Make selector order deterministic.

[Bernhard M. Wiedemann via Phabricator via cfe-commits]

bmwiedemann added a comment.

got a build failure with this patch added onto 6.0.1




Comment at: lib/CodeGen/CGObjCGNU.cpp:3547
+  allSelectors.push_back(entry.first);
+llvm::sort(allSelectors.begin(), allSelectors.end());
 

compilation failed here:
../tools/clang/lib/CodeGen/CGObjCGNU.cpp:2444:11: error: 'sort' is not a member 
of 'llvm'

it suggested std::sort


Repository:
  rC Clang

https://reviews.llvm.org/D50559



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits