[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D155775#4652773 , @AlexVlx wrote:

> In D155775#4652767 , @dyung wrote:
>
>> Hi @AlexVlx, the test you added is failing on an linux bot, can you take a 
>> look and revert if you need time to investigate? It appears it has been 
>> failing for over 6 hours.
>>
>> https://lab.llvm.org/buildbot/#/builders/139/builds/50940
>
> This is another unsupported target (as is hexagon which is also failing), 
> that I'll temporarily disable, but I admit to being actually confused as to 
> why it's failing there, because the sequence it cannot find appears to be 
> there. Thank you for flagging it.

Note that this linux bot builds with the ps4 target as the default target.

At this point, would it be easier to add a REQUIRES line for the target the 
test should support rather than just whack-a-mole for the targets it does not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155775/new/

https://reviews.llvm.org/D155775

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D155775#4652698 , @AlexVlx wrote:

> https://reviews.llvm.org/rG0701ee69f7ac should fix it, once again apologies 
> for the noise.

FYI, the test is still failing on the Windows PS5 bot after your change: 
https://lab.llvm.org/buildbot/#/builders/216/builds/28289


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155775/new/

https://reviews.llvm.org/D155775

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @AlexVlx, the test you added is failing on an linux bot, can you take a look 
and revert if you need time to investigate? It appears it has been failing for 
over 6 hours.

https://lab.llvm.org/buildbot/#/builders/139/builds/50940


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155775/new/

https://reviews.llvm.org/D155775

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D147655#4650663 , @rjmccall wrote:

> I've been informed that Apple's change to the default ABI compatibility mode 
> is in our private fork, so this is not your problem; sorry for the noise.
>
> I'm not sure why we decided to do that privately; I'll see if we can fix that.

We (Sony) also use an older ABI and I am working on a patch to be committed 
upstream to fix this for our target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147655/new/

https://reviews.llvm.org/D147655

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @sammccall, your change seems to be causing a test failure on several bots, 
can you take a look and revert if you need time to investigate?

   TEST 'Clang-Unit :: 
Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/8/35' FAILED 

  Script(shard):
  --
  
GTEST_OUTPUT=json:/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/unittests/Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests-Clang-Unit-1681597-8-35.json
 GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=35 GTEST_SHARD_INDEX=8 
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/unittests/Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests
  --
  Script:
  --
  
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/unittests/Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests
 --gtest_filter=BoolValueDebugStringTest.ComplexBooleanWithSomeNames
  --
  
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/unittests/Analysis/FlowSensitive/DebugSupportTest.cpp:111:
 Failure
  Value of: Actual
  Expected: is equal to "((Y & V2) | (X | V3))"
Actual: "((Y & V3) | (X | V2))"
  
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/unittests/Analysis/FlowSensitive/DebugSupportTest.cpp:111
  Value of: Actual
  Expected: is equal to "((Y & V2) | (X | V3))"
Actual: "((Y & V3) | (X | V2))"
  

Some affected bots:

- https://lab.llvm.org/buildbot/#/builders/139/builds/50255
- https://lab.llvm.org/buildbot/#/builders/216/builds/27735
- https://lab.llvm.org/buildbot/#/builders/247/builds/9334


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153485/new/

https://reviews.llvm.org/D153485

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @rsmith, we have an internal test where your change seems to have changed 
the mangling in C++17 mode and wanted to check if that was intentional.

Consider the following code:

  // Literals in templates
  #include 
  template  T returnit() {return I;};
  enum colour { RED = -3, GREEN, BLUE};
  // use long type for enumeration
  enum bigcolour { YELLOW = (1l << 32), CYAN, MAGENTA};
  void callreturnit() {
  auto a = returnit();
  auto b = returnit();
  auto c = returnit();
  auto d = returnit();
  auto e = returnit();
  auto f = returnit();
  auto g = returnit();
  auto n = returnit();
  auto cg = returnit();
  auto cy = returnit();
  }

The compiler in C++17 mode now seems to differently mangle each instance:

| function | before 
   | after  |
| returnit();  | _Z8returnitIiLi4EET_v  
   | _Z8returnitIiTnT_Li4EES0_v |
| returnit(); | _Z8returnitIjLj4EET_v  
   | _Z8returnitIjTnT_Lj4EES0_v |
| returnit(); | _Z8returnitIlLl4EET_v  
   | _Z8returnitIlTnT_Ll4EES0_v |
| returnit();| _Z8returnitImLm4EET_v  
   | _Z8returnitImTnT_Lm4EES0_v |
| returnit();  | _Z8returnitIxLxn456789EET_v
   | _Z8returnitIxTnT_Lxn456789EES0_v   |
| returnit();  | _Z8returnitIbLb1EET_v  
   | _Z8returnitIbTnT_Lb1EES0_v |
| returnit(); | _Z8returnitIbLb0EET_v  
   | _Z8returnitIbTnT_Lb0EES0_v |
| returnit(); | _Z8returnitIDnLDn0EET_v
   | _Z8returnitIDnTnT_LDn0EES0_v   |
| returnit();   | _Z8returnitI6colourLS0_n2EET_v 
   | _Z8returnitI6colourTnT_LS0_n2EES1_v|
| returnit();   | 
_Z8returnitI9bigcolourLS0_4294967296EET_v | 
_Z8returnitI9bigcolourTnT_LS0_4294967296EES1_v |
|

Are these changes in non-C++20 mode intentional?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147655/new/

https://reviews.llvm.org/D147655

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Sorry to comment so late, but I just had time to look into this a little bit. 
This change broke running lit tests for me on Windows, and I wanted to see if 
there was a way I could restore it.

For reference, my sources are stored locally at `C:\Dev\git\dev`, but I until 
this change, I was able to access them through a file system junction point at 
`C:\src\git\dev` and run lit tests using that. But after this change, I can no 
longer run the lit tests when I am in `C:\src\git\dev`. My system is setup this 
way because we have weird A/V scanning rules that only exclude certain named 
directories, and my original path wasn't one of them, so I used the file system 
junction point to get my builds excluded while continuing to use the path 
structure that was familiar to me and that I also use on other systems 
(mac/linux).

Since this change seems to be targeted towards preventing resolving paths that 
are greater than `MAX_PATH` on Windows, could we possibly leave the 
substitution in, but check if the resulting path is longer than MAX_PATH rather 
than just excluding it completely?

Specifically, where I am seeing the difference is in the new function 
`abs_path_preserve_drive()` in util.py where we are now using 
`os.path.abspath()` instead of `os.path.realpath()`. I'm not completely sure 
what the effects of such a change might be to the rest of this change, but 
keeping the old conversion and then checking against `MAX_PATH` it seems would 
still accomplish your goal while allowing cases like mine to continue working 
as they previously did.

Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154130/new/

https://reviews.llvm.org/D154130

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @leonardchan your change was still causing a failure on the PS4 linux bot, 
so I reverted it in 070493ddbd9473499d6f00ca62bc6aa92808ed79 
. I 
noticed earlier that the failing test omit-rtti-component-without-no-rtti.cpp 
was failing on both the linux and Windows PS bots, and I don't think it is 
because it was on Windows, but rather, these bots use PS4 and PS5 as the 
default targets, on which rtti is not enabled by default. The run command on 
line 4 in your test tests the "default" behavior which on most platforms seems 
to have rtti enabled by default. If I remove that line, the test then passes on 
both of the PS targets. To reland the change, you might want to consider 
removing that line as it makes an assumption which does not seem to be true for 
all targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152405/new/

https://reviews.llvm.org/D152405

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @serge-sans-paille, the test you added seems to be failing on some bots. Can 
you take a look and revert if you need time to investigate?

- https://lab.llvm.org/buildbot/#/builders/139/builds/48265
- https://lab.llvm.org/buildbot/#/builders/216/builds/26208


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158558/new/

https://reviews.llvm.org/D158558

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D158227#4610097 , @Manna wrote:

> The failure seems unrelated to my change.

Hi @Manna, I'm not sure which failure you are referring to, but there is a test 
failure on at least 2 build bots that seems to have been caused by your change. 
Can you take a look and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/139/builds/48141
https://lab.llvm.org/buildbot/#/builders/216/builds/26116


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158227/new/

https://reviews.llvm.org/D158227

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D92797#4596289 , @ronlieb wrote:

> hi, this seems to be breaking out amdgpu opemp and hip buildbots
> https://lab.llvm.org/staging/#/builders/247/builds/4967

And also some GCC based bots:
https://lab.llvm.org/buildbot/#/builders/139/builds/47730
https://lab.llvm.org/buildbot/#/builders/247/builds/7889


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92797/new/

https://reviews.llvm.org/D92797

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @serge-sans-paille, your change is causing the test you modified, 
`clang/test/AST/ast-dump-attr-json.cpp` to fail. Can you take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/47461
https://lab.llvm.org/buildbot/#/builders/109/builds/71264


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157808/new/

https://reviews.llvm.org/D157808

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157467: [RISCV] Add missing REQUIRES for zvk-invalid.c test

[Douglas Yung via Phabricator via cfe-commits]

dyung accepted this revision.
dyung added a comment.
This revision is now accepted and ready to land.

lgtm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157467/new/

https://reviews.llvm.org/D157467

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

The test you added clang/test/Sema/zvk-invalid.c is failing on bots, for 
example https://lab.llvm.org/buildbot/#/builders/139/builds/47055.

Is the test missing a `REQUIRES: riscv-registered-target` line by any chance?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138810/new/

https://reviews.llvm.org/D138810

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D156363#4546171 , @dyung wrote:

> In D156363#4545474 , @MaskRay wrote:
>
>> In D156363#4545215 , @dyung wrote:
>>
>>> If you cannot reproduce this issue, I can take my buildbot offline and try 
>>> to reproduce it to pinpoint which command is causing the problem, but I 
>>> won’t be able to do so until Monday.
>>
>> Thank you, knowing which command caused the failure will be very helpful.
>> `clang/test/Driver/fsanitize.c` has the most mysterious failure I have dealt 
>> with for this patch.
>>
>> FWIW I've checked that the test passes even if `/usr` does not exist 
>> (emulated by proot) => there is as if no host GCC installation that could 
>> affect Driver's behavior
>>
>>   % cat /tmp/Rel/bin/xxx
>>   #!/bin/zsh
>>   d=$(dirname "$0")
>>   exec proot -R /tmp -b /bin -b /lib64 -b /lib $d/clang 
>> --target=aarch64-linux-musl "$@"
>>   % cd clang/test/Driver
>>   % CLANG=/tmp/Rel/bin/xxx /tmp/Rel/bin/llvm-lit -vv fsanitize.c
>>   .. passed
>
> I have to run, but I did a quick -vv run with this commit and it seems to 
> fail on the RUN line on 588:
>
>   + : 'RUN: at line 581'
>   + /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang 
> --target=i386-apple-ios-simulator -fsanitize=leak 
> /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
>  -###
>   + 
> /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck 
> /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
>  --check-prefix=CHECK-LSAN-I386-IOSSIMULATOR
>   + : 'RUN: at line 584'
>   + /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang 
> --target=i386-apple-tvos-simulator -fsanitize=leak 
> /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
>  -###
>   + 
> /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck 
> /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
>  --check-prefix=CHECK-LSAN-I386-TVOSSIMULATOR
>   + : 'RUN: at line 588'
>   + not 
> /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang 
> --target=x86_64-linux-gnu -fvisibility=hidden -fsanitize=cfi -flto -c 
> /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
>  -###
>   + 
> /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck 
> /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
>  --check-prefix=CHECK-CFI
>   
>   --
>   
>   
>   
>   Failed Tests (1):
> Clang :: Driver/fsanitize.c
>
> I'll try to look more later when I get more time.

It appears that the clang command in the RUN line returns 0 which the `not` you 
added inverts it causing the test to fail:

  
buildbot@6a3c0c51ae89:~/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver$
 /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang 
--target=x86_64-linux-gnu -fvisibility=hidden -fsanitize=cfi -flto -c 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize2.c
 -###
  clang version 18.0.0 (https://github.com/llvm/llvm-project.git 
8c3550b1a78fde7bf28f420da8447d9fde37017f)
  Target: x86_64-unknown-linux-gnu
  Thread model: posix
  InstalledDir: 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin
   (in-process)
   
"/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang-18" 
"-cc1" "-triple" "x86_64-unknown-linux-gnu" "-emit-llvm-bc" "-flto=full" 
"-flto-unit" "-disable-free" "-clear-ast-before-backend" "-main-file-name" 
"fsanitize2.c" "-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" 
"-mframe-pointer=all" "-fmath-errno" "-ffp-contract=on" "-fno-rounding-math" 
"-mconstructor-aliases" "-funwind-tables=2" "-target-cpu" "x86-64" "-tune-cpu" 
"generic" "-debugger-tuning=gdb" 
"-fcoverage-compilation-dir=/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver"
 "-resource-dir" 
"/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/lib/clang/18" 
"-internal-isystem" 
"/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/lib/clang/18/include"
 "-internal-isystem" "/usr/local/include" "-internal-isystem" 
"/usr/lib/gcc/x86_64-linux-gnu/9/../../../../x86_64-linux-gnu/include" 
"-internal-externc-isystem" "/usr/include/x86_64-linux-gnu" 
"-internal-externc-isystem" "/include" "-internal-externc-isystem" 
"/usr/include" 
"-fdebug-compilation-dir=/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver"
 "-ferror-limit" "19" "-fvisibility=hidden" 

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D156363#4545474 , @MaskRay wrote:

> In D156363#4545215 , @dyung wrote:
>
>> If you cannot reproduce this issue, I can take my buildbot offline and try 
>> to reproduce it to pinpoint which command is causing the problem, but I 
>> won’t be able to do so until Monday.
>
> Thank you, knowing which command caused the failure will be very helpful.
> `clang/test/Driver/fsanitize.c` has the most mysterious failure I have dealt 
> with for this patch.
>
> FWIW I've checked that the test passes even if `/usr` does not exist 
> (emulated by proot) => there is as if no host GCC installation that could 
> affect Driver's behavior
>
>   % cat /tmp/Rel/bin/xxx
>   #!/bin/zsh
>   d=$(dirname "$0")
>   exec proot -R /tmp -b /bin -b /lib64 -b /lib $d/clang 
> --target=aarch64-linux-musl "$@"
>   % cd clang/test/Driver
>   % CLANG=/tmp/Rel/bin/xxx /tmp/Rel/bin/llvm-lit -vv fsanitize.c
>   .. passed

I have to run, but I did a quick -vv run with this commit and it seems to fail 
on the RUN line on 588:

  + : 'RUN: at line 581'
  + /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang 
--target=i386-apple-ios-simulator -fsanitize=leak 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
 -###
  + 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
 --check-prefix=CHECK-LSAN-I386-IOSSIMULATOR
  + : 'RUN: at line 584'
  + /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang 
--target=i386-apple-tvos-simulator -fsanitize=leak 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
 -###
  + 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
 --check-prefix=CHECK-LSAN-I386-TVOSSIMULATOR
  + : 'RUN: at line 588'
  + not 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang 
--target=x86_64-linux-gnu -fvisibility=hidden -fsanitize=cfi -flto -c 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
 -###
  + 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c
 --check-prefix=CHECK-CFI
  
  --
  
  
  
  Failed Tests (1):
Clang :: Driver/fsanitize.c

I'll try to look more later when I get more time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156363/new/

https://reviews.llvm.org/D156363

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

If you cannot reproduce this issue, I can take my buildbot offline and try to 
reproduce it to pinpoint which command is causing the problem, but I won’t be 
able to do so until Monday.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156363/new/

https://reviews.llvm.org/D156363

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D156363#4544803 , @aaron.ballman 
wrote:

> In D156363#4544782 , @thakis wrote:
>
>> http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this 
>> something on my end?
>
> Nope, this same failure is happening in our build farm:
> https://lab.llvm.org/buildbot/#/builders/197/builds/8677
> https://lab.llvm.org/buildbot/#/builders/179/builds/6872
> https://lab.llvm.org/buildbot/#/builders/198/builds/4171
>
> (and others)

We are also seeing this on our build bot: 
https://lab.llvm.org/buildbot/#/builders/247/builds/7117


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156363/new/

https://reviews.llvm.org/D156363

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156127: Partially revert changes to test lang-std.cpp

[Douglas Yung via Phabricator via cfe-commits]

dyung added inline comments.



Comment at: clang/test/Preprocessor/lang-std.cpp:1
+// UNSUPPORTED: target={{.*-(ps4|ps5)}}
 /// Test default standards.

This should be unneeded now, we recently updated the PS platforms to default to 
c++17 like the rest of the compiler in aa34b34e93d444efec6cd894e5e55927d0e413e6
.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156127/new/

https://reviews.llvm.org/D156127

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @yaxunl, your change appears to have broken the LLDB build. Can you take a 
look and revert if you time to investigate?

https://lab.llvm.org/buildbot/#/builders/243/builds/9581

  FAILED: 
tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o
 
  /opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG 
-D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D_LIBCPP_ENABLE_ASSERTIONS 
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/build/tools/lldb/source/Plugins/TypeSystem/Clang
 
-I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/source/Plugins/TypeSystem/Clang
 
-I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/include
 
-I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/build/tools/lldb/include
 
-I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/build/include
 
-I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/llvm/include
 -I/usr/include/python3.10 
-I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/llvm/../clang/include
 
-I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/build/tools/lldb/../clang/include
 
-I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/source
 
-I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/build/tools/lldb/source
 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden 
-Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter 
-Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic 
-Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized 
-Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move 
-Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment 
-Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color 
-ffunction-sections -fdata-sections -Wno-deprecated-declarations 
-Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG 
 -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT 
tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o
 -MF 
tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o.d
 -o 
tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o
 -c 
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
  
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:
 In function ‘void ParseLangArgs(clang::LangOptions&, clang::InputKind, const 
char*)’:
  
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:489:31:
 error: ‘lang_cuda’ is not a member of ‘clang::LangStandard’
489 |   LangStd = LangStandard::lang_cuda;
|   ^
  
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:501:31:
 error: ‘lang_hip’ is not a member of ‘clang::LangStandard’
501 |   LangStd = LangStandard::lang_hip;
|   ^~~~

Other failing buildbots:

- https://lab.llvm.org/buildbot/#/builders/96/builds/42305
- https://lab.llvm.org/buildbot/#/builders/17/builds/40545
- https://lab.llvm.org/buildbot/#/builders/68/builds/56513


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155539/new/

https://reviews.llvm.org/D155539

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@mikecrowe Your change is causing a test failure on the PS4 linux and PS5 
Windows build bots. Can you take a look and fix or revert if you need time to 
investigate?

https://lab.llvm.org/buildbot/#/builders/139/builds/43856
https://lab.llvm.org/buildbot/#/builders/216/builds/23017


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153860/new/

https://reviews.llvm.org/D153860

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

If we do not accept the form "`-fcaret-diagnostics-max-lines n`", can we add a 
negative for that? Or if we do a positive test for it as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152090/new/

https://reviews.llvm.org/D152090

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

[Douglas Yung via Phabricator via cfe-commits]

dyung added inline comments.



Comment at: clang/docs/ReleaseNotes.rst:290
+  number of code lines it prints has been increased from 1 to 16. This
+  can be controlled using ``-fcaret-diagnostics-max-lines=``.
 

Is this correct? I notice that all of the tests you update used the form of the 
option "-fcaret-diagnostics-max-lines n" rather than 
"-fcaret-diagnostics-max-lines=n". When I tried to update some private tests to 
use "-fcaret-diagnostics-max-lines=n", the compiler did not accept it, but when 
I changed it to use "-fcaret-diagnostics-max-lines n" it worked. I think we 
either need to update the option to accept both forms or to correct the 
documentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147875/new/

https://reviews.llvm.org/D147875

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D141627#4374757 , @tianshilei1992 
wrote:

> In D141627#4374753 , @Northbadge 
> wrote:
>
>> FYI this is failing- 
>> https://lab.llvm.org/buildbot/#/builders/109/builds/64971/steps/6/logs/FAIL__Clang__bug59160_c
>
> Thanks. I pushed a fix in eaf3de6970fc 
> .

In case you are not already aware, the test is still failing after your fix:
https://lab.llvm.org/buildbot/#/builders/139/builds/41495


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141627/new/

https://reviews.llvm.org/D141627

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@t-rasmud I am sorry, but I had to revert your change, it is randomly failing 
on the Windows bots causing a lot of instability. See the revert commit message 
for examples.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145739/new/

https://reviews.llvm.org/D145739

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D145739#4370674 , @barannikov88 
wrote:

> Hi, just a heads-up, some bots seem to be unhappy with the test:
>
> https://lab.llvm.org/buildbot/#/builders/216/builds/21765
>
>   error: 'note' diagnostics expected but not seen: 
> File 
> Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\SemaCXX\warn-unsafe-buffer-usage-multi-decl-warnings.cpp
>  Line 169: {{^change type of 'q' to 'std::span' to preserve bounds 
> information, and change 'r' and 'p' to 'std::span' to propagate bounds 
> information between them$}}
>   error: 'note' diagnostics seen but not expected: 
> File 
> Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\SemaCXX\warn-unsafe-buffer-usage-multi-decl-warnings.cpp
>  Line 169: change type of 'q' to 'std::span' to preserve bounds information, 
> and change 'p' and 'r' to 'std::span' to propagate bounds information between 
> them
>   2 errors generated.

The test seems to randomly pass and fail on the bot. It seems that the order of 
'p' and 'r' in the output string may not be deterministic? Can you make the 
test more reliable or make it handle each situation (if appropriate)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145739/new/

https://reviews.llvm.org/D145739

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @owenpan and @Sedeniono, this change is causing test failures across many 
bots, can you take a look and fix or revert if you need time to investigate?

Failing bots:

- https://lab.llvm.org/buildbot/#/builders/139/builds/41339
- https://lab.llvm.org/buildbot/#/builders/216/builds/21703
- https://lab.llvm.org/buildbot/#/builders/247/builds/4864
- https://lab.llvm.org/buildbot/#/builders/164/builds/38364
- https://lab.llvm.org/buildbot/#/builders/188/builds/30101
- https://lab.llvm.org/buildbot/#/builders/197/builds/5761
- https://lab.llvm.org/buildbot/#/builders/184/builds/3948
- https://lab.llvm.org/buildbot/#/builders/245/builds/8785
- https://lab.llvm.org/buildbot/#/builders/258/builds/1288
- https://lab.llvm.org/buildbot/#/builders/249/builds/4662
- https://lab.llvm.org/buildbot/#/builders/230/builds/13432
- https://lab.llvm.org/buildbot/#/builders/109/builds/64778


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151047/new/

https://reviews.llvm.org/D151047

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @HerrCai0907, this change is failing on the PS4 linux and PS5 Windows bot. 
Can you take a look? I'm guessing these failures are likely due to the PS4/PS5 
target defaulting to a different C/C++ standard than the rest of clang.

https://lab.llvm.org/buildbot/#/builders/139/builds/41248
https://lab.llvm.org/buildbot/#/builders/216/builds/21637


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149516/new/

https://reviews.llvm.org/D149516

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

I'm not really sure where else to post this, but the pre-merge linux bot still 
seems to be running 3.18.4.

https://buildkite.com/llvm-project/premerge-checks/builds/152678#018828d2-1837-4fc2-baec-fca595969219

  CMake Error at CMakeLists.txt:3 (cmake_minimum_required):
CMake 3.20.0 or higher is required.  You are running version 3.18.4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

[Douglas Yung via Phabricator via cfe-commits]

dyung added inline comments.



Comment at: clang/test/Driver/ftime-trace.cpp:54
+// RUN: %clang -### -ftime-trace=e -ftime-trace-granularity=0 d/a.cpp d/b.c -o 
f/x -dumpdir f/ 2>&1 | FileCheck %s --check-prefix=LINK3
+// LINK3: -cc1{{.*}} "-ftime-trace=e/a-{{[^.]*}}.json" 
"-ftime-trace-granularity=0"
+// LINK3: -cc1{{.*}} "-ftime-trace=e/b-{{[^.]*}}.json" 
"-ftime-trace-granularity=0"

This seems to be failing on Windows due to path separator issues:
https://lab.llvm.org/buildbot/#/builders/216/builds/21115/steps/7/logs/FAIL__Clang__ftime-trace_cpp
```
... "-ftime-trace=e\\a-b9537d.json" ...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150282/new/

https://reviews.llvm.org/D150282

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @MaskRay, the test you modified clang/test/Driver/split-debug.c is failing 
on the PS5 Windows bot, can you take a look?

https://lab.llvm.org/buildbot/#/builders/216/builds/20981

  # command stderr:
  
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Driver\split-debug.c:72:21:
 error: SPLIT_LINK_NULL: expected string not found in input
  // SPLIT_LINK_NULL: "-dumpdir" "/dev/null-"
  ^
  :1:1: note: scanning from here
  clang version 17.0.0 (https://github.com/llvm/llvm-project.git 
16a0a69aadf1ad04efeaab9073bebdfb4b4fd34f)
  ^
  :5:130: note: possible intended match here
   "z:\\b\\llvm-clang-x86_64-sie-win\\build\\bin\\clang.exe" "-cc1" "-triple" 
"x86_64-unknown-linux-gnu" "-emit-obj" "-mrelax-all" "-dumpdir" 
"C:\\Users\\buildbot\\AppData\\Local\\Temp\\lit-tmp-zjxfa_79\\tmpq2vte1gy-" 
"-disable-free" "-clear-ast-before-backend" "-main-file-name" "split-debug.c" 
"-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" "-mframe-pointer=all" 
"-fmath-errno" "-ffp-contract=on" "-fno-rounding-math" "-mconstructor-aliases" 
"-funwind-tables=2" "-target-cpu" "x86-64" "-tune-cpu" "generic" 
"-debug-info-kind=constructor" "-dwarf-version=5" "-debugger-tuning=gdb" 
"-ggnu-pubnames" "-split-dwarf-file" 
"C:\\Users\\buildbot\\AppData\\Local\\Temp\\lit-tmp-zjxfa_79\\tmpq2vte1gy-split-debug.dwo"
 "-split-dwarf-output" 
"C:\\Users\\buildbot\\AppData\\Local\\Temp\\lit-tmp-zjxfa_79\\tmpq2vte1gy-split-debug.dwo"
 
"-fcoverage-compilation-dir=Z:\\b\\llvm-clang-x86_64-sie-win\\build\\tools\\clang\\test\\Driver"
 "-resource-dir" "z:\\b\\llvm-clang-x86_64-sie-win\\build\\lib\\clang\\17" 
"-internal-isystem" 
"z:\\b\\llvm-clang-x86_64-sie-win\\build\\lib\\clang\\17\\include" 
"-internal-isystem" "/usr/local/include" "-internal-externc-isystem" "/include" 
"-internal-externc-isystem" "/usr/include" 
"-fdebug-compilation-dir=Z:\\b\\llvm-clang-x86_64-sie-win\\build\\tools\\clang\\test\\Driver"
 "-ferror-limit" "19" "-fgnuc-version=4.2.1" "-faddrsig" 
"-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o" 
"C:\\Users\\buildbot\\AppData\\Local\\Temp\\lit-tmp-zjxfa_79\\split-debug-c67aff.o"
 "-x" "c" 
"Z:\\b\\llvm-clang-x86_64-sie-win\\llvm-project\\clang\\test\\Driver\\split-debug.c"

   ^
  Input file: 
  Check file: 
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Driver\split-debug.c
  -dump-input=help explains the following input dump.
  Input was:
  <<
  1: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 
16a0a69aadf1ad04efeaab9073bebdfb4b4fd34f) 
  check:72'0 
X
 error: no match found
  2: Target: x86_64-unknown-linux-gnu 
  check:72'0 ~
  3: Thread model: posix 
  check:72'0 
  4: InstalledDir: z:\b\llvm-clang-x86_64-sie-win\build\bin 
  check:72'0 ~~~
  5:  "z:\\b\\llvm-clang-x86_64-sie-win\\build\\bin\\clang.exe" 
"-cc1" "-triple" "x86_64-unknown-linux-gnu" "-emit-obj" "-mrelax-all" 
"-dumpdir" 
"C:\\Users\\buildbot\\AppData\\Local\\Temp\\lit-tmp-zjxfa_79\\tmpq2vte1gy-" 
"-disable-free" "-clear-ast-before-backend" "-main-file-name" "split-debug.c" 
"-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" "-mframe-pointer=all" 
"-fmath-errno" "-ffp-contract=on" "-fno-rounding-math" "-mconstructor-aliases" 
"-funwind-tables=2" "-target-cpu" "x86-64" "-tune-cpu" "generic" 
"-debug-info-kind=constructor" "-dwarf-version=5" "-debugger-tuning=gdb" 
"-ggnu-pubnames" "-split-dwarf-file" 
"C:\\Users\\buildbot\\AppData\\Local\\Temp\\lit-tmp-zjxfa_79\\tmpq2vte1gy-split-debug.dwo"
 "-split-dwarf-output" 
"C:\\Users\\buildbot\\AppData\\Local\\Temp\\lit-tmp-zjxfa_79\\tmpq2vte1gy-split-debug.dwo"
 
"-fcoverage-compilation-dir=Z:\\b\\llvm-clang-x86_64-sie-win\\build\\tools\\clang\\test\\Driver"
 "-resource-dir" "z:\\b\\llvm-clang-x86_64-sie-win\\build\\lib\\clang\\17" 
"-internal-isystem" 
"z:\\b\\llvm-clang-x86_64-sie-win\\build\\lib\\clang\\17\\include" 
"-internal-isystem" "/usr/local/include" "-internal-externc-isystem" "/include" 
"-internal-externc-isystem" "/usr/include" 
"-fdebug-compilation-dir=Z:\\b\\llvm-clang-x86_64-sie-win\\build\\tools\\clang\\test\\Driver"
 "-ferror-limit" "19" "-fgnuc-version=4.2.1" "-faddrsig" 
"-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o" 
"C:\\Users\\buildbot\\AppData\\Local\\Temp\\lit-tmp-zjxfa_79\\split-debug-c67aff.o"
 "-x" "c" 
"Z:\\b\\llvm-clang-x86_64-sie-win\\llvm-project\\clang\\test\\Driver\\split-debug.c"
 
  check:72'0 

[PATCH] D149655: [tests] Add missing REQUIRES: riscv-registered-target to clang test

[Douglas Yung via Phabricator via cfe-commits]

dyung accepted this revision.
dyung added a comment.
This revision is now accepted and ready to land.

lgtm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149655/new/

https://reviews.llvm.org/D149655

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D148223#4312460 , @4vtomat wrote:

> Hi @craig.topper and @kito-cheng , the build error message was: 
> 'Z:\test\llvm-project\clang\test\CodeGen\RISCV\rvv-intrinsics-autogenerated\non-policy\non-overloaded\xsfvcp-x-rv64.c:4:10:
>  fatal error: 'riscv_vector.h' file not found'.
> Have you ever met this before? I'm not sure if I forgot to add something or 
> not..

This bot only builds the x86_64 backend. Isn’t that file only generated when 
the riscv backend is built?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148223/new/

https://reviews.llvm.org/D148223

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

[Douglas Yung via Phabricator via cfe-commits]

dyung added inline comments.



Comment at: llvm/test/MC/ELF/debug-prefix-map.s:54
+
+# MAPABS_V5_A:DW_AT_comp_dir [DW_FORM_string] ("{{(/|\\)+}}src_root/bar")
+# MAPABS_V5_A:DW_AT_decl_file [DW_FORM_data4] 
("/src_root{{(/|\\)+}}bar{{(/|\\)+}}src.s")

This might need another regex for the path separator between src_root and bar.
https://lab.llvm.org/buildbot/#/builders/216/builds/20460/steps/7/logs/FAIL__LLVM__debug-prefix-map_s
```
:11:2: note: possible intended match here
 DW_AT_comp_dir [DW_FORM_string] ("/src_root\\bar")
 ^
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148975/new/

https://reviews.llvm.org/D148975

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@MaskRay , a test you modified, debug-prefix-map.s is failing on the PS5 
Windows bot. Can you take a look?

https://lab.llvm.org/buildbot/#/builders/216/builds/20460


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148975/new/

https://reviews.llvm.org/D148975

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D141824#4289752 , @argentite wrote:

> I made patch with both precompiled library and without cstdio. D148992 
> 
>
> @dyung We can also enable this now on PS4/5 if you are interested.

Sure. Please try it out and see if it works. More coverage is always good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141824/new/

https://reviews.llvm.org/D141824

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

This change is also causing 33 test failures on a build bot 
https://lab.llvm.org/buildbot/#/builders/139/builds/39267


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148439/new/

https://reviews.llvm.org/D148439

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Is there a reason a test was not added with this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148439/new/

https://reviews.llvm.org/D148439

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148112: [include-cleaner] Improve handling for templates

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@kadircet, your change is causing 3 test failures on Windows bots, can you take 
a look and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/216/builds/19740
https://lab.llvm.org/buildbot/#/builders/123/builds/18332


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148112/new/

https://reviews.llvm.org/D148112

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D141824#4231374 , @probinson wrote:

> In D141824#4231372 , @probinson 
> wrote:
>
>> In D141824#4229953 , @argentite 
>> wrote:
>>
>>> Just to confirm, `UNSUPPORTED: target=x86_64-scei-ps4` should be enough, 
>>> right?
>>
>> `UNSUPPORTED: target={{.*-(ps4|ps5)}}` please.
>
> Oh wait, @dyung says this should work on PS5.  Yes, your original suggestion 
> is good.

Upon actually trying to run the test with a PS5 target I see that it fails in a 
similar way, so the test should be marked unsupported for both platforms. I'll 
check in a fix to do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141824/new/

https://reviews.llvm.org/D141824

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D141824#4229693 , @argentite wrote:

> Hi, @dyung ! It seems the dynamic library generation is failing from the lack 
> of a linker. We need a test library to load at runtime in clang-repl. Do you 
> have any idea how we can create one without a linker? Otherwise we can 
> disable the test on PS4 as it is probably an unlikely use case.

If you need to generate a library at test time, then the test won't work on the 
PS4 platform since the external linker won't be present. (Note that it should 
work on PS5 as that uses LLD for the linker). I think you should probably just 
mark the test as unsupported on PS4.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141824/new/

https://reviews.llvm.org/D141824

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @argentite, the test you added is failing on the PS4 linux builder because 
the test seems to require linking and the PS4 target requires an external 
linker which is not present on the system. Can the test be rewritten to not 
require linking?

https://lab.llvm.org/buildbot/#/builders/139/builds/38153

  clang: error: unable to execute command: Executable "orbis-ld" doesn't exist!
  clang: error: linker command failed with exit code 1 (use -v to see 
invocation)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141824/new/

https://reviews.llvm.org/D141824

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D143436#4203525 , @dyung wrote:

> In D143436#4203394 , 
> @DmitryPolukhin wrote:
>
>> @dyung I cannot reproduce this issue on two different machines in both cases 
>> tests work fine. For clang and llvm-jitlink binaries (the only binaries used 
>> in the tests) my changes are non-functional and I didn't change anything in 
>> compiler-rt or ORC. Are you able to reproduce the crashes locally?
>
> So far I cannot on my own dev machines. I'll take the buildbot offline and 
> try to see if I can figure out what is going on this weekend.

So after deleting the build directory and clearing the ccache, the problem no 
longer seems to occur. I'm guessing it might have been corruption somewhere. 
Sorry about that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143436/new/

https://reviews.llvm.org/D143436

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D143436#4203394 , @DmitryPolukhin 
wrote:

> @dyung I cannot reproduce this issue on two different machines in both cases 
> tests work fine. For clang and llvm-jitlink binaries (the only binaries used 
> in the tests) my changes are non-functional and I didn't change anything in 
> compiler-rt or ORC. Are you able to reproduce the crashes locally?

So far I cannot on my own dev machines. I'll take the buildbot offline and try 
to see if I can figure out what is going on this weekend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143436/new/

https://reviews.llvm.org/D143436

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a bot 
(trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or revert if 
you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/247/builds/2639

   TEST 'ORC-x86_64-linux :: 
TestCases/Linux/x86-64/trivial-cxa-atexit.S' FAILED 
  Script:
  --
  : 'RUN: at line 3';  
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/./bin/clang   
-m64  -c -o 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-cxa-atexit.S.tmp
 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-cxa-atexit.S
  : 'RUN: at line 4';   
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/./bin/llvm-jitlink
 
-orc-runtime=/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/./lib/clang/17/lib/x86_64-unknown-linux-gnu/liborc_rt.a
 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-cxa-atexit.S.tmp
  --
  Exit Code: 139
  Command Output (stderr):
  --
  PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ 
and include the crash backtrace.
  Stack dump:
  0.Program arguments: 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/./bin/llvm-jitlink
 
-orc-runtime=/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/./lib/clang/17/lib/x86_64-unknown-linux-gnu/liborc_rt.a
 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-cxa-atexit.S.tmp
  #0 0x5654e9a19e86 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) 
(/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/./bin/llvm-jitlink+0x10aae86)
  #1 0x5654e9a17534 SignalHandler(int) Signals.cpp:0:0
  #2 0x7f57b6259420 __restore_rt 
(/lib/x86_64-linux-gnu/libpthread.so.0+0x14420)
  #3 0x7f57758df13a 
  #4 0x7f57758e27bc 
  #5 0x7f57758f102a 
  #6 0x7f57758e875f 
  #7 0x7f57758f4de2 
  
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-cxa-atexit.S.script:
 line 2: 3620821 Segmentation fault  (core dumped) 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/./bin/llvm-jitlink
 
-orc-runtime=/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/./lib/clang/17/lib/x86_64-unknown-linux-gnu/liborc_rt.a
 
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-cxa-atexit.S.tmp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143436/new/

https://reviews.llvm.org/D143436

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D145770#4195018 , @dyung wrote:

> @lamb-j the test clang-offload-bundler.c is failing on the PS4 linux builder, 
> can you take a look?
>
> https://lab.llvm.org/buildbot/#/builders/139/builds/37475
>
> I don't know if it matters, but this bot only builds the x86_64 target.

To unblock our bots, I've marked the test as XFAIL for PS4/PS5 in 
768211f48f2d52fdd555a07f3dae8fbf1def88cc 
, please 
investigate when you can.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145770/new/

https://reviews.llvm.org/D145770

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@lamb-j the test clang-offload-bundler.c is failing on the PS4 linux builder, 
can you take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/37475

I don't know if it matters, but this bot only builds the x86_64 target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145770/new/

https://reviews.llvm.org/D145770

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

I'm still seeing random crashes today on a linux buildbot in the test you added 
P1689 .cppm. Can you either fix or revert?

- https://lab.llvm.org/buildbot/#/builders/139/builds/35899
- https://lab.llvm.org/buildbot/#/builders/139/builds/35886

  corrupted size vs. prev_size while consolidating
  PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ 
and include the crash backtrace.
   #0 0x55baf810283f llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) 
(/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang-scan-deps+0x3f)
   #1 0x55baf8100214 SignalHandler(int) Signals.cpp:0:0
   #2 0x7fa226358420 __restore_rt 
(/lib/x86_64-linux-gnu/libpthread.so.0+0x14420)
   #3 0x7fa225e2500b raise 
/build/glibc-SzIz7B/glibc-2.31/signal/../sysdeps/unix/sysv/linux/raise.c:51:1
   #4 0x7fa225e04859 abort 
/build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81:7
   #5 0x7fa225e6f26e __libc_message 
/build/glibc-SzIz7B/glibc-2.31/libio/../sysdeps/posix/libc_fatal.c:155:5
   #6 0x7fa225e772fc /build/glibc-SzIz7B/glibc-2.31/malloc/malloc.c:5348:3
   #7 0x7fa225e7904e _int_free 
/build/glibc-SzIz7B/glibc-2.31/malloc/malloc.c:4245:6
   #8 0x7fa225e7c88d tcache_thread_shutdown 
/build/glibc-SzIz7B/glibc-2.31/malloc/malloc.c:2960:33
   #9 0x7fa225e7c88d __malloc_arena_thread_freeres 
/build/glibc-SzIz7B/glibc-2.31/malloc/arena.c:951:3
  #10 0x7fa22634c62f start_thread 
/build/glibc-SzIz7B/glibc-2.31/nptl/pthread_create.c:496:7
  #11 0x7fa225f01133 __clone 
/build/glibc-SzIz7B/glibc-2.31/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:97:0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137527/new/

https://reviews.llvm.org/D137527

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@joshua-arch1 and @hiraditya this change is causing a test failure on many 
bots. Can you take a look and revert if you need time to investigate?

Failing bots:

- https://lab.llvm.org/buildbot/#/builders/183/builds/10688
- https://lab.llvm.org/buildbot/#/builders/249/builds/349
- https://lab.llvm.org/buildbot/#/builders/231/builds/8162
- https://lab.llvm.org/buildbot/#/builders/121/builds/27741
- https://lab.llvm.org/buildbot/#/builders/230/builds/8973
- https://lab.llvm.org/buildbot/#/builders/57/builds/24514
- https://lab.llvm.org/buildbot/#/builders/109/builds/57335
- https://lab.llvm.org/buildbot/#/builders/247/builds/1342
- https://lab.llvm.org/buildbot/#/builders/36/builds/30143


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131230/new/

https://reviews.llvm.org/D131230

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D91000#4099744 , @whisperity wrote:

> In D91000#4099669 , @dyung wrote:
>
>>   -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4
>>
>> Hopefully this can help you to reproduce the problem.
>
> Ah, thank you very much. And indeed, giving `--target=x86_64-scei-ps4` to 
> Clang-Tidy will make the test case fail, but using `x86_64-linux-gnu` works 
> perfectly.
> Now knowing the exact triple I think I can delve into the preprocessor stack 
> or something to figure out why the //Annex K.//-related flags, my best bet is 
> that it's explicitly forbidden from being defined. 
>
>   clang-tidy 
> /tmp/LLVM-Build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/unsafe-functions.c.tmp.c
>  --checks='-*,bugprone-unsafe-functions' -config={} -- 
> --target=x86_64-linux-gnu -D__STDC_LIB_EXT1__=1 -D__STDC_WANT_LIB_EXT1__=1 
> -nostdinc++
>
> My first wish is to figure out how to reliably disable the test case and have 
> this quick-fix pushed immediately so the buildbots don't continue failing, 
> and then we can figure out that this check should be disabled on this 
> specific platform, or something like that...

One particular oddity of our platform is that we use a different default C++ 
and I think C standard, so if explicitly setting the C standard causes the test 
to pass, that is likely the case.

To XFAIL the test, grep for lines with "XFAIL" and "ps4" and you should find 
some examples. It was recently changed how it worked lately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91000/new/

https://reviews.llvm.org/D91000

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D91000#4099657 , @whisperity wrote:

> Ping @dyung, it looks like you're the owner of the relevant build-bot. I 
> can't find any information what `x86_64-sie` is...
>
> Meanwhile, it seems my attempt at fix is not actually fixing anything, I'm 
> trying to figure out how to at least disable the check on this specific 
> architecture. The rest of the architectures seem to be passing normally as 
> expected. Something must be special within Clang's default environment or 
> compiler configuration...

Sorry responses from me might be delayed today as I am on holiday, but that 
build bot builds with PS4 as the default target. This is the cmake line that is 
used:

  cmake ../llvm-project/llvm -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ 
-DCMAKE_BUILD_TYPE=Release -DCLANG_ENABLE_ARCMT=OFF -DCLANG_ENABLE_CLANGD=OFF 
-DLLVM_BUILD_RUNTIME=OFF -DLLVM_CCACHE_BUILD=ON -DLLVM_INCLUDE_EXAMPLES=OFF 
-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4 -DLLVM_ENABLE_ASSERTIONS=ON 
'-DLLVM_LIT_ARGS=--verbose -j100' -DLLVM_TARGETS_TO_BUILD=X86 
-DLLVM_USE_LINKER=gold 
'-DLLVM_ENABLE_PROJECTS=clang;cross-project-tests;llvm;clang-tools-extra;lld' 
-GNinja

Hopefully this can help you to reproduce the problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91000/new/

https://reviews.llvm.org/D91000

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @hctim, the test you added is failing on buildbots where AArch64 is not 
built, can you either update the test to not require that backend, or mark the 
test as requiring it?

https://lab.llvm.org/buildbot/#/builders/139/builds/35253

  error: unable to create target: 'No available targets are compatible with 
triple "aarch64-unknown-linux-android31"'
  1 error generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133392/new/

https://reviews.llvm.org/D133392

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @eopXD this change seems to be causing builds on Windows to time out for 
some reason. Can you take a look?

- https://lab.llvm.org/buildbot/#/builders/83/builds/28484
- https://lab.llvm.org/buildbot/#/builders/172/builds/22803
- https://lab.llvm.org/buildbot/#/builders/216/builds/16210


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141796/new/

https://reviews.llvm.org/D141796

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D142046#4071594 , @yonghong-song 
wrote:

> @dyung I just pushed the fix to the 'main' branch 
> (https://github.com/llvm/llvm-project/commit/183d075055c591dedead7ece972f1bdea611aa3b).
>  Please check it out. Thanks for reporting!

That fixed it, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142046/new/

https://reviews.llvm.org/D142046

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi, our internal release build buildbot seems to have issues with this test. It 
seems you are expected the following function declaration in the emitted IR:

  define dso_local void @_Z5test1PKc(ptr noundef %msg) #0 !dbg !19 {

But in a release build, it becomes:

  define dso_local void @_Z5test1PKc(ptr noundef %0) #0 !dbg !19 {

Note that %msg became %0. Can you fix the test so that it works in release 
builds as well?

Godbolt link: https://godbolt.org/z/E5zbM4chc


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142046/new/

https://reviews.llvm.org/D142046

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@serge-sans-paille Your change is causing 24 test failures on the Linux PS4 
bot, mostly with an assertion failure it seems. Can you take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/32263


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139274/new/

https://reviews.llvm.org/D139274

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@serge-sans-paille, one of our internal tests hit an assertion failure which I 
bisected back to your change. I have filed issue 59321 
 with a repro. Can you take 
a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138474/new/

https://reviews.llvm.org/D138474

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@vsapsai I reverted your change because it was causing the test 
ClangScanDeps/no-werror.cpp to fail on the PS4/PS5 linux/Windows bots:

- https://lab.llvm.org/buildbot/#/builders/139/builds/31784
- https://lab.llvm.org/buildbot/#/builders/216/builds/13476


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138252/new/

https://reviews.llvm.org/D138252

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137885: [modules] Support zstd in .pcm file

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D137885#3947532 , @dyung wrote:

> @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. 
> Most of the errors look similar to this:
>
>   error: 'error' diagnostics seen but not expected: 
> (frontend): malformed or corrupted AST file: 'LLVM was not built with 
> LLVM_ENABLE_ZSTD or did not find zstd at build time'
>   1 error generated.
>
> Can you take a look?

Sorry, forgot to include a link to the failing buildbot: 
https://lab.llvm.org/buildbot/#/builders/139/builds/31513


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137885/new/

https://reviews.llvm.org/D137885

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137885: [modules] Support zstd in .pcm file

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. 
Most of the errors look similar to this:

  error: 'error' diagnostics seen but not expected: 
(frontend): malformed or corrupted AST file: 'LLVM was not built with 
LLVM_ENABLE_ZSTD or did not find zstd at build time'
  1 error generated.

Can you take a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137885/new/

https://reviews.llvm.org/D137885

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @lebedev.ri, we recently noticed a failure in one of our internal tests 
which I bisected back to your change. I have filed the details in Issue #59122 
. Can you take a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136806/new/

https://reviews.llvm.org/D136806

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136549: [clang] Fix time profile in "isIntegerConstantExpr"

[Douglas Yung via Phabricator via cfe-commits]

dyung accepted this revision.
dyung added a comment.

I'm not really familiar with this code, so I'll leave others to review the 
actual change, but I can confirm that when I built a compiler with this change 
and ran it against the failing tests they all now pass. So in that regard, LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136549/new/

https://reviews.llvm.org/D136549

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136022: [clang] Add time profile for constant evaluation

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @Izaron, several of our internal tests that run tests using `-ftime-trace` 
started crashing when run which I bisected back to your change. I have filed 
issue #58551  for it, can 
you take a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136022/new/

https://reviews.llvm.org/D136022

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135486: [Clang] Use C++17 in constant-builtins-fmax.cpp test

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Thanks, this is necessary because the Playstation platforms default to C++14, 
not C++17.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135486/new/

https://reviews.llvm.org/D135486

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D131469#3768352 , @steven_wu wrote:

> In D131469#3768308 , @dongjunduo 
> wrote:
>
>> In D131469#3768288 , @dyung wrote:
>>
>>> In D131469#3768283 , @dongjunduo 
>>> wrote:
>>>
 In D131469#3768282 , @dyung 
 wrote:

> In D131469#3768274 , 
> @dongjunduo wrote:
>
>> In D131469#3768260 , @dyung 
>> wrote:
>>
>>> The test you added is failing on the PS4 linux bot because the PS4 
>>> platform requires an external linker that isn't present. Is linking 
>>> necessary for your test? Or can -S or even -c work instead to 
>>> accomplish what you are trying to test?
>>
>> Yeah the new test case is designed to test the compiling jobs with a 
>> linking stage.
>>
>> Are there any options or measures to avoid this test running on the PS4?
>
> You could mark it as XFAIL: ps4
>
> Your change also seems to have possibly the same issue when run on our 
> PS5 Windows bot:
> https://lab.llvm.org/buildbot/#/builders/216/builds/9260
>
>   $ ":" "RUN: at line 2"
>   $ "z:\test\build\bin\clang.exe" "--driver-mode=g++" "-ftime-trace" 
> "-ftime-trace-granularity=0" "-o" 
> "Z:\test\build\tools\clang\test\Driver\Output/exe/check-time-trace" 
> "Z:\test\llvm-project\clang\test\Driver\check-time-trace.cpp"
>   # command stderr:
>   clang: error: unable to execute command: program not executable
>   clang: error: linker command failed with exit code 1 (use -v to see 
> invocation)

 How about "**UNSUPPORTED: ps4, ps5**"
>>>
>>> That would likely work I think.
>>
>> Done with the commit 39221ad 
>> .
>
> I don't like how this done. This generally won't work for Darwin platform as 
> well since you don't know where SDK is. Whether you have a linker or not has 
> nothing to do with the host platform, you need to check for if the linker is 
> available.
>
> This is also a regression in test coverage since all the supported tests in 
> lines after you added are no longer executed on the platform you excludes.

Thinking it over, I agree with this.

Historically, tests in clang/llvm do not do linking because it can cause a ton 
of problems (like it seems to be doing). Can you achieve what you are trying to 
test by maybe examining the `-###` output? Or if linking is really required, 
maybe the test-suite would be a better place for this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131469/new/

https://reviews.llvm.org/D131469

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D131469#3768283 , @dongjunduo 
wrote:

> In D131469#3768282 , @dyung wrote:
>
>> In D131469#3768274 , @dongjunduo 
>> wrote:
>>
>>> In D131469#3768260 , @dyung wrote:
>>>
 The test you added is failing on the PS4 linux bot because the PS4 
 platform requires an external linker that isn't present. Is linking 
 necessary for your test? Or can -S or even -c work instead to accomplish 
 what you are trying to test?
>>>
>>> Yeah the new test case is designed to test the compiling jobs with a 
>>> linking stage.
>>>
>>> Are there any options or measures to avoid this test running on the PS4?
>>
>> You could mark it as XFAIL: ps4
>>
>> Your change also seems to have possibly the same issue when run on our PS5 
>> Windows bot:
>> https://lab.llvm.org/buildbot/#/builders/216/builds/9260
>>
>>   $ ":" "RUN: at line 2"
>>   $ "z:\test\build\bin\clang.exe" "--driver-mode=g++" "-ftime-trace" 
>> "-ftime-trace-granularity=0" "-o" 
>> "Z:\test\build\tools\clang\test\Driver\Output/exe/check-time-trace" 
>> "Z:\test\llvm-project\clang\test\Driver\check-time-trace.cpp"
>>   # command stderr:
>>   clang: error: unable to execute command: program not executable
>>   clang: error: linker command failed with exit code 1 (use -v to see 
>> invocation)
>
> How about "**UNSUPPORTED: ps4, ps5**"

That would likely work I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131469/new/

https://reviews.llvm.org/D131469

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D131469#3768274 , @dongjunduo 
wrote:

> In D131469#3768260 , @dyung wrote:
>
>> The test you added is failing on the PS4 linux bot because the PS4 platform 
>> requires an external linker that isn't present. Is linking necessary for 
>> your test? Or can -S or even -c work instead to accomplish what you are 
>> trying to test?
>
> Yeah the new test case is designed to test the compiling jobs with a linking 
> stage.
>
> Are there any options or measures to avoid this test running on the PS4?

You could mark it as XFAIL: ps4

Your change also seems to have possibly the same issue when run on our PS5 
Windows bot:
https://lab.llvm.org/buildbot/#/builders/216/builds/9260

  $ ":" "RUN: at line 2"
  $ "z:\test\build\bin\clang.exe" "--driver-mode=g++" "-ftime-trace" 
"-ftime-trace-granularity=0" "-o" 
"Z:\test\build\tools\clang\test\Driver\Output/exe/check-time-trace" 
"Z:\test\llvm-project\clang\test\Driver\check-time-trace.cpp"
  # command stderr:
  clang: error: unable to execute command: program not executable
  clang: error: linker command failed with exit code 1 (use -v to see 
invocation)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131469/new/

https://reviews.llvm.org/D131469

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

The test you added is failing on the PS4 linux bot because the PS4 platform 
requires an external linker that isn't present. Is linking necessary for your 
test? Or can -S or even -c work instead to accomplish what you are trying to 
test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131469/new/

https://reviews.llvm.org/D131469

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

[Douglas Yung via Phabricator via cfe-commits]

dyung added inline comments.



Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8
+// Omit filepath to llvm project directory
+// CHECK: 
clang/test/Frontend/sarif-diagnostics.cpp"},"mimeType":"text/plain","roles":["resultFile"]}],"columnKind":"unicodeCodePoints","results":[{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":1,"startColumn":1,"startLine":12}}}],"message":{"text":"'main'
 must return 
'int'"},"ruleId":"3465","ruleIndex":0},{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":11,"startColumn":11,"startLine":13}}}],"message":{"text":"use
 of undeclared identifier 
'hello'"},"ruleId":"4604","ruleIndex":1},{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":17,"startColumn":17,"startLine":15}}}],"message":{"text":"invalid
 digit 'a' in decimal 
constant"},"ruleId":"898","ruleIndex":2},{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":5,"startColumn":5,"startLine":19}}}],"message":{"text":"misleading
 indentation; statement is not part of the previous 
'if'"},"ruleId":"1806","ruleIndex":3},{"level":"note","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":3,"startColumn":3,"startLine":17}}}],"message":{"text":"previous
 statement is 
here"},"ruleId":"1730","ruleIndex":4},{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":10,"startColumn":10,"startLine":18}}}],"message":{"text":"unused
 variable 
'Yes'"},"ruleId":"6539","ruleIndex":5},{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":12,"startColumn":12,"startLine":21}}}],"message":{"text":"use
 of undeclared identifier 
'hi'"},"ruleId":"4604","ruleIndex":6},{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":1,"startColumn":1,"startLine":23}}}],"message":{"text":"extraneous
 closing brace 
('}')"},"ruleId":"1399","ruleIndex":7},{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":6,"endLine":27,"startColumn":5,"startLine":27}}},{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":10,"endLine":27,"startColumn":9,"startLine":27}}},{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":7,"startColumn":7,"startLine":27}}}],"message":{"text":"invalid
 operands to binary expression ('t1' and 
't1')"},"ruleId":"4539","ruleIndex":8}],"tool":{"driver":{"fullName":"","informationUri":"https://clang.llvm.org/docs/UsersManual.html","language":"en-US","name":"clang","rules":[{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"3465","name":""},{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"4604","name":""},{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"898","name":""},{"defaultConfiguration":{"enabled":true,"level":"warning","rank":-1},"fullDescription":{"text":""},"id":"1806","name":""},{"defaultConfiguration":{"enabled":true,"level":"note","rank":-1},"fullDescription":{"text":""},"id":"1730","name":""},{"defaultConfiguration":{"enabled":true,"level":"warning","rank":-1},"fullDescription":{"text":""},"id":"6539","name":""},{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"4604","name":""},{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"1399","name":""},{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"4539","name":""}],"version":"16.0.0"}}}],"version":"2.1.0"}
+// CHECK: 2 warnings and 6 errors generated.

dyung wrote:
> Can this CHECK line be broken into smaller pieces? This test is failing on 
> our internal bot, and I'm going crosseyed trying to figure out what the 
> difference is because the line is 3741 characters long!
Is there any significance to the "ruleId" and "Id" values in this test? If not, 
can we just use a regex to check for a number? Our internal build with private 
changes is failing due to slightly different numbers in some of the "ruleId" 
fields


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131632/new/

https://reviews.llvm.org/D131632

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

[Douglas Yung via Phabricator via cfe-commits]

dyung added inline comments.



Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8
+// Omit filepath to llvm project directory
+// CHECK: 
clang/test/Frontend/sarif-diagnostics.cpp"},"mimeType":"text/plain","roles":["resultFile"]}],"columnKind":"unicodeCodePoints","results":[{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":1,"startColumn":1,"startLine":12}}}],"message":{"text":"'main'
 must return 
'int'"},"ruleId":"3465","ruleIndex":0},{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":11,"startColumn":11,"startLine":13}}}],"message":{"text":"use
 of undeclared identifier 
'hello'"},"ruleId":"4604","ruleIndex":1},{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":17,"startColumn":17,"startLine":15}}}],"message":{"text":"invalid
 digit 'a' in decimal 
constant"},"ruleId":"898","ruleIndex":2},{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":5,"startColumn":5,"startLine":19}}}],"message":{"text":"misleading
 indentation; statement is not part of the previous 
'if'"},"ruleId":"1806","ruleIndex":3},{"level":"note","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":3,"startColumn":3,"startLine":17}}}],"message":{"text":"previous
 statement is 
here"},"ruleId":"1730","ruleIndex":4},{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":10,"startColumn":10,"startLine":18}}}],"message":{"text":"unused
 variable 
'Yes'"},"ruleId":"6539","ruleIndex":5},{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":12,"startColumn":12,"startLine":21}}}],"message":{"text":"use
 of undeclared identifier 
'hi'"},"ruleId":"4604","ruleIndex":6},{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":1,"startColumn":1,"startLine":23}}}],"message":{"text":"extraneous
 closing brace 
('}')"},"ruleId":"1399","ruleIndex":7},{"level":"error","locations":[{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":6,"endLine":27,"startColumn":5,"startLine":27}}},{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":10,"endLine":27,"startColumn":9,"startLine":27}}},{"physicalLocation":{"artifactLocation":{"index":0},"region":{"endColumn":7,"startColumn":7,"startLine":27}}}],"message":{"text":"invalid
 operands to binary expression ('t1' and 
't1')"},"ruleId":"4539","ruleIndex":8}],"tool":{"driver":{"fullName":"","informationUri":"https://clang.llvm.org/docs/UsersManual.html","language":"en-US","name":"clang","rules":[{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"3465","name":""},{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"4604","name":""},{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"898","name":""},{"defaultConfiguration":{"enabled":true,"level":"warning","rank":-1},"fullDescription":{"text":""},"id":"1806","name":""},{"defaultConfiguration":{"enabled":true,"level":"note","rank":-1},"fullDescription":{"text":""},"id":"1730","name":""},{"defaultConfiguration":{"enabled":true,"level":"warning","rank":-1},"fullDescription":{"text":""},"id":"6539","name":""},{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"4604","name":""},{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"1399","name":""},{"defaultConfiguration":{"enabled":true,"level":"error","rank":50},"fullDescription":{"text":""},"id":"4539","name":""}],"version":"16.0.0"}}}],"version":"2.1.0"}
+// CHECK: 2 warnings and 6 errors generated.

Can this CHECK line be broken into smaller pieces? This test is failing on our 
internal bot, and I'm going crosseyed trying to figure out what the difference 
is because the line is 3741 characters long!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131632/new/

https://reviews.llvm.org/D131632

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D128830#3751368 , @dyung wrote:

> We also saw this assert on our Windows build, and it also can be reproduced 
> in Linux:
>
>   $ cat test2.c
>   static char *getenv(char *) {}
>   void foo() { getenv(""); }
>   $ ~/src/upstream/879f5118fc74657e4a5c4eff6810098e1eed75ac-linux/bin/clang 
> -c -O3 test2.c  
>   test2.c:1:27: warning: omitting the parameter name in a function definition 
> is a C2x extension [-Wc2x-extensions] 
>   
> 
>   static char *getenv(char *) {}  
>   
>   
> 
> ^ 
>   
>   
> 
>   test2.c:1:30: warning: non-void function does not return a value 
> [-Wreturn-type]   
>   
>
>   static char *getenv(char *) {}  
>   
>   
> 
>^  
>   
>   clang: 
> /home/dyung/src/upstream/llvm_clean_git/llvm/lib/Analysis/CGSCCPassManager.cpp:958:
>  updateCGAndAnalysisManagerForPass(llvm::LazyCallGraph&, 
> llvm::LazyCallGraph::SCC&, llvm::LazyCallGraph::Node&, 
> llvm::CGSCCAnalysisManager&, llvm::CGSCCUpdateResult&, 
> llvm::FunctionAnalysisManager&, bool)::: Assertion 
> `RefereeN && "Visited function should already have an associated node"' 
> failed.
>
> The key seems to be the special function getenv(). If I rename the function, 
> the crash does not occur.

Note that our internal builder found this while trying to build 
compiler-rt/lib/profile/InstrProfilingFile.c using the newly built compiler. If 
you think this might take a while to debug, could you please revert the change 
while you investigate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128830/new/

https://reviews.llvm.org/D128830

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

We also saw this assert on our Windows build, and it also can be reproduced in 
Linux:

  $ cat test2.c
  static char *getenv(char *) {}
  void foo() { getenv(""); }
  $ ~/src/upstream/879f5118fc74657e4a5c4eff6810098e1eed75ac-linux/bin/clang -c 
-O3 test2.c  
  test2.c:1:27: warning: omitting the parameter name in a function definition 
is a C2x extension [-Wc2x-extensions]   


  static char *getenv(char *) {}


  
^   


  
  test2.c:1:30: warning: non-void function does not return a value 
[-Wreturn-type] 

   
  static char *getenv(char *) {}


  
   ^

  clang: 
/home/dyung/src/upstream/llvm_clean_git/llvm/lib/Analysis/CGSCCPassManager.cpp:958:
 updateCGAndAnalysisManagerForPass(llvm::LazyCallGraph&, 
llvm::LazyCallGraph::SCC&, llvm::LazyCallGraph::Node&, 
llvm::CGSCCAnalysisManager&, llvm::CGSCCUpdateResult&, 
llvm::FunctionAnalysisManager&, bool)::: Assertion 
`RefereeN && "Visited function should already have an associated node"' failed.

The key seems to be the special function getenv(). If I rename the function, 
the crash does not occur.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128830/new/

https://reviews.llvm.org/D128830

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130689: [LLVM] Update C++ standard to 17

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

We are seeing an additional failure on an internal linux bot due to the change 
to using C++17 by default when using GNU ld:

  [3/7] Generating GwpAsan-x86_64-Test
  FAILED: projects/compiler-rt/lib/gwp_asan/tests/GwpAsan-x86_64-Test 
  cd 
/home/jenkins/j/w/workspace/opensource/opensource_build/build/projects/compiler-rt/lib/gwp_asan/tests
 && /home/jenkins/j/w/workspace/opensource/opensource_build/build/./bin/clang++ 
GwpAsanTestObjects.printf_sanitizer_common.cpp.x86_64.o 
GwpAsanTestObjects.alignment.cpp.x86_64.o 
GwpAsanTestObjects.backtrace.cpp.x86_64.o GwpAsanTestObjects.basic.cpp.x86_64.o 
GwpAsanTestObjects.compression.cpp.x86_64.o 
GwpAsanTestObjects.iterate.cpp.x86_64.o 
GwpAsanTestObjects.crash_handler_api.cpp.x86_64.o 
GwpAsanTestObjects.driver.cpp.x86_64.o 
GwpAsanTestObjects.mutex_test.cpp.x86_64.o 
GwpAsanTestObjects.slot_reuse.cpp.x86_64.o 
GwpAsanTestObjects.thread_contention.cpp.x86_64.o 
GwpAsanTestObjects.harness.cpp.x86_64.o 
GwpAsanTestObjects.enable_disable.cpp.x86_64.o 
GwpAsanTestObjects.late_init.cpp.x86_64.o 
GwpAsanTestObjects.options.cpp.x86_64.o 
GwpAsanTestObjects.gtest-all.cc.x86_64.o 
/home/jenkins/j/w/workspace/opensource/opensource_build/build/projects/compiler-rt/lib/gwp_asan/tests/libRTGwpAsanTest.x86_64.a
 -o 
/home/jenkins/j/w/workspace/opensource/opensource_build/build/projects/compiler-rt/lib/gwp_asan/tests/./GwpAsan-x86_64-Test
 -ldl -lstdc++ --driver-mode=g++ -pthread -m64
  /usr/bin/ld: /usr/bin/ld: DWARF error: invalid or unhandled FORM value: 0x25
  GwpAsanTestObjects.backtrace.cpp.x86_64.o: in function 
`Backtrace_ExceedsStorableLength_Test::TestBody()':
  backtrace.cpp:(.text+0xce6): undefined reference to 
`gwp_asan::AllocationMetadata::kMaxTraceLengthToCollect'
  clang-16: error: linker command failed with exit code 1 (use -v to see 
invocation)

And it seems at least one buildbot is also hitting the same issue:
https://lab.llvm.org/staging/#/builders/180/builds/7174

  [165/1101] Generating GwpAsan-x86_64-Test
  FAILED: projects/compiler-rt/lib/gwp_asan/tests/GwpAsan-x86_64-Test 
  cd 
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/stage1/projects/compiler-rt/lib/gwp_asan/tests
 && 
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/stage1/./bin/clang++
 GwpAsanTestObjects.printf_sanitizer_common.cpp.x86_64.o 
GwpAsanTestObjects.alignment.cpp.x86_64.o 
GwpAsanTestObjects.backtrace.cpp.x86_64.o GwpAsanTestObjects.basic.cpp.x86_64.o 
GwpAsanTestObjects.compression.cpp.x86_64.o 
GwpAsanTestObjects.iterate.cpp.x86_64.o 
GwpAsanTestObjects.crash_handler_api.cpp.x86_64.o 
GwpAsanTestObjects.driver.cpp.x86_64.o 
GwpAsanTestObjects.mutex_test.cpp.x86_64.o 
GwpAsanTestObjects.slot_reuse.cpp.x86_64.o 
GwpAsanTestObjects.thread_contention.cpp.x86_64.o 
GwpAsanTestObjects.harness.cpp.x86_64.o 
GwpAsanTestObjects.enable_disable.cpp.x86_64.o 
GwpAsanTestObjects.late_init.cpp.x86_64.o 
GwpAsanTestObjects.options.cpp.x86_64.o 
GwpAsanTestObjects.gtest-all.cc.x86_64.o 
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/stage1/projects/compiler-rt/lib/gwp_asan/tests/libRTGwpAsanTest.x86_64.a
 -o 
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/stage1/projects/compiler-rt/lib/gwp_asan/tests/./GwpAsan-x86_64-Test
 -ldl -lstdc++ --driver-mode=g++ -pthread -m64
  /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: 
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: DWARF 
error: invalid or unhandled FORM value: 0x23
  GwpAsanTestObjects.backtrace.cpp.x86_64.o: in function 
`Backtrace_ExceedsStorableLength_Test::TestBody()':
  backtrace.cpp:(.text+0xca6): undefined reference to 
`gwp_asan::AllocationMetadata::kMaxTraceLengthToCollect'
  clang-16: error: linker command failed with exit code 1 (use -v to see 
invocation)

Switching between BFD ld and gold still fails (although gold fails for a 
slightly different reason). Superficially it seems that switching to C++17 for 
some reason might be causing the compiler to emit debug info that these older 
non-lld linkers cannot understand for some reason?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130689/new/

https://reviews.llvm.org/D130689

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130689: [LLVM] Update C++ standard to 17

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Your change is causing a build failure on the PS4 linux build bot using GCC 
9.3. Can you take a look?
https://lab.llvm.org/buildbot/#/builders/139/builds/26186

  FAILED: 
tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/SignalHandlerCheck.cpp.o
 
  CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/g++ 
-DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS 
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/tools/extra/clang-tidy/bugprone
 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang-tools-extra/clang-tidy/bugprone
 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/tools/extra/clang-tidy
 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/include
 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/include
 -I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/include 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/include
 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden 
-Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings 
-Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long 
-Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess 
-Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type 
-Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment 
-Wmisleading-indentation -fdiagnostics-color -ffunction-sections 
-fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 
-DNDEBUG  -fno-exceptions -fno-rtti -UNDEBUG -std=c++17 -MD -MT 
tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/SignalHandlerCheck.cpp.o
 -MF 
tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/SignalHandlerCheck.cpp.o.d
 -o 
tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/SignalHandlerCheck.cpp.o
 -c 
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
  
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:17:45:
 error: modification of ‘’ is not a constant expression
 17 | "signal", "abort", "_Exit", "quick_exit"};
| ^
  
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:217:12:
 error: modification of ‘’ is not a constant expression
217 | "write"};
|^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130689/new/

https://reviews.llvm.org/D130689

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D130788#3689918 , @sunho wrote:

> In D130788#3689820 , @dyung wrote:
>
>> In D130788#3689795 , @sunho wrote:
>>
>>> The test isn't supposed to be ran on windows -- we don't support exception 
>>> on windows at all yet. I guess XFAIL: windows-msvc, windows-gnu is not 
>>> working out.
>>
>> If you don't want the test run on Windows, I think what you want is probably 
>> `system-windows` rather than `windows-msvc` and `windows-gnu`. The former 
>> will mark as XFAIL when it is run on Windows, while the latter will mark as 
>> XFAIL when the target triple includes those strings.
>
> Should have been fixed in 
> https://github.com/llvm/llvm-project/commit/773d51ce3bedd091539aa86a5e5fc15a9174ff7b.
>  Can you check it out?

https://lab.llvm.org/buildbot/#/builders/216/builds/7647

That seems to have worked. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D130788#3689795 , @sunho wrote:

> The test isn't supposed to be ran on windows -- we don't support exception on 
> windows at all yet. I guess XFAIL: windows-msvc, windows-gnu is not working 
> out.

If you don't want the test run on Windows, I think what you want is probably 
`system-windows` rather than `windows-msvc` and `windows-gnu`. The former will 
mark as XFAIL when it is run on Windows, while the latter will mark as XFAIL 
when the target triple includes those strings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

The test simple-exception.cpp is failing on the PS5 Windows bot after this 
change. Can you take a look?

I forced a build using the commit prior to yours which passed: 
https://lab.llvm.org/buildbot/#/builders/216/builds/7636
And then I forced a build using your commit, and the test failed: 
https://lab.llvm.org/buildbot/#/builders/216/builds/7637

   TEST 'Clang :: Interpreter/simple-exception.cpp' FAILED 

  Script:
  --
  : 'RUN: at line 4';   cat 
Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp | 
z:\test\build\bin\clang-repl.exe | z:\test\build\bin\filecheck.exe 
Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp
  --
  Exit Code: 1
  Command Output (stdout):
  --
  $ ":" "RUN: at line 4"
  $ "cat" "Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp"
  $ "z:\test\build\bin\clang-repl.exe"
  # command stderr:
  JIT session error: Symbols not found: [ ??_7type_info@@6B@ ]
  error: Failed to materialize symbols: { (main, { _CT??_R0PEAX@88, ?f@@YAHXZ, 
?r1@@3HA, _CTA2PEAD, ??_C@_0BB@DPCIAKEG@Simple?5exception?$AA@, 
??_C@_03OFAPEBGM@?$CFs?6?$AA@, $.incr_module_8.__inits.0, 
?checkException@@YAHXZ, _TIC2PEAD, ??_R0PEAD@8, ??_R0PEAX@8, 
__orc_init_func.incr_module_8, ??_C@_0N@CKKDCGKM@Running?5f?$CI?$CJ?6?$AA@, 
_CT??_R0PEAD@88 }) }
  error: Failed to materialize symbols: { (main, { 
__orc_init_func.incr_module_8 }) }
  $ "z:\test\build\bin\filecheck.exe" 
"Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp"
  # command stderr:
  Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp:10:11: 
error: CHECK: expected string not found in input
  // CHECK: Running f()
^
  :1:1: note: scanning from here
  clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> 
  ^
  :1:11: note: possible intended match here
  clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> 
^
  Input file: 
  Check file: Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp
  -dump-input=help explains the following input dump.
  Input was:
  <<
  1: clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> clang-repl>  
  check:10'0 
X
 error: no match found
  check:10'1   ?

   possible intended match
  >>
  error: command failed with exit status: 1
  --
  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @sammccall, your change seems to be causing a build failure on the PS4 linux 
bot, can you take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/25678

  FAILED: 
tools/clang/tools/extra/pseudo/gen/CMakeFiles/clang-pseudo-gen.dir/Main.cpp.o 
  CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/g++ 
-DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS 
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/tools/extra/pseudo/gen
 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang-tools-extra/pseudo/gen
 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/include
 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/include
 -I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/include 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/include
 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang-tools-extra/pseudo/include
 
-I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/tools/extra/pseudo/include
 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden 
-Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings 
-Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long 
-Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess 
-Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type 
-Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment 
-Wmisleading-indentation -fdiagnostics-color -ffunction-sections 
-fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 
-DNDEBUG  -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT 
tools/clang/tools/extra/pseudo/gen/CMakeFiles/clang-pseudo-gen.dir/Main.cpp.o 
-MF 
tools/clang/tools/extra/pseudo/gen/CMakeFiles/clang-pseudo-gen.dir/Main.cpp.o.d 
-o 
tools/clang/tools/extra/pseudo/gen/CMakeFiles/clang-pseudo-gen.dir/Main.cpp.o 
-c 
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang-tools-extra/pseudo/gen/Main.cpp
  
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang-tools-extra/pseudo/gen/Main.cpp:
 In function ‘std::string 
clang::pseudo::{anonymous}::mangleSymbol(clang::pseudo::SymbolID, const 
clang::pseudo::Grammar&)’:
  
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang-tools-extra/pseudo/gen/Main.cpp:73:50:
 error: expected primary-expression before ‘]’ token
 73 |   static std::string *TokNames = new std::string[]{
|  ^
  
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang-tools-extra/pseudo/gen/Main.cpp:77:7:
 error: too many initializers for ‘std::string [1]’ {aka 
‘std::__cxx11::basic_string [1]’}
 77 |   };
|   ^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130414/new/

https://reviews.llvm.org/D130414

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

This change is causing a build failure on the Windows PS4 bot, can you please 
take a look and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/216/builds/7026

  FAILED: 
tools/clang/lib/Analysis/FlowSensitive/CMakeFiles/obj.clangAnalysisFlowSensitive.dir/WatchedLiteralsSolver.cpp.obj
 
  
C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\cl.exe
  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE 
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS 
-D_GNU_SOURCE -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE 
-D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS 
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-Itools\clang\lib\Analysis\FlowSensitive 
-IC:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\clang\lib\Analysis\FlowSensitive
 -IC:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\clang\include 
-Itools\clang\include -Iinclude 
-IC:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\llvm\include /DWIN32 
/D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 
-wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 
-wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 
-wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 
-wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2  /EHs-c- /GR- 
-UNDEBUG -std:c++14 /showIncludes 
/Fotools\clang\lib\Analysis\FlowSensitive\CMakeFiles\obj.clangAnalysisFlowSensitive.dir\WatchedLiteralsSolver.cpp.obj
 
/Fdtools\clang\lib\Analysis\FlowSensitive\CMakeFiles\obj.clangAnalysisFlowSensitive.dir\
 /FS -c 
C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\clang\lib\Analysis\FlowSensitive\WatchedLiteralsSolver.cpp
  
C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\clang\lib\Analysis\FlowSensitive\WatchedLiteralsSolver.cpp(477):
 error C2429: language feature 'structured bindings' requires compiler flag 
'/std:c++17'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129180/new/

https://reviews.llvm.org/D129180

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @masoud.ataei, the test you added in this commit is failing on the PS4 bot, 
can you take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/24469

  clang (LLVM option parsing): Unknown command line argument 
'-enable-ppc-gen-scalar-mass'.  Try: 'clang (LLVM option parsing) --help'
  clang (LLVM option parsing): Did you mean '--enable-x86-scalar-amx'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128653/new/

https://reviews.llvm.org/D128653

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

@mboehme, one of our internal tests started to fail to compile after this 
change due to the compiler no longer accepting what I think should be a valid 
attribute declaration. I have filed issue #56077 for the problem, can you take 
a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126061/new/

https://reviews.llvm.org/D126061

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127943: cmake: configure clang lit to use hmaptool from source directly

[Douglas Yung via Phabricator via cfe-commits]

dyung accepted this revision.
dyung added a comment.
This revision is now accepted and ready to land.

I tried it on Windows building with both ninja and Visual Studio and both seem 
to work after your change. LGTM.

Thanks for looking into this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127943/new/

https://reviews.llvm.org/D127943

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D126308#3582337 , @mizvekov wrote:

> In D126308#3581240 , @dyung wrote:
>
>> Can you take a look?
>
> Hi @dyung , thanks for the report and sorry for the trouble!
> Can you help me try to reproduce it?
>
> Which version of Visual Studio, and what preset are you using?

Sure, we are using Visual Studio 2019. The cmake command I use is:

  cmake.exe -G "Visual Studio 16 2019" -DCLANG_ENABLE_ARCMT=OFF 
-DCMAKE_BUILD_TYPES=Release -DLLVM_BUILD_RUNTIME=OFF 
-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-ps4-scei -DLLVM_ENABLE_TIMESTAMPS=OFF 
-DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_TARGETS_TO_BUILD=X86 
-DLLVM_TOOL_LLD_BUILD=OFF -DLLVM_VERSION_SUFFIX= -DLLVM_LIT_ARGS="--verbose 
-j24" -Thost=x64 -DLLVM_ENABLE_PROJECTS=clang 

From the files that are generated, we then do a Release build and try to run 
the tests using that. (Although I believe any build type should be affected 
similarly.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126308/new/

https://reviews.llvm.org/D126308

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @mizvekov, this change seems to have broken the location of the hmaptool 
when using the Visual Studio builder on Windows. After your commit, 7 clang 
tests fail because hmaptool cannot be found at the expected location. For 
example, the test clang/test/Preprocessor/headermap-rel.c:

  FAIL: Clang :: Preprocessor/headermap-rel.c (1 of 1)
   TEST 'Clang :: Preprocessor/headermap-rel.c' FAILED 

  Script:
  --
  : 'RUN: at line 1';   rm -f 
D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.hmap
  : 'RUN: at line 2';   'C:/Program Files/Python310/python.exe' 
D:\src\upstream\51608515faa7-PS4-Release\Release\bin\hmaptool write 
D:\src\upstream\llvm_clean_git\clang\test\Preprocessor/Inputs/headermap-rel/foo.hmap.json
 
D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.hmap
  : 'RUN: at line 3';   
d:\src\upstream\51608515faa7-ps4-release\release\bin\clang.exe -cc1 
-internal-isystem 
d:\src\upstream\51608515faa7-ps4-release\release\lib\clang\15.0.0\include 
-nostdsysteminc -E 
D:\src\upstream\llvm_clean_git\clang\test\Preprocessor\headermap-rel.c -o 
D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.i
 -I 
D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.hmap
 -F D:\src\upstream\llvm_clean_git\clang\test\Preprocessor/Inputs/headermap-rel
  : 'RUN: at line 4';   
d:\src\upstream\51608515faa7-ps4-release\release\bin\filecheck.exe 
D:\src\upstream\llvm_clean_git\clang\test\Preprocessor\headermap-rel.c 
-input-file 
D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.i
  --
  Exit Code: 2
  
  Command Output (stdout):
  --
  $ ":" "RUN: at line 1"
  $ "rm" "-f" 
"D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.hmap"
  $ ":" "RUN: at line 2"
  $ "C:/Program Files/Python310/python.exe" 
"D:\src\upstream\51608515faa7-PS4-Release\Release\bin\hmaptool" "write" 
"D:\src\upstream\llvm_clean_git\clang\test\Preprocessor/Inputs/headermap-rel/foo.hmap.json"
 
"D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.hmap"
  # command stderr:
  C:/Program Files/Python310/python.exe: can't open file 
'D:\\src\\upstream\\51608515faa7-PS4-Release\\Release\\bin\\hmaptool': [Errno 
2] No such file or directory
  
  error: command failed with exit status: 2

Before your change, in this particular case when doing a Release build with 
Visual Studio, hmaptool can be found at \Release\bin\hmaptool, but 
after your change, it is now located at \s\bin\hmaptool which is not 
where lit expects to find it causing the test to fail.

Can you take a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126308/new/

https://reviews.llvm.org/D126308

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Just another data point, but we noticed the same issue of clang++ missing after 
install on our internal Windows builds, and I bisected it to this commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117977/new/

https://reviews.llvm.org/D117977

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D126651#3574290 , @johannes wrote:

> No idea why the conversion fails for the wide string.
> First step is to reproduce the problem. I guess we should try in a Ubuntu VM.
> Is there an easy way to see if other builders succeeded?

Unfortunately I think you would have to search through the history for it.

I can tell you that our PS4 Windows buildbot did succeed though. 
https://lab.llvm.org/buildbot/#/builders/216/builds/5492


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126651/new/

https://reviews.llvm.org/D126651

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi, the test you modified in your change seems to be failing on the PS4 linux 
build bot at https://lab.llvm.org/buildbot/#/builders/139/builds/22964.

   TEST 'Clang :: Tooling/clang-diff-ast.cpp' FAILED 

  Script:
  --
  : 'RUN: at line 1';   
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang-diff
 -ast-dump 
/home/buildbot/buildbot-root/llvm-project/clang/test/Tooling/clang-diff-ast.cpp 
-- -std=c++11 | 
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck
 /home/buildbot/buildbot-root/llvm-project/clang/test/Tooling/clang-diff-ast.cpp
  --
  Exit Code: 1
  Command Output (stderr):
  --
  
/home/buildbot/buildbot-root/llvm-project/clang/test/Tooling/clang-diff-ast.cpp:50:12:
 error: CHECK: expected string not found in input
   // CHECK: StringLiteral: wide(
 ^
  :35:21: note: scanning from here
   StringLiteral: foo(34)
  ^
  :39:2: note: possible intended match here
   StringLiteral: utf-16(38)
   ^
  Input file: 
  Check file: 
/home/buildbot/buildbot-root/llvm-project/clang/test/Tooling/clang-diff-ast.cpp
  -dump-input=help explains the following input dump.
  Input was:
  <<
  .
  .
  .
 30:  IfStmt(29) 
 31:  BinaryOperator: ==(30) 
 32:  DeclRefExpr: i(31) 
 33:  IntegerLiteral: 0(32) 
 34:  ReturnStmt(33) 
 35:  StringLiteral: foo(34) 
  check:50'0 X~~~ error: no match found
 36:  CStyleCastExpr(35) 
  check:50'0 
 37:  StringLiteral(36) 
  check:50'0 ~~~
 38:  CStyleCastExpr(37) 
  check:50'0 
 39:  StringLiteral: utf-16(38) 
  check:50'0 ~~~
  check:50'1  ?  possible intended match
 40:  CStyleCastExpr(39) 
  check:50'0 
 41:  StringLiteral: utf-32(40) 
  check:50'0 ~~~
 42:  ReturnStmt(41) 
  check:50'0 
 43:  IntegerLiteral: 0(42) 
  check:50'0 ~~~
 44:  AccessSpecDecl: public(43) 
  check:50'0 
  .
  .
  .
  >>
  --

Can you take a look and revert if you need time to investigate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126651/new/

https://reviews.llvm.org/D126651

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D120201#3547835 , @abrachet wrote:

> In D120201#3547834 , @dyung wrote:
>
>> The test you added seems to be failing on the PS4 Windows bot. A quick 
>> glance seems to suggest that you aren't properly escaping the path 
>> separators somewhere. Can you take a look and revert if you need time to 
>> investigate?
>>
>> https://lab.llvm.org/buildbot/#/builders/216/builds/5164
>
> Should be fixed by 
> https://github.com/llvm/llvm-project/commit/a0ef52cc102504c4282dec7001664ee020396681

Indeed it has, thanks for the quick action!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120201/new/

https://reviews.llvm.org/D120201

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

The test you added seems to be failing on the PS4 Windows bot. A quick glance 
seems to suggest that you aren't properly escaping the path separators 
somewhere. Can you take a look and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/216/builds/5164


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120201/new/

https://reviews.llvm.org/D120201

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @jkorous, 4 of the tests you added seem to be failing on the PS4 linux and 
Window buildbots, can you take a look, and revert if it might take a while to 
investigate?

https://lab.llvm.org/buildbot/#/builders/139/builds/21573
https://lab.llvm.org/buildbot/#/builders/216/builds/4167


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123273/new/

https://reviews.llvm.org/D123273

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

I think the problem here is that if zlib is not available, you won't get the 
clang command line you expect:

https://lab.llvm.org/buildbot/#/builders/216/builds/3519

  Input was:
  <<
   1: clang version 15.0.0 
(https://github.com/llvm/llvm-project.git 
2d0c897212d0551966b26eae986209ea31c4f032) 
   2: Target: x86_64-unknown-fuchsia 
   3: Thread model: posix 
   4: InstalledDir: 
c:\buildbot-root\llvm-clang-x86_64-sie-win\build\bin 
   5: clang: warning: cannot compress debug sections (zlib not 
installed) [-Wdebug-compression-unavailable] 
   6:  
"c:\\buildbot-root\\llvm-clang-x86_64-sie-win\\build\\bin\\clang.exe" "-cc1" 
"-triple" "x86_64-unknown-fuchsia" "-emit-obj" "--mrelax-relocations" 
"-disable-free" "-clear-ast-before-backend" "-main-file-name" "fuchsia.c" 
"-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" "-mframe-pointer=all" 
"-ffp-contract=on" "-fno-rounding-math" "-mconstructor-aliases" 
"-funwind-tables=2" "-target-cpu" "x86-64" "-tune-cpu" "generic" "-mllvm" 
"-treat-scalable-fixed-error-as-warning" "-debugger-tuning=gdb" 
"-fcoverage-compilation-dir=C:\\buildbot-root\\llvm-clang-x86_64-sie-win\\build\\tools\\clang\\test\\Driver"
 "-resource-dir" 
"c:\\buildbot-root\\llvm-clang-x86_64-sie-win\\build\\lib\\clang\\15.0.0" 
"-isysroot" 
"C:\\buildbot-root\\llvm-clang-x86_64-sie-win\\llvm-project\\clang\\test\\Driver/platform"
 "-internal-isystem" 
"c:\\buildbot-root\\llvm-clang-x86_64-sie-win\\build\\lib\\clang\\15.0.0\\include"
 "-internal-externc-isystem" 
"C:\\buildbot-root\\llvm-clang-x86_64-sie-win\\llvm-project\\clang\\test\\Driver/platform\\include"
 "-Og" 
"-fdebug-compilation-dir=C:\\buildbot-root\\llvm-clang-x86_64-sie-win\\build\\tools\\clang\\test\\Driver"
 "-ferror-limit" "19" "-fsanitize=safe-stack" "-stack-protector" "2" 
"-fgnuc-version=4.2.1" "-faddrsig" "-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o" 
"C:\\Users\\BUILDB~1\\AppData\\Local\\Temp\\lit-tmp-f3r87ykv\\fuchsia-9a49da.o" 
"-x" "c" 
"C:\\buildbot-root\\llvm-clang-x86_64-sie-win\\llvm-project\\clang\\test\\Driver\\fuchsia.c"
 
   7:  
"c:\\buildbot-root\\llvm-clang-x86_64-sie-win\\build\\bin\\ld.lld" "-z" 
"max-page-size=4096" "-z" "now" "-z" "rodynamic" "-z" 
"separate-loadable-segments" "-z" "rel" "--pack-dyn-relocs=relr" 
"--sysroot=C:\\buildbot-root\\llvm-clang-x86_64-sie-win\\llvm-project\\clang\\test\\Driver/platform"
 "-pie" "--build-id" "--hash-style=gnu" "--eh-frame-hdr" "-dynamic-linker" 
"ld.so.1" "-o" "a.out" "Scrt1.o" 
"-LC:\\buildbot-root\\llvm-clang-x86_64-sie-win\\llvm-project\\clang\\test\\Driver/platform\\lib"
 "--compress-debug-sections=zlib" 
"C:\\Users\\BUILDB~1\\AppData\\Local\\Temp\\lit-tmp-f3r87ykv\\fuchsia-9a49da.o" 
"c:\\buildbot-root\\llvm-clang-x86_64-sie-win\\build\\lib\\clang\\15.0.0\\lib\\fuchsia\\libclang_rt.builtins-x86_64.a"
 "-lc" 
  >>

Since lld does produce the expected argument, it suggests that maybe LLD isn't 
doing any detection of whether zlib is available like the compiler is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114115/new/

https://reviews.llvm.org/D114115

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D121556: [randstruct] Add randomize structure layout support

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi, the test you added is failing on the PS4 Windows bot 
https://lab.llvm.org/buildbot/#/builders/216/builds/2647.

Can you take a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121556/new/

https://reviews.llvm.org/D121556

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi, one of the tests you added. csky-toolchain.c seems to be failing on a 
Windows build bot, and from a quick look, it appears to be a path separator 
issue. Can you take a look?

https://lab.llvm.org/buildbot/#/builders/216/builds/2452


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121445/new/

https://reviews.llvm.org/D121445

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122611: [clang][extract-api] Add support for macros

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

This change is causing 9 test failures on a buildbot, can you please take a 
look and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/139/builds/19441


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122611/new/

https://reviews.llvm.org/D122611

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

I've reverted this change in order to get the build bots green again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117522/new/

https://reviews.llvm.org/D117522

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

This change seems to be causing many bots to fail when running the clang :: 
Preprocessor/init.c test, can you take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/18081
https://lab.llvm.org/buildbot/#/builders/216/builds/881
https://lab.llvm.org/buildbot/#/builders/109/builds/33853


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121014/new/

https://reviews.llvm.org/D121014

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Thanks for fixing the problem with the original commit, but in the future, if 
you make follow-up commits, can you change the commit message to reflect what 
the commit contains? Having three different commits with the exact same commit 
message can be very confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120489/new/

https://reviews.llvm.org/D120489

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

And the PS4 build bots:

https://lab.llvm.org/buildbot/#/builders/139/builds/18001
https://lab.llvm.org/buildbot/#/builders/216/builds/801


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120489/new/

https://reviews.llvm.org/D120489

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

If it helps, this is the cmake command I am using to build using gcc on linux:

  CMake command: -G Ninja -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_VERSION_SUFFIX= 
-DLLVM_BUILD_RUNTIME=ON -DLLVM_TOOL_LLD_BUILD=OFF "-DLLVM_LIT_ARGS=--verbose 
-j80 --no-progress-bar --max-tests 10" -DCMAKE_BUILD_TYPE=Release 
-DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_TARGETS_TO_BUILD=all 
-DLLVM_ENABLE_PROJECTS=clang;clang-tools-extra

Some of the stuff there probably isn't needed (it's taken from a general script 
that I make small changes to when trying to reproduce stuff), but is there for 
completeness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120254/new/

https://reviews.llvm.org/D120254

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D120254#3342570 , @svenvh wrote:

> In D120254#3342551 , @dyung wrote:
>
>> Hi, our internal release build bots are showing failures in two clang-tidy 
>> tests that I bisected back to your commit, 
>> clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and 
>> clang-tidy/checkers/altera-single-work-item-barrier.cpp. After this change, 
>> both are exhibiting this error:
>>
>>   Error while processing 
>> /home/dyung/src/upstream/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b-linux/tools/clang/tools/extra/test/clang-tidy/checkers/Output/altera-single-work-item-barrier.cpp.tmp.cpp.
>>   error: enum type memory_scope not found; include the base header with 
>> -finclude-default-header [clang-diagnostic-error]
>>
>> Oddly, this only fails in a release configuration. Can you take a look?
>
> I'll try to reproduce the failure locally, but until I've done so perhaps you 
> could try whether the following fixes one of the tests?  If so, then the 
> other test will likely need a similar fix.
>
>   diff --git 
> a/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp
>  
> b/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp
>   index a6dbab7b72fc..9bc1bbf173cc 100644
>   --- 
> a/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp
>   +++ 
> b/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp
>   @@ -1,4 +1,4 @@
>   -// RUN: %check_clang_tidy %s altera-id-dependent-backward-branch %t -- 
> -header-filter=.* "--" -cl-std=CL1.2 -c --include opencl-c.h
>   +// RUN: %check_clang_tidy %s altera-id-dependent-backward-branch %t -- 
> -header-filter=.* "--" -cl-std=CL1.2 -c --include opencl-c.h --include 
> opencl-c-base.h
>
>typedef struct ExampleStruct {
>  int IDDepField;

I just tried that patch and it doesn't seem to fix it unfortunately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120254/new/

https://reviews.llvm.org/D120254

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits