[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

[Evan Wilde via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGe4ad1f976d12: [NFC] Remove extra semicolons in 
clang/lib/APINotes/APINotesFormat.h (authored by etcwilde).
Herald added a project: All.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105049/new/

https://reviews.llvm.org/D105049

Files:
  clang/lib/APINotes/APINotesFormat.h


Index: clang/lib/APINotes/APINotesFormat.h
===
--- clang/lib/APINotes/APINotesFormat.h
+++ clang/lib/APINotes/APINotesFormat.h
@@ -220,7 +220,7 @@
   // below)
  llvm::BCBlob // map from name to tag information
  >;
-}; // namespace tag_block
+} // namespace tag_block
 
 namespace typedef_block {
 enum { TYPEDEF_DATA = 1 };
@@ -231,7 +231,7 @@
   // below)
  llvm::BCBlob // map from name to typedef information
  >;
-}; // namespace typedef_block
+} // namespace typedef_block
 
 namespace enum_constant_block {
 enum { ENUM_CONSTANT_DATA = 1 };


Index: clang/lib/APINotes/APINotesFormat.h
===
--- clang/lib/APINotes/APINotesFormat.h
+++ clang/lib/APINotes/APINotesFormat.h
@@ -220,7 +220,7 @@
   // below)
  llvm::BCBlob // map from name to tag information
  >;
-}; // namespace tag_block
+} // namespace tag_block
 
 namespace typedef_block {
 enum { TYPEDEF_DATA = 1 };
@@ -231,7 +231,7 @@
   // below)
  llvm::BCBlob // map from name to typedef information
  >;
-}; // namespace typedef_block
+} // namespace typedef_block
 
 namespace enum_constant_block {
 enum { ENUM_CONSTANT_DATA = 1 };
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155413: [NFC] Add `push_back` to `llvm::Function`

[Evan Wilde via Phabricator via cfe-commits]

etcwilde added a comment.

Failure was a formatting issue in `clang/lib/Analysis/UnsafeBufferUsage.cpp`.
I just fixed that in d7b45945fbb7c4ac27c456dd7c2ff8bb40fcf8f8 
.
I don't know how to re-trigger the tests though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155413/new/

https://reviews.llvm.org/D155413

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155413: [NFC] Add `push_back` to `llvm::Function`

[Evan Wilde via Phabricator via cfe-commits]

etcwilde updated this revision to Diff 540850.
etcwilde added a comment.

Fixing `push_back` formatting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155413/new/

https://reviews.llvm.org/D155413

Files:
  clang/lib/CodeGen/CGStmt.cpp
  clang/lib/CodeGen/CodeGenFunction.cpp
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl05.rst
  llvm/examples/Kaleidoscope/BuildingAJIT/Chapter1/toy.cpp
  llvm/examples/Kaleidoscope/BuildingAJIT/Chapter2/toy.cpp
  llvm/examples/Kaleidoscope/BuildingAJIT/Chapter3/toy.cpp
  llvm/examples/Kaleidoscope/BuildingAJIT/Chapter4/toy.cpp
  llvm/examples/Kaleidoscope/Chapter5/toy.cpp
  llvm/examples/Kaleidoscope/Chapter6/toy.cpp
  llvm/examples/Kaleidoscope/Chapter7/toy.cpp
  llvm/examples/Kaleidoscope/Chapter8/toy.cpp
  llvm/examples/Kaleidoscope/Chapter9/toy.cpp
  llvm/examples/Kaleidoscope/MCJIT/cached/toy-jit.cpp
  llvm/examples/Kaleidoscope/MCJIT/cached/toy.cpp
  llvm/examples/Kaleidoscope/MCJIT/complete/toy.cpp
  llvm/examples/Kaleidoscope/MCJIT/initial/toy.cpp
  llvm/examples/Kaleidoscope/MCJIT/lazy/toy-jit.cpp
  llvm/examples/Kaleidoscope/MCJIT/lazy/toy.cpp
  llvm/include/llvm/IR/Function.h

Index: llvm/include/llvm/IR/Function.h
===
--- llvm/include/llvm/IR/Function.h
+++ llvm/include/llvm/IR/Function.h
@@ -693,6 +693,9 @@
 return BasicBlocks.insert(Position, BB);
   }
 
+  /// append \p BB to the end of the function
+  void push_back(BasicBlock *BB) { return BasicBlocks.push_back(BB); }
+
   /// Transfer all blocks from \p FromF to this function at \p ToIt.
   void splice(Function::iterator ToIt, Function *FromF) {
 splice(ToIt, FromF, FromF->begin(), FromF->end());
Index: llvm/examples/Kaleidoscope/MCJIT/lazy/toy.cpp
===
--- llvm/examples/Kaleidoscope/MCJIT/lazy/toy.cpp
+++ llvm/examples/Kaleidoscope/MCJIT/lazy/toy.cpp
@@ -1025,7 +1025,7 @@
   ThenBB = Builder.GetInsertBlock();
 
   // Emit else block.
-  TheFunction->insert(TheFunction->end(), ElseBB);
+  TheFunction->push_back(ElseBB);
   Builder.SetInsertPoint(ElseBB);
 
   Value *ElseV = Else->Codegen();
@@ -1036,7 +1036,7 @@
   ElseBB = Builder.GetInsertBlock();
 
   // Emit merge block.
-  TheFunction->insert(TheFunction->end(), MergeBB);
+  TheFunction->push_back(MergeBB);
   Builder.SetInsertPoint(MergeBB);
   PHINode *PN = Builder.CreatePHI(Type::getDoubleTy(TheContext), 2, "iftmp");
 
Index: llvm/examples/Kaleidoscope/MCJIT/lazy/toy-jit.cpp
===
--- llvm/examples/Kaleidoscope/MCJIT/lazy/toy-jit.cpp
+++ llvm/examples/Kaleidoscope/MCJIT/lazy/toy-jit.cpp
@@ -745,7 +745,7 @@
   ThenBB = Builder.GetInsertBlock();
   
   // Emit else block.
-  TheFunction->insert(TheFunction->end(), ElseBB);
+  TheFunction->push_back(ElseBB);
   Builder.SetInsertPoint(ElseBB);
   
   Value *ElseV = Else->Codegen();
@@ -756,7 +756,7 @@
   ElseBB = Builder.GetInsertBlock();
   
   // Emit merge block.
-  TheFunction->insert(TheFunction->end(), MergeBB);
+  TheFunction->push_back(MergeBB);
   Builder.SetInsertPoint(MergeBB);
   PHINode *PN = Builder.CreatePHI(Type::getDoubleTy(TheContext), 2, "iftmp");
 
Index: llvm/examples/Kaleidoscope/MCJIT/initial/toy.cpp
===
--- llvm/examples/Kaleidoscope/MCJIT/initial/toy.cpp
+++ llvm/examples/Kaleidoscope/MCJIT/initial/toy.cpp
@@ -985,7 +985,7 @@
   ThenBB = Builder.GetInsertBlock();
 
   // Emit else block.
-  TheFunction->insert(TheFunction->end(), ElseBB);
+  TheFunction->push_back(ElseBB);
   Builder.SetInsertPoint(ElseBB);
 
   Value *ElseV = Else->Codegen();
@@ -996,7 +996,7 @@
   ElseBB = Builder.GetInsertBlock();
 
   // Emit merge block.
-  TheFunction->insert(TheFunction->end(), MergeBB);
+  TheFunction->push_back(MergeBB);
   Builder.SetInsertPoint(MergeBB);
   PHINode *PN = Builder.CreatePHI(Type::getDoubleTy(TheContext), 2, "iftmp");
 
Index: llvm/examples/Kaleidoscope/MCJIT/complete/toy.cpp
===
--- llvm/examples/Kaleidoscope/MCJIT/complete/toy.cpp
+++ llvm/examples/Kaleidoscope/MCJIT/complete/toy.cpp
@@ -1205,7 +1205,7 @@
   ThenBB = Builder.GetInsertBlock();
 
   // Emit else block.
-  TheFunction->insert(TheFunction->end(), ElseBB);
+  TheFunction->push_back(ElseBB);
   Builder.SetInsertPoint(ElseBB);
 
   Value *ElseV = Else->Codegen();
@@ -1216,7 +1216,7 @@
   ElseBB = Builder.GetInsertBlock();
 
   // Emit merge block.
-  TheFunction->insert(TheFunction->end(), MergeBB);
+  TheFunction->push_back(MergeBB);
   Builder.SetInsertPoint(MergeBB);
   PHINode *PN = Builder.CreatePHI(Type::getDoubleTy(TheContext), 2, "iftmp");
 
Index: llvm/examples/Kaleidoscope/MCJIT/cached/toy.cpp
===
--- llvm/examples/Kaleidoscope/MCJIT/cached/toy.cpp
+++ 

[PATCH] D155413: [NFC] Add `push_back` to `llvm::Function`

[Evan Wilde via Phabricator via cfe-commits]

etcwilde created this revision.
etcwilde added reviewers: compnerd, vporpo.
etcwilde added a project: LLVM.
Herald added a project: All.
etcwilde requested review of this revision.
Herald added a project: clang.
Herald added subscribers: llvm-commits, cfe-commits.

Appending a basic block to a function is a fairly common operation. The basic 
block list is private now, so pushing back is currently done by 
`myFunction->insert(myFunction->getEnd(), bb);`, which feels a bit redundant. 
This patch adds a `push_back` convenience function to `llvm::Function` to make 
appending basic blocks a bit easier again.

  +  /// append \p BB to the end of the function
  +  void push_back(BasicBlock *BB) {
  +return BasicBlocks.push_back(BB);
  +  }

I've also gone through and migrated the usage in kaleidoscope, the getting 
started docs, and in clang where I saw it.
I'm open to leaving that part of the change off, but it makes it a little bit 
clearer what the intended goal is.

I was going back and forth a little regarding the naming. `appendBasicBlock` is 
clearest, `push_back` is most consistent though.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155413

Files:
  clang/lib/CodeGen/CGStmt.cpp
  clang/lib/CodeGen/CodeGenFunction.cpp
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl05.rst
  llvm/examples/Kaleidoscope/BuildingAJIT/Chapter1/toy.cpp
  llvm/examples/Kaleidoscope/BuildingAJIT/Chapter2/toy.cpp
  llvm/examples/Kaleidoscope/BuildingAJIT/Chapter3/toy.cpp
  llvm/examples/Kaleidoscope/BuildingAJIT/Chapter4/toy.cpp
  llvm/examples/Kaleidoscope/Chapter5/toy.cpp
  llvm/examples/Kaleidoscope/Chapter6/toy.cpp
  llvm/examples/Kaleidoscope/Chapter7/toy.cpp
  llvm/examples/Kaleidoscope/Chapter8/toy.cpp
  llvm/examples/Kaleidoscope/Chapter9/toy.cpp
  llvm/examples/Kaleidoscope/MCJIT/cached/toy-jit.cpp
  llvm/examples/Kaleidoscope/MCJIT/cached/toy.cpp
  llvm/examples/Kaleidoscope/MCJIT/complete/toy.cpp
  llvm/examples/Kaleidoscope/MCJIT/initial/toy.cpp
  llvm/examples/Kaleidoscope/MCJIT/lazy/toy-jit.cpp
  llvm/examples/Kaleidoscope/MCJIT/lazy/toy.cpp
  llvm/include/llvm/IR/Function.h

Index: llvm/include/llvm/IR/Function.h
===
--- llvm/include/llvm/IR/Function.h
+++ llvm/include/llvm/IR/Function.h
@@ -693,6 +693,11 @@
 return BasicBlocks.insert(Position, BB);
   }
 
+  /// append \p BB to the end of the function
+  void push_back(BasicBlock *BB) {
+return BasicBlocks.push_back(BB);
+  }
+
   /// Transfer all blocks from \p FromF to this function at \p ToIt.
   void splice(Function::iterator ToIt, Function *FromF) {
 splice(ToIt, FromF, FromF->begin(), FromF->end());
Index: llvm/examples/Kaleidoscope/MCJIT/lazy/toy.cpp
===
--- llvm/examples/Kaleidoscope/MCJIT/lazy/toy.cpp
+++ llvm/examples/Kaleidoscope/MCJIT/lazy/toy.cpp
@@ -1025,7 +1025,7 @@
   ThenBB = Builder.GetInsertBlock();
 
   // Emit else block.
-  TheFunction->insert(TheFunction->end(), ElseBB);
+  TheFunction->push_back(ElseBB);
   Builder.SetInsertPoint(ElseBB);
 
   Value *ElseV = Else->Codegen();
@@ -1036,7 +1036,7 @@
   ElseBB = Builder.GetInsertBlock();
 
   // Emit merge block.
-  TheFunction->insert(TheFunction->end(), MergeBB);
+  TheFunction->push_back(MergeBB);
   Builder.SetInsertPoint(MergeBB);
   PHINode *PN = Builder.CreatePHI(Type::getDoubleTy(TheContext), 2, "iftmp");
 
Index: llvm/examples/Kaleidoscope/MCJIT/lazy/toy-jit.cpp
===
--- llvm/examples/Kaleidoscope/MCJIT/lazy/toy-jit.cpp
+++ llvm/examples/Kaleidoscope/MCJIT/lazy/toy-jit.cpp
@@ -745,7 +745,7 @@
   ThenBB = Builder.GetInsertBlock();
   
   // Emit else block.
-  TheFunction->insert(TheFunction->end(), ElseBB);
+  TheFunction->push_back(ElseBB);
   Builder.SetInsertPoint(ElseBB);
   
   Value *ElseV = Else->Codegen();
@@ -756,7 +756,7 @@
   ElseBB = Builder.GetInsertBlock();
   
   // Emit merge block.
-  TheFunction->insert(TheFunction->end(), MergeBB);
+  TheFunction->push_back(MergeBB);
   Builder.SetInsertPoint(MergeBB);
   PHINode *PN = Builder.CreatePHI(Type::getDoubleTy(TheContext), 2, "iftmp");
 
Index: llvm/examples/Kaleidoscope/MCJIT/initial/toy.cpp
===
--- llvm/examples/Kaleidoscope/MCJIT/initial/toy.cpp
+++ llvm/examples/Kaleidoscope/MCJIT/initial/toy.cpp
@@ -985,7 +985,7 @@
   ThenBB = Builder.GetInsertBlock();
 
   // Emit else block.
-  TheFunction->insert(TheFunction->end(), ElseBB);
+  TheFunction->push_back(ElseBB);
   Builder.SetInsertPoint(ElseBB);
 
   Value *ElseV = Else->Codegen();
@@ -996,7 +996,7 @@
   ElseBB = Builder.GetInsertBlock();
 
   // Emit merge block.
-  TheFunction->insert(TheFunction->end(), MergeBB);
+  TheFunction->push_back(MergeBB);
   Builder.SetInsertPoint(MergeBB);
   PHINode *PN = Builder.CreatePHI(Type::getDoubleTy(TheContext), 2, "iftmp");
 
Index: 

[PATCH] D154664: [NFC] Add some missing header includes

[Evan Wilde via Phabricator via cfe-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0f9f95146a7f: [NFC] Add optional include to Format.h 
(authored by etcwilde).

Changed prior to commit:
  https://reviews.llvm.org/D154664?vs=537916=538401#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154664/new/

https://reviews.llvm.org/D154664

Files:
  llvm/include/llvm/Support/Format.h


Index: llvm/include/llvm/Support/Format.h
===
--- llvm/include/llvm/Support/Format.h
+++ llvm/include/llvm/Support/Format.h
@@ -28,6 +28,7 @@
 #include "llvm/Support/DataTypes.h"
 #include 
 #include 
+#include 
 #include 
 #include 
 


Index: llvm/include/llvm/Support/Format.h
===
--- llvm/include/llvm/Support/Format.h
+++ llvm/include/llvm/Support/Format.h
@@ -28,6 +28,7 @@
 #include "llvm/Support/DataTypes.h"
 #include 
 #include 
+#include 
 #include 
 #include 
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154664: [NFC] Add some missing header includes

[Evan Wilde via Phabricator via cfe-commits]

etcwilde updated this revision to Diff 537916.
etcwilde added a comment.

Grabbed the right patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154664/new/

https://reviews.llvm.org/D154664

Files:
  llvm/include/llvm/Support/Format.h
  llvm/include/llvm/TargetParser/SubtargetFeature.h


Index: llvm/include/llvm/TargetParser/SubtargetFeature.h
===
--- llvm/include/llvm/TargetParser/SubtargetFeature.h
+++ llvm/include/llvm/TargetParser/SubtargetFeature.h
@@ -17,6 +17,7 @@
 #ifndef LLVM_TARGETPARSER_SUBTARGETFEATURE_H
 #define LLVM_TARGETPARSER_SUBTARGETFEATURE_H
 
+#include "llvm/ADT/bit.h"
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/StringRef.h"
Index: llvm/include/llvm/Support/Format.h
===
--- llvm/include/llvm/Support/Format.h
+++ llvm/include/llvm/Support/Format.h
@@ -28,6 +28,7 @@
 #include "llvm/Support/DataTypes.h"
 #include 
 #include 
+#include 
 #include 
 #include 
 


Index: llvm/include/llvm/TargetParser/SubtargetFeature.h
===
--- llvm/include/llvm/TargetParser/SubtargetFeature.h
+++ llvm/include/llvm/TargetParser/SubtargetFeature.h
@@ -17,6 +17,7 @@
 #ifndef LLVM_TARGETPARSER_SUBTARGETFEATURE_H
 #define LLVM_TARGETPARSER_SUBTARGETFEATURE_H
 
+#include "llvm/ADT/bit.h"
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/StringRef.h"
Index: llvm/include/llvm/Support/Format.h
===
--- llvm/include/llvm/Support/Format.h
+++ llvm/include/llvm/Support/Format.h
@@ -28,6 +28,7 @@
 #include "llvm/Support/DataTypes.h"
 #include 
 #include 
+#include 
 #include 
 #include 
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154664: [NFC] Add some missing header includes

[Evan Wilde via Phabricator via cfe-commits]

etcwilde created this revision.
etcwilde added reviewers: compnerd, mib.
etcwilde added projects: clang, LLVM.
Herald added a project: All.
etcwilde requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits.

Fixing local build failures due to missing header includes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154664

Files:
  clang/lib/Frontend/CachedDiagnostics.cpp
  clang/lib/Frontend/CachedDiagnostics.h
  llvm/include/llvm/Support/Format.h
  llvm/include/llvm/TargetParser/SubtargetFeature.h


Index: llvm/include/llvm/TargetParser/SubtargetFeature.h
===
--- llvm/include/llvm/TargetParser/SubtargetFeature.h
+++ llvm/include/llvm/TargetParser/SubtargetFeature.h
@@ -17,6 +17,7 @@
 #ifndef LLVM_TARGETPARSER_SUBTARGETFEATURE_H
 #define LLVM_TARGETPARSER_SUBTARGETFEATURE_H
 
+#include "llvm/ADT/bit.h"
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/StringRef.h"
Index: llvm/include/llvm/Support/Format.h
===
--- llvm/include/llvm/Support/Format.h
+++ llvm/include/llvm/Support/Format.h
@@ -28,6 +28,7 @@
 #include "llvm/Support/DataTypes.h"
 #include 
 #include 
+#include 
 #include 
 #include 
 
Index: clang/lib/Frontend/CachedDiagnostics.h
===
--- clang/lib/Frontend/CachedDiagnostics.h
+++ clang/lib/Frontend/CachedDiagnostics.h
@@ -11,6 +11,8 @@
 
 #include "clang/Basic/LLVM.h"
 #include "llvm/Support/PrefixMapper.h"
+#include 
+#include 
 
 namespace clang {
 class DiagnosticConsumer;
Index: clang/lib/Frontend/CachedDiagnostics.cpp
===
--- clang/lib/Frontend/CachedDiagnostics.cpp
+++ clang/lib/Frontend/CachedDiagnostics.cpp
@@ -25,6 +25,7 @@
 #include "llvm/Support/EndianStream.h"
 #include "llvm/Support/StringSaver.h"
 #include "llvm/Support/YAMLTraits.h"
+#include 
 
 using namespace clang;
 using namespace clang::cas;


Index: llvm/include/llvm/TargetParser/SubtargetFeature.h
===
--- llvm/include/llvm/TargetParser/SubtargetFeature.h
+++ llvm/include/llvm/TargetParser/SubtargetFeature.h
@@ -17,6 +17,7 @@
 #ifndef LLVM_TARGETPARSER_SUBTARGETFEATURE_H
 #define LLVM_TARGETPARSER_SUBTARGETFEATURE_H
 
+#include "llvm/ADT/bit.h"
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/StringRef.h"
Index: llvm/include/llvm/Support/Format.h
===
--- llvm/include/llvm/Support/Format.h
+++ llvm/include/llvm/Support/Format.h
@@ -28,6 +28,7 @@
 #include "llvm/Support/DataTypes.h"
 #include 
 #include 
+#include 
 #include 
 #include 
 
Index: clang/lib/Frontend/CachedDiagnostics.h
===
--- clang/lib/Frontend/CachedDiagnostics.h
+++ clang/lib/Frontend/CachedDiagnostics.h
@@ -11,6 +11,8 @@
 
 #include "clang/Basic/LLVM.h"
 #include "llvm/Support/PrefixMapper.h"
+#include 
+#include 
 
 namespace clang {
 class DiagnosticConsumer;
Index: clang/lib/Frontend/CachedDiagnostics.cpp
===
--- clang/lib/Frontend/CachedDiagnostics.cpp
+++ clang/lib/Frontend/CachedDiagnostics.cpp
@@ -25,6 +25,7 @@
 #include "llvm/Support/EndianStream.h"
 #include "llvm/Support/StringSaver.h"
 #include "llvm/Support/YAMLTraits.h"
+#include 
 
 using namespace clang;
 using namespace clang::cas;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112890: headers: optionalise some generated resource headers

[Evan Wilde via Phabricator via cfe-commits]

etcwilde added a comment.

Right, the header is only necessary when you're targeting riscv, so if 
compiling for riscv isn't supported by the compiler noted in the 
`LLVM_TARGETS_TO_BUILD`, you don't need it and can't use it anyway.
This is separate from the host platform that the compiler is running on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112890/new/

https://reviews.llvm.org/D112890

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112890: headers: optionalise some generated resource headers

[Evan Wilde via Phabricator via cfe-commits]

etcwilde added a comment.

This makes sense to me. It doesn't make sense to spend the time generating 
files that will never get used, nor spend the space for storing them.
`riscv_vector.h` in particular is quite large, coming in at just under 10M, and 
there are two of them showing up in my build at 
`tools/clang/lib/Headers/riscv_vector.h` and 
`lib/clang/10.0.0/include/riscv_vector.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112890/new/

https://reviews.llvm.org/D112890

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

[Evan Wilde via Phabricator via cfe-commits]

etcwilde created this revision.
etcwilde added a reviewer: compnerd.
etcwilde added a project: clang.
etcwilde requested review of this revision.
Herald added a subscriber: cfe-commits.

There are some trailing semicolons on namespaces in 
clang/lib/APINotes/APINotesFormat.h.
These result in warnings while building and don't need to be there.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105049

Files:
  clang/lib/APINotes/APINotesFormat.h


Index: clang/lib/APINotes/APINotesFormat.h
===
--- clang/lib/APINotes/APINotesFormat.h
+++ clang/lib/APINotes/APINotesFormat.h
@@ -220,7 +220,7 @@
   // below)
  llvm::BCBlob // map from name to tag information
  >;
-}; // namespace tag_block
+} // namespace tag_block
 
 namespace typedef_block {
 enum { TYPEDEF_DATA = 1 };
@@ -231,7 +231,7 @@
   // below)
  llvm::BCBlob // map from name to typedef information
  >;
-}; // namespace typedef_block
+} // namespace typedef_block
 
 namespace enum_constant_block {
 enum { ENUM_CONSTANT_DATA = 1 };


Index: clang/lib/APINotes/APINotesFormat.h
===
--- clang/lib/APINotes/APINotesFormat.h
+++ clang/lib/APINotes/APINotesFormat.h
@@ -220,7 +220,7 @@
   // below)
  llvm::BCBlob // map from name to tag information
  >;
-}; // namespace tag_block
+} // namespace tag_block
 
 namespace typedef_block {
 enum { TYPEDEF_DATA = 1 };
@@ -231,7 +231,7 @@
   // below)
  llvm::BCBlob // map from name to typedef information
  >;
-}; // namespace typedef_block
+} // namespace typedef_block
 
 namespace enum_constant_block {
 enum { ENUM_CONSTANT_DATA = 1 };
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits