fxroure-ubisoft created this revision. fxroure-ubisoft added a reviewer: clang. fxroure-ubisoft created this object with edit policy "Only User: fxroure-ubisoft (François-Xavier Roure)". Herald added a subscriber: cfe-commits.
When installing the clang-format visual studio plugin <https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.ClangFormat#overview> sometimes it won't be loaded correctly (some users seem to have the same issue <https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.ClangFormat#review-details>) and we must do devenv.exe /updateconfiguration in order to fix the installation (normally visual studio should automatically execute this command whenever you install a plugin). This issue seems to come from the fact that the plugin manifest does not list a VsPackage as an asset. After adding it to assets list (code change in this review) installation of the plugin was working and when uninstalling the plugin visual correctly ask to restart it (that was not the case before). Repository: rC Clang https://reviews.llvm.org/D43953 Files: tools/clang-format-vs/source.extension.vsixmanifest.in Index: tools/clang-format-vs/source.extension.vsixmanifest.in =================================================================== --- tools/clang-format-vs/source.extension.vsixmanifest.in +++ tools/clang-format-vs/source.extension.vsixmanifest.in @@ -16,4 +16,7 @@ <Prerequisites> <Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[11.0,)" DisplayName="Visual Studio core editor" /> </Prerequisites> + <Assets> + <Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="Project" d:ProjectName="%CurrentProject%" Path="|%CurrentProject%;PkgdefProjectOutputGroup|" /> + </Assets> </PackageManifest>
Index: tools/clang-format-vs/source.extension.vsixmanifest.in =================================================================== --- tools/clang-format-vs/source.extension.vsixmanifest.in +++ tools/clang-format-vs/source.extension.vsixmanifest.in @@ -16,4 +16,7 @@ <Prerequisites> <Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[11.0,)" DisplayName="Visual Studio core editor" /> </Prerequisites> + <Assets> + <Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="Project" d:ProjectName="%CurrentProject%" Path="|%CurrentProject%;PkgdefProjectOutputGroup|" /> + </Assets> </PackageManifest>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits