[PATCH] D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

[Galina via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG01f13f487775: Explain code coverage with Lit in 
docs/SourceBasedCodeCoverage.rst (authored by FlashSheridan, committed by 
gkistanova).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140730/new/

https://reviews.llvm.org/D140730

Files:
  clang/docs/SourceBasedCodeCoverage.rst


Index: clang/docs/SourceBasedCodeCoverage.rst
===
--- clang/docs/SourceBasedCodeCoverage.rst
+++ clang/docs/SourceBasedCodeCoverage.rst
@@ -127,6 +127,11 @@
 other platforms by passing the ``-runtime-counter-relocation`` option to the
 backend during compilation.
 
+For a program such as the :doc:`Lit ` testing tool which
+invokes other programs, it may be necessary to set ``LLVM_PROFILE_FILE`` for
+each invocation. The pattern strings "%p" or "%Nm" may help to avoid
+corruption due to concurrency.
+
 .. code-block:: console
 
 % clang++ -fprofile-instr-generate -fcoverage-mapping -mllvm 
-runtime-counter-relocation foo.cc -o foo
@@ -143,6 +148,9 @@
 # Step 3(a): Index the raw profile.
 % llvm-profdata merge -sparse foo.profraw -o foo.profdata
 
+For an example of merging multiple profiles created by testing,
+see the LLVM `coverage build script 
`_.
+
 There are multiple different ways to render coverage reports. The simplest
 option is to generate a line-oriented report:
 


Index: clang/docs/SourceBasedCodeCoverage.rst
===
--- clang/docs/SourceBasedCodeCoverage.rst
+++ clang/docs/SourceBasedCodeCoverage.rst
@@ -127,6 +127,11 @@
 other platforms by passing the ``-runtime-counter-relocation`` option to the
 backend during compilation.
 
+For a program such as the :doc:`Lit ` testing tool which
+invokes other programs, it may be necessary to set ``LLVM_PROFILE_FILE`` for
+each invocation. The pattern strings "%p" or "%Nm" may help to avoid
+corruption due to concurrency.
+
 .. code-block:: console
 
 % clang++ -fprofile-instr-generate -fcoverage-mapping -mllvm -runtime-counter-relocation foo.cc -o foo
@@ -143,6 +148,9 @@
 # Step 3(a): Index the raw profile.
 % llvm-profdata merge -sparse foo.profraw -o foo.profdata
 
+For an example of merging multiple profiles created by testing,
+see the LLVM `coverage build script `_.
+
 There are multiple different ways to render coverage reports. The simplest
 option is to generate a line-oriented report:
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

[Galina via Phabricator via cfe-commits]

gkistanova accepted this revision.
gkistanova added a comment.
This revision is now accepted and ready to land.

LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140730/new/

https://reviews.llvm.org/D140730

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69651: [CMake] Add cross Windows to ARM Linux toolchain CMake cache file.

[Galina via Phabricator via cfe-commits]

gkistanova accepted this revision.
gkistanova added a comment.

LGTM. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69651/new/

https://reviews.llvm.org/D69651



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61345: Allow 'CodeGenObjC/illegal-UTF8.m' test for 32-bit targets.

[Galina via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL360005: The CodeGenObjC/illegal-UTF8.m get 
failed with Clang built with 32-bit… (authored by gkistanova, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D61345?vs=197438=198217#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61345/new/

https://reviews.llvm.org/D61345

Files:
  cfe/trunk/test/CodeGenObjC/illegal-UTF8.m


Index: cfe/trunk/test/CodeGenObjC/illegal-UTF8.m
===
--- cfe/trunk/test/CodeGenObjC/illegal-UTF8.m
+++ cfe/trunk/test/CodeGenObjC/illegal-UTF8.m
@@ -1,4 +1,4 @@
-// RUN: %clang %s -S -m64 -o -
+// RUN: %clang %s -S -o -
 
 @class NSString;
 


Index: cfe/trunk/test/CodeGenObjC/illegal-UTF8.m
===
--- cfe/trunk/test/CodeGenObjC/illegal-UTF8.m
+++ cfe/trunk/test/CodeGenObjC/illegal-UTF8.m
@@ -1,4 +1,4 @@
-// RUN: %clang %s -S -m64 -o -
+// RUN: %clang %s -S -o -
 
 @class NSString;
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61345: Allow 'CodeGenObjC/illegal-UTF8.m' test for 32-bit targets.

[Galina via Phabricator via cfe-commits]

gkistanova accepted this revision.
gkistanova added a comment.
This revision is now accepted and ready to land.

Thanks for fixing this, Vlad!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61345/new/

https://reviews.llvm.org/D61345



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31126: Do not run tests for crash recovery if libstdc++ safe mode is enabled

[Galina via Phabricator via cfe-commits]

gkistanova accepted this revision.
gkistanova added a comment.
This revision is now accepted and ready to land.

LGTM

Thanks

Galina


https://reviews.llvm.org/D31126



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits