[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

[Justin Cady via Phabricator via cfe-commits]

justincady added a comment.

I suspect there's another unintended consequence of this change with regards to 
broken ODR violation detection. I filed an issue 
 and am connecting it here 
should someone find this review first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152604/new/

https://reviews.llvm.org/D152604

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

[Justin Cady via Phabricator via cfe-commits]

justincady added subscribers: njames93, LegalizeAdulthood, justincady.
justincady added a comment.

This feature appears to have strong user support throughout this review, and a 
lot of people (including myself) seem interested in having it landed.

cc'ing some clang-tidy owners 
:
 @LegalizeAdulthood @carlosgalvezp @njames93

Is there anything blocking this from moving forward? Can we work to get it 
submitted?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D34654/new/

https://reviews.llvm.org/D34654

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128482: [clang codegen] Add dso_local/hidden/etc. markings to VTT declarations

[Justin Cady via Phabricator via cfe-commits]

justincady accepted this revision.
justincady added a comment.

LGTM!

Just to double check I tested this exact patch locally with the setup that 
found the problem. I confirmed it resolved that issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128482/new/

https://reviews.llvm.org/D128482

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits