Re: [PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format
Why objective C? C++ has attributes and so does C2x, and I believe they’re both getting /have the unlikely attribute. > On May 25, 2020, at 1:10 PM, MyDeveloperDay via Phabricator > wrote: > > MyDeveloperDay added a comment. > > > >> I know that we didn't have a test for this in ObjC land, but the regression >> seems severe enough to revert this > > Sure go ahead, that's the process. > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D80144/new/ > > https://reviews.llvm.org/D80144 > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D75791: [clang-format] Added new option IndentExternBlock
I’m wondering if theres a way to tell if an option has been set in the
clang-format config file.
If IndentExternBlock is not set, we should default to the old behavior.
As for your suggestion of setting IndentExternBlock to
BraceWrapping.AfterExternBlock or negating it, neither way works with the tests.
> On Mar 26, 2020, at 10:33 AM, MyDeveloperDay via Phabricator
> wrote:
>
> MyDeveloperDay added a comment.
>
> Could the default be `Style.IndentExternBlock =
> Style.BraceWrapping.AfterExternBlock`
>
> Then it would match the prior behaviour off AddLevel being `true` when
> AfterExternBlock is `true`
>
> extern "C" {
> int a;
> }
>
> extern "C"
> {
>int a;
> }
>
>
> CHANGES SINCE LAST ACTION
> https://reviews.llvm.org/D75791/new/
>
> https://reviews.llvm.org/D75791
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
