[PATCH] D60115: Adding 'CLion integration' to clang-format doc

2019-04-03 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina added a comment.

@sylvestre.ledru Thanks a lot for your help


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60115/new/

https://reviews.llvm.org/D60115



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D60115: Adding 'CLion integration' to clang-format doc

2019-04-03 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina marked an inline comment as done.
MarinaKalashina added a comment.

@sylvestre.ledru Thank you! Could you please explain how I should proceed with 
the accepted revision now (without commit access, do I need to ask someone to 
make the commit for me)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60115/new/

https://reviews.llvm.org/D60115



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D60115: Adding 'CLion integration' to clang-format doc

2019-04-03 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina updated this revision to Diff 193441.
MarinaKalashina added a comment.

added a link to CLion


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60115/new/

https://reviews.llvm.org/D60115

Files:
  docs/ClangFormat.rst


Index: docs/ClangFormat.rst
===
--- docs/ClangFormat.rst
+++ docs/ClangFormat.rst
@@ -165,6 +165,19 @@
 shortcut in the BBEdit preferences, under Menus & Shortcuts.
 
 
+CLion Integration
+==
+
+:program:`clang-format` is integrated into `CLion `_ as an alternative code formatter. It is disabled by default and
+can be turned on in Settings/Preferences | Editor | Code Style.
+
+If :program:`clang-format` support is enabled, CLion detects config files when
+opening a project and suggests overriding the current IDE settings. Code style
+rules from the ``.clang-format`` files are then applied automatically to all
+editor actions, including auto-completion, code generation, and refactorings.
+
+
 Visual Studio Integration
 =
 


Index: docs/ClangFormat.rst
===
--- docs/ClangFormat.rst
+++ docs/ClangFormat.rst
@@ -165,6 +165,19 @@
 shortcut in the BBEdit preferences, under Menus & Shortcuts.
 
 
+CLion Integration
+==
+
+:program:`clang-format` is integrated into `CLion `_ as an alternative code formatter. It is disabled by default and
+can be turned on in Settings/Preferences | Editor | Code Style.
+
+If :program:`clang-format` support is enabled, CLion detects config files when
+opening a project and suggests overriding the current IDE settings. Code style
+rules from the ``.clang-format`` files are then applied automatically to all
+editor actions, including auto-completion, code generation, and refactorings.
+
+
 Visual Studio Integration
 =
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D60115: Adding 'CLion integration' to clang-format doc

2019-04-02 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina created this revision.
MarinaKalashina added reviewers: djasper, sylvestre.ledru, alexfh.
Herald added subscribers: cfe-commits, jdoerfert.
Herald added a project: clang.

This commit adds a chapter 'CLion integration' to ClangFormat.rst. 
The official announcement of clang-format support in CLion 2019.1: 
https://blog.jetbrains.com/clion/2019/03/clion-2019-1-embedded-dev-clangformat-memory-view/


Repository:
  rC Clang

https://reviews.llvm.org/D60115

Files:
  docs/ClangFormat.rst


Index: docs/ClangFormat.rst
===
--- docs/ClangFormat.rst
+++ docs/ClangFormat.rst
@@ -165,6 +165,19 @@
 shortcut in the BBEdit preferences, under Menus & Shortcuts.
 
 
+CLion Integration
+==
+
+:program:`clang-format` is integrated into CLion as an alternative code
+formatter. It is disabled by default and can be turned on in
+Settings/Preferences | Editor | Code Style.
+
+If :program:`clang-format` support is enabled, CLion detects config files when
+opening a project and suggests overriding the current IDE settings. Code style
+rules from the ``.clang-format`` files are then applied automatically to all
+editor actions, including auto-completion, code generation, and refactorings.
+
+
 Visual Studio Integration
 =
 


Index: docs/ClangFormat.rst
===
--- docs/ClangFormat.rst
+++ docs/ClangFormat.rst
@@ -165,6 +165,19 @@
 shortcut in the BBEdit preferences, under Menus & Shortcuts.
 
 
+CLion Integration
+==
+
+:program:`clang-format` is integrated into CLion as an alternative code
+formatter. It is disabled by default and can be turned on in
+Settings/Preferences | Editor | Code Style.
+
+If :program:`clang-format` support is enabled, CLion detects config files when
+opening a project and suggests overriding the current IDE settings. Code style
+rules from the ``.clang-format`` files are then applied automatically to all
+editor actions, including auto-completion, code generation, and refactorings.
+
+
 Visual Studio Integration
 =
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2019-01-17 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina added a comment.

@Eugene.Zelenko  @alexfh Thank you! How should I proceed with the revision now? 
Do I get it right from 
https://llvm.org/docs/Phabricator.html#committing-a-change, that without commit 
access, I need to ask for committing the changes for me?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2019-01-14 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina added a comment.

@Eugene.Zelenko

> I would suggest to rename contribution to Contributing (see LLVM 
> documentation) and integrations to Integrations.

Sure, done.

> Will be also good idea to fix D55523  script 
> warnings.

The script warns about double spaces and line width in the table, for example:

  warning: line 39 contains double spaces
  warning: line 39 is in excess of 80 characters (196)

These spaces and width are intended since they 'draw' the table layout. Do you 
think we could ignore such warnings in this particular case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2019-01-14 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina updated this revision to Diff 181528.
MarinaKalashina marked an inline comment as done.
MarinaKalashina added a comment.

files renamed: //contribution.rst// to //Contributing.rst//, // 
integrations.rst// to //Integrations.rst//


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/Contributing.rst
  docs/clang-tidy/Integrations.rst
  docs/clang-tidy/index.rst

Index: docs/clang-tidy/Integrations.rst
===
--- /dev/null
+++ docs/clang-tidy/Integrations.rst
@@ -0,0 +1,117 @@
+==
+Clang-tidy IDE/Editor Integrations
+==
+
+.. _Clangd: https://clang.llvm.org/extra/clangd.html
+
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into
+various IDEs, code analyzers, and editors. Besides, it is currently being
+integrated into Clangd_. The following table shows the most
+well-known :program:`clang-tidy` integrations in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
++--++-+--+-+--+
+|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|Flycheck for Emacs| \+\|   \-\   |   \-\| \+\ |   \+\   

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2019-01-11 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina updated this revision to Diff 181217.
MarinaKalashina added a comment.

restoring full content


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/contribution.rst
  docs/clang-tidy/index.rst
  docs/clang-tidy/integrations.rst

Index: docs/clang-tidy/integrations.rst
===
--- /dev/null
+++ docs/clang-tidy/integrations.rst
@@ -0,0 +1,117 @@
+==
+Clang-tidy IDE/Editor Integrations
+==
+
+.. _Clangd: https://clang.llvm.org/extra/clangd.html
+
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into
+various IDEs, code analyzers, and editors. Besides, it is currently being
+integrated into Clangd_. The following table shows the most
+well-known :program:`clang-tidy` integrations in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
++--++-+--+-+--+
+|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|Flycheck for Emacs| \+\|   \-\   |   \-\| \+\ |   \+\|

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2019-01-11 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina updated this revision to Diff 181216.
MarinaKalashina added a comment.

integrations.rst - end of file new line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/integrations.rst


Index: docs/clang-tidy/integrations.rst
===
--- docs/clang-tidy/integrations.rst
+++ docs/clang-tidy/integrations.rst
@@ -114,4 +114,4 @@
 solutions and run the :program:`clang-tidy` inspection on them. The
 CodeChecker_ application of version 5.3 or later, which also comes as a plugin_
 for Eclipse, supports :program:`clang-tidy` as a static analysis instrument and
-allows to use a custom :program:`clang-tidy` binary.
\ No newline at end of file
+allows to use a custom :program:`clang-tidy` binary.


Index: docs/clang-tidy/integrations.rst
===
--- docs/clang-tidy/integrations.rst
+++ docs/clang-tidy/integrations.rst
@@ -114,4 +114,4 @@
 solutions and run the :program:`clang-tidy` inspection on them. The
 CodeChecker_ application of version 5.3 or later, which also comes as a plugin_
 for Eclipse, supports :program:`clang-tidy` as a static analysis instrument and
-allows to use a custom :program:`clang-tidy` binary.
\ No newline at end of file
+allows to use a custom :program:`clang-tidy` binary.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2019-01-10 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina added a comment.

@alexfh Thank you, please see the updated structure.
@Eugene.Zelenko Done, the only warnings I got were about the table rows width.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2019-01-10 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina updated this revision to Diff 181018.
MarinaKalashina added a comment.

Extracting 'Getting Involved' and 'Clang-tidy integrations' to separate pages 
linked in See Also.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/contribution.rst
  docs/clang-tidy/index.rst
  docs/clang-tidy/integrations.rst

Index: docs/clang-tidy/integrations.rst
===
--- /dev/null
+++ docs/clang-tidy/integrations.rst
@@ -0,0 +1,117 @@
+==
+Clang-tidy IDE/Editor Integrations
+==
+
+.. _Clangd: https://clang.llvm.org/extra/clangd.html
+
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into
+various IDEs, code analyzers, and editors. Besides, it is currently being
+integrated into Clangd_. The following table shows the most
+well-known :program:`clang-tidy` integrations in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
++--++-+--+-+--+
+|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|Flycheck for Emacs| \+\|   \-\   |   \-\| \+\ |   \+\|

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2018-12-23 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina added a comment.

@alexfh Just for me to be sure, should there be the following structure in 
http://clang.llvm.org/extra/index.html:
Clang-Tidy

  The list of clang-tidy checks
  Using clang-tidy
  Suppressing Undesired Diagnostics
  Clang-tidy Integrated (separate page)
  Getting Involved (separate page)

And should the latter two pages be linked from 'Clang-Tidy' index.rs like 'The 
list of clang-tidy checks', which is placed in 'See also'?
Thank you.




Comment at: docs/clang-tidy/index.rst:262
+
+Clang-tidy integrated
+-

alexfh wrote:
> So how about moving this chapter to a separate page and adding a link to it 
> at the top of this document? While certainly useful, the information in this 
> section has a different focus from the rest of the documentation. Given that 
> the document has grown significantly, I suggest to split out this section and 
> the "Getting involved" section. (The latter can be done separately)
Just for me to be sure, should there be the following structure in 
http://clang.llvm.org/extra/index.html:
Clang-Tidy
  The list of clang-tidy checks
  Using clang-tidy
  Suppressing Undesired Diagnostics
  Clang-tidy Integrated (separate page)
  Getting Involved (separate page)
And should the latter two pages be linked from 'Clang-Tidy' index.rs like 'The 
list of clang-tidy checks', which is placed in 'See also'?
Thank you.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2018-12-18 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina added a comment.

@ilya-biryukov  Thank you for a quick response and sorry for so many 
iterations. I uploaded a full-context version; hopefully this time it's alright 
- on my side, it finally looks like a proper full-context diff.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2018-12-18 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina updated this revision to Diff 178647.
MarinaKalashina added a comment.

Full-context patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/index.rst

Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -21,6 +21,9 @@
 Using clang-tidy
 
 
+Standalone tool
+---
+
 :program:`clang-tidy` is a `LibTooling`_-based tool, and it's easier to work
 with if you set up a compile command database for your project (for an example
 of how to do this see `How To Setup Tooling For LLVM`_). You can also specify
@@ -255,6 +258,125 @@
   value:   'some value'
   ...
 
+
+Clang-tidy integrated
+-
+
+.. _Clangd: https://clang.llvm.org/extra/clangd.html
+
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into
+various IDEs, code analyzers, and editors. Besides, it is currently being
+integrated into Clangd_. The following table shows the most
+well-known :program:`clang-tidy` integrations in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
++--++-+--+-+--+
+|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|Flycheck for Emacs| \+\

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2018-12-18 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina updated this revision to Diff 178623.
MarinaKalashina set the repository for this revision to rCTE Clang Tools Extra.
MarinaKalashina added a comment.

Another attempt to update the patch with the following fixes:

- empty line before 'Standalone tool'
- table columns with '+/-' aligned
- line width limited to 80 (except for the table)
- clang-tidy-vs plugin added
- Clangd added to the intro, the table, and the CLion's paragraph


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/index.rst

Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -21,6 +21,9 @@
 Using clang-tidy
 
 
+Standalone tool
+---
+
 :program:`clang-tidy` is a `LibTooling`_-based tool, and it's easier to work
 with if you set up a compile command database for your project (for an example
 of how to do this see `How To Setup Tooling For LLVM`_). You can also specify
@@ -255,6 +258,125 @@
   value:   'some value'
   ...
 
+
+Clang-tidy integrated
+-
+
+.. _Clangd: https://clang.llvm.org/extra/clangd.html
+
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into
+various IDEs, code analyzers, and editors. Besides, it is currently being
+integrated into Clangd_. The following table shows the most
+well-known :program:`clang-tidy` integrations in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
++--++-+--+-+--+
+|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend | \-\|  

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2018-12-04 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina added a comment.

@alexfh Thanks a lot for your patience and help. I've made another revision, 
now with the diff made by 'git show HEAD -U99' to have the full context 
availlable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2018-12-04 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina updated this revision to Diff 176601.
MarinaKalashina added a comment.

Full-context patch for the changes introduced in the previous commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/index.rst


Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -403,7 +403,7 @@
 
 // Silent only the specified diagnostics for the next line
 // NOLINTNEXTLINE(google-explicit-constructor, google-runtime-int)
-Foo(bool param);
+Foo(bool param); 
   };
 
 The formal syntax of ``NOLINT``/``NOLINTNEXTLINE`` is the following:


Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -403,7 +403,7 @@
 
 // Silent only the specified diagnostics for the next line
 // NOLINTNEXTLINE(google-explicit-constructor, google-runtime-int)
-Foo(bool param);
+Foo(bool param); 
   };
 
 The formal syntax of ``NOLINT``/``NOLINTNEXTLINE`` is the following:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2018-12-04 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina marked 4 inline comments as done.
MarinaKalashina added a comment.

In D54945#1318278 , @alexfh wrote:

> In D54945#1316251 , @MarinaKalashina 
> wrote:
>
> > Fixes:
> >
> > - empty line before 'Standalone tool'
> > - table columns with '+/-' aligned
> > - line width limited to 80 (except for the table)
> >
> >   Additions:
> > - clang-tidy-vs plugin
> > - Clangd in the intro, the table, and CLion's paragraph
>
>
> Did you forget to add a new file to the patch?
>
> Please also include full context into the diff. See 
> https://llvm.org/docs/Phabricator.html


Sorry but the new diff was included to the patch.. I can see the updates as 
Diff 176328. Could you please check and let me know if it does not work? Thank 
you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2018-12-03 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina updated this revision to Diff 176328.
MarinaKalashina added a comment.

Fixes:

- empty line before 'Standalone tool'
- table columns with '+/-' aligned
- line width limited to 80 (except for the table)

Additions:

- clang-tidy-vs plugin
- Clangd in the intro, the table, and CLion's paragraph


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/index.rst

Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -21,9 +21,6 @@
 Using clang-tidy
 
 
-Standalone tool

-
 :program:`clang-tidy` is a `LibTooling`_-based tool, and it's easier to work
 with if you set up a compile command database for your project (for an example
 of how to do this see `How To Setup Tooling For LLVM`_). You can also specify
@@ -258,125 +255,6 @@
   value:   'some value'
   ...
 
-
-Clang-tidy integrated
--
-
-.. _Clangd: https://clang.llvm.org/extra/clangd.html
-
-Apart from being a standalone tool, :program:`clang-tidy` is integrated into
-various IDEs, code analyzers, and editors. Besides, it is currently being
-integrated into Clangd_. The following table shows the most
-well-known :program:`clang-tidy` integrations in detail.
-
-+--++-+--+-+--+
-|  |Feature   |
-+==++=+==+=+==+
-|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
-+--++-+--+-+--+
-|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
-+--++-+--+-+--+
-|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
-+--++-+--+-+--+
-|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
-+--++-+--+-+--+
-|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
-+--++-+--+-+--+
-|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
-+--++-+--+-+--+
-|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
-+--++-+--+-+--+
-|CPPDepend | \-\|   \-\   |   \-\| \-\ |   \-\|

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

2018-11-27 Thread Marina Kalashina via Phabricator via cfe-commits
MarinaKalashina created this revision.
MarinaKalashina added a reviewer: asl.
Herald added subscribers: cfe-commits, arphaman.

Proposing changes to //clang-tools-extra/docs/clang-tidy/index.rst//

'Using clang-tidy' was split into 2 chapters:

- 'Standalone tool' (the previous content of 'Using clang-tidy')
- 'Clang-tidy integrated' (a new chapter)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/index.rst

Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -20,6 +20,8 @@
 
 Using clang-tidy
 
+Standalone tool
+---
 
 :program:`clang-tidy` is a `LibTooling`_-based tool, and it's easier to work
 with if you set up a compile command database for your project (for an example
@@ -255,6 +257,105 @@
   value:   'some value'
   ...
 
+
+Clang-tidy integrated
+-
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into various IDEs,
+code analyzers, and editors. The following table shows the most well-known :program:`clang-tidy` integrations
+in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   |  \-\   |\+\  |   \-\| \+\ |\-\   |
++--++-+--+-+--+
+|CLion IDE | \+\|\+\  |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   |  \-\   |   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  |  \-\   |   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend |  \-\   |   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|Flycheck for Emacs|  \+\   |   \-\   |   \-\| \+\ |   \+\|
++--++-+--+-+--+
+|KDevelop IDE  |