[PATCH] D26082: Support for Python 3 in libclang python bindings
MathieuDuponchelle added a comment. In https://reviews.llvm.org/D26082#645361, @jbcoe wrote: > I've reverted this change and submitted https://reviews.llvm.org/D28682 to > explicitly check the Python version. > > I'll pick this up again, I do want Python 3 support. I'm not entirely sure why you reverted the patch altogether, apart from the problem I raised it worked flawlessly, and in any case did not create any problems when the bindings were used from python 2. Repository: rL LLVM https://reviews.llvm.org/D26082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D26082: Support for Python 3 in libclang python bindings
MathieuDuponchelle added a comment. In https://reviews.llvm.org/D26082#644402, @jbcoe wrote: > @MathieuDuponchelle I've set up a docker image with Fedora 23 and reproduced > the errors as you reported. > > I've no immediate idea what the problem might be. Might be worth looking with > address-sanitizer. Hey, good to know! Two questions: - Did you try running the test with valgrind on OSX? - Doesn't the fact that commenting out this line: https://github.com/llvm-mirror/clang/blob/master/bindings/python/clang/cindex.py#L181 "solve" the problem give you a good starting point? Repository: rL LLVM https://reviews.llvm.org/D26082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D26082: Support for Python 3 in libclang python bindings
MathieuDuponchelle added a comment. In https://reviews.llvm.org/D26082#621496, @jbcoe wrote: > Hi Mathieu, > What platform did you run the tests on? How did you run them? I don't get > any failures when running tests on macOS 10.12.1. Hey @jbcoe, do you think you can have a look at this issue? Please see my earlier comment for a way to reproduce this (`LD_LIBRARY_PATH=/home/meh/devel/sandbox/llvm/build/lib valgrind python3 -m nose tests.cindex.test_cursor:test_get_template_argument_value` is a valid way to reproduce this issue) Repository: rL LLVM https://reviews.llvm.org/D26082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D26082: Support for Python 3 in libclang python bindings
MathieuDuponchelle added a comment. Hey, I'm on Linux, Fedora 23 to be specific. Repository: rL LLVM https://reviews.llvm.org/D26082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D26082: Support for Python 3 in libclang python bindings
MathieuDuponchelle added a comment. Hey, for what it's worth when skipping the free at this line: https://github.com/llvm-mirror/clang/blob/master/bindings/python/clang/cindex.py#L181 the issues are gone, I haven't investigated the reason why. Repository: rL LLVM https://reviews.llvm.org/D26082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
