[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added
pbarrio accepted this revision. pbarrio added a comment. This revision is now accepted and ready to land. LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added
pbarrio requested changes to this revision.
pbarrio added a comment.
This revision now requires changes to proceed.
Suggest clarifying the commit message to something like:
"Added warning for potential cases of unaligned access when option
-mno-unaligned-access has been specified".
Nice testing :)
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:463-464
options::OPT_munaligned_access)) {
if (A->getOption().matches(options::OPT_mno_unaligned_access))
+{
Features.push_back("+strict-align");
Nit: preserve coding style of the file. Move the bracket to the previous line,
preceded by a space. I.e.
if (A->getOption().matches(options::OPT_mno_unaligned_access)) {
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116221/new/
https://reviews.llvm.org/D116221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins
pbarrio added a comment. Hi, CMSE upstreaming is indeed one of our priorities. So yes, we are very interested in your feedback. And no, CMSE upstreaming is not abandoned, just going a bit slow ATM :( but any help reviewing is much appreciated! :) @chill would it make sense to start upstream other self-contained pieces of codegen before this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62394/new/ https://reviews.llvm.org/D62394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D57060: [NFC][Clang] Add driver tests for sb and predres
pbarrio accepted this revision. pbarrio added a comment. This revision is now accepted and ready to land. Same idea as https://reviews.llvm.org/D54961 but for two other command line options. Approved! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57060/new/ https://reviews.llvm.org/D57060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D54961: [AArch64] Add command-line option for SSBS
pbarrio created this revision. pbarrio added reviewers: olista01, samparker, aemerson. Herald added subscribers: kristof.beyls, javed.absar. SSBS (Speculative Store Bypass Safe) is only mandatory from 8.5 onwards but is optional from Armv8.0-A. This patch adds testing for the ssbs command line option, added to allow enabling the feature in previous Armv8-A architectures to 8.5. Repository: rC Clang https://reviews.llvm.org/D54961 Files: test/Driver/aarch64-ssbs.c Index: test/Driver/aarch64-ssbs.c === --- /dev/null +++ test/Driver/aarch64-ssbs.c @@ -0,0 +1,9 @@ +// RUN: %clang -### -target aarch64-none-none-eabi -march=armv8a+ssbs %s 2>&1 | FileCheck %s +// CHECK: "-target-feature" "+ssbs" + +// RUN: %clang -### -target aarch64-none-none-eabi -march=armv8a+nossbs %s 2>&1 | FileCheck %s --check-prefix=NOSSBS +// NOSSBS: "-target-feature" "-ssbs" + +// RUN: %clang -### -target aarch64-none-none-eabi %s 2>&1 | FileCheck %s --check-prefix=ABSENTSSBS +// ABSENTSSBS-NOT: "-target-feature" "+ssbs" +// ABSENTSSBS-NOT: "-target-feature" "-ssbs" Index: test/Driver/aarch64-ssbs.c === --- /dev/null +++ test/Driver/aarch64-ssbs.c @@ -0,0 +1,9 @@ +// RUN: %clang -### -target aarch64-none-none-eabi -march=armv8a+ssbs %s 2>&1 | FileCheck %s +// CHECK: "-target-feature" "+ssbs" + +// RUN: %clang -### -target aarch64-none-none-eabi -march=armv8a+nossbs %s 2>&1 | FileCheck %s --check-prefix=NOSSBS +// NOSSBS: "-target-feature" "-ssbs" + +// RUN: %clang -### -target aarch64-none-none-eabi %s 2>&1 | FileCheck %s --check-prefix=ABSENTSSBS +// ABSENTSSBS-NOT: "-target-feature" "+ssbs" +// ABSENTSSBS-NOT: "-target-feature" "-ssbs" ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
