[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali added a comment. Name : Rishabh Bali Github Username : Ris-Bali email-id : rishabhsb...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali added a comment. I have made the requested changes. Please do let me know if other changes are required. Also I would like to thank everyone for their help and guidance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 519628.
Ris-Bali added a comment.
Rebase
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang/docs/ReleaseNotes.rst
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/builtin-assume-aligned.c
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,25 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible
integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
+int val(int x) {
+ return x;
+}
+
+int test16(int *b) {
+ b = (int *)__builtin_assume_aligned(val, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); //
no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -8100,8 +8100,9 @@
{
ExprResult FirstArgResult =
DefaultFunctionArrayLvalueConversion(FirstArg);
-if (FirstArgResult.isInvalid())
+if (checkBuiltinArgument(*this, TheCall, 0))
return true;
+/// In-place updation of FirstArg by checkBuiltinArgument is ignored.
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/lib/CodeGen/CGBuiltin.cpp
===
--- clang/lib/CodeGen/CGBuiltin.cpp
+++ clang/lib/CodeGen/CGBuiltin.cpp
@@ -2829,8 +2829,6 @@
case Builtin::BI__builtin_assume_aligned: {
const Expr *Ptr = E->getArg(0);
Value *PtrValue = EmitScalarExpr(Ptr);
-if (PtrValue->getType() != VoidPtrTy)
- PtrValue = EmitCastToVoidPtr(PtrValue);
Value *OffsetValue =
(E->getNumArgs() > 2) ? EmitScalarExpr(E->getArg(2)) : nullptr;
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -361,6 +361,9 @@
(`#62207 `_)
- Fix lambdas and other anonymous function names not respecting
``-fdebug-prefix-map``
(`#62192 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `_)
Bug Fixes to Compiler Builtins
^^
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,25 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
+int val(int x) {
+ return x;
+}
+
+int test16(int *b) {
+ b = (int *)__builtin_assume_aligned(val, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); // no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -8100,8 +8100,9 @@
{
ExprResult FirstArgResult =
DefaultFunctionArrayLvalueConversion(FirstArg);
-if (FirstArgResult.isInvalid())
+if (checkBuiltinArgument(*this, TheCall, 0))
return true;
+/// In-place updation of FirstArg by checkBuiltinArgument is ignored.
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/lib/CodeGen/CGBuiltin.cpp
===
--- clang/lib/CodeGen/CGBuiltin.cpp
+++ clang/lib/CodeGen/CGBuiltin.cpp
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 519544.
Ris-Bali marked 5 inline comments as done.
Ris-Bali added a comment.
Requested Changes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang/docs/ReleaseNotes.rst
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/builtin-assume-aligned.c
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,26 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible
integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
+int val(int x) {
+ return x;
+}
+
+int test16(int *b) {
+ b = (int*)__builtin_assume_aligned(val, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); //
no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7979,8 +7979,9 @@
{
ExprResult FirstArgResult =
DefaultFunctionArrayLvalueConversion(FirstArg);
-if (FirstArgResult.isInvalid())
+if (checkBuiltinArgument(*this, TheCall, 0))
return true;
+/// In-place updation of FirstArg by checkBuiltinArgument is ignored.
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/lib/CodeGen/CGBuiltin.cpp
===
--- clang/lib/CodeGen/CGBuiltin.cpp
+++ clang/lib/CodeGen/CGBuiltin.cpp
@@ -2829,8 +2829,6 @@
case Builtin::BI__builtin_assume_aligned: {
const Expr *Ptr = E->getArg(0);
Value *PtrValue = EmitScalarExpr(Ptr);
-if (PtrValue->getType() != VoidPtrTy)
- PtrValue = EmitCastToVoidPtr(PtrValue);
Value *OffsetValue =
(E->getNumArgs() > 2) ? EmitScalarExpr(E->getArg(2)) : nullptr;
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `_)
Bug Fixes to Compiler Builtins
^^
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,26 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
+int val(int x) {
+ return x;
+}
+
+int test16(int *b) {
+ b = (int*)__builtin_assume_aligned(val, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); // no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7979,8 +7979,9 @@
{
ExprResult FirstArgResult =
DefaultFunctionArrayLvalueConversion(FirstArg);
-if (FirstArgResult.isInvalid())
+if (checkBuiltinArgument(*this, TheCall, 0))
return true;
+/// In-place updation of FirstArg by checkBuiltinArgument is ignored.
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/lib/CodeGen/CGBuiltin.cpp
===
---
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 518543.
Ris-Bali added a comment.
Added test for function type
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/builtin-assume-aligned.c
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,26 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible
integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
+int val(int x) {
+ return x;
+}
+
+int test16(int *b) {
+ b = (int*)__builtin_assume_aligned(val, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); //
no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7979,8 +7979,9 @@
{
ExprResult FirstArgResult =
DefaultFunctionArrayLvalueConversion(FirstArg);
-if (FirstArgResult.isInvalid())
+if (checkBuiltinArgument(*this, TheCall, 0))
return true;
+/// In-place updation of FirstArg by checkBuiltinArgument is ignored.
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `_)
Bug Fixes to Compiler Builtins
^^
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,26 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
+int val(int x) {
+ return x;
+}
+
+int test16(int *b) {
+ b = (int*)__builtin_assume_aligned(val, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); // no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7979,8 +7979,9 @@
{
ExprResult FirstArgResult =
DefaultFunctionArrayLvalueConversion(FirstArg);
-if (FirstArgResult.isInvalid())
+if (checkBuiltinArgument(*this, TheCall, 0))
return true;
+/// In-place updation of FirstArg by checkBuiltinArgument is ignored.
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `_)
Bug Fixes to Compiler Builtins
^^
___
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali marked an inline comment as done. Ris-Bali added a comment. I have made the requested changes. Please do let me know if any other changes are required CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 518425.
Ris-Bali marked 2 inline comments as done.
Ris-Bali added a comment.
Removed redundant code
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/builtin-assume-aligned.c
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,17 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible
integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); //
no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7979,7 +7979,8 @@
{
ExprResult FirstArgResult =
DefaultFunctionArrayLvalueConversion(FirstArg);
-if (FirstArgResult.isInvalid())
+/// Type-check first argument normally.
+if (checkBuiltinArgument(*this, TheCall, 0))
return true;
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `)
Bug Fixes to Compiler Builtins
^^
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,17 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); // no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7979,7 +7979,8 @@
{
ExprResult FirstArgResult =
DefaultFunctionArrayLvalueConversion(FirstArg);
-if (FirstArgResult.isInvalid())
+/// Type-check first argument normally.
+if (checkBuiltinArgument(*this, TheCall, 0))
return true;
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `)
Bug Fixes to Compiler Builtins
^^
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 518348.
Ris-Bali added a comment.
Removed redundant code.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/builtin-assume-aligned.c
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,17 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible
integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); //
no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,9 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+
+if (checkBuiltinArgument(*this, TheCall, 0))
+ return true;
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `)
Bug Fixes to Compiler Builtins
^^
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,17 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); // no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,9 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+
+if (checkBuiltinArgument(*this, TheCall, 0))
+ return true;
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `)
Bug Fixes to Compiler Builtins
^^
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 518300.
Ris-Bali marked 4 inline comments as done.
Ris-Bali added a comment.
Array test added
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/builtin-assume-aligned.c
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,17 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible
integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); //
no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,15 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+QualType FirstArgType = FirstArgResult.get()->getType();
+
+if (checkBuiltinArgument(*this, TheCall, 0)) {
+ const QualType =
+ Context.getPointerType(Context.VoidTy.withConst());
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << FirstArgType << ConstVoidPointerType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `)
Bug Fixes to Compiler Builtins
^^
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,17 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int *b) {
+ int arr[3] = {1, 2, 3};
+ b = (int *)__builtin_assume_aligned(arr, 32);
+ return b[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); // no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,15 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+QualType FirstArgType = FirstArgResult.get()->getType();
+
+if (checkBuiltinArgument(*this, TheCall, 0)) {
+ const QualType =
+ Context.getPointerType(Context.VoidTy.withConst());
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << FirstArgType << ConstVoidPointerType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 518293.
Ris-Bali added a comment.
Requested changes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/builtin-assume-aligned.c
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,16 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible
integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int a[5]) {
+ a = (int *)__builtin_assume_aligned(a, 32);
+ return a[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); //
no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,15 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+QualType FirstArgType = FirstArgResult.get()->getType();
+
+if (checkBuiltinArgument(*this, TheCall, 0)) {
+ const QualType =
+ Context.getPointerType(Context.VoidTy.withConst());
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << FirstArgType << ConstVoidPointerType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `)
Bug Fixes to Compiler Builtins
^^
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,16 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *}}
+ return a[0];
+}
+
+int test15(int a[5]) {
+ a = (int *)__builtin_assume_aligned(a, 32);
+ return a[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); // no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,15 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+QualType FirstArgType = FirstArgResult.get()->getType();
+
+if (checkBuiltinArgument(*this, TheCall, 0)) {
+ const QualType =
+ Context.getPointerType(Context.VoidTy.withConst());
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << FirstArgType << ConstVoidPointerType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 518274.
Ris-Bali added a comment.
Herald added subscribers: carlosgalvezp, kbarton, nemanjai.
Herald added a project: clang-tools-extra.
Removed __builtin_assume_aligned from ignoredbuiltinstest() in
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-vararg.cpp.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-vararg.cpp
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/builtin-assume-aligned.c
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,11 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{passing
'int' to parameter of incompatible type 'int *'}}
+ return a[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); //
no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,14 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+QualType firstArgType = FirstArgResult.get()->getType();
+
+if (!firstArgType->isAnyPointerType()) {
+ QualType expectedType = Context.getPointerType(firstArgType);
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << firstArgType << expectedType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `)
Bug Fixes to Compiler Builtins
^^
Index:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-vararg.cpp
===
---
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-vararg.cpp
+++
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-vararg.cpp
@@ -52,7 +52,6 @@
int my_vprintf(const char* format, va_list arg ); // OK to declare function
taking va_list
void ignoredBuiltinsTest() {
- (void)__builtin_assume_aligned(0, 8);
(void)__builtin_constant_p(0);
(void)__builtin_fpclassify(0, 0, 0, 0, 0, 0.f);
(void)__builtin_isinf_sign(0.f);
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,11 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{passing 'int' to parameter of incompatible type 'int *'}}
+ return a[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); // no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,14 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+QualType firstArgType = FirstArgResult.get()->getType();
+
+if (!firstArgType->isAnyPointerType()) {
+ QualType expectedType = Context.getPointerType(firstArgType);
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << firstArgType << expectedType << 1 << 0 << 0;
+
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 518228.
Ris-Bali added a comment.
Added test and made changes in ReleaseNotes.rst
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/builtin-assume-aligned.c
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,11 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{passing
'int' to parameter of incompatible type 'int *'}}
+ return a[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); //
expected-warning {{'assume_aligned' attribute only applies to return values
that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); //
no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,14 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+QualType firstArgType = FirstArgResult.get()->getType();
+
+if (!firstArgType->isAnyPointerType()) {
+ QualType expectedType = Context.getPointerType(firstArgType);
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << firstArgType << expectedType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `)
Bug Fixes to Compiler Builtins
^^
Index: clang/test/Sema/builtin-assume-aligned.c
===
--- clang/test/Sema/builtin-assume-aligned.c
+++ clang/test/Sema/builtin-assume-aligned.c
@@ -71,6 +71,11 @@
return a[0];
}
+int test14(int *a, int b) {
+ a = (int *)__builtin_assume_aligned(b, 32); // expected-error {{passing 'int' to parameter of incompatible type 'int *'}}
+ return a[0];
+}
+
void test_void_assume_aligned(void) __attribute__((assume_aligned(32))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
int test_int_assume_aligned(void) __attribute__((assume_aligned(16))); // expected-warning {{'assume_aligned' attribute only applies to return values that are pointers}}
void *test_ptr_assume_aligned(void) __attribute__((assume_aligned(64))); // no-warning
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,14 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+QualType firstArgType = FirstArgResult.get()->getType();
+
+if (!firstArgType->isAnyPointerType()) {
+ QualType expectedType = Context.getPointerType(firstArgType);
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << firstArgType << expectedType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -338,6 +338,9 @@
- Fix crash when attempting to perform parenthesized initialization of an
aggregate with a base class with only non-public constructors.
(`#62296 `_)
+- Fix crash when attempting to pass a non-pointer type as first argument of
+ ``__builtin_assume_aligned``.
+ (`#62305 `)
Bug Fixes to Compiler Builtins
^^
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 518156.
Ris-Bali added a comment.
QualType error fix
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang/lib/Sema/SemaChecking.cpp
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,14 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+QualType firstArgType = FirstArgResult.get()->getType();
+
+if (!firstArgType->isAnyPointerType()) {
+ QualType expectedType = Context.getPointerType(firstArgType);
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << firstArgType << expectedType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,14 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+QualType firstArgType = FirstArgResult.get()->getType();
+
+if (!firstArgType->isAnyPointerType()) {
+ QualType expectedType = Context.getPointerType(firstArgType);
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << firstArgType << expectedType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali updated this revision to Diff 518153.
Ris-Bali added a comment.
Clang-format fix
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149514/new/
https://reviews.llvm.org/D149514
Files:
clang/lib/Sema/SemaChecking.cpp
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,14 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+Qualtype firstArgType = FirstArgResult.get()->getType();
+
+if (!firstArgType->isAnyPointerType()) {
+ Qualtype expectedType = Context.getPointerType(firstArgType);
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << firstArgType << expectedType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,14 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+Qualtype firstArgType = FirstArgResult.get()->getType();
+
+if (!firstArgType->isAnyPointerType()) {
+ Qualtype expectedType = Context.getPointerType(firstArgType);
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << firstArgType << expectedType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type
Ris-Bali created this revision.
Ris-Bali added a reviewer: tbaeder.
Ris-Bali added a project: clang.
Herald added a project: All.
Ris-Bali requested review of this revision.
Herald added a subscriber: cfe-commits.
Currently clang doesn't verify if the first argument in
_builtin_assume_aligned_ is of pointer type. This leads to an assertion build
failure. This patch aims to add a check if the first argument is of pointer
type or not and diagnose it with `diag::err_typecheck_convert_incompatible` if
its not of pointer type.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D149514
Files:
clang/lib/Sema/SemaChecking.cpp
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,14 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+Qualtype firstArgType = FirstArgResult.get()->getType();
+
+if (!firstArgType->isAnyPointerType()) {
+ Qualtype expectedType = Context.getPointerType(firstArgType);
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << firstArgType << expectedType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -7981,6 +7981,14 @@
DefaultFunctionArrayLvalueConversion(FirstArg);
if (FirstArgResult.isInvalid())
return true;
+Qualtype firstArgType = FirstArgResult.get()->getType();
+
+if (!firstArgType->isAnyPointerType()) {
+ Qualtype expectedType = Context.getPointerType(firstArgType);
+ return Diag(FirstArg->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << firstArgType << expectedType << 1 << 0 << 0;
+}
TheCall->setArg(0, FirstArgResult.get());
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
