[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

[Rui Zhang via Phabricator via cfe-commits]

rui.zhang added subscribers: mcberg2021, craig.topper.
rui.zhang added a comment.

In D122573#3872138 , @fhahn wrote:

> Rebased on current main
>
> In D122573#3630767 , @rui.zhang 
> wrote:
>
>> I like the direction where this change is leading to and hope there is some 
>> way to land it incrementally. Since BuiltinType has the above mentioned 
>> concern on `void *`, how about we focus on `RecordType` pointers as a first 
>> step instead? Are there any pitfalls if we distinguish `RecordType` pointers 
>> by depth?
>
> An initial restriction like that sounds reasonable to me. @jcranmer-intel 
> @efriedma @rjmccall WDYT?
>
> I also updated the type sanitizer patches and posted 
> https://discourse.llvm.org/t/reviving-typesanitizer-a-sanitizer-to-catch-type-based-aliasing-violations/66092
>  to discuss ways to move forward with the sanitizer.

@craig.topper @mcberg2021 FYI


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122573/new/

https://reviews.llvm.org/D122573

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D134077: [RISCV] Support -mno-implicit-float.

[Rui Zhang via Phabricator via cfe-commits]

rui.zhang accepted this revision.
rui.zhang added a comment.
This revision is now accepted and ready to land.

Thanks for fixing it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134077/new/

https://reviews.llvm.org/D134077

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

[Rui Zhang via Phabricator via cfe-commits]

rui.zhang added a comment.

I like the direction where this change is leading to and hope there is some way 
to land it incrementally. Since BuiltinType has the above mentioned concern on 
`void *`, how about we focus on `RecordType` pointers as a first step instead? 
Are there any pitfalls if we distinguish `RecordType` pointers by depth?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122573/new/

https://reviews.llvm.org/D122573

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

[Rui Zhang via Phabricator via cfe-commits]

rui.zhang added a comment.

> Well, if you can find a solution to the `void*` <-> `T**` problem, that might 
> make it tractable.  Or you can introduce a flag to control whether we do this 
> — I guess on some level `-fstrict-aliasing` ought to be the full language 
> model, so this would mean introducing a `-fless-strict-aliasing` or something 
> like it.

Is it helpful if we only track pointers to user defined types so that `void *` 
or `char *` is not in the picture?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122573/new/

https://reviews.llvm.org/D122573

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits