[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

[Vitaly Buka via Phabricator via cfe-commits]

vitalybuka added a comment.

In D101832#2820465 , @MaskRay wrote:

> In D101832#2736636 , @MaskRay wrote:
>
>> I think @vitalybuka has concrete suggestion on the naming.
>
> If ignorelist is used, I can delete `-fsanitize-coverage-blocklist=`

lgtm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101832/new/

https://reviews.llvm.org/D101832

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.
Herald added a subscriber: ormris.

In D101832#2736636 , @MaskRay wrote:

> I think @vitalybuka has concrete suggestion on the naming.

If ignorelist is used, I can delete `-fsanitize-coverage-blocklist=`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101832/new/

https://reviews.llvm.org/D101832

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added subscribers: vitalybuka, MaskRay.
MaskRay added a comment.

I think @vitalybuka has concrete suggestion on the naming.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101832/new/

https://reviews.llvm.org/D101832

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101832/new/

https://reviews.llvm.org/D101832

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

[Hans Wennborg via Phabricator via cfe-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm




Comment at: clang/include/clang/Driver/Options.td:1524
+  Alias,
+  HelpText<"Deprecated, use -fsanitize-coverage-ignorelist= instead">;
 def fsanitize_memory_track_origins_EQ : Joined<["-"], 
"fsanitize-memory-track-origins=">,

Should the aliases above also have "Deprecated' in their help texts?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101832/new/

https://reviews.llvm.org/D101832

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits