Re: [PATCH] D10356: scan-build: Add --analyzer-target option

2015-08-12 Thread Honggyu Kim via cfe-commits
honggyu.kim accepted this revision.
honggyu.kim added a reviewer: honggyu.kim.
honggyu.kim added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D10356#219772, @krememek wrote:

 Committed r244400


Thanks for accepting it!


http://reviews.llvm.org/D10356



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


Re: [PATCH] D10356: scan-build: Add --analyzer-target option

2015-08-07 Thread Honggyu Kim via cfe-commits
honggyu.kim added a comment.

In http://reviews.llvm.org/D10356#219499, @krememek wrote:

 I see.  The problem is that the ad hoc interposition that scan-build uses 
 does not handle the case that the underlying compiler is built as a 
 cross-compiler, but does not take a direct target triple.  That compiler only 
 builds for the other target, unlike clang which is a cross-compiler.


That's exactly what I was going to explain.  I hope that scan-build can 
automatically extract the target triple information from the given compiler, 
but there's no way to do it as of yet.  That's the reason I made this option to 
explicitly set the target triple info for analysis.

 In that case, I am fine with taking this change.  That you for explaining it.


Thanks for the review and comments. If you want to change the option name, 
--analyzer-target, I'm okay to change it. And I would also like to hear some 
feedback about the description for the option as well.
So please let me know if you have any other idea on that. I appreciate your 
help.


http://reviews.llvm.org/D10356



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits