[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

2021-10-12 Thread Arthur Eubanks via Phabricator via cfe-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb6a8c695542b: [NFC] Rename EmitAssemblyHelper new/legacy PM 
methods (authored by aeubanks).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111680/new/

https://reviews.llvm.org/D111680

Files:
  clang/lib/CodeGen/BackendUtil.cpp


Index: clang/lib/CodeGen/BackendUtil.cpp
===
--- clang/lib/CodeGen/BackendUtil.cpp
+++ clang/lib/CodeGen/BackendUtil.cpp
@@ -172,11 +172,16 @@
 
   std::unique_ptr TM;
 
+  // Emit output using the legacy pass manager for the optimization pipeline.
+  // This will be removed soon when using the legacy pass manager for the
+  // optimization pipeline is no longer supported.
+  void EmitAssemblyWithLegacyPassManager(BackendAction Action,
+ std::unique_ptr 
OS);
+
+  // Emit output using the new pass manager for the optimization pipeline. This
+  // is the default.
   void EmitAssembly(BackendAction Action,
 std::unique_ptr OS);
-
-  void EmitAssemblyWithNewPassManager(BackendAction Action,
-  std::unique_ptr OS);
 };
 
 // We need this wrapper to access LangOpts and CGOpts from extension functions
@@ -966,8 +971,8 @@
   return true;
 }
 
-void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
-  std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssemblyWithLegacyPassManager(
+BackendAction Action, std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
 
   setCommandLineOpts(CodeGenOpts);
@@ -1509,8 +1514,8 @@
 ///
 /// This API is planned to have its functionality finished and then to replace
 /// `EmitAssembly` at some point in the future when the default switches.
-void EmitAssemblyHelper::EmitAssemblyWithNewPassManager(
-BackendAction Action, std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
+  std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
   setCommandLineOpts(CodeGenOpts);
 
@@ -1686,8 +1691,8 @@
 
   EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M);
 
-  if (!CGOpts.LegacyPassManager)
-AsmHelper.EmitAssemblyWithNewPassManager(Action, std::move(OS));
+  if (CGOpts.LegacyPassManager)
+AsmHelper.EmitAssemblyWithLegacyPassManager(Action, std::move(OS));
   else
 AsmHelper.EmitAssembly(Action, std::move(OS));
 


Index: clang/lib/CodeGen/BackendUtil.cpp
===
--- clang/lib/CodeGen/BackendUtil.cpp
+++ clang/lib/CodeGen/BackendUtil.cpp
@@ -172,11 +172,16 @@
 
   std::unique_ptr TM;
 
+  // Emit output using the legacy pass manager for the optimization pipeline.
+  // This will be removed soon when using the legacy pass manager for the
+  // optimization pipeline is no longer supported.
+  void EmitAssemblyWithLegacyPassManager(BackendAction Action,
+ std::unique_ptr OS);
+
+  // Emit output using the new pass manager for the optimization pipeline. This
+  // is the default.
   void EmitAssembly(BackendAction Action,
 std::unique_ptr OS);
-
-  void EmitAssemblyWithNewPassManager(BackendAction Action,
-  std::unique_ptr OS);
 };
 
 // We need this wrapper to access LangOpts and CGOpts from extension functions
@@ -966,8 +971,8 @@
   return true;
 }
 
-void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
-  std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssemblyWithLegacyPassManager(
+BackendAction Action, std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
 
   setCommandLineOpts(CodeGenOpts);
@@ -1509,8 +1514,8 @@
 ///
 /// This API is planned to have its functionality finished and then to replace
 /// `EmitAssembly` at some point in the future when the default switches.
-void EmitAssemblyHelper::EmitAssemblyWithNewPassManager(
-BackendAction Action, std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
+  std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
   setCommandLineOpts(CodeGenOpts);
 
@@ -1686,8 +1691,8 @@
 
   EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M);
 
-  if (!CGOpts.LegacyPassManager)
-AsmHelper.EmitAssemblyWithNewPassManager(Action, std::move(OS));
+  if (CGOpts.LegacyPassManager)
+AsmHelper.EmitAssemblyWithLegacyPassManager(Action, std::move(OS));
   else
 AsmHelper.EmitAssembly(Action, std::move(OS));
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

2021-10-12 Thread Arthur Eubanks via Phabricator via cfe-commits 
aeubanks updated this revision to Diff 379208.
aeubanks added a comment.

add comment
I'd rather switch everything to lowerCamel at once rather than just a few 
methods


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111680/new/

https://reviews.llvm.org/D111680

Files:
  clang/lib/CodeGen/BackendUtil.cpp


Index: clang/lib/CodeGen/BackendUtil.cpp
===
--- clang/lib/CodeGen/BackendUtil.cpp
+++ clang/lib/CodeGen/BackendUtil.cpp
@@ -172,11 +172,16 @@
 
   std::unique_ptr TM;
 
+  // Emit output using the legacy pass manager for the optimization pipeline.
+  // This will be removed soon when using the legacy pass manager for the
+  // optimization pipeline is no longer supported.
+  void EmitAssemblyWithLegacyPassManager(BackendAction Action,
+ std::unique_ptr 
OS);
+
+  // Emit output using the new pass manager for the optimization pipeline. This
+  // is the default.
   void EmitAssembly(BackendAction Action,
 std::unique_ptr OS);
-
-  void EmitAssemblyWithNewPassManager(BackendAction Action,
-  std::unique_ptr OS);
 };
 
 // We need this wrapper to access LangOpts and CGOpts from extension functions
@@ -966,8 +971,8 @@
   return true;
 }
 
-void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
-  std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssemblyWithLegacyPassManager(
+BackendAction Action, std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
 
   setCommandLineOpts(CodeGenOpts);
@@ -1509,8 +1514,8 @@
 ///
 /// This API is planned to have its functionality finished and then to replace
 /// `EmitAssembly` at some point in the future when the default switches.
-void EmitAssemblyHelper::EmitAssemblyWithNewPassManager(
-BackendAction Action, std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
+  std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
   setCommandLineOpts(CodeGenOpts);
 
@@ -1686,8 +1691,8 @@
 
   EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M);
 
-  if (!CGOpts.LegacyPassManager)
-AsmHelper.EmitAssemblyWithNewPassManager(Action, std::move(OS));
+  if (CGOpts.LegacyPassManager)
+AsmHelper.EmitAssemblyWithLegacyPassManager(Action, std::move(OS));
   else
 AsmHelper.EmitAssembly(Action, std::move(OS));
 


Index: clang/lib/CodeGen/BackendUtil.cpp
===
--- clang/lib/CodeGen/BackendUtil.cpp
+++ clang/lib/CodeGen/BackendUtil.cpp
@@ -172,11 +172,16 @@
 
   std::unique_ptr TM;
 
+  // Emit output using the legacy pass manager for the optimization pipeline.
+  // This will be removed soon when using the legacy pass manager for the
+  // optimization pipeline is no longer supported.
+  void EmitAssemblyWithLegacyPassManager(BackendAction Action,
+ std::unique_ptr OS);
+
+  // Emit output using the new pass manager for the optimization pipeline. This
+  // is the default.
   void EmitAssembly(BackendAction Action,
 std::unique_ptr OS);
-
-  void EmitAssemblyWithNewPassManager(BackendAction Action,
-  std::unique_ptr OS);
 };
 
 // We need this wrapper to access LangOpts and CGOpts from extension functions
@@ -966,8 +971,8 @@
   return true;
 }
 
-void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
-  std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssemblyWithLegacyPassManager(
+BackendAction Action, std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
 
   setCommandLineOpts(CodeGenOpts);
@@ -1509,8 +1514,8 @@
 ///
 /// This API is planned to have its functionality finished and then to replace
 /// `EmitAssembly` at some point in the future when the default switches.
-void EmitAssemblyHelper::EmitAssemblyWithNewPassManager(
-BackendAction Action, std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
+  std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
   setCommandLineOpts(CodeGenOpts);
 
@@ -1686,8 +1691,8 @@
 
   EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M);
 
-  if (!CGOpts.LegacyPassManager)
-AsmHelper.EmitAssemblyWithNewPassManager(Action, std::move(OS));
+  if (CGOpts.LegacyPassManager)
+AsmHelper.EmitAssemblyWithLegacyPassManager(Action, std::move(OS));
   else
 AsmHelper.EmitAssembly(Action, std::move(OS));
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

2021-10-12 Thread Fangrui Song via Phabricator via cfe-commits 
MaskRay added inline comments.



Comment at: clang/lib/CodeGen/BackendUtil.cpp:175
 
+  void EmitAssemblyWithLegacyPassManager(BackendAction Action,
+ std::unique_ptr 
OS);

Perhaps add a comment to bring awareness to possible downstream users 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111680/new/

https://reviews.llvm.org/D111680

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

2021-10-12 Thread Fangrui Song via Phabricator via cfe-commits 
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Consider switching to `functionName` while updating the function names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111680/new/

https://reviews.llvm.org/D111680

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

2021-10-12 Thread Arthur Eubanks via Phabricator via cfe-commits 
aeubanks created this revision.
aeubanks added a reviewer: MaskRay.
Herald added a subscriber: ormris.
Herald added a reviewer: ctetreau.
Herald added a reviewer: ctetreau.
Herald added a reviewer: ctetreau.
aeubanks requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

To reflect the fact that the new PM is the default now.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111680

Files:
  clang/lib/CodeGen/BackendUtil.cpp


Index: clang/lib/CodeGen/BackendUtil.cpp
===
--- clang/lib/CodeGen/BackendUtil.cpp
+++ clang/lib/CodeGen/BackendUtil.cpp
@@ -172,11 +172,11 @@
 
   std::unique_ptr TM;
 
+  void EmitAssemblyWithLegacyPassManager(BackendAction Action,
+ std::unique_ptr 
OS);
+
   void EmitAssembly(BackendAction Action,
 std::unique_ptr OS);
-
-  void EmitAssemblyWithNewPassManager(BackendAction Action,
-  std::unique_ptr OS);
 };
 
 // We need this wrapper to access LangOpts and CGOpts from extension functions
@@ -966,8 +966,8 @@
   return true;
 }
 
-void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
-  std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssemblyWithLegacyPassManager(
+BackendAction Action, std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
 
   setCommandLineOpts(CodeGenOpts);
@@ -1509,8 +1509,8 @@
 ///
 /// This API is planned to have its functionality finished and then to replace
 /// `EmitAssembly` at some point in the future when the default switches.
-void EmitAssemblyHelper::EmitAssemblyWithNewPassManager(
-BackendAction Action, std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
+  std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
   setCommandLineOpts(CodeGenOpts);
 
@@ -1686,8 +1686,8 @@
 
   EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M);
 
-  if (!CGOpts.LegacyPassManager)
-AsmHelper.EmitAssemblyWithNewPassManager(Action, std::move(OS));
+  if (CGOpts.LegacyPassManager)
+AsmHelper.EmitAssemblyWithLegacyPassManager(Action, std::move(OS));
   else
 AsmHelper.EmitAssembly(Action, std::move(OS));
 


Index: clang/lib/CodeGen/BackendUtil.cpp
===
--- clang/lib/CodeGen/BackendUtil.cpp
+++ clang/lib/CodeGen/BackendUtil.cpp
@@ -172,11 +172,11 @@
 
   std::unique_ptr TM;
 
+  void EmitAssemblyWithLegacyPassManager(BackendAction Action,
+ std::unique_ptr OS);
+
   void EmitAssembly(BackendAction Action,
 std::unique_ptr OS);
-
-  void EmitAssemblyWithNewPassManager(BackendAction Action,
-  std::unique_ptr OS);
 };
 
 // We need this wrapper to access LangOpts and CGOpts from extension functions
@@ -966,8 +966,8 @@
   return true;
 }
 
-void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
-  std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssemblyWithLegacyPassManager(
+BackendAction Action, std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
 
   setCommandLineOpts(CodeGenOpts);
@@ -1509,8 +1509,8 @@
 ///
 /// This API is planned to have its functionality finished and then to replace
 /// `EmitAssembly` at some point in the future when the default switches.
-void EmitAssemblyHelper::EmitAssemblyWithNewPassManager(
-BackendAction Action, std::unique_ptr OS) {
+void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
+  std::unique_ptr OS) {
   TimeRegion Region(CodeGenOpts.TimePasses ?  : nullptr);
   setCommandLineOpts(CodeGenOpts);
 
@@ -1686,8 +1686,8 @@
 
   EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M);
 
-  if (!CGOpts.LegacyPassManager)
-AsmHelper.EmitAssemblyWithNewPassManager(Action, std::move(OS));
+  if (CGOpts.LegacyPassManager)
+AsmHelper.EmitAssemblyWithLegacyPassManager(Action, std::move(OS));
   else
 AsmHelper.EmitAssembly(Action, std::move(OS));
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits