[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist
This revision was automatically updated to reflect the committed changes. Closed by commit rG05f34ffa2169: [clang] Inclusive language: change instances of blacklist/whitelist to… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113189/new/ https://reviews.llvm.org/D113189 Files: clang/include/clang/AST/CommentHTMLTags.td clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Frontend/HeaderIncludeGen.cpp clang/test/CodeGen/sanitize-address-field-padding.cpp Index: clang/test/CodeGen/sanitize-address-field-padding.cpp === --- clang/test/CodeGen/sanitize-address-field-padding.cpp +++ clang/test/CodeGen/sanitize-address-field-padding.cpp @@ -1,9 +1,9 @@ // Test -fsanitize-address-field-padding -// RUN: echo 'type:SomeNamespace::BlacklistedByName=field-padding' > %t.type.blacklist -// RUN: echo 'src:*sanitize-address-field-padding.cpp=field-padding' > %t.file.blacklist -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.type.blacklist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.type.blacklist -Rsanitize-address -emit-llvm -o - %s -O1 -fno-experimental-new-pass-manager -mconstructor-aliases 2>&1 | FileCheck %s --check-prefix=WITH_CTOR_ALIASES -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.file.blacklist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=FILE_BLACKLIST +// RUN: echo 'type:SomeNamespace::IgnorelistedByName=field-padding' > %t.type.ignorelist +// RUN: echo 'src:*sanitize-address-field-padding.cpp=field-padding' > %t.file.ignorelist +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.type.ignorelist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.type.ignorelist -Rsanitize-address -emit-llvm -o - %s -O1 -fno-experimental-new-pass-manager -mconstructor-aliases 2>&1 | FileCheck %s --check-prefix=WITH_CTOR_ALIASES +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.file.ignorelist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=FILE_IGNORELIST // RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=NO_PADDING // Try to emulate -save-temps option and make sure -disable-llvm-passes will not run sanitize instrumentation. // RUN: %clang_cc1 -fsanitize=address -emit-llvm -disable-llvm-passes -o - %s | %clang_cc1 -fsanitize=address -emit-llvm -o - -x ir | FileCheck %s --check-prefix=NO_PADDING @@ -17,11 +17,11 @@ // CHECK: -fsanitize-address-field-padding ignored for Negative3 because it is a union // CHECK: -fsanitize-address-field-padding ignored for Negative4 because it is trivially copyable // CHECK: -fsanitize-address-field-padding ignored for Negative5 because it is packed -// CHECK: -fsanitize-address-field-padding ignored for SomeNamespace::BlacklistedByName because it is blacklisted +// CHECK: -fsanitize-address-field-padding ignored for SomeNamespace::IgnorelistedByName because it is ignorelisted // CHECK: -fsanitize-address-field-padding ignored for ExternCStruct because it is not C++ // -// FILE_BLACKLIST: -fsanitize-address-field-padding ignored for Positive1 because it is in a blacklisted file -// FILE_BLACKLIST-NOT: __asan_poison_intra_object_redzone +// FILE_IGNORELIST: -fsanitize-address-field-padding ignored for Positive1 because it is in a ignorelisted file +// FILE_IGNORELIST-NOT: __asan_poison_intra_object_redzone // NO_PADDING-NOT: __asan_poison_intra_object_redzone @@ -141,10 +141,10 @@ namespace SomeNamespace { -class BlacklistedByName { +class IgnorelistedByName { public: - BlacklistedByName() {} - ~BlacklistedByName() {} + IgnorelistedByName() {} + ~IgnorelistedByName() {} int make_it_non_standard_layout; private: char private1; @@ -152,7 +152,7 @@ }; } // SomeNamespace -SomeNamespace::BlacklistedByName blacklisted_by_name; +SomeNamespace::IgnorelistedByName ignorelisted_by_name; extern "C" { class ExternCStruct { Index: clang/lib/Frontend/HeaderIncludeGen.cpp === --- clang/lib/Frontend/HeaderIncludeGen.cpp +++ clang/lib/Frontend/HeaderIncludeGen.cpp @@ -119,7 +119,7 @@ // Print header info for extra headers, pretending they were discovered by // the regular preprocessor. The primary use case is to support proper // g
[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist
ZarkoCA updated this revision to Diff 385479. ZarkoCA added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113189/new/ https://reviews.llvm.org/D113189 Files: clang/include/clang/AST/CommentHTMLTags.td clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Frontend/HeaderIncludeGen.cpp clang/test/CodeGen/sanitize-address-field-padding.cpp Index: clang/test/CodeGen/sanitize-address-field-padding.cpp === --- clang/test/CodeGen/sanitize-address-field-padding.cpp +++ clang/test/CodeGen/sanitize-address-field-padding.cpp @@ -1,9 +1,9 @@ // Test -fsanitize-address-field-padding -// RUN: echo 'type:SomeNamespace::BlacklistedByName=field-padding' > %t.type.blacklist -// RUN: echo 'src:*sanitize-address-field-padding.cpp=field-padding' > %t.file.blacklist -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.type.blacklist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.type.blacklist -Rsanitize-address -emit-llvm -o - %s -O1 -fno-experimental-new-pass-manager -mconstructor-aliases 2>&1 | FileCheck %s --check-prefix=WITH_CTOR_ALIASES -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.file.blacklist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=FILE_BLACKLIST +// RUN: echo 'type:SomeNamespace::IgnorelistedByName=field-padding' > %t.type.ignorelist +// RUN: echo 'src:*sanitize-address-field-padding.cpp=field-padding' > %t.file.ignorelist +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.type.ignorelist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.type.ignorelist -Rsanitize-address -emit-llvm -o - %s -O1 -fno-experimental-new-pass-manager -mconstructor-aliases 2>&1 | FileCheck %s --check-prefix=WITH_CTOR_ALIASES +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.file.ignorelist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=FILE_IGNORELIST // RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=NO_PADDING // Try to emulate -save-temps option and make sure -disable-llvm-passes will not run sanitize instrumentation. // RUN: %clang_cc1 -fsanitize=address -emit-llvm -disable-llvm-passes -o - %s | %clang_cc1 -fsanitize=address -emit-llvm -o - -x ir | FileCheck %s --check-prefix=NO_PADDING @@ -17,11 +17,11 @@ // CHECK: -fsanitize-address-field-padding ignored for Negative3 because it is a union // CHECK: -fsanitize-address-field-padding ignored for Negative4 because it is trivially copyable // CHECK: -fsanitize-address-field-padding ignored for Negative5 because it is packed -// CHECK: -fsanitize-address-field-padding ignored for SomeNamespace::BlacklistedByName because it is blacklisted +// CHECK: -fsanitize-address-field-padding ignored for SomeNamespace::IgnorelistedByName because it is ignorelisted // CHECK: -fsanitize-address-field-padding ignored for ExternCStruct because it is not C++ // -// FILE_BLACKLIST: -fsanitize-address-field-padding ignored for Positive1 because it is in a blacklisted file -// FILE_BLACKLIST-NOT: __asan_poison_intra_object_redzone +// FILE_IGNORELIST: -fsanitize-address-field-padding ignored for Positive1 because it is in a ignorelisted file +// FILE_IGNORELIST-NOT: __asan_poison_intra_object_redzone // NO_PADDING-NOT: __asan_poison_intra_object_redzone @@ -141,10 +141,10 @@ namespace SomeNamespace { -class BlacklistedByName { +class IgnorelistedByName { public: - BlacklistedByName() {} - ~BlacklistedByName() {} + IgnorelistedByName() {} + ~IgnorelistedByName() {} int make_it_non_standard_layout; private: char private1; @@ -152,7 +152,7 @@ }; } // SomeNamespace -SomeNamespace::BlacklistedByName blacklisted_by_name; +SomeNamespace::IgnorelistedByName ignorelisted_by_name; extern "C" { class ExternCStruct { Index: clang/lib/Frontend/HeaderIncludeGen.cpp === --- clang/lib/Frontend/HeaderIncludeGen.cpp +++ clang/lib/Frontend/HeaderIncludeGen.cpp @@ -119,7 +119,7 @@ // Print header info for extra headers, pretending they were discovered by // the regular preprocessor. The primary use case is to support proper // generation of Make / Ninja file dependencies for implicit includes, such - // as sanitizer blacklists. It's only import
[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist
ZarkoCA updated this revision to Diff 385478. ZarkoCA retitled this revision from "[clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist " to "[clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist". ZarkoCA added a comment. - Address review: reworded comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113189/new/ https://reviews.llvm.org/D113189 Files: clang/include/clang/AST/CommentHTMLTags.td clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Frontend/HeaderIncludeGen.cpp clang/test/CodeGen/sanitize-address-field-padding.cpp Index: clang/test/CodeGen/sanitize-address-field-padding.cpp === --- clang/test/CodeGen/sanitize-address-field-padding.cpp +++ clang/test/CodeGen/sanitize-address-field-padding.cpp @@ -1,9 +1,9 @@ // Test -fsanitize-address-field-padding -// RUN: echo 'type:SomeNamespace::BlacklistedByName=field-padding' > %t.type.blacklist -// RUN: echo 'src:*sanitize-address-field-padding.cpp=field-padding' > %t.file.blacklist -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.type.blacklist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.type.blacklist -Rsanitize-address -emit-llvm -o - %s -O1 -fno-experimental-new-pass-manager -mconstructor-aliases 2>&1 | FileCheck %s --check-prefix=WITH_CTOR_ALIASES -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.file.blacklist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=FILE_BLACKLIST +// RUN: echo 'type:SomeNamespace::IgnorelistedByName=field-padding' > %t.type.ignorelist +// RUN: echo 'src:*sanitize-address-field-padding.cpp=field-padding' > %t.file.ignorelist +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.type.ignorelist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.type.ignorelist -Rsanitize-address -emit-llvm -o - %s -O1 -fno-experimental-new-pass-manager -mconstructor-aliases 2>&1 | FileCheck %s --check-prefix=WITH_CTOR_ALIASES +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.file.ignorelist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=FILE_IGNORELIST // RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=NO_PADDING // Try to emulate -save-temps option and make sure -disable-llvm-passes will not run sanitize instrumentation. // RUN: %clang_cc1 -fsanitize=address -emit-llvm -disable-llvm-passes -o - %s | %clang_cc1 -fsanitize=address -emit-llvm -o - -x ir | FileCheck %s --check-prefix=NO_PADDING @@ -17,11 +17,11 @@ // CHECK: -fsanitize-address-field-padding ignored for Negative3 because it is a union // CHECK: -fsanitize-address-field-padding ignored for Negative4 because it is trivially copyable // CHECK: -fsanitize-address-field-padding ignored for Negative5 because it is packed -// CHECK: -fsanitize-address-field-padding ignored for SomeNamespace::BlacklistedByName because it is blacklisted +// CHECK: -fsanitize-address-field-padding ignored for SomeNamespace::IgnorelistedByName because it is ignorelisted // CHECK: -fsanitize-address-field-padding ignored for ExternCStruct because it is not C++ // -// FILE_BLACKLIST: -fsanitize-address-field-padding ignored for Positive1 because it is in a blacklisted file -// FILE_BLACKLIST-NOT: __asan_poison_intra_object_redzone +// FILE_IGNORELIST: -fsanitize-address-field-padding ignored for Positive1 because it is in a ignorelisted file +// FILE_IGNORELIST-NOT: __asan_poison_intra_object_redzone // NO_PADDING-NOT: __asan_poison_intra_object_redzone @@ -141,10 +141,10 @@ namespace SomeNamespace { -class BlacklistedByName { +class IgnorelistedByName { public: - BlacklistedByName() {} - ~BlacklistedByName() {} + IgnorelistedByName() {} + ~IgnorelistedByName() {} int make_it_non_standard_layout; private: char private1; @@ -152,7 +152,7 @@ }; } // SomeNamespace -SomeNamespace::BlacklistedByName blacklisted_by_name; +SomeNamespace::IgnorelistedByName ignorelisted_by_name; extern "C" { class ExternCStruct { Index: clang/lib/Frontend/HeaderIncludeGen.cpp === --- clang/lib/Frontend/HeaderIncludeGen.cpp +++ clang/lib/Frontend/HeaderIncludeGen.cpp @@ -119,7 +119,7 @@ // Print header in
[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Generally lg. I find the word "allowlist" (and to a lesser level also "ignorelist") a bit awkward; imho you can often make things more clear by rephrasing things away from "foolist". A few suggestions along those lines below. Comment at: clang/include/clang/AST/CommentHTMLTags.td:55 -// Define a blacklist of attributes that are not safe to pass through to HTML +// Define an ignorelist of attributes that are not safe to pass through to HTML // output if the input is untrusted. "Define a list of…" Comment at: clang/include/clang/AST/CommentHTMLTags.td:58 // -// FIXME: this should be a whitelist. When changing this to a whitelist, don't -// forget to change the default in the TableGen backend. +// FIXME: this should be an allowlist. When changing this to an allowlist, +// don't forget to change the default in the TableGen backend. "This should be a list of attributes that _are_ safe. When making this change, don't forget…" Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:570 "%select{is not C++|is packed|is a union|is trivially copyable|" -"has trivial destructor|is standard layout|is in a blacklisted file|" -"is blacklisted}1">, ShowInSystemHeader, +"has trivial destructor|is standard layout|is in a ignorelisted file|" +"is ignorelisted}1">, ShowInSystemHeader, s/a/an/ Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:571 +"has trivial destructor|is standard layout|is in a ignorelisted file|" +"is ignorelisted}1">, ShowInSystemHeader, InGroup; "is ignored" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113189/new/ https://reviews.llvm.org/D113189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist
ZarkoCA created this revision. ZarkoCA added reviewers: thakis, compnerd, rtrieu, gribozavr, kcc. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the error message to use ignorelist, and changed some variable and function names in related code and test. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113189 Files: clang/include/clang/AST/CommentHTMLTags.td clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Frontend/HeaderIncludeGen.cpp clang/test/CodeGen/sanitize-address-field-padding.cpp Index: clang/test/CodeGen/sanitize-address-field-padding.cpp === --- clang/test/CodeGen/sanitize-address-field-padding.cpp +++ clang/test/CodeGen/sanitize-address-field-padding.cpp @@ -1,9 +1,9 @@ // Test -fsanitize-address-field-padding -// RUN: echo 'type:SomeNamespace::BlacklistedByName=field-padding' > %t.type.blacklist -// RUN: echo 'src:*sanitize-address-field-padding.cpp=field-padding' > %t.file.blacklist -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.type.blacklist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.type.blacklist -Rsanitize-address -emit-llvm -o - %s -O1 -fno-experimental-new-pass-manager -mconstructor-aliases 2>&1 | FileCheck %s --check-prefix=WITH_CTOR_ALIASES -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-blacklist=%t.file.blacklist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=FILE_BLACKLIST +// RUN: echo 'type:SomeNamespace::IgnorelistedByName=field-padding' > %t.type.ignorelist +// RUN: echo 'src:*sanitize-address-field-padding.cpp=field-padding' > %t.file.ignorelist +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.type.ignorelist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.type.ignorelist -Rsanitize-address -emit-llvm -o - %s -O1 -fno-experimental-new-pass-manager -mconstructor-aliases 2>&1 | FileCheck %s --check-prefix=WITH_CTOR_ALIASES +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsanitize=address -fsanitize-address-field-padding=1 -fsanitize-ignorelist=%t.file.ignorelist -Rsanitize-address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=FILE_IGNORELIST // RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=NO_PADDING // Try to emulate -save-temps option and make sure -disable-llvm-passes will not run sanitize instrumentation. // RUN: %clang_cc1 -fsanitize=address -emit-llvm -disable-llvm-passes -o - %s | %clang_cc1 -fsanitize=address -emit-llvm -o - -x ir | FileCheck %s --check-prefix=NO_PADDING @@ -17,11 +17,11 @@ // CHECK: -fsanitize-address-field-padding ignored for Negative3 because it is a union // CHECK: -fsanitize-address-field-padding ignored for Negative4 because it is trivially copyable // CHECK: -fsanitize-address-field-padding ignored for Negative5 because it is packed -// CHECK: -fsanitize-address-field-padding ignored for SomeNamespace::BlacklistedByName because it is blacklisted +// CHECK: -fsanitize-address-field-padding ignored for SomeNamespace::IgnorelistedByName because it is ignorelisted // CHECK: -fsanitize-address-field-padding ignored for ExternCStruct because it is not C++ // -// FILE_BLACKLIST: -fsanitize-address-field-padding ignored for Positive1 because it is in a blacklisted file -// FILE_BLACKLIST-NOT: __asan_poison_intra_object_redzone +// FILE_IGNORELIST: -fsanitize-address-field-padding ignored for Positive1 because it is in a ignorelisted file +// FILE_IGNORELIST-NOT: __asan_poison_intra_object_redzone // NO_PADDING-NOT: __asan_poison_intra_object_redzone @@ -141,10 +141,10 @@ namespace SomeNamespace { -class BlacklistedByName { +class IgnorelistedByName { public: - BlacklistedByName() {} - ~BlacklistedByName() {} + IgnorelistedByName() {} + ~IgnorelistedByName() {} int make_it_non_standard_layout; private: char private1; @@ -152,7 +152,7 @@ }; } // SomeNamespace -SomeNamespace::BlacklistedByName blacklisted_by_name; +SomeNamespace::IgnorelistedByName ignorelisted_by_name; extern "C" { class ExternCStruct { Index: clang/lib/Frontend/HeaderIncludeGen.cpp === --- clang/lib/Frontend/HeaderIncludeGen.cpp +++ clang/lib/Frontend/HeaderIncludeGen.cpp @@ -119,7 +119,7 @@ // Print header info for extra headers, pretending they were discovered by // the regular pr