[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

[Lu Weining via Phabricator via cfe-commits]

SixWeining abandoned this revision.
SixWeining added a comment.

Abandon because https://reviews.llvm.org/D115580 has already fixed it although 
later than my fix.

Thanks @dexonsmith


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114505/new/

https://reviews.llvm.org/D114505

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.

Lost track of this again :/. Was just about to commit this for you (finally) 
but it looks like https://reviews.llvm.org/D115580 has already fixed it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114505/new/

https://reviews.llvm.org/D114505

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

[Lu Weining via Phabricator via cfe-commits]

SixWeining added a comment.

ping


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114505/new/

https://reviews.llvm.org/D114505

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

[Lu Weining via Phabricator via cfe-commits]

SixWeining added a comment.

In D114505#3181637 , @dexonsmith 
wrote:

> LGTM. Sorry for missing this before. Looks to me like the debian build 
> failure above is unrelated.
>
> If you need someone to commit for you, please include the info for 
> GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL.

Thanks @dexonsmith . I don't have commit access, could you help to land this 
patch for me? Please use below info to commit the change.

email = luwein...@loongson.cn
name = Weining Lu

BTW, according to the policy 
, a "Differential 
Revision: " line should be added to the commit message. But it seems that 
I'm not allowed to add such line without commit access. Could you help to add 
it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114505/new/

https://reviews.llvm.org/D114505

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM. Sorry for missing this before. Looks to me like the debian build failure 
above is unrelated.

If you need someone to commit for you, please include the info for 
GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114505/new/

https://reviews.llvm.org/D114505

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

[Lu Weining via Phabricator via cfe-commits]

SixWeining updated this revision to Diff 389696.
SixWeining added a comment.

diff1 and diff2 are the same, but diff1 build pass while diff2 build fail. So 
weird. Just reupload the patch to have a try. Sorry for the noise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114505/new/

https://reviews.llvm.org/D114505

Files:
  clang/unittests/Basic/CMakeLists.txt


Index: clang/unittests/Basic/CMakeLists.txt
===
--- clang/unittests/Basic/CMakeLists.txt
+++ clang/unittests/Basic/CMakeLists.txt
@@ -18,5 +18,9 @@
   clangAST
   clangBasic
   clangLex
-  LLVMTestingSupport
   )
+
+target_link_libraries(BasicTests
+  PRIVATE
+  LLVMTestingSupport
+)


Index: clang/unittests/Basic/CMakeLists.txt
===
--- clang/unittests/Basic/CMakeLists.txt
+++ clang/unittests/Basic/CMakeLists.txt
@@ -18,5 +18,9 @@
   clangAST
   clangBasic
   clangLex
-  LLVMTestingSupport
   )
+
+target_link_libraries(BasicTests
+  PRIVATE
+  LLVMTestingSupport
+)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

[Lu Weining via Phabricator via cfe-commits]

SixWeining updated this revision to Diff 389650.
SixWeining retitled this revision from "[clang][unittests]Fix a clang 
unittest linking issue" to "[clang][unittests] Fix a clang unittest linking 
issue".
SixWeining edited the summary of this revision.
SixWeining added a comment.
Herald added a subscriber: pengfei.

Modify the summary to be more descriptive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114505/new/

https://reviews.llvm.org/D114505

Files:
  clang/unittests/Basic/CMakeLists.txt


Index: clang/unittests/Basic/CMakeLists.txt
===
--- clang/unittests/Basic/CMakeLists.txt
+++ clang/unittests/Basic/CMakeLists.txt
@@ -18,5 +18,9 @@
   clangAST
   clangBasic
   clangLex
-  LLVMTestingSupport
   )
+
+target_link_libraries(BasicTests
+  PRIVATE
+  LLVMTestingSupport
+)


Index: clang/unittests/Basic/CMakeLists.txt
===
--- clang/unittests/Basic/CMakeLists.txt
+++ clang/unittests/Basic/CMakeLists.txt
@@ -18,5 +18,9 @@
   clangAST
   clangBasic
   clangLex
-  LLVMTestingSupport
   )
+
+target_link_libraries(BasicTests
+  PRIVATE
+  LLVMTestingSupport
+)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114505: [clang][unittests]Fix a clang unittest linking issue

[Lu Weining via Phabricator via cfe-commits]

SixWeining created this revision.
SixWeining added reviewers: cfe-commits, dexonsmith.
Herald added a subscriber: mgorny.
SixWeining requested review of this revision.
Herald added a project: clang.

Currently the clang/unittests/Basic/CMakeLists.txt links LLVMTestingSupport in 
an incorrect way that would cause `ninja check-clang` failing with a linking 
error like below:
/usr/bin/ld: 
tools/clang/unittests/Basic/CMakeFiles/BasicTests.dir/FileManagerTest.cpp.o: in 
function `(anonymous 
namespace)::FileManagerTest_getBypassFile_Test::TestBody()':
FileManagerTest.cpp:(.text._ZN12_GLOBAL__N_134FileManagerTest_getBypassFile_Test8TestBodyEv+0x3a3):
 undefined reference to `llvm::detail::TakeError(llvm::Error)'

This patch changes the linking method of LLVMTestingSupport from 
clang_target_link_libraries to target_link_libraries just like other tests do.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114505

Files:
  clang/unittests/Basic/CMakeLists.txt


Index: clang/unittests/Basic/CMakeLists.txt
===
--- clang/unittests/Basic/CMakeLists.txt
+++ clang/unittests/Basic/CMakeLists.txt
@@ -18,5 +18,9 @@
   clangAST
   clangBasic
   clangLex
-  LLVMTestingSupport
   )
+
+target_link_libraries(BasicTests
+  PRIVATE
+  LLVMTestingSupport
+)


Index: clang/unittests/Basic/CMakeLists.txt
===
--- clang/unittests/Basic/CMakeLists.txt
+++ clang/unittests/Basic/CMakeLists.txt
@@ -18,5 +18,9 @@
   clangAST
   clangBasic
   clangLex
-  LLVMTestingSupport
   )
+
+target_link_libraries(BasicTests
+  PRIVATE
+  LLVMTestingSupport
+)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits