Re: [PATCH] D12982: Move routines for guessing mode/target from driver to ToolChain

2015-09-25 Thread Luke Zarko via cfe-commits 
zarko added a comment.

Great!

I don't have commit access; would someone who does please land this?


Repository:
  rL LLVM

http://reviews.llvm.org/D12982



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12982: Move routines for guessing mode/target from driver to ToolChain

2015-09-25 Thread Eric Christopher via cfe-commits 
echristo added a subscriber: echristo.
echristo added a comment.

Oh, sure I can.

Done thusly:

dzur:~/sources/llvm/tools/clang> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
M include/clang/Driver/ToolChain.h
M lib/Driver/ToolChain.cpp
M tools/driver/driver.cpp
Committed r248592

-eric


Repository:
  rL LLVM

http://reviews.llvm.org/D12982



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12982: Move routines for guessing mode/target from driver to ToolChain

2015-09-25 Thread Eric Christopher via cfe-commits 
Oh, sure I can.

Done thusly:

dzur:~/sources/llvm/tools/clang> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
M include/clang/Driver/ToolChain.h
M lib/Driver/ToolChain.cpp
M tools/driver/driver.cpp
Committed r248592

-eric


On Fri, Sep 25, 2015 at 10:20 AM Luke Zarko  wrote:

> zarko added a comment.
>
> Great!
>
> I don't have commit access; would someone who does please land this?
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D12982
>
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12982: Move routines for guessing mode/target from driver to ToolChain

2015-09-21 Thread Luke Zarko via cfe-commits 
zarko added a comment.

This should be a straight move, unless there is something I don't understand 
about the semantics of `llvm::InitializeAllTargets();` that would make moving 
it earlier in `main` a bad idea.


Repository:
  rL LLVM

http://reviews.llvm.org/D12982



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits