[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-08-19 Thread Sam Clegg via Phabricator via cfe-commits 
sbc100 added a comment.

https://chromium-review.googlesource.com/c/emscripten-releases/+/3842345... 
I suppose the alternative would be to keep the backup method that was 
previously working in our case (but not in yours)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-08-19 Thread Sunho Kim via Phabricator via cfe-commits 
sunho added a comment.

In D130788#3732325 , @sbc100 wrote:

> In D130788#3731232 , @sunho wrote:
>
>> In D130788#3730533 , @sbc100 wrote:
>>
>>> I'm not totally sure but I think the change is responsible for the 
>>> emscripten integration bot failing `InterpreterTest.CatchException`: 
>>> https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8807160007692150337/+/u/LLVM_regression/stdout
>>>
>>>   [==] Running 1 test from 1 test suite.
>>>   [--] Global test environment set-up.
>>>   [--] 1 test from InterpreterTest
>>>   [ RUN  ] InterpreterTest.CatchException
>>>   JIT session error: Symbols not found: [ __gxx_personality_v0, 
>>> _ZSt9terminatev, _ZTVN10__cxxabiv117__class_type_infoE, 
>>> __cxa_allocate_exception, __cxa_begin_catch, __cxa_end_catch, 
>>> __cxa_free_exception, __cxa_throw ]
>>>   Failure value returned from cantFail wrapped call
>>>   Failed to materialize symbols: { (main, { _ZN16custom_exceptionC2EPKc, 
>>> __clang_call_terminate, _ZTI16custom_exception, _ZTS16custom_exception, 
>>> throw_exception }) }
>>>   UNREACHABLE executed at 
>>> /b/s/w/ir/cache/builder/emscripten-releases/llvm-project/llvm/include/llvm/Support/Error.h:786!
>>>   Stack dump without symbol names (ensure you have llvm-symbolizer in your 
>>> PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x2464413)[0x55cb14660413]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246236c)[0x55cb1465e36c]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x24648df)[0x55cb146608df]
>>>   /lib/x86_64-linux-gnu/libpthread.so.0(+0x12980)[0x7fad2fab1980]
>>>   /lib/x86_64-linux-gnu/libc.so.6(gsignal+0xc7)[0x7fad2eb0de87]
>>>   /lib/x86_64-linux-gnu/libc.so.6(abort+0x141)[0x7fad2eb0f7f1]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x23f798f)[0x55cb145f398f]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9de35)[0x55cb14099e35]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9d597)[0x55cb14099597]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246d6be)[0x55cb146696be]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246e659)[0x55cb1466a659]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246ee40)[0x55cb1466ae40]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x247b2c3)[0x55cb146772c3]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x247ab42)[0x55cb14676b42]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246559c)[0x55cb1466159c]
>>>   /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7fad2eaf0c87]
>>>   
>>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9ceda)[0x55cb14098eda]
>>>
>>> This started happening consistently after this change 
>>> https://chromium.googlesource.com/emscripten-releases/+/584b2f531314d1e70cd5ebadcce7e015a6215c9a.
>>>   The only CL in that list that looks related seems to be this one.
>>
>> Could you share the detailed build configuration of those bots?
>
> All the step should be visible here: 
> https://ci.chromium.org/ui/p/emscripten-releases/builders/ci/linux-test-suites/b8805531315340503553/steps
>
> The most relevant one I guess would be:
>
> https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8805531315340503553/+/u/Build_LLVM/stdout
>
> Here you can see LLVM being configured with:
>
>   
> subprocess.check_call(`/b/s/w/ir/cache/builder/emscripten-releases/cmake-3.21.3-linux-x86_64/bin/cmake
>  -G Ninja

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-08-18 Thread Sam Clegg via Phabricator via cfe-commits 
sbc100 added a comment.

In D130788#3731232 , @sunho wrote:

> In D130788#3730533 , @sbc100 wrote:
>
>> I'm not totally sure but I think the change is responsible for the 
>> emscripten integration bot failing `InterpreterTest.CatchException`: 
>> https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8807160007692150337/+/u/LLVM_regression/stdout
>>
>>   [==] Running 1 test from 1 test suite.
>>   [--] Global test environment set-up.
>>   [--] 1 test from InterpreterTest
>>   [ RUN  ] InterpreterTest.CatchException
>>   JIT session error: Symbols not found: [ __gxx_personality_v0, 
>> _ZSt9terminatev, _ZTVN10__cxxabiv117__class_type_infoE, 
>> __cxa_allocate_exception, __cxa_begin_catch, __cxa_end_catch, 
>> __cxa_free_exception, __cxa_throw ]
>>   Failure value returned from cantFail wrapped call
>>   Failed to materialize symbols: { (main, { _ZN16custom_exceptionC2EPKc, 
>> __clang_call_terminate, _ZTI16custom_exception, _ZTS16custom_exception, 
>> throw_exception }) }
>>   UNREACHABLE executed at 
>> /b/s/w/ir/cache/builder/emscripten-releases/llvm-project/llvm/include/llvm/Support/Error.h:786!
>>   Stack dump without symbol names (ensure you have llvm-symbolizer in your 
>> PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x2464413)[0x55cb14660413]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246236c)[0x55cb1465e36c]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x24648df)[0x55cb146608df]
>>   /lib/x86_64-linux-gnu/libpthread.so.0(+0x12980)[0x7fad2fab1980]
>>   /lib/x86_64-linux-gnu/libc.so.6(gsignal+0xc7)[0x7fad2eb0de87]
>>   /lib/x86_64-linux-gnu/libc.so.6(abort+0x141)[0x7fad2eb0f7f1]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x23f798f)[0x55cb145f398f]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9de35)[0x55cb14099e35]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9d597)[0x55cb14099597]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246d6be)[0x55cb146696be]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246e659)[0x55cb1466a659]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246ee40)[0x55cb1466ae40]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x247b2c3)[0x55cb146772c3]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x247ab42)[0x55cb14676b42]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246559c)[0x55cb1466159c]
>>   /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7fad2eaf0c87]
>>   
>> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9ceda)[0x55cb14098eda]
>>
>> This started happening consistently after this change 
>> https://chromium.googlesource.com/emscripten-releases/+/584b2f531314d1e70cd5ebadcce7e015a6215c9a.
>>   The only CL in that list that looks related seems to be this one.
>
> Could you share the detailed build configuration of those bots?

All the step should be visible here: 
https://ci.chromium.org/ui/p/emscripten-releases/builders/ci/linux-test-suites/b8805531315340503553/steps

The most relevant one I guess would be:

https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8805531315340503553/+/u/Build_LLVM/stdout

Here you can see LLVM being configured with:

  
subprocess.check_call(`/b/s/w/ir/cache/builder/emscripten-releases/cmake-3.21.3-linux-x86_64/bin/cmake
 -G Ninja -DPython3_EXECUTABLE=/b/s/w/ir/cache/vpython/68bda9/bin/python 
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Release 
-DCMAKE_INSTALL_PREFIX=/b/s/w/ir/x/w/install

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-08-18 Thread Sunho Kim via Phabricator via cfe-commits 
sunho added a comment.

In D130788#3730533 , @sbc100 wrote:

> I'm not totally sure but I think the change is responsible for the emscripten 
> integration bot failing `InterpreterTest.CatchException`: 
> https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8807160007692150337/+/u/LLVM_regression/stdout
>
>   [==] Running 1 test from 1 test suite.
>   [--] Global test environment set-up.
>   [--] 1 test from InterpreterTest
>   [ RUN  ] InterpreterTest.CatchException
>   JIT session error: Symbols not found: [ __gxx_personality_v0, 
> _ZSt9terminatev, _ZTVN10__cxxabiv117__class_type_infoE, 
> __cxa_allocate_exception, __cxa_begin_catch, __cxa_end_catch, 
> __cxa_free_exception, __cxa_throw ]
>   Failure value returned from cantFail wrapped call
>   Failed to materialize symbols: { (main, { _ZN16custom_exceptionC2EPKc, 
> __clang_call_terminate, _ZTI16custom_exception, _ZTS16custom_exception, 
> throw_exception }) }
>   UNREACHABLE executed at 
> /b/s/w/ir/cache/builder/emscripten-releases/llvm-project/llvm/include/llvm/Support/Error.h:786!
>   Stack dump without symbol names (ensure you have llvm-symbolizer in your 
> PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x2464413)[0x55cb14660413]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246236c)[0x55cb1465e36c]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x24648df)[0x55cb146608df]
>   /lib/x86_64-linux-gnu/libpthread.so.0(+0x12980)[0x7fad2fab1980]
>   /lib/x86_64-linux-gnu/libc.so.6(gsignal+0xc7)[0x7fad2eb0de87]
>   /lib/x86_64-linux-gnu/libc.so.6(abort+0x141)[0x7fad2eb0f7f1]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x23f798f)[0x55cb145f398f]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9de35)[0x55cb14099e35]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9d597)[0x55cb14099597]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246d6be)[0x55cb146696be]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246e659)[0x55cb1466a659]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246ee40)[0x55cb1466ae40]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x247b2c3)[0x55cb146772c3]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x247ab42)[0x55cb14676b42]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246559c)[0x55cb1466159c]
>   /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7fad2eaf0c87]
>   
> /b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9ceda)[0x55cb14098eda]
>
> This started happening consistently after this change 
> https://chromium.googlesource.com/emscripten-releases/+/584b2f531314d1e70cd5ebadcce7e015a6215c9a.
>   The only CL in that list that looks related seems to be this one.

Could you share the detailed build configuration of those bots?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-08-17 Thread Sam Clegg via Phabricator via cfe-commits 
sbc100 added a comment.

I'm not totally sure but I think the change is responsible for the emscripten 
integration bot failing `InterpreterTest.CatchException`: 
https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8807160007692150337/+/u/LLVM_regression/stdout

  [==] Running 1 test from 1 test suite.
  [--] Global test environment set-up.
  [--] 1 test from InterpreterTest
  [ RUN  ] InterpreterTest.CatchException
  JIT session error: Symbols not found: [ __gxx_personality_v0, 
_ZSt9terminatev, _ZTVN10__cxxabiv117__class_type_infoE, 
__cxa_allocate_exception, __cxa_begin_catch, __cxa_end_catch, 
__cxa_free_exception, __cxa_throw ]
  Failure value returned from cantFail wrapped call
  Failed to materialize symbols: { (main, { _ZN16custom_exceptionC2EPKc, 
__clang_call_terminate, _ZTI16custom_exception, _ZTS16custom_exception, 
throw_exception }) }
  UNREACHABLE executed at 
/b/s/w/ir/cache/builder/emscripten-releases/llvm-project/llvm/include/llvm/Support/Error.h:786!
  Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH 
or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x2464413)[0x55cb14660413]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246236c)[0x55cb1465e36c]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x24648df)[0x55cb146608df]
  /lib/x86_64-linux-gnu/libpthread.so.0(+0x12980)[0x7fad2fab1980]
  /lib/x86_64-linux-gnu/libc.so.6(gsignal+0xc7)[0x7fad2eb0de87]
  /lib/x86_64-linux-gnu/libc.so.6(abort+0x141)[0x7fad2eb0f7f1]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x23f798f)[0x55cb145f398f]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9de35)[0x55cb14099e35]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9d597)[0x55cb14099597]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246d6be)[0x55cb146696be]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246e659)[0x55cb1466a659]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246ee40)[0x55cb1466ae40]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x247b2c3)[0x55cb146772c3]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x247ab42)[0x55cb14676b42]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x246559c)[0x55cb1466159c]
  /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7fad2eaf0c87]
  
/b/s/w/ir/cache/builder/emscripten-releases/build/llvm-out/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests(+0x1e9ceda)[0x55cb14098eda]

This started happening consistently after this change 
https://chromium.googlesource.com/emscripten-releases/+/584b2f531314d1e70cd5ebadcce7e015a6215c9a.
  The only CL in that list that looks related seems to be this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-07-31 Thread Douglas Yung via Phabricator via cfe-commits 
dyung added a comment.

In D130788#3689918 , @sunho wrote:

> In D130788#3689820 , @dyung wrote:
>
>> In D130788#3689795 , @sunho wrote:
>>
>>> The test isn't supposed to be ran on windows -- we don't support exception 
>>> on windows at all yet. I guess XFAIL: windows-msvc, windows-gnu is not 
>>> working out.
>>
>> If you don't want the test run on Windows, I think what you want is probably 
>> `system-windows` rather than `windows-msvc` and `windows-gnu`. The former 
>> will mark as XFAIL when it is run on Windows, while the latter will mark as 
>> XFAIL when the target triple includes those strings.
>
> Should have been fixed in 
> https://github.com/llvm/llvm-project/commit/773d51ce3bedd091539aa86a5e5fc15a9174ff7b.
>  Can you check it out?

https://lab.llvm.org/buildbot/#/builders/216/builds/7647

That seems to have worked. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-07-31 Thread Sunho Kim via Phabricator via cfe-commits 
sunho added a comment.

In D130788#3689820 , @dyung wrote:

> In D130788#3689795 , @sunho wrote:
>
>> The test isn't supposed to be ran on windows -- we don't support exception 
>> on windows at all yet. I guess XFAIL: windows-msvc, windows-gnu is not 
>> working out.
>
> If you don't want the test run on Windows, I think what you want is probably 
> `system-windows` rather than `windows-msvc` and `windows-gnu`. The former 
> will mark as XFAIL when it is run on Windows, while the latter will mark as 
> XFAIL when the target triple includes those strings.

Should have been fixed in 
https://github.com/llvm/llvm-project/commit/773d51ce3bedd091539aa86a5e5fc15a9174ff7b.
 Can you check it out?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-07-31 Thread Douglas Yung via Phabricator via cfe-commits 
dyung added a comment.

In D130788#3689795 , @sunho wrote:

> The test isn't supposed to be ran on windows -- we don't support exception on 
> windows at all yet. I guess XFAIL: windows-msvc, windows-gnu is not working 
> out.

If you don't want the test run on Windows, I think what you want is probably 
`system-windows` rather than `windows-msvc` and `windows-gnu`. The former will 
mark as XFAIL when it is run on Windows, while the latter will mark as XFAIL 
when the target triple includes those strings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-07-31 Thread Sunho Kim via Phabricator via cfe-commits 
sunho added a comment.

In D130788#3689693 , @dyung wrote:

> The test simple-exception.cpp is failing on the PS5 Windows bot after this 
> change. Can you take a look?
>
> I forced a build using the commit prior to yours which passed: 
> https://lab.llvm.org/buildbot/#/builders/216/builds/7636
> And then I forced a build using your commit, and the test failed: 
> https://lab.llvm.org/buildbot/#/builders/216/builds/7637
>
>    TEST 'Clang :: Interpreter/simple-exception.cpp' 
> FAILED 
>   Script:
>   --
>   : 'RUN: at line 4';   cat 
> Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp | 
> z:\test\build\bin\clang-repl.exe | z:\test\build\bin\filecheck.exe 
> Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp
>   --
>   Exit Code: 1
>   Command Output (stdout):
>   --
>   $ ":" "RUN: at line 4"
>   $ "cat" "Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp"
>   $ "z:\test\build\bin\clang-repl.exe"
>   # command stderr:
>   JIT session error: Symbols not found: [ ??_7type_info@@6B@ ]
>   error: Failed to materialize symbols: { (main, { _CT??_R0PEAX@88, 
> ?f@@YAHXZ, ?r1@@3HA, _CTA2PEAD, ??_C@_0BB@DPCIAKEG@Simple?5exception?$AA@, 
> ??_C@_03OFAPEBGM@?$CFs?6?$AA@, $.incr_module_8.__inits.0, 
> ?checkException@@YAHXZ, _TIC2PEAD, ??_R0PEAD@8, ??_R0PEAX@8, 
> __orc_init_func.incr_module_8, ??_C@_0N@CKKDCGKM@Running?5f?$CI?$CJ?6?$AA@, 
> _CT??_R0PEAD@88 }) }
>   error: Failed to materialize symbols: { (main, { 
> __orc_init_func.incr_module_8 }) }
>   $ "z:\test\build\bin\filecheck.exe" 
> "Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp"
>   # command stderr:
>   Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp:10:11: 
> error: CHECK: expected string not found in input
>   // CHECK: Running f()
> ^
>   :1:1: note: scanning from here
>   clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
> clang-repl> 
>   ^
>   :1:11: note: possible intended match here
>   clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
> clang-repl> 
> ^
>   Input file: 
>   Check file: Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp
>   -dump-input=help explains the following input dump.
>   Input was:
>   <<
>   1: clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
> clang-repl> clang-repl>  
>   check:10'0 
> X
>  error: no match found
>   check:10'1   ?  
>   
>possible intended match
>   >>
>   error: command failed with exit status: 1
>   --
>   

The test isn't supposed to be ran on windows -- we don't support exception on 
windows at all yet. I guess XFAIL: windows-msvc, windows-gnu is not working out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-07-31 Thread Douglas Yung via Phabricator via cfe-commits 
dyung added a comment.

The test simple-exception.cpp is failing on the PS5 Windows bot after this 
change. Can you take a look?

I forced a build using the commit prior to yours which passed: 
https://lab.llvm.org/buildbot/#/builders/216/builds/7636
And then I forced a build using your commit, and the test failed: 
https://lab.llvm.org/buildbot/#/builders/216/builds/7637

   TEST 'Clang :: Interpreter/simple-exception.cpp' FAILED 

  Script:
  --
  : 'RUN: at line 4';   cat 
Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp | 
z:\test\build\bin\clang-repl.exe | z:\test\build\bin\filecheck.exe 
Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp
  --
  Exit Code: 1
  Command Output (stdout):
  --
  $ ":" "RUN: at line 4"
  $ "cat" "Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp"
  $ "z:\test\build\bin\clang-repl.exe"
  # command stderr:
  JIT session error: Symbols not found: [ ??_7type_info@@6B@ ]
  error: Failed to materialize symbols: { (main, { _CT??_R0PEAX@88, ?f@@YAHXZ, 
?r1@@3HA, _CTA2PEAD, ??_C@_0BB@DPCIAKEG@Simple?5exception?$AA@, 
??_C@_03OFAPEBGM@?$CFs?6?$AA@, $.incr_module_8.__inits.0, 
?checkException@@YAHXZ, _TIC2PEAD, ??_R0PEAD@8, ??_R0PEAX@8, 
__orc_init_func.incr_module_8, ??_C@_0N@CKKDCGKM@Running?5f?$CI?$CJ?6?$AA@, 
_CT??_R0PEAD@88 }) }
  error: Failed to materialize symbols: { (main, { 
__orc_init_func.incr_module_8 }) }
  $ "z:\test\build\bin\filecheck.exe" 
"Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp"
  # command stderr:
  Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp:10:11: 
error: CHECK: expected string not found in input
  // CHECK: Running f()
^
  :1:1: note: scanning from here
  clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> 
  ^
  :1:11: note: possible intended match here
  clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> 
^
  Input file: 
  Check file: Z:\test\llvm-project\clang\test\Interpreter\simple-exception.cpp
  -dump-input=help explains the following input dump.
  Input was:
  <<
  1: clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> 
clang-repl> clang-repl>  
  check:10'0 
X
 error: no match found
  check:10'1   ?

   possible intended match
  >>
  error: command failed with exit status: 1
  --
  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-07-30 Thread Sunho Kim via Phabricator via cfe-commits 
sunho added a comment.

https://lab.llvm.org/buildbot/#/builders/98/builds/22588 fuschia build bot is 
happy with this change and I don't see new build breakages so far!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

2022-07-30 Thread Sunho Kim via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa8f2e24e48fd: [clang-repl] Disable building when 
LLVM_STATIC_LINK_CXX_STDLIB is ON. (authored by sunho).
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788

Files:
  clang/CMakeLists.txt
  clang/test/CMakeLists.txt
  clang/test/Interpreter/code-undo.cpp
  clang/test/Interpreter/execute-weak.cpp
  clang/test/Interpreter/execute.cpp
  clang/test/Interpreter/global-dtor-win.cpp
  clang/test/Interpreter/global-dtor.cpp
  clang/test/Interpreter/lit.local.cfg
  clang/test/Interpreter/plugins.cpp
  clang/test/Interpreter/simple-exception.cpp
  clang/test/lit.cfg.py
  clang/tools/CMakeLists.txt
  clang/tools/clang-repl/ClangRepl.cpp
  clang/unittests/CMakeLists.txt
  clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp

Index: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
===
--- clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
+++ clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
@@ -113,17 +113,6 @@
   Triple.getArch() == llvm::Triple::aarch64_32))
 return;
 
-  // Check if platform does not support exceptions.
-  {
-// Force the creation of an incremental executor to call getSymbolAddress.
-llvm::cantFail(Interp->ParseAndExecute(""));
-auto Sym = Interp->getSymbolAddress("__cxa_throw");
-if (!Sym) {
-  LLVMConsumeError(llvm::wrap(Sym.takeError()));
-  return;
-}
-  }
-
   llvm::cantFail(Interp->ParseAndExecute(ExceptionCode));
   testing::internal::CaptureStdout();
   auto ThrowException =
Index: clang/unittests/CMakeLists.txt
===
--- clang/unittests/CMakeLists.txt
+++ clang/unittests/CMakeLists.txt
@@ -35,7 +35,9 @@
 add_subdirectory(Rewrite)
 add_subdirectory(Sema)
 add_subdirectory(CodeGen)
-add_subdirectory(Interpreter)
+if(HAVE_CLANG_REPL_SUPPORT)
+  add_subdirectory(Interpreter)
+endif()
 # FIXME: libclang unit tests are disabled on Windows due
 # to failures, mostly in libclang.VirtualFileOverlay_*.
 if(NOT WIN32 AND CLANG_TOOL_LIBCLANG_BUILD) 
Index: clang/tools/clang-repl/ClangRepl.cpp
===
--- clang/tools/clang-repl/ClangRepl.cpp
+++ clang/tools/clang-repl/ClangRepl.cpp
@@ -28,8 +28,6 @@
   llvm::cl::CommaSeparated);
 static llvm::cl::opt OptHostSupportsJit("host-supports-jit",
   llvm::cl::Hidden);
-static llvm::cl::opt OptHostSupportsException("host-supports-exception",
-llvm::cl::Hidden);
 static llvm::cl::list OptInputs(llvm::cl::Positional,
  llvm::cl::desc("[code to run]"));
 
@@ -67,42 +65,6 @@
   return Errs ? EXIT_FAILURE : EXIT_SUCCESS;
 }
 
-// Check if the host environment supports c++ exception handling
-// by querying the existence of symbol __cxa_throw.
-static bool checkExceptionSupport() {
-  auto J = llvm::orc::LLJITBuilder().create();
-  if (!J) {
-llvm::consumeError(J.takeError());
-return false;
-  }
-
-  std::vector Dummy;
-  auto CI = clang::IncrementalCompilerBuilder::create(Dummy);
-  if (!CI) {
-llvm::consumeError(CI.takeError());
-return false;
-  }
-
-  auto Interp = clang::Interpreter::create(std::move(*CI));
-  if (!Interp) {
-llvm::consumeError(Interp.takeError());
-return false;
-  }
-
-  if (auto Err = (*Interp)->ParseAndExecute("")) {
-llvm::consumeError(std::move(Err));
-return false;
-  }
-
-  auto Sym = (*Interp)->getSymbolAddress("__cxa_throw");
-  if (!Sym) {
-llvm::consumeError(Sym.takeError());
-return false;
-  }
-
-  return true;
-}
-
 llvm::ExitOnError ExitOnErr;
 int main(int argc, const char **argv) {
   ExitOnErr.setBanner("clang-repl: ");
@@ -127,14 +89,6 @@
 return 0;
   }
 
-  if (OptHostSupportsException) {
-if (checkExceptionSupport())
-  llvm::outs() << "true\n";
-else
-  llvm::outs() << "false\n";
-return 0;
-  }
-
   // FIXME: Investigate if we could use runToolOnCodeWithArgs from tooling. It
   // can replace the boilerplate code for creation of the compiler instance.
   auto CI = ExitOnErr(clang::IncrementalCompilerBuilder::create(ClangArgv));
Index: clang/tools/CMakeLists.txt
===
--- clang/tools/CMakeLists.txt
+++ clang/tools/CMakeLists.txt
@@ -14,7 +14,9 @@
 add_clang_subdirectory(clang-offload-bundler)
 add_clang_subdirectory(clang-offload-wrapper)
 add_clang_subdirectory(clang-scan-deps)
-add_clang_subdirectory(clang-repl)
+if(HAVE_CLANG_REPL_SUPPORT)
+