[PATCH] D130826: [clang-tools-extra] Fixed a number of typos
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0ed2bd9311fd: [clang-tools-extra] Fixed a number of typos
(authored by GabrielRavier, committed by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130826/new/
https://reviews.llvm.org/D130826
Files:
clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.h
clang-tools-extra/clangd/CodeComplete.h
clang-tools-extra/clangd/ConfigFragment.h
clang-tools-extra/clangd/DumpAST.cpp
clang-tools-extra/clangd/HeuristicResolver.cpp
clang-tools-extra/clangd/IncludeCleaner.cpp
clang-tools-extra/clangd/InlayHints.cpp
clang-tools-extra/clangd/Quality.cpp
clang-tools-extra/clangd/SemanticHighlighting.cpp
clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp
clang-tools-extra/clangd/index/CanonicalIncludes.h
clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
clang-tools-extra/clangd/unittests/XRefsTests.cpp
clang-tools-extra/pseudo/gen/Main.cpp
clang-tools-extra/pseudo/lib/cxx/cxx.bnf
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp
Index: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp
===
--- clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp
+++ clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp
@@ -143,7 +143,7 @@
// CHECK-FIXES: virtual ~PublicNonVirtualBaseClass() {}
};
-class PublicNonVirtualNonBaseClass { // OK accoring to C.35, since this class does not have any virtual methods.
+class PublicNonVirtualNonBaseClass { // OK according to C.35, since this class does not have any virtual methods.
void f();
public:
Index: clang-tools-extra/pseudo/lib/cxx/cxx.bnf
===
--- clang-tools-extra/pseudo/lib/cxx/cxx.bnf
+++ clang-tools-extra/pseudo/lib/cxx/cxx.bnf
@@ -1,7 +1,7 @@
# This is a C++ grammar from the C++ standard [1].
#
# The grammar is a superset of the true grammar requring semantic constraints to
-# resolve ambiguties. The grammar is context-free and ambiguous (beyond the
+# resolve ambiguities. The grammar is context-free and ambiguous (beyond the
# limit of LR(k)). We use general parsing algorithm (e.g GLR) to handle the
# grammar and generate a transition table which is used to drive the parsing.
#
Index: clang-tools-extra/pseudo/gen/Main.cpp
===
--- clang-tools-extra/pseudo/gen/Main.cpp
+++ clang-tools-extra/pseudo/gen/Main.cpp
@@ -65,7 +65,7 @@
// Mangles a symbol name into a valid identifier.
//
// These follow names in the grammar fairly closely:
-// nonterminal: `ptr-declartor` becomes `ptr_declarator`;
+// nonterminal: `ptr-declarator` becomes `ptr_declarator`;
// punctuator: `,` becomes `COMMA`;
// keyword: `INT` becomes `INT`;
// terminal: `IDENTIFIER` becomes `IDENTIFIER`;
Index: clang-tools-extra/clangd/unittests/XRefsTests.cpp
===
--- clang-tools-extra/clangd/unittests/XRefsTests.cpp
+++ clang-tools-extra/clangd/unittests/XRefsTests.cpp
@@ -1801,7 +1801,7 @@
}
}
-TEST(FindImplementations, CaptureDefintion) {
+TEST(FindImplementations, CaptureDefinition) {
llvm::StringRef Test = R"cpp(
struct Base {
virtual void F^oo();
Index: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
===
--- clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
+++ clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
@@ -1035,7 +1035,7 @@
// Starts handling the update action and blocks until the
// first preamble is built.
ASTAction::RunningAction,
- // Afterwqards it builds an AST for that preamble to publish
+ // Afterwards it builds an AST for that preamble to publish
// diagnostics.
ASTAction::Building,
// Then goes idle.
Index: clang-tools-extra/clangd/index/CanonicalIncludes.h
===
--- clang-tools-extra/clangd/index/CanonicalIncludes.h
+++ clang-tools-extra/clangd/index/CanonicalIncludes.h
@@ -78,7 +78,7 @@
/// - export: this is common and potentially interesting, there are three cases:
///* Points to a public header (common): we can suppress include2 if you
/// already have include1. Only marginally useful.
-///* Points to a private header annotated with `private` (somewhat commmon):
+///* Points to a private header annotated with `private` (somewhat common):
/// No
[PATCH] D130826: [clang-tools-extra] Fixed a number of typos
GabrielRavier added a comment. Well I'm pretty sure I don't have commit rights to LLVM and it seems landing means to push the revision onto main, so that would be nice, yes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130826/new/ https://reviews.llvm.org/D130826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D130826: [clang-tools-extra] Fixed a number of typos
kadircet added a comment. also LMK if I should land this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130826/new/ https://reviews.llvm.org/D130826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D130826: [clang-tools-extra] Fixed a number of typos
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130826/new/ https://reviews.llvm.org/D130826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D130826: [clang-tools-extra] Fixed a number of typos
GabrielRavier created this revision.
Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman,
javed.absar, kbarton, nemanjai.
Herald added a project: All.
GabrielRavier requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
I went over the output of the following mess of a command:
`(ulimit -m 200; ulimit -v 200; git ls-files -z | parallel --xargs -0
cat | aspell list --mode=none --ignore-case | grep -E '^[A-Za-z][a-z]*$' | sort
| uniq -c | sort -n | grep -vE '.{25}' | aspell pipe -W3 | grep : | cut -d' '
-f2 | less)`
and proceeded to spend a few days looking at it to find probable typos
and fixed a few hundred of them in all of the llvm project (note, the
ones I found are not anywhere near all of them, but it seems like a
good start).
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D130826
Files:
clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.h
clang-tools-extra/clangd/CodeComplete.h
clang-tools-extra/clangd/ConfigFragment.h
clang-tools-extra/clangd/DumpAST.cpp
clang-tools-extra/clangd/HeuristicResolver.cpp
clang-tools-extra/clangd/IncludeCleaner.cpp
clang-tools-extra/clangd/InlayHints.cpp
clang-tools-extra/clangd/Quality.cpp
clang-tools-extra/clangd/SemanticHighlighting.cpp
clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp
clang-tools-extra/clangd/index/CanonicalIncludes.h
clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
clang-tools-extra/clangd/unittests/XRefsTests.cpp
clang-tools-extra/pseudo/gen/Main.cpp
clang-tools-extra/pseudo/lib/cxx/cxx.bnf
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp
Index: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp
===
--- clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp
+++ clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp
@@ -143,7 +143,7 @@
// CHECK-FIXES: virtual ~PublicNonVirtualBaseClass() {}
};
-class PublicNonVirtualNonBaseClass { // OK accoring to C.35, since this class does not have any virtual methods.
+class PublicNonVirtualNonBaseClass { // OK according to C.35, since this class does not have any virtual methods.
void f();
public:
Index: clang-tools-extra/pseudo/lib/cxx/cxx.bnf
===
--- clang-tools-extra/pseudo/lib/cxx/cxx.bnf
+++ clang-tools-extra/pseudo/lib/cxx/cxx.bnf
@@ -1,7 +1,7 @@
# This is a C++ grammar from the C++ standard [1].
#
# The grammar is a superset of the true grammar requring semantic constraints to
-# resolve ambiguties. The grammar is context-free and ambiguous (beyond the
+# resolve ambiguities. The grammar is context-free and ambiguous (beyond the
# limit of LR(k)). We use general parsing algorithm (e.g GLR) to handle the
# grammar and generate a transition table which is used to drive the parsing.
#
Index: clang-tools-extra/pseudo/gen/Main.cpp
===
--- clang-tools-extra/pseudo/gen/Main.cpp
+++ clang-tools-extra/pseudo/gen/Main.cpp
@@ -65,7 +65,7 @@
// Mangles a symbol name into a valid identifier.
//
// These follow names in the grammar fairly closely:
-// nonterminal: `ptr-declartor` becomes `ptr_declarator`;
+// nonterminal: `ptr-declarator` becomes `ptr_declarator`;
// punctuator: `,` becomes `COMMA`;
// keyword: `INT` becomes `INT`;
// terminal: `IDENTIFIER` becomes `IDENTIFIER`;
Index: clang-tools-extra/clangd/unittests/XRefsTests.cpp
===
--- clang-tools-extra/clangd/unittests/XRefsTests.cpp
+++ clang-tools-extra/clangd/unittests/XRefsTests.cpp
@@ -1801,7 +1801,7 @@
}
}
-TEST(FindImplementations, CaptureDefintion) {
+TEST(FindImplementations, CaptureDefinition) {
llvm::StringRef Test = R"cpp(
struct Base {
virtual void F^oo();
Index: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
===
--- clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
+++ clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
@@ -1035,7 +1035,7 @@
// Starts handling the update action and blocks until the
// first preamble is built.
ASTAction::RunningAction,
- // Afterwqards it builds an AST for that preamble to publish
+ // Afterwards it builds an AST for that preamble to publish
// diagnostics.
ASTAction::Building,
// Then goes idle.
Index: clang-tools-extra/clangd/index/CanonicalIncludes.h
===
