[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test
azat abandoned this revision. azat added a comment. Closed in favor of https://reviews.llvm.org/D133875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133847/new/ https://reviews.llvm.org/D133847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test
azat added a comment. > Perhaps lld[^"]*" would be better? But yeah, this looks better anyway. Applied your suggestion. New revision - https://reviews.llvm.org/D133875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133847/new/ https://reviews.llvm.org/D133847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test
azat added a comment. > Presumably this would break if someone's build uses a tool suffix (so lld > becomes lld-tot or something like that)? Perhaps lld[^"]*" would be better? I thought about this too, but I found this in another test, so likely it should work... > Are there other test cases that test something similar that we could look at > to see how they work/more likely get something that works as well? This one is copied from `clang/test/Driver/debug-options-lld.c` Anyway I need to resubmit the initial patch since it got reverted. But I don't see close button here, only trusted users can do this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133847/new/ https://reviews.llvm.org/D133847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test
dblaikie added a comment. Presumably this would break if someone's build uses a tool suffix (so lld becomes lld-tot or something like that)? Perhaps `lld[^"]*"` would be better? Are there other test cases that test something similar that we could look at to see how they work/more likely get something that works as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133847/new/ https://reviews.llvm.org/D133847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test
azat added a comment. Can someone pick this please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133847/new/ https://reviews.llvm.org/D133847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test
azat created this revision.
azat added reviewers: hokein, dblaikie.
Herald added a project: All.
azat requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Now, when the filename contains lld, it does not filter correctly.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D133847
Files:
clang/test/Driver/debug-options-lld.c
Index: clang/test/Driver/debug-options-lld.c
===
--- clang/test/Driver/debug-options-lld.c
+++ clang/test/Driver/debug-options-lld.c
@@ -8,5 +8,5 @@
// RUN: %clang -### -target x86_64-unknown-linux -fuse-ld=lld -flto=thin
-gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LLDGARANGE %s
//
// GARANGE-DAG: -generate-arange-section
-// LDGARANGE-NOT: {{".*lld.*"}} {{.*}} "-generate-arange-section"
-// LLDGARANGE: {{".*lld.*"}} {{.*}} "-generate-arange-section"
+// LDGARANGE-NOT: {{"[^"]*lld(\.exe){0,1}".*}} {{.*}}
"-generate-arange-section"
+// LLDGARANGE: {{"[^"]*lld(\.exe){0,1}".*}} {{.*}} "-generate-arange-section"
Index: clang/test/Driver/debug-options-lld.c
===
--- clang/test/Driver/debug-options-lld.c
+++ clang/test/Driver/debug-options-lld.c
@@ -8,5 +8,5 @@
// RUN: %clang -### -target x86_64-unknown-linux -fuse-ld=lld -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LLDGARANGE %s
//
// GARANGE-DAG: -generate-arange-section
-// LDGARANGE-NOT: {{".*lld.*"}} {{.*}} "-generate-arange-section"
-// LLDGARANGE: {{".*lld.*"}} {{.*}} "-generate-arange-section"
+// LDGARANGE-NOT: {{"[^"]*lld(\.exe){0,1}".*}} {{.*}} "-generate-arange-section"
+// LLDGARANGE: {{"[^"]*lld(\.exe){0,1}".*}} {{.*}} "-generate-arange-section"
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
