[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6bca52be0349: [Clang] update cxx_dr_status.html by running
make_cxx_dr_status (authored by ychen).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136133/new/
https://reviews.llvm.org/D136133
Files:
clang/test/CXX/drs/dr25xx.cpp
clang/test/CXX/drs/dr2xx.cpp
clang/www/cxx_dr_status.html
clang/www/make_cxx_dr_status
Index: clang/www/make_cxx_dr_status
===
--- clang/www/make_cxx_dr_status
+++ clang/www/make_cxx_dr_status
@@ -91,7 +91,7 @@
Available in Clang?
''')
-latest_release = 13
+latest_release = 15
def availability(issue):
status = status_map.get(issue, 'unknown')
@@ -158,7 +158,10 @@
# This refers to the old ("C++0x") concepts feature, which was not part
# of any C++ International Standard or Technical Specification.
continue
- if dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
+ if dr.issue in (1432,2565):
+row_style = ' class="open"'
+avail, avail_style = availability(dr.issue)
+ elif dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
# We may have to deal with these some day, but not yet.
row_style = ' class="open"'
if dr.status == 'extension':
@@ -182,7 +185,7 @@
''' % (row_style, dr.issue, dr.issue, dr.issue, dr.status, dr.title, avail_style, avail))
for status, num in sorted(count.items()):
- print("%s: %s" % (status, num))
+ print("%s: %s" % (status, num), file=sys.stderr)
out_file.write('''\
Index: clang/www/cxx_dr_status.html
===
--- clang/www/cxx_dr_status.html
+++ clang/www/cxx_dr_status.html
@@ -1383,7 +1383,7 @@
https://wg21.link/cwg224";>224
CD1
Definition of dependent names
-No
+Clang 16
https://wg21.link/cwg225";>225
@@ -7650,7 +7650,7 @@
https://wg21.link/cwg1307";>1307
C++14
Overload resolution based on size of array initializer-list
-Clang 14
+Clang 14
https://wg21.link/cwg1308";>1308
@@ -8172,7 +8172,7 @@
https://wg21.link/cwg1394";>1394
CD3
Incomplete types as parameters of deleted functions
-Clang 15
+Clang 15
https://wg21.link/cwg1395";>1395
@@ -8400,7 +8400,7 @@
https://wg21.link/cwg1432";>1432
open
Newly-ambiguous variadic template expansions
-Not resolved
+Clang 16
https://wg21.link/cwg1433";>1433
@@ -10380,7 +10380,7 @@
https://wg21.link/cwg1762";>1762
C++14
Reserved identifier used in literal-operator-id example
-Clang 14
+Clang 14
https://wg21.link/cwg1763";>1763
@@ -10440,7 +10440,7 @@
https://wg21.link/cwg1772";>1772
C++14
__func__ in a lambda body
-Clang 14
+Clang 14
https://wg21.link/cwg1773";>1773
@@ -10482,7 +10482,7 @@
https://wg21.link/cwg1779";>1779
CD4
Type dependency of __func__
-Clang 14
+Clang 14
https://wg21.link/cwg1780";>1780
@@ -12834,7 +12834,7 @@
https://wg21.link/cwg2171";>2171
CD4
Triviality of copy constructor with less-qualified parameter
-Clang 15
+Clang 15
https://wg21.link/cwg2172";>2172
@@ -13932,7 +13932,7 @@
https://wg21.link/cwg2354";>2354
CD5
Extended alignment and object representation
-Clang 15
+Clang 15
https://wg21.link/cwg2355";>2355
@@ -14172,7 +14172,7 @@
https://wg21.link/cwg2394";>2394
CD5
Const-default-constructible for members
-Clang 15
+Clang 15
https://wg21.link/cwg2395";>2395
@@ -15198,7 +15198,7 @@
https://wg21.link/cwg2565";>2565
open
Invalid types in the parameter-declaration-clause of a requires-expression
-Clang 16
+Clang 16
https://wg21.link/cwg2566";>2566
Index: clang/test/CXX/drs/dr2xx.cpp
===
--- clang/test/CXX/drs/dr2xx.cpp
+++ clang/test/CXX/drs/dr2xx.cpp
@@ -243,7 +243,7 @@
// dr223: na
-namespace dr224 { // dr224: yes
+namespace dr224 { // dr224: 16
namespace example1 {
template class A {
typedef int type;
Index: clang/test/CXX/drs/dr25xx.cpp
===
--- clang/test/CXX/drs/dr25xx.cpp
+++ clang/test/CXX/drs/dr25xx.cpp
@@ -1,6 +1,6 @@
// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify
-namespace dr2565 { // dr252: 16
+namespace dr2565 { // dr2565: 16
template
concept C = requires (typename T::type x) {
x + 1;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. SGTM with teh changes discussed above Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136133/new/ https://reviews.llvm.org/D136133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status
ychen updated this revision to Diff 468631.
ychen added a comment.
- DR2565 is fully implemented.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136133/new/
https://reviews.llvm.org/D136133
Files:
clang/test/CXX/drs/dr25xx.cpp
clang/test/CXX/drs/dr2xx.cpp
clang/www/cxx_dr_status.html
clang/www/make_cxx_dr_status
Index: clang/www/make_cxx_dr_status
===
--- clang/www/make_cxx_dr_status
+++ clang/www/make_cxx_dr_status
@@ -91,7 +91,7 @@
Available in Clang?
''')
-latest_release = 13
+latest_release = 15
def availability(issue):
status = status_map.get(issue, 'unknown')
@@ -158,7 +158,10 @@
# This refers to the old ("C++0x") concepts feature, which was not part
# of any C++ International Standard or Technical Specification.
continue
- if dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
+ if dr.issue in (1432,2565):
+row_style = ' class="open"'
+avail, avail_style = availability(dr.issue)
+ elif dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
# We may have to deal with these some day, but not yet.
row_style = ' class="open"'
if dr.status == 'extension':
@@ -182,7 +185,7 @@
''' % (row_style, dr.issue, dr.issue, dr.issue, dr.status, dr.title, avail_style, avail))
for status, num in sorted(count.items()):
- print("%s: %s" % (status, num))
+ print("%s: %s" % (status, num), file=sys.stderr)
out_file.write('''\
Index: clang/www/cxx_dr_status.html
===
--- clang/www/cxx_dr_status.html
+++ clang/www/cxx_dr_status.html
@@ -1383,7 +1383,7 @@
https://wg21.link/cwg224";>224
CD1
Definition of dependent names
-No
+Clang 16
https://wg21.link/cwg225";>225
@@ -7650,7 +7650,7 @@
https://wg21.link/cwg1307";>1307
C++14
Overload resolution based on size of array initializer-list
-Clang 14
+Clang 14
https://wg21.link/cwg1308";>1308
@@ -8172,7 +8172,7 @@
https://wg21.link/cwg1394";>1394
CD3
Incomplete types as parameters of deleted functions
-Clang 15
+Clang 15
https://wg21.link/cwg1395";>1395
@@ -8400,7 +8400,7 @@
https://wg21.link/cwg1432";>1432
open
Newly-ambiguous variadic template expansions
-Not resolved
+Clang 16
https://wg21.link/cwg1433";>1433
@@ -10380,7 +10380,7 @@
https://wg21.link/cwg1762";>1762
C++14
Reserved identifier used in literal-operator-id example
-Clang 14
+Clang 14
https://wg21.link/cwg1763";>1763
@@ -10440,7 +10440,7 @@
https://wg21.link/cwg1772";>1772
C++14
__func__ in a lambda body
-Clang 14
+Clang 14
https://wg21.link/cwg1773";>1773
@@ -10482,7 +10482,7 @@
https://wg21.link/cwg1779";>1779
CD4
Type dependency of __func__
-Clang 14
+Clang 14
https://wg21.link/cwg1780";>1780
@@ -12834,7 +12834,7 @@
https://wg21.link/cwg2171";>2171
CD4
Triviality of copy constructor with less-qualified parameter
-Clang 15
+Clang 15
https://wg21.link/cwg2172";>2172
@@ -13932,7 +13932,7 @@
https://wg21.link/cwg2354";>2354
CD5
Extended alignment and object representation
-Clang 15
+Clang 15
https://wg21.link/cwg2355";>2355
@@ -14172,7 +14172,7 @@
https://wg21.link/cwg2394";>2394
CD5
Const-default-constructible for members
-Clang 15
+Clang 15
https://wg21.link/cwg2395";>2395
@@ -15198,7 +15198,7 @@
https://wg21.link/cwg2565";>2565
open
Invalid types in the parameter-declaration-clause of a requires-expression
-Clang 16
+Clang 16
https://wg21.link/cwg2566";>2566
Index: clang/test/CXX/drs/dr2xx.cpp
===
--- clang/test/CXX/drs/dr2xx.cpp
+++ clang/test/CXX/drs/dr2xx.cpp
@@ -243,7 +243,7 @@
// dr223: na
-namespace dr224 { // dr224: yes
+namespace dr224 { // dr224: 16
namespace example1 {
template class A {
typedef int type;
Index: clang/test/CXX/drs/dr25xx.cpp
===
--- clang/test/CXX/drs/dr25xx.cpp
+++ clang/test/CXX/drs/dr25xx.cpp
@@ -1,6 +1,6 @@
// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify
-namespace dr2565 { // dr252: 16
+namespace dr2565 { // dr2565: 16
template
concept C = requires (typename T::type x) {
x + 1;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status
ychen added inline comments.
Comment at: clang/test/CXX/drs/dr25xx.cpp:3
-namespace dr2565 { // dr252: 16
+namespace dr2565 { // dr2565: partial
template
erichkeane wrote:
> If you could add a comment explaining this status for me, I would be grateful:
>
> // We've implemented DR2565 as proposed (that is, a substitution failure in a
> requires parameter list causes the requires clause to evaluate as false) as
> it seems to make the most sense, and fit best into our implementation. If
> this issue gets accepted as-is, this can be marked as complete.
You said `we were in a position where we had 1/2 of it implemented`. So I put
it as partial. I must've misunderstood you. Will change it back.
Comment at: clang/www/make_cxx_dr_status:161
continue
- if dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
+ if dr.issue in (1432,2565):
+row_style = ' class="open"'
erichkeane wrote:
> I guess this is OK, its a shame we have to custom-tag these, but I guess I'm
> 1/2 responsible here :/
Yeah, it looks hacky. If the list gets larger, we could do something like
`namespace dr1432 { // dr1432: open 16` to make it more general.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136133/new/
https://reviews.llvm.org/D136133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status
erichkeane added a comment.
Thank you so much for doing this. I'm hopeful our hackery can go away sometime
soon.
Comment at: clang/test/CXX/drs/dr25xx.cpp:3
-namespace dr2565 { // dr252: 16
+namespace dr2565 { // dr2565: partial
template
If you could add a comment explaining this status for me, I would be grateful:
// We've implemented DR2565 as proposed (that is, a substitution failure in a
requires parameter list causes the requires clause to evaluate as false) as it
seems to make the most sense, and fit best into our implementation. If this
issue gets accepted as-is, this can be marked as complete.
Comment at: clang/www/make_cxx_dr_status:161
continue
- if dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
+ if dr.issue in (1432,2565):
+row_style = ' class="open"'
I guess this is OK, its a shame we have to custom-tag these, but I guess I'm
1/2 responsible here :/
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136133/new/
https://reviews.llvm.org/D136133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status
ychen updated this revision to Diff 468430.
ychen added a comment.
- rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136133/new/
https://reviews.llvm.org/D136133
Files:
clang/test/CXX/drs/dr25xx.cpp
clang/test/CXX/drs/dr2xx.cpp
clang/www/cxx_dr_status.html
clang/www/make_cxx_dr_status
Index: clang/www/make_cxx_dr_status
===
--- clang/www/make_cxx_dr_status
+++ clang/www/make_cxx_dr_status
@@ -91,7 +91,7 @@
Available in Clang?
''')
-latest_release = 13
+latest_release = 15
def availability(issue):
status = status_map.get(issue, 'unknown')
@@ -158,7 +158,10 @@
# This refers to the old ("C++0x") concepts feature, which was not part
# of any C++ International Standard or Technical Specification.
continue
- if dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
+ if dr.issue in (1432,2565):
+row_style = ' class="open"'
+avail, avail_style = availability(dr.issue)
+ elif dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
# We may have to deal with these some day, but not yet.
row_style = ' class="open"'
if dr.status == 'extension':
@@ -182,7 +185,7 @@
''' % (row_style, dr.issue, dr.issue, dr.issue, dr.status, dr.title, avail_style, avail))
for status, num in sorted(count.items()):
- print("%s: %s" % (status, num))
+ print("%s: %s" % (status, num), file=sys.stderr)
out_file.write('''\
Index: clang/www/cxx_dr_status.html
===
--- clang/www/cxx_dr_status.html
+++ clang/www/cxx_dr_status.html
@@ -1383,7 +1383,7 @@
https://wg21.link/cwg224";>224
CD1
Definition of dependent names
-No
+Clang 16
https://wg21.link/cwg225";>225
@@ -7650,7 +7650,7 @@
https://wg21.link/cwg1307";>1307
C++14
Overload resolution based on size of array initializer-list
-Clang 14
+Clang 14
https://wg21.link/cwg1308";>1308
@@ -8172,7 +8172,7 @@
https://wg21.link/cwg1394";>1394
CD3
Incomplete types as parameters of deleted functions
-Clang 15
+Clang 15
https://wg21.link/cwg1395";>1395
@@ -8400,7 +8400,7 @@
https://wg21.link/cwg1432";>1432
open
Newly-ambiguous variadic template expansions
-Not resolved
+Clang 16
https://wg21.link/cwg1433";>1433
@@ -10380,7 +10380,7 @@
https://wg21.link/cwg1762";>1762
C++14
Reserved identifier used in literal-operator-id example
-Clang 14
+Clang 14
https://wg21.link/cwg1763";>1763
@@ -10440,7 +10440,7 @@
https://wg21.link/cwg1772";>1772
C++14
__func__ in a lambda body
-Clang 14
+Clang 14
https://wg21.link/cwg1773";>1773
@@ -10482,7 +10482,7 @@
https://wg21.link/cwg1779";>1779
CD4
Type dependency of __func__
-Clang 14
+Clang 14
https://wg21.link/cwg1780";>1780
@@ -12834,7 +12834,7 @@
https://wg21.link/cwg2171";>2171
CD4
Triviality of copy constructor with less-qualified parameter
-Clang 15
+Clang 15
https://wg21.link/cwg2172";>2172
@@ -13932,7 +13932,7 @@
https://wg21.link/cwg2354";>2354
CD5
Extended alignment and object representation
-Clang 15
+Clang 15
https://wg21.link/cwg2355";>2355
@@ -14172,7 +14172,7 @@
https://wg21.link/cwg2394";>2394
CD5
Const-default-constructible for members
-Clang 15
+Clang 15
https://wg21.link/cwg2395";>2395
@@ -15198,7 +15198,7 @@
https://wg21.link/cwg2565";>2565
open
Invalid types in the parameter-declaration-clause of a requires-expression
-Clang 16
+Partial
https://wg21.link/cwg2566";>2566
Index: clang/test/CXX/drs/dr2xx.cpp
===
--- clang/test/CXX/drs/dr2xx.cpp
+++ clang/test/CXX/drs/dr2xx.cpp
@@ -243,7 +243,7 @@
// dr223: na
-namespace dr224 { // dr224: yes
+namespace dr224 { // dr224: 16
namespace example1 {
template class A {
typedef int type;
Index: clang/test/CXX/drs/dr25xx.cpp
===
--- clang/test/CXX/drs/dr25xx.cpp
+++ clang/test/CXX/drs/dr25xx.cpp
@@ -1,6 +1,6 @@
// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify
-namespace dr2565 { // dr252: 16
+namespace dr2565 { // dr2565: partial
template
concept C = requires (typename T::type x) {
x + 1;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status
ychen created this revision.
ychen added reviewers: royjacobson, erichkeane.
Herald added a project: All.
ychen requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
For https://github.com/llvm/llvm-project/issues/58382
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D136133
Files:
clang/test/CXX/drs/dr25xx.cpp
clang/test/CXX/drs/dr2xx.cpp
clang/www/cxx_dr_status.html
clang/www/make_cxx_dr_status
Index: clang/www/make_cxx_dr_status
===
--- clang/www/make_cxx_dr_status
+++ clang/www/make_cxx_dr_status
@@ -91,7 +91,7 @@
Available in Clang?
''')
-latest_release = 13
+latest_release = 15
def availability(issue):
status = status_map.get(issue, 'unknown')
@@ -158,7 +158,10 @@
# This refers to the old ("C++0x") concepts feature, which was not part
# of any C++ International Standard or Technical Specification.
continue
- if dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
+ if dr.issue in (1432,2565):
+row_style = ' class="open"'
+avail, avail_style = availability(dr.issue)
+ elif dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
# We may have to deal with these some day, but not yet.
row_style = ' class="open"'
if dr.status == 'extension':
@@ -182,7 +185,7 @@
''' % (row_style, dr.issue, dr.issue, dr.issue, dr.status, dr.title, avail_style, avail))
for status, num in sorted(count.items()):
- print("%s: %s" % (status, num))
+ print("%s: %s" % (status, num), file=sys.stderr)
out_file.write('''\
Index: clang/www/cxx_dr_status.html
===
--- clang/www/cxx_dr_status.html
+++ clang/www/cxx_dr_status.html
@@ -1383,7 +1383,7 @@
https://wg21.link/cwg224";>224
CD1
Definition of dependent names
-No
+Clang 16
https://wg21.link/cwg225";>225
@@ -7650,7 +7650,7 @@
https://wg21.link/cwg1307";>1307
C++14
Overload resolution based on size of array initializer-list
-Clang 14
+Clang 14
https://wg21.link/cwg1308";>1308
@@ -8172,7 +8172,7 @@
https://wg21.link/cwg1394";>1394
CD3
Incomplete types as parameters of deleted functions
-Clang 15
+Clang 15
https://wg21.link/cwg1395";>1395
@@ -8400,7 +8400,7 @@
https://wg21.link/cwg1432";>1432
open
Newly-ambiguous variadic template expansions
-Not resolved
+Clang 16
https://wg21.link/cwg1433";>1433
@@ -10380,7 +10380,7 @@
https://wg21.link/cwg1762";>1762
C++14
Reserved identifier used in literal-operator-id example
-Clang 14
+Clang 14
https://wg21.link/cwg1763";>1763
@@ -10440,7 +10440,7 @@
https://wg21.link/cwg1772";>1772
C++14
__func__ in a lambda body
-Clang 14
+Clang 14
https://wg21.link/cwg1773";>1773
@@ -10482,7 +10482,7 @@
https://wg21.link/cwg1779";>1779
CD4
Type dependency of __func__
-Clang 14
+Clang 14
https://wg21.link/cwg1780";>1780
@@ -12834,7 +12834,7 @@
https://wg21.link/cwg2171";>2171
CD4
Triviality of copy constructor with less-qualified parameter
-Clang 15
+Clang 15
https://wg21.link/cwg2172";>2172
@@ -13836,7 +13836,7 @@
https://wg21.link/cwg2338";>2338
CD5
Undefined behavior converting to short enums with fixed underlying types
-Clang 16
+Clang 12
https://wg21.link/cwg2339";>2339
@@ -13932,7 +13932,7 @@
https://wg21.link/cwg2354";>2354
CD5
Extended alignment and object representation
-Clang 15
+Clang 15
https://wg21.link/cwg2355";>2355
@@ -14172,7 +14172,7 @@
https://wg21.link/cwg2394";>2394
CD5
Const-default-constructible for members
-Clang 15
+Clang 15
https://wg21.link/cwg2395";>2395
@@ -15198,7 +15198,7 @@
https://wg21.link/cwg2565";>2565
open
Invalid types in the parameter-declaration-clause of a requires-expression
-Clang 16
+Partial
https://wg21.link/cwg2566";>2566
Index: clang/test/CXX/drs/dr2xx.cpp
===
--- clang/test/CXX/drs/dr2xx.cpp
+++ clang/test/CXX/drs/dr2xx.cpp
@@ -243,7 +243,7 @@
// dr223: na
-namespace dr224 { // dr224: yes
+namespace dr224 { // dr224: 16
namespace example1 {
template class A {
typedef int type;
Index: clang/test/CXX/drs/dr25xx.cpp
===
--- clang/test/CXX/drs/dr25xx.cpp
+++ clang/test/CXX/drs/dr25xx.cpp
@@ -1,6 +1,6 @@
// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify
-namespace dr2565 { // dr252: 16
+namespace dr2565 { // dr2565: partial
template
concept C = requires (typename T::type x) {
x + 1;
