[PATCH] D138391: clang/HIP: Add new header test for math IR gen

[Matt Arsenault via Phabricator via cfe-commits]

arsenm closed this revision.
arsenm added a comment.

2edafe8393fa7c9ad2e95d691191469adb7bf4b0 



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138391/new/

https://reviews.llvm.org/D138391

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138391: clang/HIP: Add new header test for math IR gen

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl accepted this revision.
yaxunl added a comment.

LGTM. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138391/new/

https://reviews.llvm.org/D138391

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138391: clang/HIP: Add new header test for math IR gen

[Jon Chesterfield via Phabricator via cfe-commits]

JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

Good call adding this test, thanks.

I think some of the skipping is glibc quirk related and some was to avoid 
clobbering the user's namespace for openmp. The math header defines various 
functions at global scope which can collide with user symbols. In practice that 
may not be a big deal.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138391/new/

https://reviews.llvm.org/D138391

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits