Re: [PATCH] D13891: Apply modernize-use-default to llvm.

2016-09-26 Thread Eugene Zelenko via cfe-commits 
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.

Looks like patch was not committed.


https://reviews.llvm.org/D13891



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13891: Apply modernize-use-default to llvm.

2015-10-27 Thread Benjamin Kramer via cfe-commits 
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.

Two minor comments, otherwise looks good:

1. beware of the GCC 4.7 issues and trivial class initializer issues we hit 
with this kind of changes earlier.
2. I prefer to leave utils/unittest/googletest alone as it's imported from 
google code. Changing it makes merging upstream changes harder.
3. Please leave the comments inside empty constructors or destructors.


http://reviews.llvm.org/D13891



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13891: Apply modernize-use-default to llvm.

2015-10-20 Thread Manuel Klimek via cfe-commits 
klimek added a reviewer: bkramer.
klimek added a comment.

+benjamin, who has been doing those changes lately...


http://reviews.llvm.org/D13891



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits