[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize

[Guillaume Chatelet via Phabricator via cfe-commits]

gchatelet closed this revision.
gchatelet added a comment.

So i've submitted the following patches which remove the usage of 
`TypeSize::getFixedSize()` and `TypeSize::getKnownMinSize()`

- rG6916ebd02650 
: 
[clang][NFC] Use the TypeSize::getXXXValue() instead of 
TypeSize::getXXXSize).Wed, Jan 11, 5:08 PM
- rGca8485578652 
: 
[mlir][NFC] Use TypeSize::getFixedValue() instead of 
TypeSize::getFixedSize().Wed, Jan 11, 5:22 PM
- rGfbd207fd6f6b 
: [NFC] 
Use TypeSize::getKnownMinValue() instead of TypeSize::getKnownMinSize().Wed, 
Jan 11, 5:29 PM
- rG48f5d77eeed4 
: [NFC] 
Use TypeSize::getKnownMinValue() instead of TypeSize::getKnownMinSize().Wed, 
Jan 11, 5:37 PM
- rG8fd5558b2976 
: [NFC] 
Use TypeSize::geFixedValue() instead of TypeSize::getFixedSize().Wed, Jan 11, 
5:49 PM

I've also marked the functions deprecated so downstream users can fix their 
codebase.

- rG1dcaa2bdf230 
: Marking 
TypeSize getFixedSize() and getKnownMinSize() deprecated.

I'm marking this patch as closed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141134/new/

https://reviews.llvm.org/D141134

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize

[Guillaume Chatelet via Phabricator via cfe-commits]

gchatelet added a comment.

I've created https://reviews.llvm.org/D141267 to get a feel of what it looks 
like to only keep the Size version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141134/new/

https://reviews.llvm.org/D141134

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize

[Guillaume Chatelet via Phabricator via cfe-commits]

gchatelet updated this revision to Diff 487339.
gchatelet added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

- Fix missing clang change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141134/new/

https://reviews.llvm.org/D141134

Files:
  clang/lib/CodeGen/CGDecl.cpp
  llvm/include/llvm/Support/TypeSize.h
  llvm/lib/Analysis/ConstantFolding.cpp
  llvm/lib/Analysis/Loads.cpp
  llvm/lib/CodeGen/Analysis.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/StackProtector.cpp
  llvm/lib/IR/DataLayout.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
  llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp
  llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
  llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
  llvm/utils/TableGen/CodeGenDAGPatterns.cpp

Index: llvm/utils/TableGen/CodeGenDAGPatterns.cpp
===
--- llvm/utils/TableGen/CodeGenDAGPatterns.cpp
+++ llvm/utils/TableGen/CodeGenDAGPatterns.cpp
@@ -764,8 +764,8 @@
 namespace {
 struct TypeSizeComparator {
   bool operator()(const TypeSize &LHS, const TypeSize &RHS) const {
-return std::make_tuple(LHS.isScalable(), LHS.getKnownMinValue()) <
-   std::make_tuple(RHS.isScalable(), RHS.getKnownMinValue());
+return std::make_tuple(LHS.isScalable(), LHS.getKnownMinSize()) <
+   std::make_tuple(RHS.isScalable(), RHS.getKnownMinSize());
   }
 };
 } // end anonymous namespace
Index: llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
===
--- llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
+++ llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
@@ -543,7 +543,7 @@
   if (!isAligned(I->getAlign(), Off))
 return false;
 
-  NeededDerefBytes = std::max(NeededDerefBytes, Off + Size.getFixedValue());
+  NeededDerefBytes = std::max(NeededDerefBytes, Off + Size.getFixedSize());
   NeededAlign = std::max(NeededAlign, I->getAlign());
 }
 
Index: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
===
--- llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
+++ llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
@@ -990,7 +990,7 @@
 unsigned RISCVTTIImpl::getEstimatedVLFor(VectorType *Ty) {
   if (isa(Ty)) {
 const unsigned EltSize = DL.getTypeSizeInBits(Ty->getElementType());
-const unsigned MinSize = DL.getTypeSizeInBits(Ty).getKnownMinValue();
+const unsigned MinSize = DL.getTypeSizeInBits(Ty).getKnownMinSize();
 const unsigned VectorBits = *getVScaleForTuning() * RISCV::RVVBitsPerBlock;
 return RISCVTargetLowering::computeVLMAX(VectorBits, EltSize, MinSize);
   }
@@ -1455,7 +1455,7 @@
   TypeSize Size = DL.getTypeSizeInBits(Ty);
   if (Ty->isVectorTy()) {
 if (Size.isScalable() && ST->hasVInstructions())
-  return divideCeil(Size.getKnownMinValue(), RISCV::RVVBitsPerBlock);
+  return divideCeil(Size.getKnownMinSize(), RISCV::RVVBitsPerBlock);
 
 if (ST->useRVVForFixedLengthVectors())
   return divideCeil(Size, ST->getRealMinVLen());
Index: llvm/lib/Target/RISCV/RISCVISelLowering.cpp
===
--- llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -138,7 +138,7 @@
   if (VT.getVectorMinNumElements() < MinElts)
 return;
 
-  unsigned Size = VT.getSizeInBits().getKnownMinValue();
+  unsigned Size = VT.getSizeInBits().getKnownMinSize();
   const TargetRegisterClass *RC;
   if (Size <= RISCV::RVVBitsPerBlock)
 RC = &RISCV::VRRegClass;
@@ -1589,7 +1589,7 @@
 
 RISCVII::VLMUL RISCVTargetLowering::getLMUL(MVT VT) {
   assert(VT.isScalableVector() && "Expecting a scalable vector type");
-  unsigned KnownSize = VT.getSizeInBits().getKnownMinValue();
+  unsigned KnownSize = VT.getSizeInBits().getKnownMinSize();
   if (VT.getVectorElementType() == MVT::i1)
 KnownSize *= 8;
 
@@ -5443,7 +5443,7 @@
 // Optimize for constant AVL
 if (isa(AVL)) {
   unsigned EltSize = VT.getScalarSizeInBits();
-  unsigned MinSize = VT.getSizeInBits().getKnownMinValue();
+  unsigned MinSize = VT.getSizeInBits().getKnownMinSize();
 
   unsigned VectorBitsMax = Subtarget.getRealMaxVLen();
   unsigned MaxVLMAX =
@@ -6419,7 +6419,7 @@
 return DAG.getNode(ISD::TRUNCATE, DL, VecVT, Op2);
   }
   unsigned EltSize = VecVT.getScalarSizeInBits();
-  unsigned MinSize = VecVT.getSizeInBits().getKnownMinValue();
+  unsigned MinSize = VecVT.getSizeInBits().getKnownMinSize();
   unsigned VectorBitsMax = Subtarget.getRealMaxVLen();
   unsigned MaxVLMAX =
 RISCVTargetLowering::computeVLMAX(VectorBitsMax, EltSize, MinSize);
Index: llvm/lib