[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

2023-05-04 Thread Job Noorman via Phabricator via cfe-commits 
jobnoorman added a comment.

In D148767#4316464 , @chapuni wrote:

> In D148767#4315667 , @jobnoorman 
> wrote:
>
>> Hi, this seems to have broken my bolt+debug+shared build. I don't think 
>> there are build bots for this configuration but you can reproduce it like 
>> this:
>
> Sorry for inconvenience. Could you add `CodeGenTypes` in `LINK_COMPONENTS` 
> please?

No worries. It feels a bit wrong though to have to add transitive dependencies 
to `LINK_COMPONENTS`.

My build is also fixed by moving the implementation of `LLT::dump` to a .cpp 
file. Would it be an option to apply the following patch?

F27324556: llt-link-fix.patch 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

2023-05-03 Thread NAKAMURA Takumi via Phabricator via cfe-commits 
chapuni added a comment.

Please come in; 
https://discourse.llvm.org/t/rfc-let-mvt-generated-and-restore-mvt-into-llvm-codegen/69547/3


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

2023-05-03 Thread Sergei Barannikov via Phabricator via cfe-commits 
barannikov88 added a comment.

In D148767#4316464 , @chapuni wrote:

> In D148767#4312692 , @barannikov88 
> wrote:
>
>> Sorry, I don't follow. They may theoretically depend on anything. Why 
>> CodeGen/CodeGenTypes, specifically?
>> If they don't require it, why add it?
>
> I added deps pessimistically, "This depends on CodeGenTypes if LowLevelType.h 
> is included".

Sorry if I was not being clear. Dependencies are harmful and should be avoided 
wherever possible. 
They should not be added "just in case". Now when I want to build just llvm-mc 
I have to build half of the whole stack.
Although D148769  improves the situation, it 
does not justify adding these dependencies.
Your RFC was about dependencies, so I think you understand my concern.
Please try to remove them and only keep the ones that are really necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

2023-05-03 Thread NAKAMURA Takumi via Phabricator via cfe-commits 
chapuni added a comment.

In D148767#4312692 , @barannikov88 
wrote:

> Sorry, I don't follow. They may theoretically depend on anything. Why 
> CodeGen/CodeGenTypes, specifically?
> If they don't require it, why add it?

I added deps pessimistically, "This depends on CodeGenTypes if LowLevelType.h 
is included".

In D148767#4315667 , @jobnoorman 
wrote:

> Hi, this seems to have broken my bolt+debug+shared build. I don't think there 
> are build bots for this configuration but you can reproduce it like this:

Sorry for inconvenience. Could you add `CodeGenTypes` in `LINK_COMPONENTS` 
please?

In D148767#4315757 , @vzakhari wrote:

> I can add `CodeGenTypes` link component in 
> `flang/lib/Optimizer/Transforms/CMakeLists.txt`, but I am worried about the 
> comment in `llvm/lib/CodeGen/CMakeLists.txt`:
>
>   # Be careful to append deps on this, since Targets' tablegens depend on 
> this.
>   add_llvm_component_library(LLVMCodeGenTypes
>
> I am not sure whether I need to be careful about adding dependencies onto 
> `LLVMCodeGenTypes` (as I am planning to do) or about adding dependencies for 
> `LLVMCodeGenTypes` target in `llvm/lib/CodeGen/CMakeLists.txt` :)

The latter. Excuse my wrong wording.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

2023-05-03 Thread Slava Zakharin via Phabricator via cfe-commits 
vzakhari added a comment.

In D148767#4315667 , @jobnoorman 
wrote:

> Hi, this seems to have broken my bolt+debug+shared build. I don't think there 
> are build bots for this configuration but you can reproduce it like this:

Same with flang+debug+shared build:

  ld.lld: error: undefined symbol: llvm::LLT::print(llvm::raw_ostream&) const
  >>> referenced by LowLevelType.h:269 
(/llvm-project/llvm/include/llvm/CodeGen/LowLevelType.h:269)
  >>>   
CMakeFiles/obj.FIRTransforms.dir/SimplifyIntrinsics.cpp.o:(llvm::LLT::dump() 
const)

I can add `CodeGenTypes` link component in 
`flang/lib/Optimizer/Transforms/CMakeLists.txt`, but I am worried about the 
comment in `llvm/lib/CodeGen/CMakeLists.txt`:

  # Be careful to append deps on this, since Targets' tablegens depend on this.
  add_llvm_component_library(LLVMCodeGenTypes

I am not sure whether I need to be careful about adding dependencies onto 
`LLVMCodeGenTypes` (as I am planning to do) or about adding dependencies for 
`LLVMCodeGenTypes` target in `llvm/lib/CodeGen/CMakeLists.txt` :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

2023-05-03 Thread Job Noorman via Phabricator via cfe-commits 
jobnoorman added a comment.

Hi, this seems to have broken my bolt+debug+shared build. I don't think there 
are build bots for this configuration but you can reproduce it like this:

  cmake -G Ninja -DCMAKE_BUILD_TYPE="Debug" \
 -DLLVM_ENABLE_PROJECTS="clang;lld;bolt" \
 -DBUILD_SHARED_LIBS=True \
 -DLLVM_BUILD_TESTS=True \
 -DLLVM_CCACHE_BUILD=ON \
 -DLLVM_ENABLE_LLD=True \
 -DLLVM_TARGETS_TO_BUILD="X86;RISCV;AArch64" \
 -DLLVM_APPEND_VC_REV=False ../llvm

And this is the linker error:

  ld.lld: error: undefined symbol: llvm::LLT::print(llvm::raw_ostream&) const
  >>> referenced by LowLevelType.h:269 
(/.../llvm-project/llvm/include/llvm/CodeGen/LowLevelType.h:269)
  >>>   
tools/bolt/lib/Passes/CMakeFiles/LLVMBOLTPasses.dir/AsmDump.cpp.o:(llvm::LLT::dump()
 const)
  collect2: error: ld returned 1 exit status


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

2023-05-02 Thread Sergei Barannikov via Phabricator via cfe-commits 
barannikov88 added a comment.

In D148767#4311589 , @chapuni wrote:

> In D148767#4311564 , @barannikov88 
> wrote:
>
>> Adding CodeGen dependency to MCTargetDesc/AsmParser/Disassembler does not 
>> seem right. Why is it necessary?
>
> This commit shows they may depend on `CodeGen` theoretically and actually 
> (but not efficient)
> I will decouple again in D148769 .

Sorry, I don't follow. They may theoretically depend on anything. Why 
CodeGen/CodeGenTypes, specifically?
If they don't require it, why add it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

2023-05-02 Thread NAKAMURA Takumi via Phabricator via cfe-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9cfeba5b12b6: Restore CodeGen/LowLevelType from `Support` 
(authored by chapuni).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

Files:
  clang/lib/CodeGen/CMakeLists.txt
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
  llvm/include/llvm/CodeGen/GlobalISel/InstructionSelector.h
  llvm/include/llvm/CodeGen/GlobalISel/LegacyLegalizerInfo.h
  llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
  llvm/include/llvm/CodeGen/GlobalISel/Utils.h
  llvm/include/llvm/CodeGen/LowLevelType.h
  llvm/include/llvm/CodeGen/LowLevelTypeUtils.h
  llvm/include/llvm/CodeGen/MachineMemOperand.h
  llvm/include/llvm/CodeGen/RegisterBankInfo.h
  llvm/include/llvm/Support/LowLevelTypeImpl.h
  llvm/include/llvm/module.modulemap
  llvm/lib/CodeGen/CMakeLists.txt
  llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
  llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp
  llvm/lib/CodeGen/LowLevelType.cpp
  llvm/lib/CodeGen/MIRParser/MIParser.cpp
  llvm/lib/CodeGen/MIRPrinter.cpp
  llvm/lib/CodeGen/MachineInstr.cpp
  llvm/lib/CodeGen/MachineVerifier.cpp
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/LowLevelType.cpp
  llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt
  llvm/lib/Target/AArch64/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AMDGPU/AMDGPUGlobalISelUtils.cpp
  llvm/lib/Target/AMDGPU/AsmParser/CMakeLists.txt
  llvm/lib/Target/AMDGPU/Disassembler/CMakeLists.txt
  llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt
  llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AMDGPU/Utils/CMakeLists.txt
  llvm/lib/Target/ARC/Disassembler/CMakeLists.txt
  llvm/lib/Target/ARM/ARMCallLowering.cpp
  llvm/lib/Target/ARM/AsmParser/CMakeLists.txt
  llvm/lib/Target/ARM/Disassembler/CMakeLists.txt
  llvm/lib/Target/ARM/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AVR/AsmParser/CMakeLists.txt
  llvm/lib/Target/AVR/Disassembler/CMakeLists.txt
  llvm/lib/Target/CSKY/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/Lanai/AsmParser/CMakeLists.txt
  llvm/lib/Target/Lanai/Disassembler/CMakeLists.txt
  llvm/lib/Target/M68k/AsmParser/CMakeLists.txt
  llvm/lib/Target/M68k/Disassembler/CMakeLists.txt
  llvm/lib/Target/MSP430/AsmParser/CMakeLists.txt
  llvm/lib/Target/Mips/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/Mips/MCTargetDesc/MipsABIInfo.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/RISCV/MCA/CMakeLists.txt
  llvm/lib/Target/SPIRV/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/SystemZ/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/VE/AsmParser/CMakeLists.txt
  llvm/lib/Target/VE/Disassembler/CMakeLists.txt
  llvm/lib/Target/VE/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/WebAssembly/AsmParser/CMakeLists.txt
  llvm/lib/Target/WebAssembly/Disassembler/CMakeLists.txt
  llvm/lib/Target/WebAssembly/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/X86/MCA/CMakeLists.txt
  llvm/lib/Target/X86/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/X86/X86CallLowering.cpp
  llvm/lib/Target/X86/X86InstructionSelector.cpp
  llvm/lib/Target/XCore/Disassembler/CMakeLists.txt
  llvm/tools/llvm-dwarfutil/CMakeLists.txt
  llvm/tools/llvm-exegesis/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/Mips/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/PowerPC/CMakeLists.txt
  llvm/unittests/CodeGen/MachineOperandTest.cpp
  llvm/unittests/DebugInfo/DWARF/CMakeLists.txt
  llvm/utils/TableGen/CMakeLists.txt
  llvm/utils/TableGen/GlobalISel/CMakeLists.txt
  llvm/utils/TableGen/GlobalISelEmitter.cpp
  utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

Index: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
===
--- utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -616,6 +616,7 @@
 features = ["-header_modules"],
 strip_include_prefix = "utils/TableGen",
 deps = [
+":CodeGen",
 ":Support",
 ":TableGen",
 ":config",
@@ -642,11 +643,11 @@
 copts = llvm_copts,
 stamp = 0,
 deps = [
+":CodeGen",
 ":Support",
 ":TableGen",
 ":TableGenGlobalISel",
 ":config",
-":intrinsic_enums_gen",
 ":llvm-tblgen-headers",
 ],
 )
@@ -2336,6 +2337,7 @@
 copts = llvm_copts,
 features = ["-layering_check"],
 deps = [
+":CodeGen",
 ":MC",
 ":MCA",
 ":MCParser",
@@ -3404,6 +3406,7 @@
 deps = [
 ":AllTargetsAsmParsers",
 ":AllTargetsCodeGens",
+":CodeGen",
 ":DWARFLinker",
 ":DebugInfoDWARF",
 ":DwarfutilOptionsTableGen",
@@ -3444,6 +3447,7 @@
 ":AllTargetsAsmParsers",

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

2023-05-02 Thread NAKAMURA Takumi via Phabricator via cfe-commits 
chapuni updated this revision to Diff 518713.
chapuni retitled this revision from "Restore CodeGen/LowLevelType" to "Restore 
CodeGen/LowLevelType from `Support`".
chapuni edited the summary of this revision.
chapuni added a comment.

- Rebase and update the desc


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

Files:
  clang/lib/CodeGen/CMakeLists.txt
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
  llvm/include/llvm/CodeGen/GlobalISel/InstructionSelector.h
  llvm/include/llvm/CodeGen/GlobalISel/LegacyLegalizerInfo.h
  llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
  llvm/include/llvm/CodeGen/GlobalISel/Utils.h
  llvm/include/llvm/CodeGen/LowLevelType.h
  llvm/include/llvm/CodeGen/LowLevelTypeUtils.h
  llvm/include/llvm/CodeGen/MachineMemOperand.h
  llvm/include/llvm/CodeGen/RegisterBankInfo.h
  llvm/include/llvm/Support/LowLevelTypeImpl.h
  llvm/include/llvm/module.modulemap
  llvm/lib/CodeGen/CMakeLists.txt
  llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
  llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp
  llvm/lib/CodeGen/LowLevelType.cpp
  llvm/lib/CodeGen/MIRParser/MIParser.cpp
  llvm/lib/CodeGen/MIRPrinter.cpp
  llvm/lib/CodeGen/MachineInstr.cpp
  llvm/lib/CodeGen/MachineVerifier.cpp
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/LowLevelType.cpp
  llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt
  llvm/lib/Target/AArch64/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AMDGPU/AMDGPUGlobalISelUtils.cpp
  llvm/lib/Target/AMDGPU/AsmParser/CMakeLists.txt
  llvm/lib/Target/AMDGPU/Disassembler/CMakeLists.txt
  llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt
  llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AMDGPU/Utils/CMakeLists.txt
  llvm/lib/Target/ARC/Disassembler/CMakeLists.txt
  llvm/lib/Target/ARM/ARMCallLowering.cpp
  llvm/lib/Target/ARM/AsmParser/CMakeLists.txt
  llvm/lib/Target/ARM/Disassembler/CMakeLists.txt
  llvm/lib/Target/ARM/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AVR/AsmParser/CMakeLists.txt
  llvm/lib/Target/AVR/Disassembler/CMakeLists.txt
  llvm/lib/Target/CSKY/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/Lanai/AsmParser/CMakeLists.txt
  llvm/lib/Target/Lanai/Disassembler/CMakeLists.txt
  llvm/lib/Target/M68k/AsmParser/CMakeLists.txt
  llvm/lib/Target/M68k/Disassembler/CMakeLists.txt
  llvm/lib/Target/MSP430/AsmParser/CMakeLists.txt
  llvm/lib/Target/Mips/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/Mips/MCTargetDesc/MipsABIInfo.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/RISCV/MCA/CMakeLists.txt
  llvm/lib/Target/SPIRV/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/SystemZ/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/VE/AsmParser/CMakeLists.txt
  llvm/lib/Target/VE/Disassembler/CMakeLists.txt
  llvm/lib/Target/VE/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/WebAssembly/AsmParser/CMakeLists.txt
  llvm/lib/Target/WebAssembly/Disassembler/CMakeLists.txt
  llvm/lib/Target/WebAssembly/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/X86/MCA/CMakeLists.txt
  llvm/lib/Target/X86/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/X86/X86CallLowering.cpp
  llvm/lib/Target/X86/X86InstructionSelector.cpp
  llvm/lib/Target/XCore/Disassembler/CMakeLists.txt
  llvm/tools/llvm-dwarfutil/CMakeLists.txt
  llvm/tools/llvm-exegesis/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/Mips/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/PowerPC/CMakeLists.txt
  llvm/unittests/CodeGen/MachineOperandTest.cpp
  llvm/unittests/DebugInfo/DWARF/CMakeLists.txt
  llvm/utils/TableGen/CMakeLists.txt
  llvm/utils/TableGen/GlobalISel/CMakeLists.txt
  llvm/utils/TableGen/GlobalISelEmitter.cpp
  utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

Index: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
===
--- utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -616,6 +616,7 @@
 features = ["-header_modules"],
 strip_include_prefix = "utils/TableGen",
 deps = [
+":CodeGen",
 ":Support",
 ":TableGen",
 ":config",
@@ -642,11 +643,11 @@
 copts = llvm_copts,
 stamp = 0,
 deps = [
+":CodeGen",
 ":Support",
 ":TableGen",
 ":TableGenGlobalISel",
 ":config",
-":intrinsic_enums_gen",
 ":llvm-tblgen-headers",
 ],
 )
@@ -2336,6 +2337,7 @@
 copts = llvm_copts,
 features = ["-layering_check"],
 deps = [
+":CodeGen",
 ":MC",
 ":MCA",
 ":MCParser",
@@ -3404,6 +3406,7 @@
 deps = [
 ":AllTargetsAsmParsers",
 ":AllTargetsCodeGens",
+":CodeGen",
 ":DWARFLinker",
 ":DebugInfoDWARF",
 ":DwarfutilOptionsTableGen",
@@ -3444,6 +3447,7 @@

[PATCH] D148767: Restore CodeGen/LowLevelType

2023-05-01 Thread NAKAMURA Takumi via Phabricator via cfe-commits 
chapuni added a comment.

In D148767#4311529 , @MaskRay wrote:

> Add some information why this is restored? Assume that people may not read 
> the depended patches (`Depends on D145937, D146352, and D148768.`).

Yes sure. This was just an isolated diff with similar changes at first.

In D148767#4311564 , @barannikov88 
wrote:

> Adding CodeGen dependency to MCTargetDesc/AsmParser/Disassembler does not 
> seem right. Why is it necessary?

This commit shows they may depend on `CodeGen` theoretically and actually (but 
not efficient)
I will decouple again in D148769 .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148767: Restore CodeGen/LowLevelType

2023-05-01 Thread Sergei Barannikov via Phabricator via cfe-commits 
barannikov88 added a comment.

Adding CodeGen dependency to MCTargetDesc layer does not seem right. Why is it 
necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148767: Restore CodeGen/LowLevelType

2023-05-01 Thread Fangrui Song via Phabricator via cfe-commits 
MaskRay added a comment.

> This is rework of;
>
> D30046  (LLT)

Add some information why this is restored? Assume that people may not read the 
depended patches (`Depends on D145937, D146352, and D148768.`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148767: Restore CodeGen/LowLevelType

2023-04-26 Thread NAKAMURA Takumi via Phabricator via cfe-commits 
chapuni updated this revision to Diff 517193.
chapuni added a comment.

- Rebase


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

Files:
  clang/lib/CodeGen/CMakeLists.txt
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
  llvm/include/llvm/CodeGen/GlobalISel/InstructionSelector.h
  llvm/include/llvm/CodeGen/GlobalISel/LegacyLegalizerInfo.h
  llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
  llvm/include/llvm/CodeGen/GlobalISel/Utils.h
  llvm/include/llvm/CodeGen/LowLevelType.h
  llvm/include/llvm/CodeGen/LowLevelTypeUtils.h
  llvm/include/llvm/CodeGen/MachineMemOperand.h
  llvm/include/llvm/CodeGen/RegisterBankInfo.h
  llvm/include/llvm/Support/LowLevelTypeImpl.h
  llvm/include/llvm/module.modulemap
  llvm/lib/CodeGen/CMakeLists.txt
  llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
  llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp
  llvm/lib/CodeGen/LowLevelType.cpp
  llvm/lib/CodeGen/MIRParser/MIParser.cpp
  llvm/lib/CodeGen/MIRPrinter.cpp
  llvm/lib/CodeGen/MachineInstr.cpp
  llvm/lib/CodeGen/MachineVerifier.cpp
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/LowLevelType.cpp
  llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt
  llvm/lib/Target/AArch64/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AMDGPU/AMDGPUGlobalISelUtils.cpp
  llvm/lib/Target/AMDGPU/AsmParser/CMakeLists.txt
  llvm/lib/Target/AMDGPU/Disassembler/CMakeLists.txt
  llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt
  llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AMDGPU/Utils/CMakeLists.txt
  llvm/lib/Target/ARC/Disassembler/CMakeLists.txt
  llvm/lib/Target/ARM/ARMCallLowering.cpp
  llvm/lib/Target/ARM/AsmParser/CMakeLists.txt
  llvm/lib/Target/ARM/Disassembler/CMakeLists.txt
  llvm/lib/Target/ARM/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AVR/AsmParser/CMakeLists.txt
  llvm/lib/Target/AVR/Disassembler/CMakeLists.txt
  llvm/lib/Target/CSKY/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/Lanai/AsmParser/CMakeLists.txt
  llvm/lib/Target/Lanai/Disassembler/CMakeLists.txt
  llvm/lib/Target/M68k/AsmParser/CMakeLists.txt
  llvm/lib/Target/M68k/Disassembler/CMakeLists.txt
  llvm/lib/Target/MSP430/AsmParser/CMakeLists.txt
  llvm/lib/Target/Mips/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/Mips/MCTargetDesc/MipsABIInfo.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/RISCV/MCA/CMakeLists.txt
  llvm/lib/Target/SPIRV/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/SystemZ/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/VE/AsmParser/CMakeLists.txt
  llvm/lib/Target/VE/Disassembler/CMakeLists.txt
  llvm/lib/Target/VE/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/WebAssembly/AsmParser/CMakeLists.txt
  llvm/lib/Target/WebAssembly/Disassembler/CMakeLists.txt
  llvm/lib/Target/WebAssembly/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/X86/MCA/CMakeLists.txt
  llvm/lib/Target/X86/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/X86/X86CallLowering.cpp
  llvm/lib/Target/X86/X86InstructionSelector.cpp
  llvm/lib/Target/XCore/Disassembler/CMakeLists.txt
  llvm/tools/llvm-dwarfutil/CMakeLists.txt
  llvm/tools/llvm-exegesis/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/Mips/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/PowerPC/CMakeLists.txt
  llvm/unittests/CodeGen/MachineOperandTest.cpp
  llvm/unittests/DebugInfo/DWARF/CMakeLists.txt
  llvm/utils/TableGen/CMakeLists.txt
  llvm/utils/TableGen/GlobalISel/CMakeLists.txt
  llvm/utils/TableGen/GlobalISelEmitter.cpp
  utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

Index: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
===
--- utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -616,6 +616,7 @@
 features = ["-header_modules"],
 strip_include_prefix = "utils/TableGen",
 deps = [
+":CodeGen",
 ":Support",
 ":TableGen",
 ":config",
@@ -642,11 +643,11 @@
 copts = llvm_copts,
 stamp = 0,
 deps = [
+":CodeGen",
 ":Support",
 ":TableGen",
 ":TableGenGlobalISel",
 ":config",
-":intrinsic_enums_gen",
 ":llvm-tblgen-headers",
 ],
 )
@@ -2336,6 +2337,7 @@
 copts = llvm_copts,
 features = ["-layering_check"],
 deps = [
+":CodeGen",
 ":MC",
 ":MCA",
 ":MCParser",
@@ -3404,6 +3406,7 @@
 deps = [
 ":AllTargetsAsmParsers",
 ":AllTargetsCodeGens",
+":CodeGen",
 ":DWARFLinker",
 ":DebugInfoDWARF",
 ":DwarfutilOptionsTableGen",
@@ -3444,6 +3447,7 @@
 ":AllTargetsAsmParsers",
 ":AllTargetsCodeGens",
 ":AllTargetsDisassemblers",
+":CodeGen",
 ":Exegesis",
 ":MC",
 ":MCParser",

[PATCH] D148767: Restore CodeGen/LowLevelType

2023-04-23 Thread NAKAMURA Takumi via Phabricator via cfe-commits 
chapuni updated this revision to Diff 516177.
chapuni retitled this revision from "Restore MVT and LLT into llvm/CodeGen" to 
"Restore CodeGen/LowLevelType".
chapuni edited the summary of this revision.
chapuni added a comment.

- Split out


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767

Files:
  clang/lib/CodeGen/CMakeLists.txt
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
  llvm/include/llvm/CodeGen/GlobalISel/InstructionSelector.h
  llvm/include/llvm/CodeGen/GlobalISel/LegacyLegalizerInfo.h
  llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
  llvm/include/llvm/CodeGen/GlobalISel/Utils.h
  llvm/include/llvm/CodeGen/LowLevelType.h
  llvm/include/llvm/CodeGen/LowLevelTypeUtils.h
  llvm/include/llvm/CodeGen/MachineMemOperand.h
  llvm/include/llvm/CodeGen/RegisterBankInfo.h
  llvm/include/llvm/Support/LowLevelTypeImpl.h
  llvm/include/llvm/module.modulemap
  llvm/lib/CodeGen/CMakeLists.txt
  llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
  llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp
  llvm/lib/CodeGen/LowLevelType.cpp
  llvm/lib/CodeGen/MIRParser/MIParser.cpp
  llvm/lib/CodeGen/MIRPrinter.cpp
  llvm/lib/CodeGen/MachineInstr.cpp
  llvm/lib/CodeGen/MachineVerifier.cpp
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/LowLevelType.cpp
  llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt
  llvm/lib/Target/AArch64/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AMDGPU/AMDGPUGlobalISelUtils.cpp
  llvm/lib/Target/AMDGPU/AsmParser/CMakeLists.txt
  llvm/lib/Target/AMDGPU/Disassembler/CMakeLists.txt
  llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt
  llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AMDGPU/Utils/CMakeLists.txt
  llvm/lib/Target/ARC/Disassembler/CMakeLists.txt
  llvm/lib/Target/ARM/ARMCallLowering.cpp
  llvm/lib/Target/ARM/AsmParser/CMakeLists.txt
  llvm/lib/Target/ARM/Disassembler/CMakeLists.txt
  llvm/lib/Target/ARM/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/AVR/AsmParser/CMakeLists.txt
  llvm/lib/Target/AVR/Disassembler/CMakeLists.txt
  llvm/lib/Target/CSKY/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/Lanai/AsmParser/CMakeLists.txt
  llvm/lib/Target/Lanai/Disassembler/CMakeLists.txt
  llvm/lib/Target/M68k/AsmParser/CMakeLists.txt
  llvm/lib/Target/M68k/Disassembler/CMakeLists.txt
  llvm/lib/Target/MSP430/AsmParser/CMakeLists.txt
  llvm/lib/Target/Mips/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/Mips/MCTargetDesc/MipsABIInfo.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/RISCV/MCA/CMakeLists.txt
  llvm/lib/Target/SPIRV/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/SystemZ/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/VE/AsmParser/CMakeLists.txt
  llvm/lib/Target/VE/Disassembler/CMakeLists.txt
  llvm/lib/Target/VE/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/WebAssembly/AsmParser/CMakeLists.txt
  llvm/lib/Target/WebAssembly/Disassembler/CMakeLists.txt
  llvm/lib/Target/WebAssembly/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/X86/MCA/CMakeLists.txt
  llvm/lib/Target/X86/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/X86/X86CallLowering.cpp
  llvm/lib/Target/X86/X86InstructionSelector.cpp
  llvm/lib/Target/XCore/Disassembler/CMakeLists.txt
  llvm/tools/llvm-dwarfutil/CMakeLists.txt
  llvm/tools/llvm-exegesis/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/Mips/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/PowerPC/CMakeLists.txt
  llvm/unittests/CodeGen/MachineOperandTest.cpp
  llvm/unittests/DebugInfo/DWARF/CMakeLists.txt
  llvm/utils/TableGen/CMakeLists.txt
  llvm/utils/TableGen/GlobalISel/CMakeLists.txt
  llvm/utils/TableGen/GlobalISelEmitter.cpp
  utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

Index: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
===
--- utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -616,6 +616,7 @@
 features = ["-header_modules"],
 strip_include_prefix = "utils/TableGen",
 deps = [
+":CodeGen",
 ":Support",
 ":TableGen",
 ":config",
@@ -642,6 +643,7 @@
 copts = llvm_copts,
 stamp = 0,
 deps = [
+":CodeGen",
 ":Support",
 ":TableGen",
 ":TableGenGlobalISel",
@@ -2335,6 +2337,7 @@
 copts = llvm_copts,
 features = ["-layering_check"],
 deps = [
+":CodeGen",
 ":MC",
 ":MCA",
 ":MCParser",
@@ -3403,6 +3406,7 @@
 deps = [
 ":AllTargetsAsmParsers",
 ":AllTargetsCodeGens",
+":CodeGen",
 ":DWARFLinker",
 ":DebugInfoDWARF",
 ":DwarfutilOptionsTableGen",
@@ -3443,6 +3447,7 @@
 ":AllTargetsAsmParsers",
 ":AllTargetsCodeGens",
 ":AllTargetsDisassemblers",
+":CodeGen",