[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and adapt __bf16 to be arithmetic type

[Ties Stuij via Phabricator via cfe-commits]

stuij added a comment.

In D149573#4341323 , @codemzs wrote:

> @stuij, as you initially introduced `__bf16` as a storage-type, your review 
> on this adjustment would be greatly appreciated.

Sorry for the late reaction, was on holiday. Yes, I'll have a look. I've put it 
on my todo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149573/new/

https://reviews.llvm.org/D149573

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and adapt __bf16 to be arithmetic type

[M. Zeeshan Siddiqui via Phabricator via cfe-commits]

codemzs added a comment.

I have created a separate change to upgrade existing `__bf16` to arithmetic 
type at D150913 




Comment at: clang/lib/AST/Type.cpp:
+  return (BT->getKind() >= BuiltinType::Bool &&
+  BT->getKind() <= BuiltinType::Ibm128 &&
+  (BT->getKind() != BuiltinType::BFloat16 ||

Remove



Comment at: clang/lib/Basic/Targets/AMDGPU.h:122
+  const char *getBFloat16Mangling() const override { return "DF16b"; };
+  
   std::string_view getClobbers() const override { return ""; }

Remove


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149573/new/

https://reviews.llvm.org/D149573

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits