[PATCH] D14977: clang-tidy: code cleanup with isAssignmentOperator

[Daniel Marjamäki via cfe-commits]

danielmarjamaki created this revision.
danielmarjamaki added subscribers: cfe-commits, alexfh.

This is a small code cleanup. No change in logical behaviour is intended.

http://reviews.llvm.org/D14977

Files:
  clang-tidy/misc/AssertSideEffectCheck.cpp

Index: clang-tidy/misc/AssertSideEffectCheck.cpp
===
--- clang-tidy/misc/AssertSideEffectCheck.cpp
+++ clang-tidy/misc/AssertSideEffectCheck.cpp
@@ -33,11 +33,7 @@
   }
 
   if (const auto *Op = dyn_cast(E)) {
-BinaryOperator::Opcode OC = Op->getOpcode();
-return OC == BO_Assign || OC == BO_MulAssign || OC == BO_DivAssign ||
-   OC == BO_RemAssign || OC == BO_AddAssign || OC == BO_SubAssign ||
-   OC == BO_ShlAssign || OC == BO_ShrAssign || OC == BO_AndAssign ||
-   OC == BO_XorAssign || OC == BO_OrAssign;
+return Op->isAssignmentOp();
   }
 
   if (const auto *OpCallExpr = dyn_cast(E)) {


Index: clang-tidy/misc/AssertSideEffectCheck.cpp
===
--- clang-tidy/misc/AssertSideEffectCheck.cpp
+++ clang-tidy/misc/AssertSideEffectCheck.cpp
@@ -33,11 +33,7 @@
   }
 
   if (const auto *Op = dyn_cast(E)) {
-BinaryOperator::Opcode OC = Op->getOpcode();
-return OC == BO_Assign || OC == BO_MulAssign || OC == BO_DivAssign ||
-   OC == BO_RemAssign || OC == BO_AddAssign || OC == BO_SubAssign ||
-   OC == BO_ShlAssign || OC == BO_ShrAssign || OC == BO_AndAssign ||
-   OC == BO_XorAssign || OC == BO_OrAssign;
+return Op->isAssignmentOp();
   }
 
   if (const auto *OpCallExpr = dyn_cast(E)) {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14977: clang-tidy: code cleanup with isAssignmentOperator

[Daniel Marjamäki via cfe-commits]

danielmarjamaki closed this revision.
danielmarjamaki added a comment.

Committed with 254066.


http://reviews.llvm.org/D14977



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits