[PATCH] D150668: Add doc link to missing include diagnostics.

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

For the records: Fixed in 76941b68ecd9 
. Thanks 
for the quick fix!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150668/new/

https://reviews.llvm.org/D150668

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D150668: Add doc link to missing include diagnostics.

[Viktoriia Bakalova via cfe-commits]

Thanks, I'm on it. Should be fixed within minutes.

On Tue, May 16, 2023 at 6:47 PM Nico Weber via Phabricator <
revi...@reviews.llvm.org> wrote:

> thakis added a comment.
>
> This seems to break tests: http://45.33.8.238/linux/107099/step_9.txt
>
> Please take a look, and revert for now if it takes a while to fix.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D150668/new/
>
> https://reviews.llvm.org/D150668
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150668: Add doc link to missing include diagnostics.

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

This seems to break tests: http://45.33.8.238/linux/107099/step_9.txt

Please take a look, and revert for now if it takes a while to fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150668/new/

https://reviews.llvm.org/D150668

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150668: Add doc link to missing include diagnostics.

[Viktoriia Bakalova via Phabricator via cfe-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5cb2770bd714: Add doc link to missing include diagnostics. 
(authored by VitaNuo).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150668/new/

https://reviews.llvm.org/D150668

Files:
  clang-tools-extra/clangd/Diagnostics.cpp


Index: clang-tools-extra/clangd/Diagnostics.cpp
===
--- clang-tools-extra/clangd/Diagnostics.cpp
+++ clang-tools-extra/clangd/Diagnostics.cpp
@@ -918,7 +918,7 @@
 .str();
   }
   case Diag::Clangd:
-if (Name == "unused-includes")
+if (Name == "unused-includes" || Name == "missing-includes")
   return {"https://clangd.llvm.org/guides/include-cleaner"};
 break;
   case Diag::ClangdConfig:


Index: clang-tools-extra/clangd/Diagnostics.cpp
===
--- clang-tools-extra/clangd/Diagnostics.cpp
+++ clang-tools-extra/clangd/Diagnostics.cpp
@@ -918,7 +918,7 @@
 .str();
   }
   case Diag::Clangd:
-if (Name == "unused-includes")
+if (Name == "unused-includes" || Name == "missing-includes")
   return {"https://clangd.llvm.org/guides/include-cleaner"};
 break;
   case Diag::ClangdConfig:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150668: Add doc link to missing include diagnostics.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150668/new/

https://reviews.llvm.org/D150668

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150668: Add doc link to missing include diagnostics.

[Viktoriia Bakalova via Phabricator via cfe-commits]

VitaNuo created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
VitaNuo requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150668

Files:
  clang-tools-extra/clangd/Diagnostics.cpp


Index: clang-tools-extra/clangd/Diagnostics.cpp
===
--- clang-tools-extra/clangd/Diagnostics.cpp
+++ clang-tools-extra/clangd/Diagnostics.cpp
@@ -918,7 +918,7 @@
 .str();
   }
   case Diag::Clangd:
-if (Name == "unused-includes")
+if (Name == "unused-includes" || Name == "missing-includes")
   return {"https://clangd.llvm.org/guides/include-cleaner"};
 break;
   case Diag::ClangdConfig:


Index: clang-tools-extra/clangd/Diagnostics.cpp
===
--- clang-tools-extra/clangd/Diagnostics.cpp
+++ clang-tools-extra/clangd/Diagnostics.cpp
@@ -918,7 +918,7 @@
 .str();
   }
   case Diag::Clangd:
-if (Name == "unused-includes")
+if (Name == "unused-includes" || Name == "missing-includes")
   return {"https://clangd.llvm.org/guides/include-cleaner"};
 break;
   case Diag::ClangdConfig:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits