[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9877eca408e: [NFC] Initialize class member pointers to nullptr. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/ https://reviews.llvm.org/D153892 Files: clang/lib/ARCMigrate/TransProperties.cpp clang/lib/AST/ExprConstant.cpp clang/lib/Frontend/ASTConsumers.cpp clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp Index: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp === --- clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp +++ clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp @@ -29,7 +29,7 @@ class StackAddrEscapeChecker : public Checker, check::EndFunction> { - mutable IdentifierInfo *dispatch_semaphore_tII; + mutable IdentifierInfo *dispatch_semaphore_tII = nullptr; mutable std::unique_ptr BT_stackleak; mutable std::unique_ptr BT_returnstack; mutable std::unique_ptr BT_capturedstackasync; Index: clang/lib/Frontend/ASTConsumers.cpp === --- clang/lib/Frontend/ASTConsumers.cpp +++ clang/lib/Frontend/ASTConsumers.cpp @@ -183,21 +183,20 @@ /// ASTViewer - AST Visualization namespace { - class ASTViewer : public ASTConsumer { -ASTContext *Context; - public: -void Initialize(ASTContext ) override { - this->Context = -} +class ASTViewer : public ASTConsumer { + ASTContext *Context = nullptr; -bool HandleTopLevelDecl(DeclGroupRef D) override { - for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) -HandleTopLevelSingleDecl(*I); - return true; -} +public: + void Initialize(ASTContext ) override { this->Context = } -void HandleTopLevelSingleDecl(Decl *D); - }; + bool HandleTopLevelDecl(DeclGroupRef D) override { +for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) + HandleTopLevelSingleDecl(*I); +return true; + } + + void HandleTopLevelSingleDecl(Decl *D); +}; } void ASTViewer::HandleTopLevelSingleDecl(Decl *D) { Index: clang/lib/AST/ExprConstant.cpp === --- clang/lib/AST/ExprConstant.cpp +++ clang/lib/AST/ExprConstant.cpp @@ -583,7 +583,7 @@ /// LambdaCaptureFields - Mapping from captured variables/this to /// corresponding data members in the closure class. llvm::DenseMap LambdaCaptureFields; -FieldDecl *LambdaThisCaptureField; +FieldDecl *LambdaThisCaptureField = nullptr; CallStackFrame(EvalInfo , SourceLocation CallLoc, const FunctionDecl *Callee, const LValue *This, Index: clang/lib/ARCMigrate/TransProperties.cpp === --- clang/lib/ARCMigrate/TransProperties.cpp +++ clang/lib/ARCMigrate/TransProperties.cpp @@ -45,7 +45,7 @@ class PropertiesRewriter { MigrationContext MigrationPass - ObjCImplementationDecl *CurImplD; + ObjCImplementationDecl *CurImplD = nullptr; enum PropActionKind { PropAction_None, Index: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp === --- clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp +++ clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp @@ -29,7 +29,7 @@ class StackAddrEscapeChecker : public Checker, check::EndFunction> { - mutable IdentifierInfo *dispatch_semaphore_tII; + mutable IdentifierInfo *dispatch_semaphore_tII = nullptr; mutable std::unique_ptr BT_stackleak; mutable std::unique_ptr BT_returnstack; mutable std::unique_ptr BT_capturedstackasync; Index: clang/lib/Frontend/ASTConsumers.cpp === --- clang/lib/Frontend/ASTConsumers.cpp +++ clang/lib/Frontend/ASTConsumers.cpp @@ -183,21 +183,20 @@ /// ASTViewer - AST Visualization namespace { - class ASTViewer : public ASTConsumer { -ASTContext *Context; - public: -void Initialize(ASTContext ) override { - this->Context = -} +class ASTViewer : public ASTConsumer { + ASTContext *Context = nullptr; -bool HandleTopLevelDecl(DeclGroupRef D) override { - for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) -HandleTopLevelSingleDecl(*I); - return true; -} +public: + void Initialize(ASTContext ) override { this->Context = } -void HandleTopLevelSingleDecl(Decl *D); - }; + bool HandleTopLevelDecl(DeclGroupRef D) override { +for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) + HandleTopLevelSingleDecl(*I); +return true; + } + + void HandleTopLevelSingleDecl(Decl *D); +}; }
[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.
tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks, Sindhu! This looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/ https://reviews.llvm.org/D153892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.
schittir updated this revision to Diff 538851. schittir marked an inline comment as done. schittir added a comment. Fix format per comments - indent class members and avoid indenting the class definition line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/ https://reviews.llvm.org/D153892 Files: clang/lib/ARCMigrate/TransProperties.cpp clang/lib/AST/ExprConstant.cpp clang/lib/Frontend/ASTConsumers.cpp clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp Index: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp === --- clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp +++ clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp @@ -29,7 +29,7 @@ class StackAddrEscapeChecker : public Checker, check::EndFunction> { - mutable IdentifierInfo *dispatch_semaphore_tII; + mutable IdentifierInfo *dispatch_semaphore_tII = nullptr; mutable std::unique_ptr BT_stackleak; mutable std::unique_ptr BT_returnstack; mutable std::unique_ptr BT_capturedstackasync; Index: clang/lib/Frontend/ASTConsumers.cpp === --- clang/lib/Frontend/ASTConsumers.cpp +++ clang/lib/Frontend/ASTConsumers.cpp @@ -183,21 +183,20 @@ /// ASTViewer - AST Visualization namespace { - class ASTViewer : public ASTConsumer { -ASTContext *Context; - public: -void Initialize(ASTContext ) override { - this->Context = -} +class ASTViewer : public ASTConsumer { + ASTContext *Context = nullptr; -bool HandleTopLevelDecl(DeclGroupRef D) override { - for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) -HandleTopLevelSingleDecl(*I); - return true; -} +public: + void Initialize(ASTContext ) override { this->Context = } -void HandleTopLevelSingleDecl(Decl *D); - }; + bool HandleTopLevelDecl(DeclGroupRef D) override { +for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) + HandleTopLevelSingleDecl(*I); +return true; + } + + void HandleTopLevelSingleDecl(Decl *D); +}; } void ASTViewer::HandleTopLevelSingleDecl(Decl *D) { Index: clang/lib/AST/ExprConstant.cpp === --- clang/lib/AST/ExprConstant.cpp +++ clang/lib/AST/ExprConstant.cpp @@ -580,7 +580,7 @@ /// LambdaCaptureFields - Mapping from captured variables/this to /// corresponding data members in the closure class. llvm::DenseMap LambdaCaptureFields; -FieldDecl *LambdaThisCaptureField; +FieldDecl *LambdaThisCaptureField = nullptr; CallStackFrame(EvalInfo , SourceLocation CallLoc, const FunctionDecl *Callee, const LValue *This, Index: clang/lib/ARCMigrate/TransProperties.cpp === --- clang/lib/ARCMigrate/TransProperties.cpp +++ clang/lib/ARCMigrate/TransProperties.cpp @@ -45,7 +45,7 @@ class PropertiesRewriter { MigrationContext MigrationPass - ObjCImplementationDecl *CurImplD; + ObjCImplementationDecl *CurImplD = nullptr; enum PropActionKind { PropAction_None, Index: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp === --- clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp +++ clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp @@ -29,7 +29,7 @@ class StackAddrEscapeChecker : public Checker, check::EndFunction> { - mutable IdentifierInfo *dispatch_semaphore_tII; + mutable IdentifierInfo *dispatch_semaphore_tII = nullptr; mutable std::unique_ptr BT_stackleak; mutable std::unique_ptr BT_returnstack; mutable std::unique_ptr BT_capturedstackasync; Index: clang/lib/Frontend/ASTConsumers.cpp === --- clang/lib/Frontend/ASTConsumers.cpp +++ clang/lib/Frontend/ASTConsumers.cpp @@ -183,21 +183,20 @@ /// ASTViewer - AST Visualization namespace { - class ASTViewer : public ASTConsumer { -ASTContext *Context; - public: -void Initialize(ASTContext ) override { - this->Context = -} +class ASTViewer : public ASTConsumer { + ASTContext *Context = nullptr; -bool HandleTopLevelDecl(DeclGroupRef D) override { - for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) -HandleTopLevelSingleDecl(*I); - return true; -} +public: + void Initialize(ASTContext ) override { this->Context = } -void HandleTopLevelSingleDecl(Decl *D); - }; + bool HandleTopLevelDecl(DeclGroupRef D) override { +for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) + HandleTopLevelSingleDecl(*I); +return true; + } + + void HandleTopLevelSingleDecl(Decl *D); +}; } void ASTViewer::HandleTopLevelSingleDecl(Decl *D) { Index:
[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.
tahonermann requested changes to this revision. tahonermann added inline comments. This revision now requires changes to proceed. Herald added a subscriber: wangpc. Comment at: clang/lib/Frontend/ASTConsumers.cpp:192-198 + bool HandleTopLevelDecl(DeclGroupRef D) override { for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) HandleTopLevelSingleDecl(*I); return true; } void HandleTopLevelSingleDecl(Decl *D); Indentation is still inconsistent here. I suggest following the indentation used for `StackAddrEscapeChecker` in `clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp`; Don't indent the `ASTViewer` class definition within the unnamed namespace and do indent the class members. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/ https://reviews.llvm.org/D153892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.
schittir updated this revision to Diff 535459. schittir added a comment. Hope clang-format likes this patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/ https://reviews.llvm.org/D153892 Files: clang/lib/ARCMigrate/TransProperties.cpp clang/lib/AST/ExprConstant.cpp clang/lib/Frontend/ASTConsumers.cpp clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp Index: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp === --- clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp +++ clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp @@ -29,7 +29,7 @@ class StackAddrEscapeChecker : public Checker, check::EndFunction> { - mutable IdentifierInfo *dispatch_semaphore_tII; + mutable IdentifierInfo *dispatch_semaphore_tII = nullptr; mutable std::unique_ptr BT_stackleak; mutable std::unique_ptr BT_returnstack; mutable std::unique_ptr BT_capturedstackasync; Index: clang/lib/Frontend/ASTConsumers.cpp === --- clang/lib/Frontend/ASTConsumers.cpp +++ clang/lib/Frontend/ASTConsumers.cpp @@ -184,13 +184,12 @@ namespace { class ASTViewer : public ASTConsumer { -ASTContext *Context; - public: -void Initialize(ASTContext ) override { - this->Context = -} + ASTContext *Context = nullptr; + +public: + void Initialize(ASTContext ) override { this->Context = } -bool HandleTopLevelDecl(DeclGroupRef D) override { + bool HandleTopLevelDecl(DeclGroupRef D) override { for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) HandleTopLevelSingleDecl(*I); return true; Index: clang/lib/AST/ExprConstant.cpp === --- clang/lib/AST/ExprConstant.cpp +++ clang/lib/AST/ExprConstant.cpp @@ -580,7 +580,7 @@ /// LambdaCaptureFields - Mapping from captured variables/this to /// corresponding data members in the closure class. llvm::DenseMap LambdaCaptureFields; -FieldDecl *LambdaThisCaptureField; +FieldDecl *LambdaThisCaptureField = nullptr; CallStackFrame(EvalInfo , SourceLocation CallLoc, const FunctionDecl *Callee, const LValue *This, Index: clang/lib/ARCMigrate/TransProperties.cpp === --- clang/lib/ARCMigrate/TransProperties.cpp +++ clang/lib/ARCMigrate/TransProperties.cpp @@ -45,7 +45,7 @@ class PropertiesRewriter { MigrationContext MigrationPass - ObjCImplementationDecl *CurImplD; + ObjCImplementationDecl *CurImplD = nullptr; enum PropActionKind { PropAction_None, Index: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp === --- clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp +++ clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp @@ -29,7 +29,7 @@ class StackAddrEscapeChecker : public Checker, check::EndFunction> { - mutable IdentifierInfo *dispatch_semaphore_tII; + mutable IdentifierInfo *dispatch_semaphore_tII = nullptr; mutable std::unique_ptr BT_stackleak; mutable std::unique_ptr BT_returnstack; mutable std::unique_ptr BT_capturedstackasync; Index: clang/lib/Frontend/ASTConsumers.cpp === --- clang/lib/Frontend/ASTConsumers.cpp +++ clang/lib/Frontend/ASTConsumers.cpp @@ -184,13 +184,12 @@ namespace { class ASTViewer : public ASTConsumer { -ASTContext *Context; - public: -void Initialize(ASTContext ) override { - this->Context = -} + ASTContext *Context = nullptr; + +public: + void Initialize(ASTContext ) override { this->Context = } -bool HandleTopLevelDecl(DeclGroupRef D) override { + bool HandleTopLevelDecl(DeclGroupRef D) override { for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I) HandleTopLevelSingleDecl(*I); return true; Index: clang/lib/AST/ExprConstant.cpp === --- clang/lib/AST/ExprConstant.cpp +++ clang/lib/AST/ExprConstant.cpp @@ -580,7 +580,7 @@ /// LambdaCaptureFields - Mapping from captured variables/this to /// corresponding data members in the closure class. llvm::DenseMap LambdaCaptureFields; -FieldDecl *LambdaThisCaptureField; +FieldDecl *LambdaThisCaptureField = nullptr; CallStackFrame(EvalInfo , SourceLocation CallLoc, const FunctionDecl *Callee, const LValue *This, Index: clang/lib/ARCMigrate/TransProperties.cpp === --- clang/lib/ARCMigrate/TransProperties.cpp +++ clang/lib/ARCMigrate/TransProperties.cpp @@ -45,7 +45,7 @@ class PropertiesRewriter { MigrationContext
[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Test failure is clang-format on ASTConsumers.cpp. Fix that please (whatever it wants?) otherwise, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/ https://reviews.llvm.org/D153892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.
schittir created this revision. schittir added reviewers: aaron.ballman, erichkeane, tahonermann. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D153892 Files: clang/lib/ARCMigrate/TransProperties.cpp clang/lib/AST/ExprConstant.cpp clang/lib/Frontend/ASTConsumers.cpp clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp Index: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp === --- clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp +++ clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp @@ -29,7 +29,7 @@ class StackAddrEscapeChecker : public Checker, check::EndFunction> { - mutable IdentifierInfo *dispatch_semaphore_tII; + mutable IdentifierInfo *dispatch_semaphore_tII = nullptr; mutable std::unique_ptr BT_stackleak; mutable std::unique_ptr BT_returnstack; mutable std::unique_ptr BT_capturedstackasync; Index: clang/lib/Frontend/ASTConsumers.cpp === --- clang/lib/Frontend/ASTConsumers.cpp +++ clang/lib/Frontend/ASTConsumers.cpp @@ -184,7 +184,7 @@ namespace { class ASTViewer : public ASTConsumer { -ASTContext *Context; +ASTContext *Context = nullptr; public: void Initialize(ASTContext ) override { this->Context = Index: clang/lib/AST/ExprConstant.cpp === --- clang/lib/AST/ExprConstant.cpp +++ clang/lib/AST/ExprConstant.cpp @@ -580,7 +580,7 @@ /// LambdaCaptureFields - Mapping from captured variables/this to /// corresponding data members in the closure class. llvm::DenseMap LambdaCaptureFields; -FieldDecl *LambdaThisCaptureField; +FieldDecl *LambdaThisCaptureField = nullptr; CallStackFrame(EvalInfo , SourceLocation CallLoc, const FunctionDecl *Callee, const LValue *This, Index: clang/lib/ARCMigrate/TransProperties.cpp === --- clang/lib/ARCMigrate/TransProperties.cpp +++ clang/lib/ARCMigrate/TransProperties.cpp @@ -45,7 +45,7 @@ class PropertiesRewriter { MigrationContext MigrationPass - ObjCImplementationDecl *CurImplD; + ObjCImplementationDecl *CurImplD = nullptr; enum PropActionKind { PropAction_None, Index: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp === --- clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp +++ clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp @@ -29,7 +29,7 @@ class StackAddrEscapeChecker : public Checker, check::EndFunction> { - mutable IdentifierInfo *dispatch_semaphore_tII; + mutable IdentifierInfo *dispatch_semaphore_tII = nullptr; mutable std::unique_ptr BT_stackleak; mutable std::unique_ptr BT_returnstack; mutable std::unique_ptr BT_capturedstackasync; Index: clang/lib/Frontend/ASTConsumers.cpp === --- clang/lib/Frontend/ASTConsumers.cpp +++ clang/lib/Frontend/ASTConsumers.cpp @@ -184,7 +184,7 @@ namespace { class ASTViewer : public ASTConsumer { -ASTContext *Context; +ASTContext *Context = nullptr; public: void Initialize(ASTContext ) override { this->Context = Index: clang/lib/AST/ExprConstant.cpp === --- clang/lib/AST/ExprConstant.cpp +++ clang/lib/AST/ExprConstant.cpp @@ -580,7 +580,7 @@ /// LambdaCaptureFields - Mapping from captured variables/this to /// corresponding data members in the closure class. llvm::DenseMap LambdaCaptureFields; -FieldDecl *LambdaThisCaptureField; +FieldDecl *LambdaThisCaptureField = nullptr; CallStackFrame(EvalInfo , SourceLocation CallLoc, const FunctionDecl *Callee, const LValue *This, Index: clang/lib/ARCMigrate/TransProperties.cpp === --- clang/lib/ARCMigrate/TransProperties.cpp +++ clang/lib/ARCMigrate/TransProperties.cpp @@ -45,7 +45,7 @@ class PropertiesRewriter { MigrationContext MigrationPass - ObjCImplementationDecl *CurImplD; + ObjCImplementationDecl *CurImplD = nullptr; enum PropActionKind { PropAction_None, ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits