[PATCH] D155220: [IRGen] Remove 'Sve' from the name of some IR names that are shared with RISC-V now.

2023-07-17 Thread Craig Topper via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe8dc9dcd7df7: [IRGen] Remove Sve from the name 
of some IR names that are shared with RISC-V… (authored by craig.topper).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155220/new/

https://reviews.llvm.org/D155220

Files:
  clang/lib/CodeGen/CGCall.cpp
  clang/lib/CodeGen/CGExprScalar.cpp


Index: clang/lib/CodeGen/CGExprScalar.cpp
===
--- clang/lib/CodeGen/CGExprScalar.cpp
+++ clang/lib/CodeGen/CGExprScalar.cpp
@@ -2152,7 +2152,7 @@
   llvm::Value *UndefVec = llvm::UndefValue::get(DstTy);
   llvm::Value *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
   llvm::Value *Result = Builder.CreateInsertVector(
-  DstTy, UndefVec, Src, Zero, "castScalableSve");
+  DstTy, UndefVec, Src, Zero, "cast.scalable");
   if (NeedsBitCast)
 Result = Builder.CreateBitCast(Result, OrigType);
   return Result;
@@ -2176,7 +2176,7 @@
 }
 if (ScalableSrc->getElementType() == FixedDst->getElementType()) {
   llvm::Value *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
-  return Builder.CreateExtractVector(DstTy, Src, Zero, "castFixedSve");
+  return Builder.CreateExtractVector(DstTy, Src, Zero, "cast.fixed");
 }
   }
 }
Index: clang/lib/CodeGen/CGCall.cpp
===
--- clang/lib/CodeGen/CGCall.cpp
+++ clang/lib/CodeGen/CGCall.cpp
@@ -1311,7 +1311,7 @@
 auto *UndefVec = llvm::UndefValue::get(ScalableDst);
 auto *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
 llvm::Value *Result = CGF.Builder.CreateInsertVector(
-ScalableDst, UndefVec, Load, Zero, "castScalableSve");
+ScalableDst, UndefVec, Load, Zero, "cast.scalable");
 if (NeedsBitcast)
   Result = CGF.Builder.CreateBitCast(Result, OrigType);
 return Result;
@@ -3146,7 +3146,7 @@
 assert(NumIRArgs == 1);
 Coerced->setName(Arg->getName() + ".coerce");
 
ArgVals.push_back(ParamValue::forDirect(Builder.CreateExtractVector(
-VecTyTo, Coerced, Zero, "castFixedSve")));
+VecTyTo, Coerced, Zero, "cast.fixed")));
 break;
   }
 }


Index: clang/lib/CodeGen/CGExprScalar.cpp
===
--- clang/lib/CodeGen/CGExprScalar.cpp
+++ clang/lib/CodeGen/CGExprScalar.cpp
@@ -2152,7 +2152,7 @@
   llvm::Value *UndefVec = llvm::UndefValue::get(DstTy);
   llvm::Value *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
   llvm::Value *Result = Builder.CreateInsertVector(
-  DstTy, UndefVec, Src, Zero, "castScalableSve");
+  DstTy, UndefVec, Src, Zero, "cast.scalable");
   if (NeedsBitCast)
 Result = Builder.CreateBitCast(Result, OrigType);
   return Result;
@@ -2176,7 +2176,7 @@
 }
 if (ScalableSrc->getElementType() == FixedDst->getElementType()) {
   llvm::Value *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
-  return Builder.CreateExtractVector(DstTy, Src, Zero, "castFixedSve");
+  return Builder.CreateExtractVector(DstTy, Src, Zero, "cast.fixed");
 }
   }
 }
Index: clang/lib/CodeGen/CGCall.cpp
===
--- clang/lib/CodeGen/CGCall.cpp
+++ clang/lib/CodeGen/CGCall.cpp
@@ -1311,7 +1311,7 @@
 auto *UndefVec = llvm::UndefValue::get(ScalableDst);
 auto *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
 llvm::Value *Result = CGF.Builder.CreateInsertVector(
-ScalableDst, UndefVec, Load, Zero, "castScalableSve");
+ScalableDst, UndefVec, Load, Zero, "cast.scalable");
 if (NeedsBitcast)
   Result = CGF.Builder.CreateBitCast(Result, OrigType);
 return Result;
@@ -3146,7 +3146,7 @@
 assert(NumIRArgs == 1);
 Coerced->setName(Arg->getName() + ".coerce");
 ArgVals.push_back(ParamValue::forDirect(Builder.CreateExtractVector(
-VecTyTo, Coerced, Zero, "castFixedSve")));
+VecTyTo, Coerced, Zero, "cast.fixed")));
 break;
   }
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D155220: [IRGen] Remove 'Sve' from the name of some IR names that are shared with RISC-V now.

2023-07-17 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes accepted this revision.
c-rhodes added a comment.
This revision is now accepted and ready to land.

LGTM cheers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155220/new/

https://reviews.llvm.org/D155220

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D155220: [IRGen] Remove 'Sve' from the name of some IR names that are shared with RISC-V now.

2023-07-13 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision.
craig.topper added reviewers: joechrisellis, bsmith, c-rhodes, sdesmalen.
Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, 
s.egerton, Jim, rogfer01, shiva0217, kito-cheng, simoncook, arichardson.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added a subscriber: wangpc.
Herald added a project: clang.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155220

Files:
  clang/lib/CodeGen/CGCall.cpp
  clang/lib/CodeGen/CGExprScalar.cpp


Index: clang/lib/CodeGen/CGExprScalar.cpp
===
--- clang/lib/CodeGen/CGExprScalar.cpp
+++ clang/lib/CodeGen/CGExprScalar.cpp
@@ -2152,7 +2152,7 @@
   llvm::Value *UndefVec = llvm::UndefValue::get(DstTy);
   llvm::Value *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
   llvm::Value *Result = Builder.CreateInsertVector(
-  DstTy, UndefVec, Src, Zero, "castScalableSve");
+  DstTy, UndefVec, Src, Zero, "cast.scalable");
   if (NeedsBitCast)
 Result = Builder.CreateBitCast(Result, OrigType);
   return Result;
@@ -2176,7 +2176,7 @@
 }
 if (ScalableSrc->getElementType() == FixedDst->getElementType()) {
   llvm::Value *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
-  return Builder.CreateExtractVector(DstTy, Src, Zero, "castFixedSve");
+  return Builder.CreateExtractVector(DstTy, Src, Zero, "cast.fixed");
 }
   }
 }
Index: clang/lib/CodeGen/CGCall.cpp
===
--- clang/lib/CodeGen/CGCall.cpp
+++ clang/lib/CodeGen/CGCall.cpp
@@ -1311,7 +1311,7 @@
 auto *UndefVec = llvm::UndefValue::get(ScalableDst);
 auto *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
 llvm::Value *Result = CGF.Builder.CreateInsertVector(
-ScalableDst, UndefVec, Load, Zero, "castScalableSve");
+ScalableDst, UndefVec, Load, Zero, "cast.scalable");
 if (NeedsBitcast)
   Result = CGF.Builder.CreateBitCast(Result, OrigType);
 return Result;
@@ -3146,7 +3146,7 @@
 assert(NumIRArgs == 1);
 Coerced->setName(Arg->getName() + ".coerce");
 
ArgVals.push_back(ParamValue::forDirect(Builder.CreateExtractVector(
-VecTyTo, Coerced, Zero, "castFixedSve")));
+VecTyTo, Coerced, Zero, "cast.fixed")));
 break;
   }
 }


Index: clang/lib/CodeGen/CGExprScalar.cpp
===
--- clang/lib/CodeGen/CGExprScalar.cpp
+++ clang/lib/CodeGen/CGExprScalar.cpp
@@ -2152,7 +2152,7 @@
   llvm::Value *UndefVec = llvm::UndefValue::get(DstTy);
   llvm::Value *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
   llvm::Value *Result = Builder.CreateInsertVector(
-  DstTy, UndefVec, Src, Zero, "castScalableSve");
+  DstTy, UndefVec, Src, Zero, "cast.scalable");
   if (NeedsBitCast)
 Result = Builder.CreateBitCast(Result, OrigType);
   return Result;
@@ -2176,7 +2176,7 @@
 }
 if (ScalableSrc->getElementType() == FixedDst->getElementType()) {
   llvm::Value *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
-  return Builder.CreateExtractVector(DstTy, Src, Zero, "castFixedSve");
+  return Builder.CreateExtractVector(DstTy, Src, Zero, "cast.fixed");
 }
   }
 }
Index: clang/lib/CodeGen/CGCall.cpp
===
--- clang/lib/CodeGen/CGCall.cpp
+++ clang/lib/CodeGen/CGCall.cpp
@@ -1311,7 +1311,7 @@
 auto *UndefVec = llvm::UndefValue::get(ScalableDst);
 auto *Zero = llvm::Constant::getNullValue(CGF.CGM.Int64Ty);
 llvm::Value *Result = CGF.Builder.CreateInsertVector(
-ScalableDst, UndefVec, Load, Zero, "castScalableSve");
+ScalableDst, UndefVec, Load, Zero, "cast.scalable");
 if (NeedsBitcast)
   Result = CGF.Builder.CreateBitCast(Result, OrigType);
 return Result;
@@ -3146,7 +3146,7 @@
 assert(NumIRArgs == 1);
 Coerced->setName(Arg->getName() + ".coerce");
 ArgVals.push_back(ParamValue::forDirect(Builder.CreateExtractVector(
-VecTyTo, Coerced, Zero, "castFixedSve")));
+VecTyTo, Coerced, Zero, "cast.fixed")));
 break;
   }
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits