[PATCH] D156357: clang: Add elementwise bitreverse builtin
This revision was automatically updated to reflect the committed changes.
Closed by commit rG57f879cdd4c6: clang: Add elementwise bitreverse builtin
(authored by bob80905).
Changed prior to commit:
https://reviews.llvm.org/D156357?vs=545251=545741#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156357/new/
https://reviews.llvm.org/D156357
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
clang/include/clang/Basic/Builtins.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Sema/SemaChecking.cpp
clang/test/CodeGen/builtins-elementwise-math.c
clang/test/Sema/builtins-elementwise-math.c
clang/test/SemaCXX/builtins-elementwise-math.cpp
Index: clang/test/SemaCXX/builtins-elementwise-math.cpp
===
--- clang/test/SemaCXX/builtins-elementwise-math.cpp
+++ clang/test/SemaCXX/builtins-elementwise-math.cpp
@@ -206,3 +206,10 @@
static_assert(!is_const::value);
static_assert(!is_const::value);
}
+
+void test_builtin_elementwise_bitreverse() {
+ const int a = 2;
+ int b = 1;
+ static_assert(!is_const::value);
+ static_assert(!is_const::value);
+}
Index: clang/test/Sema/builtins-elementwise-math.c
===
--- clang/test/Sema/builtins-elementwise-math.c
+++ clang/test/Sema/builtins-elementwise-math.c
@@ -269,6 +269,27 @@
// expected-error@-1 {{1st argument must be a vector, integer or floating point type (was '_Complex float')}}
}
+void test_builtin_elementwise_bitreverse(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
+
+ struct Foo s = __builtin_elementwise_ceil(f);
+ // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'float'}}
+
+ i = __builtin_elementwise_bitreverse();
+ // expected-error@-1 {{too few arguments to function call, expected 1, have 0}}
+
+ i = __builtin_elementwise_bitreverse(f);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'float')}}
+
+ i = __builtin_elementwise_bitreverse(f, f);
+ // expected-error@-1 {{too many arguments to function call, expected 1, have 2}}
+
+ u = __builtin_elementwise_bitreverse(d);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'double')}}
+
+ v = __builtin_elementwise_bitreverse(v);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'float4' (vector of 4 'float' values))}}
+}
+
void test_builtin_elementwise_ceil(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
struct Foo s = __builtin_elementwise_ceil(f);
Index: clang/test/CodeGen/builtins-elementwise-math.c
===
--- clang/test/CodeGen/builtins-elementwise-math.c
+++ clang/test/CodeGen/builtins-elementwise-math.c
@@ -323,6 +323,42 @@
int_as_one = __builtin_elementwise_min(int_as_one, b);
}
+void test_builtin_elementwise_bitreverse(si8 vi1, si8 vi2,
+ long long int i1, long long int i2, short si,
+ _BitInt(31) bi1, _BitInt(31) bi2) {
+
+
+ // CHECK: [[I1:%.+]] = load i64, ptr %i1.addr, align 8
+ // CHECK-NEXT: call i64 @llvm.bitreverse.i64(i64 [[I1]])
+ i2 = __builtin_elementwise_bitreverse(i1);
+
+ // CHECK: [[VI1:%.+]] = load <8 x i16>, ptr %vi1.addr, align 16
+ // CHECK-NEXT: call <8 x i16> @llvm.bitreverse.v8i16(<8 x i16> [[VI1]])
+ vi2 = __builtin_elementwise_bitreverse(vi1);
+
+ // CHECK: [[CVI2:%.+]] = load <8 x i16>, ptr %cvi2, align 16
+ // CHECK-NEXT: call <8 x i16> @llvm.bitreverse.v8i16(<8 x i16> [[CVI2]])
+ const si8 cvi2 = vi2;
+ vi2 = __builtin_elementwise_bitreverse(cvi2);
+
+ // CHECK: [[BI1:%.+]] = load i31, ptr %bi1.addr, align 4
+ // CHECK-NEXT: call i31 @llvm.bitreverse.i31(i31 [[BI1]])
+ bi2 = __builtin_elementwise_bitreverse(bi1);
+
+ // CHECK: [[IA1:%.+]] = load i32, ptr addrspace(1) @int_as_one, align 4
+ // CHECK-NEXT: call i32 @llvm.bitreverse.i32(i32 [[IA1]])
+ b = __builtin_elementwise_bitreverse(int_as_one);
+
+ // CHECK: call i32 @llvm.bitreverse.i32(i32 -10)
+ b = __builtin_elementwise_bitreverse(-10);
+
+ // CHECK: [[SI:%.+]] = load i16, ptr %si.addr, align 2
+ // CHECK-NEXT: [[SI_EXT:%.+]] = sext i16 [[SI]] to i32
+ // CHECK-NEXT: [[RES:%.+]] = call i32 @llvm.bitreverse.i32(i32 [[SI_EXT]])
+ // CHECK-NEXT: = trunc i32 [[RES]] to i16
+ si = __builtin_elementwise_bitreverse(si);
+}
+
void test_builtin_elementwise_ceil(float f1, float f2, double d1, double d2,
float4 vf1, float4 vf2) {
// CHECK-LABEL: define void @test_builtin_elementwise_ceil(
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -2700,6 +2700,26 @@
if
[PATCH] D156357: clang: Add elementwise bitreverse builtin
bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:634 the most negative integer remains the most negative integer - T __builtin_elementwise_fma(T x, T y, T z) fused multiply add, (x * y) + z. floating point types + T __builtin_elementwise_fma(T x, T y, T z) fused multiply add, (x * y) + z. floating point types T __builtin_elementwise_ceil(T x) return the smallest integral value greater than or equal to xfloating point types arsenm wrote: > Unrelated but I noticed a couple of the elementwise builtins are missing from > this list if you're fixing up the docs for them. Can't remember which off the > top of my head Are you sure? I double checked CGBuiltin.cpp and Builtins.def for all "builtin_elementwise*"'s, there's only the 24 listed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156357/new/ https://reviews.llvm.org/D156357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D156357: clang: Add elementwise bitreverse builtin
bob80905 updated this revision to Diff 545251.
bob80905 added a comment.
- add float4 test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156357/new/
https://reviews.llvm.org/D156357
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
clang/include/clang/Basic/Builtins.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Sema/SemaChecking.cpp
clang/test/CodeGen/builtins-elementwise-math.c
clang/test/Sema/builtins-elementwise-math.c
clang/test/SemaCXX/builtins-elementwise-math.cpp
Index: clang/test/SemaCXX/builtins-elementwise-math.cpp
===
--- clang/test/SemaCXX/builtins-elementwise-math.cpp
+++ clang/test/SemaCXX/builtins-elementwise-math.cpp
@@ -206,3 +206,10 @@
static_assert(!is_const::value);
static_assert(!is_const::value);
}
+
+void test_builtin_elementwise_bitreverse() {
+ const int a = 2;
+ int b = 1;
+ static_assert(!is_const::value);
+ static_assert(!is_const::value);
+}
Index: clang/test/Sema/builtins-elementwise-math.c
===
--- clang/test/Sema/builtins-elementwise-math.c
+++ clang/test/Sema/builtins-elementwise-math.c
@@ -269,6 +269,27 @@
// expected-error@-1 {{1st argument must be a vector, integer or floating point type (was '_Complex float')}}
}
+void test_builtin_elementwise_bitreverse(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
+
+ struct Foo s = __builtin_elementwise_ceil(f);
+ // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'float'}}
+
+ i = __builtin_elementwise_bitreverse();
+ // expected-error@-1 {{too few arguments to function call, expected 1, have 0}}
+
+ i = __builtin_elementwise_bitreverse(f);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'float')}}
+
+ i = __builtin_elementwise_bitreverse(f, f);
+ // expected-error@-1 {{too many arguments to function call, expected 1, have 2}}
+
+ u = __builtin_elementwise_bitreverse(d);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'double')}}
+
+ v = __builtin_elementwise_bitreverse(v);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'float4' (vector of 4 'float' values))}}
+}
+
void test_builtin_elementwise_ceil(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
struct Foo s = __builtin_elementwise_ceil(f);
Index: clang/test/CodeGen/builtins-elementwise-math.c
===
--- clang/test/CodeGen/builtins-elementwise-math.c
+++ clang/test/CodeGen/builtins-elementwise-math.c
@@ -323,6 +323,42 @@
int_as_one = __builtin_elementwise_min(int_as_one, b);
}
+void test_builtin_elementwise_bitreverse(si8 vi1, si8 vi2,
+ long long int i1, long long int i2, short si,
+ _BitInt(31) bi1, _BitInt(31) bi2) {
+
+
+ // CHECK: [[I1:%.+]] = load i64, ptr %i1.addr, align 8
+ // CHECK-NEXT: call i64 @llvm.bitreverse.i64(i64 [[I1]])
+ i2 = __builtin_elementwise_bitreverse(i1);
+
+ // CHECK: [[VI1:%.+]] = load <8 x i16>, ptr %vi1.addr, align 16
+ // CHECK-NEXT: call <8 x i16> @llvm.bitreverse.v8i16(<8 x i16> [[VI1]])
+ vi2 = __builtin_elementwise_bitreverse(vi1);
+
+ // CHECK: [[CVI2:%.+]] = load <8 x i16>, ptr %cvi2, align 16
+ // CHECK-NEXT: call <8 x i16> @llvm.bitreverse.v8i16(<8 x i16> [[CVI2]])
+ const si8 cvi2 = vi2;
+ vi2 = __builtin_elementwise_bitreverse(cvi2);
+
+ // CHECK: [[BI1:%.+]] = load i31, ptr %bi1.addr, align 4
+ // CHECK-NEXT: call i31 @llvm.bitreverse.i31(i31 [[BI1]])
+ bi2 = __builtin_elementwise_bitreverse(bi1);
+
+ // CHECK: [[IA1:%.+]] = load i32, ptr addrspace(1) @int_as_one, align 4
+ // CHECK-NEXT: call i32 @llvm.bitreverse.i32(i32 [[IA1]])
+ b = __builtin_elementwise_bitreverse(int_as_one);
+
+ // CHECK: call i32 @llvm.bitreverse.i32(i32 -10)
+ b = __builtin_elementwise_bitreverse(-10);
+
+ // CHECK: [[SI:%.+]] = load i16, ptr %si.addr, align 2
+ // CHECK-NEXT: [[SI_EXT:%.+]] = sext i16 [[SI]] to i32
+ // CHECK-NEXT: [[RES:%.+]] = call i32 @llvm.bitreverse.i32(i32 [[SI_EXT]])
+ // CHECK-NEXT: = trunc i32 [[RES]] to i16
+ si = __builtin_elementwise_bitreverse(si);
+}
+
void test_builtin_elementwise_ceil(float f1, float f2, double d1, double d2,
float4 vf1, float4 vf2) {
// CHECK-LABEL: define void @test_builtin_elementwise_ceil(
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -2700,6 +2700,26 @@
if (SemaBuiltinElementwiseMath(TheCall))
return ExprError();
break;
+
+ case Builtin::BI__builtin_elementwise_bitreverse: {
+if
[PATCH] D156357: clang: Add elementwise bitreverse builtin
arsenm added inline comments.
Comment at: clang/docs/LanguageExtensions.rst:634
the most negative integer remains
the most negative integer
- T __builtin_elementwise_fma(T x, T y, T z) fused multiply add, (x * y) + z.
floating point types
+ T __builtin_elementwise_fma(T x, T y, T z) fused multiply add, (x * y) + z.
floating point types
T __builtin_elementwise_ceil(T x) return the smallest integral
value greater than or equal to xfloating point types
Unrelated but I noticed a couple of the elementwise builtins are missing from
this list if you're fixing up the docs for them. Can't remember which off the
top of my head
Comment at: clang/test/Sema/builtins-elementwise-math.c:272
+void test_builtin_elementwise_bitreverse(int i, float f, double d, float4 v,
int3 iv, unsigned u, unsigned4 uv) {
+
Test the vector of float case?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156357/new/
https://reviews.llvm.org/D156357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D156357: clang: Add elementwise bitreverse builtin
bob80905 updated this revision to Diff 544830.
bob80905 added a comment.
- apply clang-format on CGBuiltin.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156357/new/
https://reviews.llvm.org/D156357
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
clang/include/clang/Basic/Builtins.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Sema/SemaChecking.cpp
clang/test/CodeGen/builtins-elementwise-math.c
clang/test/Sema/builtins-elementwise-math.c
clang/test/SemaCXX/builtins-elementwise-math.cpp
Index: clang/test/SemaCXX/builtins-elementwise-math.cpp
===
--- clang/test/SemaCXX/builtins-elementwise-math.cpp
+++ clang/test/SemaCXX/builtins-elementwise-math.cpp
@@ -206,3 +206,10 @@
static_assert(!is_const::value);
static_assert(!is_const::value);
}
+
+void test_builtin_elementwise_bitreverse() {
+ const int a = 2;
+ int b = 1;
+ static_assert(!is_const::value);
+ static_assert(!is_const::value);
+}
Index: clang/test/Sema/builtins-elementwise-math.c
===
--- clang/test/Sema/builtins-elementwise-math.c
+++ clang/test/Sema/builtins-elementwise-math.c
@@ -269,6 +269,24 @@
// expected-error@-1 {{1st argument must be a vector, integer or floating point type (was '_Complex float')}}
}
+void test_builtin_elementwise_bitreverse(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
+
+ struct Foo s = __builtin_elementwise_ceil(f);
+ // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'float'}}
+
+ i = __builtin_elementwise_bitreverse();
+ // expected-error@-1 {{too few arguments to function call, expected 1, have 0}}
+
+ i = __builtin_elementwise_bitreverse(f);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'float')}}
+
+ i = __builtin_elementwise_bitreverse(f, f);
+ // expected-error@-1 {{too many arguments to function call, expected 1, have 2}}
+
+ u = __builtin_elementwise_bitreverse(d);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'double')}}
+}
+
void test_builtin_elementwise_ceil(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
struct Foo s = __builtin_elementwise_ceil(f);
Index: clang/test/CodeGen/builtins-elementwise-math.c
===
--- clang/test/CodeGen/builtins-elementwise-math.c
+++ clang/test/CodeGen/builtins-elementwise-math.c
@@ -323,6 +323,42 @@
int_as_one = __builtin_elementwise_min(int_as_one, b);
}
+void test_builtin_elementwise_bitreverse(si8 vi1, si8 vi2,
+ long long int i1, long long int i2, short si,
+ _BitInt(31) bi1, _BitInt(31) bi2) {
+
+
+ // CHECK: [[I1:%.+]] = load i64, ptr %i1.addr, align 8
+ // CHECK-NEXT: call i64 @llvm.bitreverse.i64(i64 [[I1]])
+ i2 = __builtin_elementwise_bitreverse(i1);
+
+ // CHECK: [[VI1:%.+]] = load <8 x i16>, ptr %vi1.addr, align 16
+ // CHECK-NEXT: call <8 x i16> @llvm.bitreverse.v8i16(<8 x i16> [[VI1]])
+ vi2 = __builtin_elementwise_bitreverse(vi1);
+
+ // CHECK: [[CVI2:%.+]] = load <8 x i16>, ptr %cvi2, align 16
+ // CHECK-NEXT: call <8 x i16> @llvm.bitreverse.v8i16(<8 x i16> [[CVI2]])
+ const si8 cvi2 = vi2;
+ vi2 = __builtin_elementwise_bitreverse(cvi2);
+
+ // CHECK: [[BI1:%.+]] = load i31, ptr %bi1.addr, align 4
+ // CHECK-NEXT: call i31 @llvm.bitreverse.i31(i31 [[BI1]])
+ bi2 = __builtin_elementwise_bitreverse(bi1);
+
+ // CHECK: [[IA1:%.+]] = load i32, ptr addrspace(1) @int_as_one, align 4
+ // CHECK-NEXT: call i32 @llvm.bitreverse.i32(i32 [[IA1]])
+ b = __builtin_elementwise_bitreverse(int_as_one);
+
+ // CHECK: call i32 @llvm.bitreverse.i32(i32 -10)
+ b = __builtin_elementwise_bitreverse(-10);
+
+ // CHECK: [[SI:%.+]] = load i16, ptr %si.addr, align 2
+ // CHECK-NEXT: [[SI_EXT:%.+]] = sext i16 [[SI]] to i32
+ // CHECK-NEXT: [[RES:%.+]] = call i32 @llvm.bitreverse.i32(i32 [[SI_EXT]])
+ // CHECK-NEXT: = trunc i32 [[RES]] to i16
+ si = __builtin_elementwise_bitreverse(si);
+}
+
void test_builtin_elementwise_ceil(float f1, float f2, double d1, double d2,
float4 vf1, float4 vf2) {
// CHECK-LABEL: define void @test_builtin_elementwise_ceil(
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -2700,6 +2700,26 @@
if (SemaBuiltinElementwiseMath(TheCall))
return ExprError();
break;
+
+ case Builtin::BI__builtin_elementwise_bitreverse: {
+if (PrepareBuiltinElementwiseMathOneArgCall(TheCall))
+ return ExprError();
+
+const Expr *Arg = TheCall->getArg(0);
+QualType ArgTy = Arg->getType();
+QualType EltTy
[PATCH] D156357: clang: Add elementwise bitreverse builtin
bob80905 updated this revision to Diff 544610.
bob80905 added a comment.
- remove tests that only test floating point inputs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156357/new/
https://reviews.llvm.org/D156357
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
clang/include/clang/Basic/Builtins.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Sema/SemaChecking.cpp
clang/test/CodeGen/builtins-elementwise-math.c
clang/test/Sema/builtins-elementwise-math.c
clang/test/SemaCXX/builtins-elementwise-math.cpp
Index: clang/test/SemaCXX/builtins-elementwise-math.cpp
===
--- clang/test/SemaCXX/builtins-elementwise-math.cpp
+++ clang/test/SemaCXX/builtins-elementwise-math.cpp
@@ -206,3 +206,10 @@
static_assert(!is_const::value);
static_assert(!is_const::value);
}
+
+void test_builtin_elementwise_bitreverse() {
+ const int a = 2;
+ int b = 1;
+ static_assert(!is_const::value);
+ static_assert(!is_const::value);
+}
Index: clang/test/Sema/builtins-elementwise-math.c
===
--- clang/test/Sema/builtins-elementwise-math.c
+++ clang/test/Sema/builtins-elementwise-math.c
@@ -269,6 +269,24 @@
// expected-error@-1 {{1st argument must be a vector, integer or floating point type (was '_Complex float')}}
}
+void test_builtin_elementwise_bitreverse(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
+
+ struct Foo s = __builtin_elementwise_ceil(f);
+ // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'float'}}
+
+ i = __builtin_elementwise_bitreverse();
+ // expected-error@-1 {{too few arguments to function call, expected 1, have 0}}
+
+ i = __builtin_elementwise_bitreverse(f);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'float')}}
+
+ i = __builtin_elementwise_bitreverse(f, f);
+ // expected-error@-1 {{too many arguments to function call, expected 1, have 2}}
+
+ u = __builtin_elementwise_bitreverse(d);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'double')}}
+}
+
void test_builtin_elementwise_ceil(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
struct Foo s = __builtin_elementwise_ceil(f);
Index: clang/test/CodeGen/builtins-elementwise-math.c
===
--- clang/test/CodeGen/builtins-elementwise-math.c
+++ clang/test/CodeGen/builtins-elementwise-math.c
@@ -323,6 +323,42 @@
int_as_one = __builtin_elementwise_min(int_as_one, b);
}
+void test_builtin_elementwise_bitreverse(si8 vi1, si8 vi2,
+ long long int i1, long long int i2, short si,
+ _BitInt(31) bi1, _BitInt(31) bi2) {
+
+
+ // CHECK: [[I1:%.+]] = load i64, ptr %i1.addr, align 8
+ // CHECK-NEXT: call i64 @llvm.bitreverse.i64(i64 [[I1]])
+ i2 = __builtin_elementwise_bitreverse(i1);
+
+ // CHECK: [[VI1:%.+]] = load <8 x i16>, ptr %vi1.addr, align 16
+ // CHECK-NEXT: call <8 x i16> @llvm.bitreverse.v8i16(<8 x i16> [[VI1]])
+ vi2 = __builtin_elementwise_bitreverse(vi1);
+
+ // CHECK: [[CVI2:%.+]] = load <8 x i16>, ptr %cvi2, align 16
+ // CHECK-NEXT: call <8 x i16> @llvm.bitreverse.v8i16(<8 x i16> [[CVI2]])
+ const si8 cvi2 = vi2;
+ vi2 = __builtin_elementwise_bitreverse(cvi2);
+
+ // CHECK: [[BI1:%.+]] = load i31, ptr %bi1.addr, align 4
+ // CHECK-NEXT: call i31 @llvm.bitreverse.i31(i31 [[BI1]])
+ bi2 = __builtin_elementwise_bitreverse(bi1);
+
+ // CHECK: [[IA1:%.+]] = load i32, ptr addrspace(1) @int_as_one, align 4
+ // CHECK-NEXT: call i32 @llvm.bitreverse.i32(i32 [[IA1]])
+ b = __builtin_elementwise_bitreverse(int_as_one);
+
+ // CHECK: call i32 @llvm.bitreverse.i32(i32 -10)
+ b = __builtin_elementwise_bitreverse(-10);
+
+ // CHECK: [[SI:%.+]] = load i16, ptr %si.addr, align 2
+ // CHECK-NEXT: [[SI_EXT:%.+]] = sext i16 [[SI]] to i32
+ // CHECK-NEXT: [[RES:%.+]] = call i32 @llvm.bitreverse.i32(i32 [[SI_EXT]])
+ // CHECK-NEXT: = trunc i32 [[RES]] to i16
+ si = __builtin_elementwise_bitreverse(si);
+}
+
void test_builtin_elementwise_ceil(float f1, float f2, double d1, double d2,
float4 vf1, float4 vf2) {
// CHECK-LABEL: define void @test_builtin_elementwise_ceil(
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -2700,6 +2700,26 @@
if (SemaBuiltinElementwiseMath(TheCall))
return ExprError();
break;
+
+ case Builtin::BI__builtin_elementwise_bitreverse: {
+if (PrepareBuiltinElementwiseMathOneArgCall(TheCall))
+ return ExprError();
+
+const Expr *Arg = TheCall->getArg(0);
+QualType ArgTy = Arg->getType();
+
[PATCH] D156357: clang: Add elementwise bitreverse builtin
bob80905 updated this revision to Diff 544563.
bob80905 added a comment.
- remove strictfp test, add cgbuiltin case and update test in codegen
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156357/new/
https://reviews.llvm.org/D156357
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
clang/include/clang/Basic/Builtins.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Sema/SemaChecking.cpp
clang/test/CodeGen/builtins-elementwise-math.c
clang/test/Sema/aarch64-sve-vector-bitreverse-ops.c
clang/test/Sema/builtins-elementwise-math.c
clang/test/Sema/riscv-sve-vector-bitreverse-ops.c
clang/test/SemaCXX/builtins-elementwise-math.cpp
Index: clang/test/SemaCXX/builtins-elementwise-math.cpp
===
--- clang/test/SemaCXX/builtins-elementwise-math.cpp
+++ clang/test/SemaCXX/builtins-elementwise-math.cpp
@@ -206,3 +206,10 @@
static_assert(!is_const::value);
static_assert(!is_const::value);
}
+
+void test_builtin_elementwise_bitreverse() {
+ const int a = 2;
+ int b = 1;
+ static_assert(!is_const::value);
+ static_assert(!is_const::value);
+}
Index: clang/test/Sema/riscv-sve-vector-bitreverse-ops.c
===
--- /dev/null
+++ clang/test/Sema/riscv-sve-vector-bitreverse-ops.c
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -triple riscv64 -target-feature +f -target-feature +d \
+// RUN: -target-feature +v -target-feature +zfh -target-feature +experimental-zvfh \
+// RUN: -disable-O0-optnone -o - -fsyntax-only %s -verify
+// REQUIRES: riscv-registered-target
+
+#include
+
+
+vfloat32mf2_t test_bitreverse_vv_i8mf8(vfloat32mf2_t v) {
+
+ return __builtin_elementwise_bitreverse(v, v);
+ // expected-error@-1 {{1st argument must be a vector, integer or floating point type}}
+}
Index: clang/test/Sema/builtins-elementwise-math.c
===
--- clang/test/Sema/builtins-elementwise-math.c
+++ clang/test/Sema/builtins-elementwise-math.c
@@ -269,6 +269,24 @@
// expected-error@-1 {{1st argument must be a vector, integer or floating point type (was '_Complex float')}}
}
+void test_builtin_elementwise_bitreverse(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
+
+ struct Foo s = __builtin_elementwise_ceil(f);
+ // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'float'}}
+
+ i = __builtin_elementwise_bitreverse();
+ // expected-error@-1 {{too few arguments to function call, expected 1, have 0}}
+
+ i = __builtin_elementwise_bitreverse(f);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'float')}}
+
+ i = __builtin_elementwise_bitreverse(f, f);
+ // expected-error@-1 {{too many arguments to function call, expected 1, have 2}}
+
+ u = __builtin_elementwise_bitreverse(d);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'double')}}
+}
+
void test_builtin_elementwise_ceil(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
struct Foo s = __builtin_elementwise_ceil(f);
Index: clang/test/Sema/aarch64-sve-vector-bitreverse-ops.c
===
--- /dev/null
+++ clang/test/Sema/aarch64-sve-vector-bitreverse-ops.c
@@ -0,0 +1,12 @@
+// RUN: %clang_cc1 -triple aarch64 -target-feature +f -target-feature +d \
+// RUN: -target-feature +v -target-feature +zfh -target-feature +sve -target-feature +experimental-zvfh \
+// RUN: -disable-O0-optnone -o - -fsyntax-only %s -verify
+// REQUIRES: aarch64-registered-target
+
+#include
+
+svfloat32_t test_bitreverse_vv_i8mf8(svfloat32_t v) {
+
+ return __builtin_elementwise_bitreverse(v, v);
+ // expected-error@-1 {{1st argument must be a vector, integer or floating point type}}
+}
Index: clang/test/CodeGen/builtins-elementwise-math.c
===
--- clang/test/CodeGen/builtins-elementwise-math.c
+++ clang/test/CodeGen/builtins-elementwise-math.c
@@ -323,6 +323,42 @@
int_as_one = __builtin_elementwise_min(int_as_one, b);
}
+void test_builtin_elementwise_bitreverse(si8 vi1, si8 vi2,
+ long long int i1, long long int i2, short si,
+ _BitInt(31) bi1, _BitInt(31) bi2) {
+
+
+ // CHECK: [[I1:%.+]] = load i64, ptr %i1.addr, align 8
+ // CHECK-NEXT: call i64 @llvm.bitreverse.i64(i64 [[I1]])
+ i2 = __builtin_elementwise_bitreverse(i1);
+
+ // CHECK: [[VI1:%.+]] = load <8 x i16>, ptr %vi1.addr, align 16
+ // CHECK-NEXT: call <8 x i16> @llvm.bitreverse.v8i16(<8 x i16> [[VI1]])
+ vi2 = __builtin_elementwise_bitreverse(vi1);
+
+ // CHECK: [[CVI2:%.+]] = load <8 x i16>, ptr %cvi2, align 16
+ // CHECK-NEXT: call <8 x i16> @llvm.bitreverse.v8i16(<8 x i16> [[CVI2]])
+ const si8 cvi2 = vi2;
+
[PATCH] D156357: clang: Add elementwise bitreverse builtin
bob80905 updated this revision to Diff 544463.
bob80905 added a comment.
Herald added subscribers: wangpc, luke, frasercrmck, luismarques, apazos,
sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult,
MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal,
simoncook, johnrusso, rbar, asb.
add attempt 1 commit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156357/new/
https://reviews.llvm.org/D156357
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
clang/include/clang/Basic/Builtins.def
clang/lib/Sema/SemaChecking.cpp
clang/test/CodeGen/builtins-elementwise-math.c
clang/test/CodeGen/strictfp-elementwise-bulitins.cpp
clang/test/Sema/aarch64-sve-vector-bitreverse-ops.c
clang/test/Sema/builtins-elementwise-math.c
clang/test/Sema/riscv-sve-vector-bitreverse-ops.c
clang/test/SemaCXX/builtins-elementwise-math.cpp
Index: clang/test/SemaCXX/builtins-elementwise-math.cpp
===
--- clang/test/SemaCXX/builtins-elementwise-math.cpp
+++ clang/test/SemaCXX/builtins-elementwise-math.cpp
@@ -206,3 +206,10 @@
static_assert(!is_const::value);
static_assert(!is_const::value);
}
+
+void test_builtin_elementwise_bitreverse() {
+ const int a = 2;
+ int b = 1;
+ static_assert(!is_const::value);
+ static_assert(!is_const::value);
+}
Index: clang/test/Sema/riscv-sve-vector-bitreverse-ops.c
===
--- /dev/null
+++ clang/test/Sema/riscv-sve-vector-bitreverse-ops.c
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -triple riscv64 -target-feature +f -target-feature +d \
+// RUN: -target-feature +v -target-feature +zfh -target-feature +experimental-zvfh \
+// RUN: -disable-O0-optnone -o - -fsyntax-only %s -verify
+// REQUIRES: riscv-registered-target
+
+#include
+
+
+vfloat32mf2_t test_bitreverse_vv_i8mf8(vfloat32mf2_t v) {
+
+ return __builtin_elementwise_bitreverse(v, v);
+ // expected-error@-1 {{1st argument must be a vector, integer or floating point type}}
+}
Index: clang/test/Sema/builtins-elementwise-math.c
===
--- clang/test/Sema/builtins-elementwise-math.c
+++ clang/test/Sema/builtins-elementwise-math.c
@@ -269,6 +269,24 @@
// expected-error@-1 {{1st argument must be a vector, integer or floating point type (was '_Complex float')}}
}
+void test_builtin_elementwise_bitreverse(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
+
+ struct Foo s = __builtin_elementwise_ceil(f);
+ // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'float'}}
+
+ i = __builtin_elementwise_bitreverse();
+ // expected-error@-1 {{too few arguments to function call, expected 1, have 0}}
+
+ i = __builtin_elementwise_bitreverse(f);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'float')}}
+
+ i = __builtin_elementwise_bitreverse(f, f);
+ // expected-error@-1 {{too many arguments to function call, expected 1, have 2}}
+
+ u = __builtin_elementwise_bitreverse(d);
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'double')}}
+}
+
void test_builtin_elementwise_ceil(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
struct Foo s = __builtin_elementwise_ceil(f);
Index: clang/test/Sema/aarch64-sve-vector-bitreverse-ops.c
===
--- /dev/null
+++ clang/test/Sema/aarch64-sve-vector-bitreverse-ops.c
@@ -0,0 +1,12 @@
+// RUN: %clang_cc1 -triple aarch64 -target-feature +f -target-feature +d \
+// RUN: -target-feature +v -target-feature +zfh -target-feature +sve -target-feature +experimental-zvfh \
+// RUN: -disable-O0-optnone -o - -fsyntax-only %s -verify
+// REQUIRES: aarch64-registered-target
+
+#include
+
+svfloat32_t test_bitreverse_vv_i8mf8(svfloat32_t v) {
+
+ return __builtin_elementwise_bitreverse(v, v);
+ // expected-error@-1 {{1st argument must be a vector, integer or floating point type}}
+}
Index: clang/test/CodeGen/strictfp-elementwise-bulitins.cpp
===
--- clang/test/CodeGen/strictfp-elementwise-bulitins.cpp
+++ clang/test/CodeGen/strictfp-elementwise-bulitins.cpp
@@ -47,6 +47,16 @@
return __builtin_elementwise_min(a, b);
}
+// CHECK-LABEL: define dso_local noundef <4 x float> @_Z22strict_elementwise_bitreverseDv4_fS_
+// CHECK-SAME: (<4 x float> noundef [[A:%.*]], <4 x float> noundef [[B:%.*]]) local_unnamed_addr #[[ATTR2]] {
+// CHECK-NEXT: entry:
+// CHECK-NEXT:[[TMP0:%.*]] = tail call <4 x float> @llvm.bitreverse.v4f32(<4 x float> [[A]], <4 x float> [[B]]) #[[ATTR4]]
+// CHECK-NEXT:ret <4 x float> [[TMP0]]
+//
+float4 strict_elementwise_bitreverse(float4 a, float4 b) {
+ return __builtin_elementwise_bitreverse(a, b);
+}
+
// CHECK-LABEL:
[PATCH] D156357: clang: Add elementwise bitreverse builtin
bob80905 created this revision.
Herald added a subscriber: Anastasia.
Herald added a project: All.
bob80905 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add codegen for llvm bitreverse elementwise builtin
The bitreverse elementwise builtin is necessary for HLSL codegen.
Tests were added to make sure that the expected errors are encountered when
these functions are given inputs of incompatible types, or too many inputs.
The new builtin is restricted to integer types only.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D156357
Files:
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/builtins-elementwise-math.c
Index: clang/test/Sema/builtins-elementwise-math.c
===
--- clang/test/Sema/builtins-elementwise-math.c
+++ clang/test/Sema/builtins-elementwise-math.c
@@ -278,13 +278,13 @@
// expected-error@-1 {{too few arguments to function call, expected 1, have
0}}
i = __builtin_elementwise_bitreverse(f);
- // expected-error@-1 {{1st argument must be a integer type (was 'float')}}
-
+ // expected-error@-1 {{1st argument must be a vector of integers (was
'float')}}
+
i = __builtin_elementwise_bitreverse(f, f);
// expected-error@-1 {{too many arguments to function call, expected 1, have
2}}
u = __builtin_elementwise_bitreverse(d);
- // expected-error@-1 {{1st argument must be a integer type (was 'double')}}
+ // expected-error@-1 {{1st argument must be a vector of integers (was
'double')}}
}
void test_builtin_elementwise_ceil(int i, float f, double d, float4 v, int3
iv, unsigned u, unsigned4 uv) {
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -2697,10 +2697,29 @@
case Builtin::BI__builtin_elementwise_min:
case Builtin::BI__builtin_elementwise_max:
- case Builtin::BI__builtin_elementwise_bitreverse:
if (SemaBuiltinElementwiseMath(TheCall))
return ExprError();
break;
+
+ case Builtin::BI__builtin_elementwise_bitreverse: {
+if (PrepareBuiltinElementwiseMathOneArgCall(TheCall))
+ return ExprError();
+
+const Expr *Arg = TheCall->getArg(0);
+QualType ArgTy = Arg->getType();
+QualType EltTy = ArgTy;
+
+if (auto *VecTy = EltTy->getAs())
+ EltTy = VecTy->getElementType();
+
+if (!EltTy->isIntegerType()) {
+ Diag(Arg->getBeginLoc(), diag::err_builtin_invalid_arg_type)
+ << 1 << /* integer ty */ 6 << ArgTy;
+ return ExprError();
+}
+break;
+ }
+
case Builtin::BI__builtin_elementwise_copysign: {
if (checkArgCount(*this, TheCall, 2))
return ExprError();
Index: clang/test/Sema/builtins-elementwise-math.c
===
--- clang/test/Sema/builtins-elementwise-math.c
+++ clang/test/Sema/builtins-elementwise-math.c
@@ -278,13 +278,13 @@
// expected-error@-1 {{too few arguments to function call, expected 1, have 0}}
i = __builtin_elementwise_bitreverse(f);
- // expected-error@-1 {{1st argument must be a integer type (was 'float')}}
-
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'float')}}
+
i = __builtin_elementwise_bitreverse(f, f);
// expected-error@-1 {{too many arguments to function call, expected 1, have 2}}
u = __builtin_elementwise_bitreverse(d);
- // expected-error@-1 {{1st argument must be a integer type (was 'double')}}
+ // expected-error@-1 {{1st argument must be a vector of integers (was 'double')}}
}
void test_builtin_elementwise_ceil(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
Index: clang/lib/Sema/SemaChecking.cpp
===
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -2697,10 +2697,29 @@
case Builtin::BI__builtin_elementwise_min:
case Builtin::BI__builtin_elementwise_max:
- case Builtin::BI__builtin_elementwise_bitreverse:
if (SemaBuiltinElementwiseMath(TheCall))
return ExprError();
break;
+
+ case Builtin::BI__builtin_elementwise_bitreverse: {
+if (PrepareBuiltinElementwiseMathOneArgCall(TheCall))
+ return ExprError();
+
+const Expr *Arg = TheCall->getArg(0);
+QualType ArgTy = Arg->getType();
+QualType EltTy = ArgTy;
+
+if (auto *VecTy = EltTy->getAs())
+ EltTy = VecTy->getElementType();
+
+if (!EltTy->isIntegerType()) {
+ Diag(Arg->getBeginLoc(), diag::err_builtin_invalid_arg_type)
+ << 1 << /* integer ty */ 6 << ArgTy;
+ return ExprError();
+}
+break;
+ }
+
case Builtin::BI__builtin_elementwise_copysign: {
if (checkArgCount(*this, TheCall, 2))
return ExprError();
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
