[PATCH] D158037: [Driver][DXC] Remove a bunch of options from DXC
This revision was automatically updated to reflect the committed changes. Closed by commit rGe17667b33f1f: [Driver][DXC] Remove a bunch of options from DXC (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158037/new/ https://reviews.llvm.org/D158037 Files: clang/include/clang/Driver/Options.td Index: clang/include/clang/Driver/Options.td === --- clang/include/clang/Driver/Options.td +++ clang/include/clang/Driver/Options.td @@ -195,8 +195,7 @@ def m_wasm_Features_Driver_Group : OptionGroup<"">, Group, DocName<"WebAssembly Driver">; def m_x86_Features_Group : OptionGroup<"">, - Group, - Visibility<[ClangOption, CLOption, DXCOption]>, + Group, Visibility<[ClangOption, CLOption]>, DocName<"X86">; def m_riscv_Features_Group : OptionGroup<"">, Group, DocName<"RISC-V">; @@ -274,8 +273,7 @@ // Retired with clang-16.0, to provide a deprecation period; it should // be removed in Clang 18 or later. def enable_trivial_var_init_zero : Flag<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">, - Flags<[NoArgumentUnused]>, - Visibility<[ClangOption, CC1Option, CLOption, DXCOption]>, + Flags<[NoArgumentUnused]>, Visibility<[ClangOption, CC1Option, CLOption]>, Group; // Group that ignores all gcc optimizations that won't be implemented @@ -1079,7 +1077,7 @@ Visibility<[ClangOption, CLOption, DXCOption]>, HelpText<"User directory for configuration files">; def coverage : Flag<["-", "--"], "coverage">, Group, - Visibility<[ClangOption, CLOption, DXCOption]>; + Visibility<[ClangOption, CLOption]>; def cpp_precomp : Flag<["-"], "cpp-precomp">, Group; def current__version : JoinedOrSeparate<["-"], "current_version">; def cxx_isystem : JoinedOrSeparate<["-"], "cxx-isystem">, Group, @@ -1449,7 +1447,7 @@ PosFlag, NegFlag, - BothFlags<[], [ClangOption, CLOption, DXCOption]>>; + BothFlags<[], [ClangOption, CLOption]>>; def fassume_sane_operator_new : Flag<["-"], "fassume-sane-operator-new">, Group; def fastcp : Flag<["-"], "fastcp">, Group; @@ -1488,7 +1486,7 @@ defm experimental_library : BoolFOption<"experimental-library", LangOpts<"ExperimentalLibrary">, DefaultFalse, - PosFlag>; def fprofile_sample_use : Flag<["-"], "fprofile-sample-use">, Group, -Visibility<[ClangOption, CLOption, DXCOption]>; +Visibility<[ClangOption, CLOption]>; def fno_profile_sample_use : Flag<["-"], "fno-profile-sample-use">, Group, -Visibility<[ClangOption, CLOption, DXCOption]>; +Visibility<[ClangOption, CLOption]>; def fprofile_sample_use_EQ : Joined<["-"], "fprofile-sample-use=">, Group, Flags<[NoXarchOption]>, Visibility<[ClangOption, CC1Option]>, @@ -1568,8 +1566,7 @@ Visibility<[ClangOption, CC1Option, CC1AsOption, CLOption, DXCOption]>, Alias; def fcoverage_compilation_dir_EQ : Joined<["-"], "fcoverage-compilation-dir=">, -Group, -Visibility<[ClangOption, CC1Option, CC1AsOption, CLOption, DXCOption]>, +Group, Visibility<[ClangOption, CC1Option, CC1AsOption, CLOption]>, HelpText<"The compilation directory to embed in the coverage mapping.">, MarshallingInfoString>; def ffile_compilation_dir_EQ : Joined<["-"], "ffile-compilation-dir=">, Group, @@ -1581,19 +1578,18 @@ "Emit extra debug info to make sample profile more accurate">, NegFlag>; def fprofile_instr_generate : Flag<["-"], "fprofile-instr-generate">, -Group, Visibility<[ClangOption, CLOption, DXCOption]>, +Group, Visibility<[ClangOption, CLOption]>, HelpText<"Generate instrumented code to collect execution counts into default.profraw file (overridden by '=' form of option or LLVM_PROFILE_FILE env var)">; def fprofile_instr_generate_EQ : Joined<["-"], "fprofile-instr-generate=">, -Group, Visibility<[ClangOption, CLOption, DXCOption]>, -MetaVarName<"">, +Group, Visibility<[ClangOption, CLOption]>, MetaVarName<"">, HelpText<"Generate instrumented code to collect execution counts into (overridden by LLVM_PROFILE_FILE env var)">; def fprofile_instr_use : Flag<["-"], "fprofile-instr-use">, Group, -Visibility<[ClangOption, CLOption, DXCOption]>; +Visibility<[ClangOption, CLOption]>; def fprofile_instr_use_EQ : Joined<["-"], "fprofile-instr-use=">, -Group, Visibility<[ClangOption, CLOption, DXCOption]>, +Group, Visibility<[ClangOption, CLOption]>, HelpText<"Use instrumentation data for profile-guided optimization">; def fprofile_remapping_file_EQ : Joined<["-"], "fprofile-remapping-file=">, -Group, Visibility<[ClangOption, CC1Option, CLOption, DXCOption]>, +Group, Visibility<[ClangOption, CC1Option, CLOption]>, MetaVarName<"">, HelpText<"Use the remappings described in
[PATCH] D158037: [Driver][DXC] Remove a bunch of options from DXC
bogner created this revision. bogner added reviewers: beanz, python3kgae. Herald added a subscriber: mcrosier. Herald added a reviewer: sscalpone. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove DXCOption from a whole bunch of options that we probably won't support in the DXC driver. The initial clang-dxc support just made everything that was a "CoreOption" available, regardless of whether it made sense. Here I don't remove all of them, but this makes a dent on making the list a bit more sensible. We can easily add or remove more if they make sense later. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158037 Files: clang/include/clang/Driver/Options.td Index: clang/include/clang/Driver/Options.td === --- clang/include/clang/Driver/Options.td +++ clang/include/clang/Driver/Options.td @@ -195,8 +195,7 @@ def m_wasm_Features_Driver_Group : OptionGroup<"">, Group, DocName<"WebAssembly Driver">; def m_x86_Features_Group : OptionGroup<"">, - Group, - Visibility<[ClangOption, CLOption, DXCOption]>, + Group, Visibility<[ClangOption, CLOption]>, DocName<"X86">; def m_riscv_Features_Group : OptionGroup<"">, Group, DocName<"RISC-V">; @@ -274,8 +273,7 @@ // Retired with clang-16.0, to provide a deprecation period; it should // be removed in Clang 18 or later. def enable_trivial_var_init_zero : Flag<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">, - Flags<[NoArgumentUnused]>, - Visibility<[ClangOption, CC1Option, CLOption, DXCOption]>, + Flags<[NoArgumentUnused]>, Visibility<[ClangOption, CC1Option, CLOption]>, Group; // Group that ignores all gcc optimizations that won't be implemented @@ -1079,7 +1077,7 @@ Visibility<[ClangOption, CLOption, DXCOption]>, HelpText<"User directory for configuration files">; def coverage : Flag<["-", "--"], "coverage">, Group, - Visibility<[ClangOption, CLOption, DXCOption]>; + Visibility<[ClangOption, CLOption]>; def cpp_precomp : Flag<["-"], "cpp-precomp">, Group; def current__version : JoinedOrSeparate<["-"], "current_version">; def cxx_isystem : JoinedOrSeparate<["-"], "cxx-isystem">, Group, @@ -1449,7 +1447,7 @@ PosFlag, NegFlag, - BothFlags<[], [ClangOption, CLOption, DXCOption]>>; + BothFlags<[], [ClangOption, CLOption]>>; def fassume_sane_operator_new : Flag<["-"], "fassume-sane-operator-new">, Group; def fastcp : Flag<["-"], "fastcp">, Group; @@ -1488,7 +1486,7 @@ defm experimental_library : BoolFOption<"experimental-library", LangOpts<"ExperimentalLibrary">, DefaultFalse, - PosFlag>; def fprofile_sample_use : Flag<["-"], "fprofile-sample-use">, Group, -Visibility<[ClangOption, CLOption, DXCOption]>; +Visibility<[ClangOption, CLOption]>; def fno_profile_sample_use : Flag<["-"], "fno-profile-sample-use">, Group, -Visibility<[ClangOption, CLOption, DXCOption]>; +Visibility<[ClangOption, CLOption]>; def fprofile_sample_use_EQ : Joined<["-"], "fprofile-sample-use=">, Group, Flags<[NoXarchOption]>, Visibility<[ClangOption, CC1Option]>, @@ -1568,8 +1566,7 @@ Visibility<[ClangOption, CC1Option, CC1AsOption, CLOption, DXCOption]>, Alias; def fcoverage_compilation_dir_EQ : Joined<["-"], "fcoverage-compilation-dir=">, -Group, -Visibility<[ClangOption, CC1Option, CC1AsOption, CLOption, DXCOption]>, +Group, Visibility<[ClangOption, CC1Option, CC1AsOption, CLOption]>, HelpText<"The compilation directory to embed in the coverage mapping.">, MarshallingInfoString>; def ffile_compilation_dir_EQ : Joined<["-"], "ffile-compilation-dir=">, Group, @@ -1581,19 +1578,18 @@ "Emit extra debug info to make sample profile more accurate">, NegFlag>; def fprofile_instr_generate : Flag<["-"], "fprofile-instr-generate">, -Group, Visibility<[ClangOption, CLOption, DXCOption]>, +Group, Visibility<[ClangOption, CLOption]>, HelpText<"Generate instrumented code to collect execution counts into default.profraw file (overridden by '=' form of option or LLVM_PROFILE_FILE env var)">; def fprofile_instr_generate_EQ : Joined<["-"], "fprofile-instr-generate=">, -Group, Visibility<[ClangOption, CLOption, DXCOption]>, -MetaVarName<"">, +Group, Visibility<[ClangOption, CLOption]>, MetaVarName<"">, HelpText<"Generate instrumented code to collect execution counts into (overridden by LLVM_PROFILE_FILE env var)">; def fprofile_instr_use : Flag<["-"], "fprofile-instr-use">, Group, -Visibility<[ClangOption, CLOption, DXCOption]>; +Visibility<[ClangOption, CLOption]>; def fprofile_instr_use_EQ : Joined<["-"], "fprofile-instr-use=">, -Group, Visibility<[ClangOption,
