[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

[Soumi Manna via Phabricator via cfe-commits]

Manna added a comment.

In D158227#4610219 , @dyung wrote:

> In D158227#4610097 , @Manna wrote:
>
>> The failure seems unrelated to my change.
>
> Hi @Manna, I'm not sure which failure you are referring to, but there is a 
> test failure on at least 2 build bots that seems to have been caused by your 
> change. Can you take a look and revert if you need time to investigate?
>
> https://lab.llvm.org/buildbot/#/builders/139/builds/48141
> https://lab.llvm.org/buildbot/#/builders/216/builds/26116

Thank you @dyung for reporting the buildbot failure. I have reverted my patch. 
I will investigate it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158227/new/

https://reviews.llvm.org/D158227

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D158227#4610097 , @Manna wrote:

> The failure seems unrelated to my change.

Hi @Manna, I'm not sure which failure you are referring to, but there is a test 
failure on at least 2 build bots that seems to have been caused by your change. 
Can you take a look and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/139/builds/48141
https://lab.llvm.org/buildbot/#/builders/216/builds/26116


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158227/new/

https://reviews.llvm.org/D158227

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

[Soumi Manna via Phabricator via cfe-commits]

Manna added a comment.

The failure seems unrelated to my change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158227/new/

https://reviews.llvm.org/D158227

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

[Soumi Manna via Phabricator via cfe-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9e150adaea7b: [NFC][clang] EditedSource::applyRewrites - 
useless call (authored by Manna).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158227/new/

https://reviews.llvm.org/D158227

Files:
  clang/lib/Edit/EditedSource.cpp


Index: clang/lib/Edit/EditedSource.cpp
===
--- clang/lib/Edit/EditedSource.cpp
+++ clang/lib/Edit/EditedSource.cpp
@@ -430,7 +430,7 @@
 if (offs == CurEnd) {
   StrVec += act.Text;
   CurLen += act.RemoveLen;
-  CurEnd.getWithOffset(act.RemoveLen);
+  CurEnd = CurEnd.getWithOffset(act.RemoveLen);
   continue;
 }
 


Index: clang/lib/Edit/EditedSource.cpp
===
--- clang/lib/Edit/EditedSource.cpp
+++ clang/lib/Edit/EditedSource.cpp
@@ -430,7 +430,7 @@
 if (offs == CurEnd) {
   StrVec += act.Text;
   CurLen += act.RemoveLen;
-  CurEnd.getWithOffset(act.RemoveLen);
+  CurEnd = CurEnd.getWithOffset(act.RemoveLen);
   continue;
 }
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

[Soumi Manna via Phabricator via cfe-commits]

Manna added a comment.

Thank you @aaron.ballman for reviews and feedbacks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158227/new/

https://reviews.llvm.org/D158227

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM! This is an NFC change that doesn't require additional testing because 
`CurEnd` is only used in an assertion, not for any of the function's semantics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158227/new/

https://reviews.llvm.org/D158227

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

[Soumi Manna via Phabricator via cfe-commits]

Manna created this revision.
Manna added reviewers: RKSimon, aaron.ballman, tahonermann.
Herald added a project: All.
Manna requested review of this revision.
Herald added a project: clang.

Fixes https://github.com/llvm/llvm-project/issues/53426


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158227

Files:
  clang/lib/Edit/EditedSource.cpp


Index: clang/lib/Edit/EditedSource.cpp
===
--- clang/lib/Edit/EditedSource.cpp
+++ clang/lib/Edit/EditedSource.cpp
@@ -430,7 +430,7 @@
 if (offs == CurEnd) {
   StrVec += act.Text;
   CurLen += act.RemoveLen;
-  CurEnd.getWithOffset(act.RemoveLen);
+  CurEnd = CurEnd.getWithOffset(act.RemoveLen);
   continue;
 }
 


Index: clang/lib/Edit/EditedSource.cpp
===
--- clang/lib/Edit/EditedSource.cpp
+++ clang/lib/Edit/EditedSource.cpp
@@ -430,7 +430,7 @@
 if (offs == CurEnd) {
   StrVec += act.Text;
   CurLen += act.RemoveLen;
-  CurEnd.getWithOffset(act.RemoveLen);
+  CurEnd = CurEnd.getWithOffset(act.RemoveLen);
   continue;
 }
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits