[PATCH] D158309: [flang][driver] Mark -Wl as visible in Flang
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3758aed31a51: [flang][driver] Mark -Wl as visible in Flang (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D158309?vs=551620=551912#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158309/new/ https://reviews.llvm.org/D158309 Files: clang/include/clang/Driver/Options.td flang/test/Driver/driver-help-hidden.f90 flang/test/Driver/driver-help.f90 flang/test/Driver/misc-flags.f90 Index: flang/test/Driver/misc-flags.f90 === --- flang/test/Driver/misc-flags.f90 +++ flang/test/Driver/misc-flags.f90 @@ -1,6 +1,9 @@ ! Make sure that `-l` is "visible" to Flang's driver ! RUN: %flang -lpgmath -### %s +! Make sure that `-Wl` is "visible" to Flang's driver +! RUN: %flang -Wl,abs -### %s + program hello write(*,*), "Hello world!" end program hello Index: flang/test/Driver/driver-help.f90 === --- flang/test/Driver/driver-help.f90 +++ flang/test/Driver/driver-help.f90 @@ -120,6 +120,7 @@ ! HELP-NEXT: -U Undefine macro ! HELP-NEXT: --version Print version information ! HELP-NEXT: -v Show commands to run and use verbose output +! HELP-NEXT: -Wl, Pass the comma separated arguments in to the linker ! HELP-NEXT: -W Enable the specified warning ! HELP-NEXT: -XflangPass to the flang compiler ! HELP-NEXT: -xTreat subsequent input files as having type Index: flang/test/Driver/driver-help-hidden.f90 === --- flang/test/Driver/driver-help-hidden.f90 +++ flang/test/Driver/driver-help-hidden.f90 @@ -132,6 +132,7 @@ ! CHECK-NEXT: -U Undefine macro ! CHECK-NEXT: --version Print version information ! CHECK-NEXT: -v Show commands to run and use verbose output +! CHECK-NEXT: -Wl, Pass the comma separated arguments in to the linker ! CHECK-NEXT: -W Enable the specified warning ! CHECK-NEXT: -XflangPass to the flang compiler ! CHECK-NEXT: -xTreat subsequent input files as having type Index: clang/include/clang/Driver/Options.td === --- clang/include/clang/Driver/Options.td +++ clang/include/clang/Driver/Options.td @@ -912,7 +912,8 @@ HelpText<"Enable warnings for deprecated constructs and define __DEPRECATED">; def Wno_deprecated : Flag<["-"], "Wno-deprecated">, Group, Visibility<[ClangOption, CC1Option]>; -def Wl_COMMA : CommaJoined<["-"], "Wl,">, Flags<[LinkerInput, RenderAsInput]>, +def Wl_COMMA : CommaJoined<["-"], "Wl,">, Visibility<[ClangOption, FlangOption]>, + Flags<[LinkerInput, RenderAsInput]>, HelpText<"Pass the comma separated arguments in to the linker">, MetaVarName<"">, Group; // FIXME: This is broken; these should not be Joined arguments. Index: flang/test/Driver/misc-flags.f90 === --- flang/test/Driver/misc-flags.f90 +++ flang/test/Driver/misc-flags.f90 @@ -1,6 +1,9 @@ ! Make sure that `-l` is "visible" to Flang's driver ! RUN: %flang -lpgmath -### %s +! Make sure that `-Wl` is "visible" to Flang's driver +! RUN: %flang -Wl,abs -### %s + program hello write(*,*), "Hello world!" end program hello Index: flang/test/Driver/driver-help.f90 === --- flang/test/Driver/driver-help.f90 +++ flang/test/Driver/driver-help.f90 @@ -120,6 +120,7 @@ ! HELP-NEXT: -U Undefine macro ! HELP-NEXT: --version Print version information ! HELP-NEXT: -v Show commands to run and use verbose output +! HELP-NEXT: -Wl, Pass the comma separated arguments in to the linker ! HELP-NEXT: -W Enable the specified warning ! HELP-NEXT: -XflangPass to the flang compiler ! HELP-NEXT: -xTreat subsequent input files as having type Index: flang/test/Driver/driver-help-hidden.f90 === --- flang/test/Driver/driver-help-hidden.f90 +++ flang/test/Driver/driver-help-hidden.f90 @@ -132,6 +132,7 @@ ! CHECK-NEXT: -U Undefine macro ! CHECK-NEXT: --version Print version information ! CHECK-NEXT: -v Show commands to run and use verbose output +! CHECK-NEXT: -Wl, Pass the comma separated arguments in to the linker ! CHECK-NEXT: -W Enable the specified warning ! CHECK-NEXT: -XflangPass to the flang compiler ! CHECK-NEXT: -xTreat
[PATCH] D158309: [flang][driver] Mark -Wl as visible in Flang
kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158309/new/ https://reviews.llvm.org/D158309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D158309: [flang][driver] Mark -Wl as visible in Flang
awarzynski created this revision. awarzynski added a reviewer: kiranchandramohan. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158309 Files: clang/include/clang/Driver/Options.td flang/test/Driver/driver-help-hidden.f90 flang/test/Driver/driver-help.f90 flang/test/Driver/misc-flags.f90 Index: flang/test/Driver/misc-flags.f90 === --- flang/test/Driver/misc-flags.f90 +++ flang/test/Driver/misc-flags.f90 @@ -1,6 +1,9 @@ ! Make sure that `-l` is "visible" to Flang's driver ! RUN: %flang -lpgmath -### %s +! Make sure that `-Wl` is "visible" to Flang's driver +! RUN: %flang -Wl,abs -### %s + program hello write(*,*), "Hello world!" end program hello Index: flang/test/Driver/driver-help.f90 === --- flang/test/Driver/driver-help.f90 +++ flang/test/Driver/driver-help.f90 @@ -120,6 +120,7 @@ ! HELP-NEXT: -U Undefine macro ! HELP-NEXT: --version Print version information ! HELP-NEXT: -v Show commands to run and use verbose output +! HELP-NEXT: -Wl, Pass the comma separated arguments in to the linker ! HELP-NEXT: -W Enable the specified warning ! HELP-NEXT: -XflangPass to the flang compiler ! HELP-NEXT: -xTreat subsequent input files as having type Index: flang/test/Driver/driver-help-hidden.f90 === --- flang/test/Driver/driver-help-hidden.f90 +++ flang/test/Driver/driver-help-hidden.f90 @@ -132,6 +132,7 @@ ! CHECK-NEXT: -U Undefine macro ! CHECK-NEXT: --version Print version information ! CHECK-NEXT: -v Show commands to run and use verbose output +! CHECK-NEXT: -Wl, Pass the comma separated arguments in to the linker ! CHECK-NEXT: -W Enable the specified warning ! CHECK-NEXT: -XflangPass to the flang compiler ! CHECK-NEXT: -xTreat subsequent input files as having type Index: clang/include/clang/Driver/Options.td === --- clang/include/clang/Driver/Options.td +++ clang/include/clang/Driver/Options.td @@ -912,7 +912,8 @@ HelpText<"Enable warnings for deprecated constructs and define __DEPRECATED">; def Wno_deprecated : Flag<["-"], "Wno-deprecated">, Group, Visibility<[ClangOption, CC1Option]>; -def Wl_COMMA : CommaJoined<["-"], "Wl,">, Flags<[LinkerInput, RenderAsInput]>, +def Wl_COMMA : CommaJoined<["-"], "Wl,">, Visibility<[ClangOption, FlangOption]>, + Flags<[LinkerInput, RenderAsInput]>, HelpText<"Pass the comma separated arguments in to the linker">, MetaVarName<"">, Group; // FIXME: This is broken; these should not be Joined arguments. Index: flang/test/Driver/misc-flags.f90 === --- flang/test/Driver/misc-flags.f90 +++ flang/test/Driver/misc-flags.f90 @@ -1,6 +1,9 @@ ! Make sure that `-l` is "visible" to Flang's driver ! RUN: %flang -lpgmath -### %s +! Make sure that `-Wl` is "visible" to Flang's driver +! RUN: %flang -Wl,abs -### %s + program hello write(*,*), "Hello world!" end program hello Index: flang/test/Driver/driver-help.f90 === --- flang/test/Driver/driver-help.f90 +++ flang/test/Driver/driver-help.f90 @@ -120,6 +120,7 @@ ! HELP-NEXT: -U Undefine macro ! HELP-NEXT: --version Print version information ! HELP-NEXT: -v Show commands to run and use verbose output +! HELP-NEXT: -Wl, Pass the comma separated arguments in to the linker ! HELP-NEXT: -W Enable the specified warning ! HELP-NEXT: -XflangPass to the flang compiler ! HELP-NEXT: -xTreat subsequent input files as having type Index: flang/test/Driver/driver-help-hidden.f90 === --- flang/test/Driver/driver-help-hidden.f90 +++ flang/test/Driver/driver-help-hidden.f90 @@ -132,6 +132,7 @@ ! CHECK-NEXT: -U Undefine macro ! CHECK-NEXT: --version Print version information ! CHECK-NEXT: -v Show commands to run and use verbose output +! CHECK-NEXT: -Wl, Pass the comma separated arguments in to the linker ! CHECK-NEXT: -W Enable the specified warning ! CHECK-NEXT: -XflangPass to the flang compiler ! CHECK-NEXT: -xTreat subsequent input files as having type Index: clang/include/clang/Driver/Options.td === ---
