Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

2016-01-26 Thread Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258870: Fix Clang-tidy modernize-use-override warning in 
unittests/clang… (authored by eugenezelenko).

Changed prior to commit:
  http://reviews.llvm.org/D16566?vs=45938&id=46054#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D16566

Files:
  clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp

Index: clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
===
--- clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
+++ clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
@@ -98,7 +98,6 @@
 public:
   CXXSystemIncludeInserterCheck(StringRef CheckName, ClangTidyContext *Context)
   : IncludeInserterCheckBase(CheckName, Context) {}
-  virtual ~CXXSystemIncludeInserterCheck() {}
 
   std::vector HeadersToInclude() const override { return {"set"}; }
   bool IsAngledInclude() const override { return true; }
@@ -522,7 +521,7 @@
"insert_includes_test_header.cc"));
 }
 
-} // namespace
+} // anonymous namespace
 } // namespace tidy
 } // namespace clang
 


Index: clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
===
--- clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
+++ clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
@@ -98,7 +98,6 @@
 public:
   CXXSystemIncludeInserterCheck(StringRef CheckName, ClangTidyContext *Context)
   : IncludeInserterCheckBase(CheckName, Context) {}
-  virtual ~CXXSystemIncludeInserterCheck() {}
 
   std::vector HeadersToInclude() const override { return {"set"}; }
   bool IsAngledInclude() const override { return true; }
@@ -522,7 +521,7 @@
"insert_includes_test_header.cc"));
 }
 
-} // namespace
+} // anonymous namespace
 } // namespace tidy
 } // namespace clang
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

2016-01-26 Thread Eugene Zelenko via cfe-commits 
Eugene.Zelenko added inline comments.


Comment at: unittests/clang-tidy/IncludeInserterTest.cpp:101
@@ -100,3 +100,3 @@
   : IncludeInserterCheckBase(CheckName, Context) {}
-  virtual ~CXXSystemIncludeInserterCheck() {}
+  ~CXXSystemIncludeInserterCheck() override = default;
 

alexfh wrote:
> I'd better remove it completely.
Will do this in commit.


Repository:
  rL LLVM

http://reviews.llvm.org/D16566



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

2016-01-26 Thread Alexander Kornienko via cfe-commits 
alexfh added inline comments.


Comment at: unittests/clang-tidy/IncludeInserterTest.cpp:101
@@ -100,3 +100,3 @@
   : IncludeInserterCheckBase(CheckName, Context) {}
-  virtual ~CXXSystemIncludeInserterCheck() {}
+  ~CXXSystemIncludeInserterCheck() override = default;
 

I'd better remove it completely.


Repository:
  rL LLVM

http://reviews.llvm.org/D16566



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

2016-01-26 Thread David Blaikie via cfe-commits 
On Mon, Jan 25, 2016 at 6:20 PM, Eugene Zelenko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> Eugene.Zelenko created this revision.
> Eugene.Zelenko added reviewers: alexfh, aaron.ballman.
> Eugene.Zelenko added a subscriber: cfe-commits.
> Eugene.Zelenko set the repository for this revision to rL LLVM.
>
> I checked this patch on my own build on RHEL 6. Regressions were OK.
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D16566
>
> Files:
>   unittests/clang-tidy/IncludeInserterTest.cpp
>
> Index: unittests/clang-tidy/IncludeInserterTest.cpp
> ===
> --- unittests/clang-tidy/IncludeInserterTest.cpp
> +++ unittests/clang-tidy/IncludeInserterTest.cpp
> @@ -98,7 +98,7 @@
>  public:
>CXXSystemIncludeInserterCheck(StringRef CheckName, ClangTidyContext
> *Context)
>: IncludeInserterCheckBase(CheckName, Context) {}
> -  virtual ~CXXSystemIncludeInserterCheck() {}
> +  ~CXXSystemIncludeInserterCheck() override = default;
>

Perhaps we should just remove this user-declared dtor entirely? The
implicitly provided dtor will do all that by default anyway...


>
>std::vector HeadersToInclude() const override { return
> {"set"}; }
>bool IsAngledInclude() const override { return true; }
> @@ -522,7 +522,7 @@
> "insert_includes_test_header.cc"));
>  }
>
> -} // namespace
> +} // anonymous namespace
>  } // namespace tidy
>  } // namespace clang
>
>
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

2016-01-26 Thread Aaron Ballman via cfe-commits 
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!


Repository:
  rL LLVM

http://reviews.llvm.org/D16566



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

2016-01-25 Thread Eugene Zelenko via cfe-commits 
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.

I checked this patch on my own build on RHEL 6. Regressions were OK.

Repository:
  rL LLVM

http://reviews.llvm.org/D16566

Files:
  unittests/clang-tidy/IncludeInserterTest.cpp

Index: unittests/clang-tidy/IncludeInserterTest.cpp
===
--- unittests/clang-tidy/IncludeInserterTest.cpp
+++ unittests/clang-tidy/IncludeInserterTest.cpp
@@ -98,7 +98,7 @@
 public:
   CXXSystemIncludeInserterCheck(StringRef CheckName, ClangTidyContext *Context)
   : IncludeInserterCheckBase(CheckName, Context) {}
-  virtual ~CXXSystemIncludeInserterCheck() {}
+  ~CXXSystemIncludeInserterCheck() override = default;
 
   std::vector HeadersToInclude() const override { return {"set"}; }
   bool IsAngledInclude() const override { return true; }
@@ -522,7 +522,7 @@
"insert_includes_test_header.cc"));
 }
 
-} // namespace
+} // anonymous namespace
 } // namespace tidy
 } // namespace clang
 


Index: unittests/clang-tidy/IncludeInserterTest.cpp
===
--- unittests/clang-tidy/IncludeInserterTest.cpp
+++ unittests/clang-tidy/IncludeInserterTest.cpp
@@ -98,7 +98,7 @@
 public:
   CXXSystemIncludeInserterCheck(StringRef CheckName, ClangTidyContext *Context)
   : IncludeInserterCheckBase(CheckName, Context) {}
-  virtual ~CXXSystemIncludeInserterCheck() {}
+  ~CXXSystemIncludeInserterCheck() override = default;
 
   std::vector HeadersToInclude() const override { return {"set"}; }
   bool IsAngledInclude() const override { return true; }
@@ -522,7 +522,7 @@
"insert_includes_test_header.cc"));
 }
 
-} // namespace
+} // anonymous namespace
 } // namespace tidy
 } // namespace clang
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits