Re: [PATCH] D16584: [libcxx] Work around for clang calling GAS after having already failed.

2016-01-27 Thread Eric Fiselier via cfe-commits 
EricWF added a comment.

I'm OK signing off on this myself.


http://reviews.llvm.org/D16584



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16584: [libcxx] Work around for clang calling GAS after having already failed.

2016-01-26 Thread Daniel Sanders via cfe-commits 
dsanders created this revision.
dsanders added reviewers: EricWF, mclow.lists, hans.
dsanders added a subscriber: cfe-commits.

This is a workaround to a clang bug which causes libcxx tests to fail in the 3.8
release. The clang bug is currently being investigated. It seems that clang
does not stop after frontend errors when using -verify and -fno-integrated-as
(or when this is the default). This patch adds -fsyntax-only to prevent GAS
from being called, fixing the libcxx failures.

PR26277

Patch by Eric Fiselier

http://reviews.llvm.org/D16584

Files:
  test/libcxx/test/format.py

Index: test/libcxx/test/format.py
===
--- test/libcxx/test/format.py
+++ test/libcxx/test/format.py
@@ -161,7 +161,7 @@
'expected-error', 'expected-no-diagnostics']
 use_verify = self.use_verify_for_fail and \
  any([tag in contents for tag in verify_tags])
-extra_flags = []
+extra_flags = ['-fsyntax-only']
 if use_verify:
 extra_flags += ['-Xclang', '-verify',
 '-Xclang', '-verify-ignore-unexpected=note']


Index: test/libcxx/test/format.py
===
--- test/libcxx/test/format.py
+++ test/libcxx/test/format.py
@@ -161,7 +161,7 @@
'expected-error', 'expected-no-diagnostics']
 use_verify = self.use_verify_for_fail and \
  any([tag in contents for tag in verify_tags])
-extra_flags = []
+extra_flags = ['-fsyntax-only']
 if use_verify:
 extra_flags += ['-Xclang', '-verify',
 '-Xclang', '-verify-ignore-unexpected=note']
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16584: [libcxx] Work around for clang calling GAS after having already failed.

2016-01-26 Thread Eric Fiselier via cfe-commits 
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

Obviously LGTM. @hans I'm OK with this going into 3.8.


http://reviews.llvm.org/D16584



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits