Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

2016-10-25 Thread Kelvin Li via cfe-commits 
The failure cannot be reproduced.  I re-apply r279045.  Committed revision
285066.

Thanks,
Kelvin

On Thu, Aug 18, 2016 at 5:46 AM, Diana Picus  wrote:

> Hi,
>
> I had to revert this (r279045) because it breaks some of our buildbots
> (e.g.
> clang-cmake-aarch64-quick, clang-x86_64-linux-selfhost-modules).
>
> The error is in OpenMP/teams_distribute_simd_ast_print.cpp:
> clang: /home/buildslave/buildslave/clang-cmake-aarch64-quick/llvm/
> include/llvm/ADT/DenseMap.h:527:
> bool llvm::DenseMapBase BucketT>::LookupBucketFor(const LookupKeyT&, const BucketT*&) const
> [with LookupKeyT = clang::Stmt*; DerivedT = llvm::DenseMap long unsigned int>;
> KeyT = clang::Stmt*; ValueT = long unsigned int;
> KeyInfoT = llvm::DenseMapInfo;
> BucketT = llvm::detail::DenseMapPair int>]:
>
> Assertion `!KeyInfoT::isEqual(Val, EmptyKey) && !KeyInfoT::isEqual(Val,
> TombstoneKey) &&
> "Empty/Tombstone value shouldn't be inserted into map!"' failed.
>
> On 18 August 2016 at 02:21, Phabricator via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> This revision was automatically updated to reflect the committed changes.
>> Closed by commit rL279003: [OpenMP] Sema and parsing for 'teams
>> distribute simd’ pragma (authored by kli).
>>
>> Changed prior to commit:
>>   https://reviews.llvm.org/D23528?vs=68216=68448#toc
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D23528
>>
>> Files:
>>   cfe/trunk/include/clang-c/Index.h
>>   cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
>>   cfe/trunk/include/clang/AST/StmtOpenMP.h
>>   cfe/trunk/include/clang/Basic/OpenMPKinds.def
>>   cfe/trunk/include/clang/Basic/StmtNodes.td
>>   cfe/trunk/include/clang/Sema/Sema.h
>>   cfe/trunk/include/clang/Serialization/ASTBitCodes.h
>>   cfe/trunk/lib/AST/StmtOpenMP.cpp
>>   cfe/trunk/lib/AST/StmtPrinter.cpp
>>   cfe/trunk/lib/AST/StmtProfile.cpp
>>   cfe/trunk/lib/Basic/OpenMPKinds.cpp
>>   cfe/trunk/lib/CodeGen/CGStmt.cpp
>>   cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
>>   cfe/trunk/lib/CodeGen/CodeGenFunction.h
>>   cfe/trunk/lib/Parse/ParseOpenMP.cpp
>>   cfe/trunk/lib/Sema/SemaOpenMP.cpp
>>   cfe/trunk/lib/Sema/TreeTransform.h
>>   cfe/trunk/lib/Serialization/ASTReaderStmt.cpp
>>   cfe/trunk/lib/Serialization/ASTWriterStmt.cpp
>>   cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
>>   cfe/trunk/test/OpenMP/nesting_of_regions.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_aligned_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_ast_print.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_collapse_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_default_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_dist_schedule_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_firstprivate_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_lastprivate_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_linear_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_loop_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_num_teams_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_private_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_reduction_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_safelen_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_shared_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_simdlen_messages.cpp
>>   cfe/trunk/test/OpenMP/teams_distribute_simd_thread_limit_messages.cpp
>>   cfe/trunk/tools/libclang/CIndex.cpp
>>   cfe/trunk/tools/libclang/CXCursor.cpp
>>
>>
>> ___
>> cfe-commits mailing list
>> cfe-commits@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

2016-08-18 Thread Diana Picus via cfe-commits 
Hi,

I had to revert this (r279045) because it breaks some of our buildbots (e.g.
clang-cmake-aarch64-quick, clang-x86_64-linux-selfhost-modules).

The error is in OpenMP/teams_distribute_simd_ast_print.cpp:
clang:
/home/buildslave/buildslave/clang-cmake-aarch64-quick/llvm/include/llvm/ADT/DenseMap.h:527:
bool llvm::DenseMapBase::LookupBucketFor(const LookupKeyT&, const BucketT*&) const
[with LookupKeyT = clang::Stmt*; DerivedT = llvm::DenseMap;
KeyT = clang::Stmt*; ValueT = long unsigned int;
KeyInfoT = llvm::DenseMapInfo;
BucketT = llvm::detail::DenseMapPair]:

Assertion `!KeyInfoT::isEqual(Val, EmptyKey) && !KeyInfoT::isEqual(Val,
TombstoneKey) &&
"Empty/Tombstone value shouldn't be inserted into map!"' failed.

On 18 August 2016 at 02:21, Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL279003: [OpenMP] Sema and parsing for 'teams distribute
> simd’ pragma (authored by kli).
>
> Changed prior to commit:
>   https://reviews.llvm.org/D23528?vs=68216=68448#toc
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D23528
>
> Files:
>   cfe/trunk/include/clang-c/Index.h
>   cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
>   cfe/trunk/include/clang/AST/StmtOpenMP.h
>   cfe/trunk/include/clang/Basic/OpenMPKinds.def
>   cfe/trunk/include/clang/Basic/StmtNodes.td
>   cfe/trunk/include/clang/Sema/Sema.h
>   cfe/trunk/include/clang/Serialization/ASTBitCodes.h
>   cfe/trunk/lib/AST/StmtOpenMP.cpp
>   cfe/trunk/lib/AST/StmtPrinter.cpp
>   cfe/trunk/lib/AST/StmtProfile.cpp
>   cfe/trunk/lib/Basic/OpenMPKinds.cpp
>   cfe/trunk/lib/CodeGen/CGStmt.cpp
>   cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
>   cfe/trunk/lib/CodeGen/CodeGenFunction.h
>   cfe/trunk/lib/Parse/ParseOpenMP.cpp
>   cfe/trunk/lib/Sema/SemaOpenMP.cpp
>   cfe/trunk/lib/Sema/TreeTransform.h
>   cfe/trunk/lib/Serialization/ASTReaderStmt.cpp
>   cfe/trunk/lib/Serialization/ASTWriterStmt.cpp
>   cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
>   cfe/trunk/test/OpenMP/nesting_of_regions.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_aligned_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_ast_print.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_collapse_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_default_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_dist_schedule_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_firstprivate_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_lastprivate_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_linear_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_loop_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_num_teams_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_private_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_reduction_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_safelen_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_shared_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_simdlen_messages.cpp
>   cfe/trunk/test/OpenMP/teams_distribute_simd_thread_limit_messages.cpp
>   cfe/trunk/tools/libclang/CIndex.cpp
>   cfe/trunk/tools/libclang/CXCursor.cpp
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

2016-08-17 Thread Alexey Bataev via cfe-commits 
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.

LG


https://reviews.llvm.org/D23528



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

2016-08-16 Thread Alexey Bataev via cfe-commits 
ABataev requested changes to this revision.
ABataev added a comment.
This revision now requires changes to proceed.

No tests for serialization/deserialization/AST printing


https://reviews.llvm.org/D23528



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits