Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info
This revision was automatically updated to reflect the committed changes. Closed by commit rL281440: Document option '-rtlib' in clang's man page and help info (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D24069?vs=69947=71298#toc Repository: rL LLVM https://reviews.llvm.org/D24069 Files: cfe/trunk/docs/CommandGuide/clang.rst cfe/trunk/include/clang/Driver/Options.td Index: cfe/trunk/docs/CommandGuide/clang.rst === --- cfe/trunk/docs/CommandGuide/clang.rst +++ cfe/trunk/docs/CommandGuide/clang.rst @@ -105,7 +105,12 @@ .. option:: -stdlib= Specify the C++ standard library to use; supported options are libstdc++ and - libc++. + libc++. If not specified, platform default will be used. + +.. option:: -rtlib= + + Specify the compiler runtime library to use; supported options are libgcc and + compiler-rt. If not specified, platform default will be used. .. option:: -ansi Index: cfe/trunk/include/clang/Driver/Options.td === --- cfe/trunk/include/clang/Driver/Options.td +++ cfe/trunk/include/clang/Driver/Options.td @@ -1863,7 +1863,8 @@ def resource_dir_EQ : Joined<["-"], "resource-dir=">, Flags<[DriverOption]>, Alias; def rpath : Separate<["-"], "rpath">, Flags<[LinkerInput]>; -def rtlib_EQ : Joined<["-", "--"], "rtlib=">; +def rtlib_EQ : Joined<["-", "--"], "rtlib=">, + HelpText<"Compiler runtime library to use">; def r : Flag<["-"], "r">, Flags<[LinkerInput,NoArgumentUnused]>; def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[DriverOption]>, HelpText<"Save intermediate compilation results.">; Index: cfe/trunk/docs/CommandGuide/clang.rst === --- cfe/trunk/docs/CommandGuide/clang.rst +++ cfe/trunk/docs/CommandGuide/clang.rst @@ -105,7 +105,12 @@ .. option:: -stdlib= Specify the C++ standard library to use; supported options are libstdc++ and - libc++. + libc++. If not specified, platform default will be used. + +.. option:: -rtlib= + + Specify the compiler runtime library to use; supported options are libgcc and + compiler-rt. If not specified, platform default will be used. .. option:: -ansi Index: cfe/trunk/include/clang/Driver/Options.td === --- cfe/trunk/include/clang/Driver/Options.td +++ cfe/trunk/include/clang/Driver/Options.td @@ -1863,7 +1863,8 @@ def resource_dir_EQ : Joined<["-"], "resource-dir=">, Flags<[DriverOption]>, Alias; def rpath : Separate<["-"], "rpath">, Flags<[LinkerInput]>; -def rtlib_EQ : Joined<["-", "--"], "rtlib=">; +def rtlib_EQ : Joined<["-", "--"], "rtlib=">, + HelpText<"Compiler runtime library to use">; def r : Flag<["-"], "r">, Flags<[LinkerInput,NoArgumentUnused]>; def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[DriverOption]>, HelpText<"Save intermediate compilation results.">; ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info
zlei added a comment. In https://reviews.llvm.org/D24069#540804, @Hahnfeld wrote: > @zlei will you commit the patch or do you want me to do that on your behalf? I don't have commit access, so please do me a favor :) https://reviews.llvm.org/D24069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info
Hahnfeld added a comment. @zlei will you commit the patch or do you want me to do that on your behalf? https://reviews.llvm.org/D24069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info
Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM, thanks for the improvement! https://reviews.llvm.org/D24069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info
zlei edited reviewers, added: bruno; removed: cfe-commits. zlei edited subscribers, added: cfe-commits; removed: bruno. zlei updated this revision to Diff 69947. zlei added a comment. Update the man page entry to state default behavior of this option. https://reviews.llvm.org/D24069 Files: docs/CommandGuide/clang.rst include/clang/Driver/Options.td Index: include/clang/Driver/Options.td === --- include/clang/Driver/Options.td +++ include/clang/Driver/Options.td @@ -1860,7 +1860,8 @@ def resource_dir_EQ : Joined<["-"], "resource-dir=">, Flags<[DriverOption]>, Alias; def rpath : Separate<["-"], "rpath">, Flags<[LinkerInput]>; -def rtlib_EQ : Joined<["-", "--"], "rtlib=">; +def rtlib_EQ : Joined<["-", "--"], "rtlib=">, + HelpText<"Compiler runtime library to use">; def r : Flag<["-"], "r">, Flags<[LinkerInput,NoArgumentUnused]>; def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[DriverOption]>, HelpText<"Save intermediate compilation results.">; Index: docs/CommandGuide/clang.rst === --- docs/CommandGuide/clang.rst +++ docs/CommandGuide/clang.rst @@ -105,7 +105,12 @@ .. option:: -stdlib= Specify the C++ standard library to use; supported options are libstdc++ and - libc++. + libc++. If not specified, platform default will be used. + +.. option:: -rtlib= + + Specify the compiler runtime library to use; supported options are libgcc and + compiler-rt. If not specified, platform default will be used. .. option:: -ansi Index: include/clang/Driver/Options.td === --- include/clang/Driver/Options.td +++ include/clang/Driver/Options.td @@ -1860,7 +1860,8 @@ def resource_dir_EQ : Joined<["-"], "resource-dir=">, Flags<[DriverOption]>, Alias; def rpath : Separate<["-"], "rpath">, Flags<[LinkerInput]>; -def rtlib_EQ : Joined<["-", "--"], "rtlib=">; +def rtlib_EQ : Joined<["-", "--"], "rtlib=">, + HelpText<"Compiler runtime library to use">; def r : Flag<["-"], "r">, Flags<[LinkerInput,NoArgumentUnused]>; def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[DriverOption]>, HelpText<"Save intermediate compilation results.">; Index: docs/CommandGuide/clang.rst === --- docs/CommandGuide/clang.rst +++ docs/CommandGuide/clang.rst @@ -105,7 +105,12 @@ .. option:: -stdlib= Specify the C++ standard library to use; supported options are libstdc++ and - libc++. + libc++. If not specified, platform default will be used. + +.. option:: -rtlib= + + Specify the compiler runtime library to use; supported options are libgcc and + compiler-rt. If not specified, platform default will be used. .. option:: -ansi ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info
bruno added inline comments. Comment at: docs/CommandGuide/clang.rst:114 @@ -110,1 +113,3 @@ + compiler-rt. + .. option:: -ansi zlei wrote: > bruno wrote: > > It might be worth mentioning what's the default behaviour in case the flag > > isn't specified? > This option behaves a lot like `-stdlib`, so I want their doc entries to look > alike too. Perhaps I should update them both to state the default behavior? That would be great, but feel free to do this update in follow up patches/commits if you want to. https://reviews.llvm.org/D24069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info
bruno added a subscriber: bruno. bruno added a comment. Hi Lei, Thanks for the doc improvement! Comment at: docs/CommandGuide/clang.rst:114 @@ -110,1 +113,3 @@ + compiler-rt. + .. option:: -ansi It might be worth mentioning what's the default behaviour in case the flag isn't specified? https://reviews.llvm.org/D24069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D24069: Document option '-rtlib' in clang's man page and help info
zlei created this revision. zlei added reviewers: cfe-commits, Hahnfeld. This patch adds an entry for "-rtlib" in the output of `man clang` and `clang -help`. https://reviews.llvm.org/D24069 Files: docs/CommandGuide/clang.rst include/clang/Driver/Options.td Index: include/clang/Driver/Options.td === --- include/clang/Driver/Options.td +++ include/clang/Driver/Options.td @@ -1860,7 +1860,8 @@ def resource_dir_EQ : Joined<["-"], "resource-dir=">, Flags<[DriverOption]>, Alias; def rpath : Separate<["-"], "rpath">, Flags<[LinkerInput]>; -def rtlib_EQ : Joined<["-", "--"], "rtlib=">; +def rtlib_EQ : Joined<["-", "--"], "rtlib=">, + HelpText<"Compiler runtime library to use">; def r : Flag<["-"], "r">, Flags<[LinkerInput,NoArgumentUnused]>; def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[DriverOption]>, HelpText<"Save intermediate compilation results.">; Index: docs/CommandGuide/clang.rst === --- docs/CommandGuide/clang.rst +++ docs/CommandGuide/clang.rst @@ -107,6 +107,11 @@ Specify the C++ standard library to use; supported options are libstdc++ and libc++. +.. option:: -rtlib= + + Specify the compiler runtime library to use; supported options are libgcc and + compiler-rt. + .. option:: -ansi Same as -std=c89. Index: include/clang/Driver/Options.td === --- include/clang/Driver/Options.td +++ include/clang/Driver/Options.td @@ -1860,7 +1860,8 @@ def resource_dir_EQ : Joined<["-"], "resource-dir=">, Flags<[DriverOption]>, Alias; def rpath : Separate<["-"], "rpath">, Flags<[LinkerInput]>; -def rtlib_EQ : Joined<["-", "--"], "rtlib=">; +def rtlib_EQ : Joined<["-", "--"], "rtlib=">, + HelpText<"Compiler runtime library to use">; def r : Flag<["-"], "r">, Flags<[LinkerInput,NoArgumentUnused]>; def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[DriverOption]>, HelpText<"Save intermediate compilation results.">; Index: docs/CommandGuide/clang.rst === --- docs/CommandGuide/clang.rst +++ docs/CommandGuide/clang.rst @@ -107,6 +107,11 @@ Specify the C++ standard library to use; supported options are libstdc++ and libc++. +.. option:: -rtlib= + + Specify the compiler runtime library to use; supported options are libgcc and + compiler-rt. + .. option:: -ansi Same as -std=c89. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
