Re: [PATCH] D26024: [Xray] Don't generate output for xray tests
How/what output are these producing if they're meant to fail ("not" in the
test line) anyway?
& these tests should probably check the diagnostic result to be more
precise than "Clang exited with a non-zero exit code".
On Thu, Oct 27, 2016 at 1:54 AM Dean Michael Berris via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> dberris accepted this revision.
> dberris added a comment.
>
> Yes, thanks (and sorry for missing this).
>
>
> https://reviews.llvm.org/D26024
>
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D26024: [Xray] Don't generate output for xray tests
This revision was automatically updated to reflect the committed changes. Closed by commit rL285276: [Xray] Don't generate output for xray tests (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D26024?vs=75991=75994#toc Repository: rL LLVM https://reviews.llvm.org/D26024 Files: cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c cfe/trunk/test/Driver/XRay/xray-instrument-os.c Index: cfe/trunk/test/Driver/XRay/xray-instrument-os.c === --- cfe/trunk/test/Driver/XRay/xray-instrument-os.c +++ cfe/trunk/test/Driver/XRay/xray-instrument-os.c @@ -1,4 +1,4 @@ -// RUN: not %clang -v -fxray-instrument -c %s +// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s // XFAIL: -linux- // REQUIRES-ANY: amd64, x86_64, x86_64h, arm typedef int a; Index: cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c === --- cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c +++ cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c @@ -1,4 +1,4 @@ -// RUN: not %clang -v -fxray-instrument -c %s +// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s // XFAIL: amd64-, x86_64-, x86_64h-, arm // REQUIRES: linux typedef int a; Index: cfe/trunk/test/Driver/XRay/xray-instrument-os.c === --- cfe/trunk/test/Driver/XRay/xray-instrument-os.c +++ cfe/trunk/test/Driver/XRay/xray-instrument-os.c @@ -1,4 +1,4 @@ -// RUN: not %clang -v -fxray-instrument -c %s +// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s // XFAIL: -linux- // REQUIRES-ANY: amd64, x86_64, x86_64h, arm typedef int a; Index: cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c === --- cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c +++ cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c @@ -1,4 +1,4 @@ -// RUN: not %clang -v -fxray-instrument -c %s +// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s // XFAIL: amd64-, x86_64-, x86_64h-, arm // REQUIRES: linux typedef int a; ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D26024: [Xray] Don't generate output for xray tests
dberris accepted this revision. dberris added a comment. Yes, thanks (and sorry for missing this). https://reviews.llvm.org/D26024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D26024: [Xray] Don't generate output for xray tests
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Testing the code generator in a Driver test is a really weird thing to do. The patch doesn't make it worse though and spamming the test directory is a bad thing. I'll land this. https://reviews.llvm.org/D26024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D26024: [Xray] Don't generate output for xray tests
sammccall created this revision. sammccall added a reviewer: dberris. sammccall added a subscriber: cfe-commits. Don't generate output for xray tests https://reviews.llvm.org/D26024 Files: test/Driver/XRay/xray-instrument-cpu.c test/Driver/XRay/xray-instrument-os.c Index: test/Driver/XRay/xray-instrument-os.c === --- test/Driver/XRay/xray-instrument-os.c +++ test/Driver/XRay/xray-instrument-os.c @@ -1,4 +1,4 @@ -// RUN: not %clang -v -fxray-instrument -c %s +// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s // XFAIL: -linux- // REQUIRES-ANY: amd64, x86_64, x86_64h, arm typedef int a; Index: test/Driver/XRay/xray-instrument-cpu.c === --- test/Driver/XRay/xray-instrument-cpu.c +++ test/Driver/XRay/xray-instrument-cpu.c @@ -1,4 +1,4 @@ -// RUN: not %clang -v -fxray-instrument -c %s +// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s // XFAIL: amd64-, x86_64-, x86_64h-, arm // REQUIRES: linux typedef int a; Index: test/Driver/XRay/xray-instrument-os.c === --- test/Driver/XRay/xray-instrument-os.c +++ test/Driver/XRay/xray-instrument-os.c @@ -1,4 +1,4 @@ -// RUN: not %clang -v -fxray-instrument -c %s +// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s // XFAIL: -linux- // REQUIRES-ANY: amd64, x86_64, x86_64h, arm typedef int a; Index: test/Driver/XRay/xray-instrument-cpu.c === --- test/Driver/XRay/xray-instrument-cpu.c +++ test/Driver/XRay/xray-instrument-cpu.c @@ -1,4 +1,4 @@ -// RUN: not %clang -v -fxray-instrument -c %s +// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s // XFAIL: amd64-, x86_64-, x86_64h-, arm // REQUIRES: linux typedef int a; ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
